Re: [EXTERNAL] Re: [edk2-devel] !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock

2021-03-25 Thread Bret Barkelew via groups.io
Yes, this is expected behavior. The messages are to encourage code owners to 
move from using the VariableLockRequestToLock() interface to the VariablePolicy 
interface so that the RTL interface may be removed in the future.

The correct solution is to find the offending code and submit a patch that 
updates it to not use RTL. My guess is that this is the location that you’re 
hitting, if you’re using the edk2 BdsDxe:
https://github.com/tianocore/edk2/blob/4bf2a5b045ebf8b5e90d9210ad5190699bddb592/MdeModulePkg/Universal/BdsDxe/BdsEntry.c#L723

I can try to submit a patch next week (I’m slammed this week) to port this over 
to VariablePolicy.
Note, however, that the messages are not affecting the functionality. They’re 
purely nag messages.

- Bret

From: Laszlo Ersek<mailto:ler...@redhat.com>
Sent: Thursday, March 25, 2021 12:04 PM
To: Bret Barkelew<mailto:bret.barke...@microsoft.com>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; 
m...@semihalf.com<mailto:m...@semihalf.com>
Subject: [EXTERNAL] Re: [edk2-devel] !!! DEPRECATED INTERFACE !!! 
VariableLockRequestToLock

Hi Bret,

can you help Marcin please?

Thanks
Laszlo

On 03/25/21 10:19, Marcin Wojtas wrote:
> Hi,
>
> When booting the latest edk2 on Marvell SoCs I get a number of prints as
> below:
>
> !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away soon!
> !!! DEPRECATED INTERFACE !!! Please move to use Variable Policy!
> !!! DEPRECATED INTERFACE !!! Variable: 8BE4DF61-93CA-11D2-AA0D-00E098032B8C
> PlatformLangCodes
> !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away soon!
> !!! DEPRECATED INTERFACE !!! Please move to use Variable Policy!
> !!! DEPRECATED INTERFACE !!! Variable: 8BE4DF61-93CA-11D2-AA0D-00E098032B8C
> LangCodes
> ...
>
> I cleared variable storage, looked into code, compared VariablePolicy
> library resolution to other platforms (it looks the same and was updated
> along with all others in
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-platforms%2Fcommit%2F8034e3b2ae9470adbdata=04%7C01%7Cbret.barkelew%40microsoft.com%7C98c3d9be0b2c4654874d08d8efc0cdb5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637522958656548916%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=mwHi%2BAwmh5rh%2BAfdXBBx0ZXobV1bT1%2Bsi8%2BpcLxVNsQ%3Dreserved=0),
>  but
> still don't see, how to get rid of those.
>
> Is it expected behavior? Any suggestions how to properly remove those
> messages?
>
> Best regards,
> Marcin
>
>
> 
>
>
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73292): https://edk2.groups.io/g/devel/message/73292
Mute This Topic: https://groups.io/mt/81614021/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock

2021-03-25 Thread Laszlo Ersek
Hi Bret,

can you help Marcin please?

Thanks
Laszlo

On 03/25/21 10:19, Marcin Wojtas wrote:
> Hi,
> 
> When booting the latest edk2 on Marvell SoCs I get a number of prints as
> below:
> 
> !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away soon!
> !!! DEPRECATED INTERFACE !!! Please move to use Variable Policy!
> !!! DEPRECATED INTERFACE !!! Variable: 8BE4DF61-93CA-11D2-AA0D-00E098032B8C
> PlatformLangCodes
> !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away soon!
> !!! DEPRECATED INTERFACE !!! Please move to use Variable Policy!
> !!! DEPRECATED INTERFACE !!! Variable: 8BE4DF61-93CA-11D2-AA0D-00E098032B8C
> LangCodes
> ...
> 
> I cleared variable storage, looked into code, compared VariablePolicy
> library resolution to other platforms (it looks the same and was updated
> along with all others in
> https://github.com/tianocore/edk2-platforms/commit/8034e3b2ae9470adb), but
> still don't see, how to get rid of those.
> 
> Is it expected behavior? Any suggestions how to properly remove those
> messages?
> 
> Best regards,
> Marcin
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73289): https://edk2.groups.io/g/devel/message/73289
Mute This Topic: https://groups.io/mt/81597957/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] !!! DEPRECATED INTERFACE !!! VariableLockRequestToLock

2021-03-25 Thread Marcin Wojtas
Hi,

When booting the latest edk2 on Marvell SoCs I get a number of prints as
below:

!!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away soon!
!!! DEPRECATED INTERFACE !!! Please move to use Variable Policy!
!!! DEPRECATED INTERFACE !!! Variable: 8BE4DF61-93CA-11D2-AA0D-00E098032B8C
PlatformLangCodes
!!! DEPRECATED INTERFACE !!! VariableLockRequestToLock() will go away soon!
!!! DEPRECATED INTERFACE !!! Please move to use Variable Policy!
!!! DEPRECATED INTERFACE !!! Variable: 8BE4DF61-93CA-11D2-AA0D-00E098032B8C
LangCodes
...

I cleared variable storage, looked into code, compared VariablePolicy
library resolution to other platforms (it looks the same and was updated
along with all others in
https://github.com/tianocore/edk2-platforms/commit/8034e3b2ae9470adb), but
still don't see, how to get rid of those.

Is it expected behavior? Any suggestions how to properly remove those
messages?

Best regards,
Marcin


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73265): https://edk2.groups.io/g/devel/message/73265
Mute This Topic: https://groups.io/mt/81597957/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-