Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute

2024-05-30 Thread Du Lin 
Liming - It is still under discussion. I’m checking if this patch can be 
reviewed and merged first. You may find more details in the attached email.

BRs,
Lin, Du

From: devel@edk2.groups.io  On Behalf Of gaoliming via 
groups.io
Sent: Thursday, May 30, 2024 1:02 PM
To: devel@edk2.groups.io; Lin, Du 
Cc: Ni, Ray ; o...@linux.microsoft.com
Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion 
to support SP attribute

Lin:
  I see there is some discussion. Have you made the agreement with this change?

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> 
mailto:devel@edk2.groups.io>> 代表 Du Lin
发送时间: 2024年5月29日 21:05
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
抄送: Liming Gao mailto:gaolim...@byosoft.com.cn>>; Ni, 
Ray mailto:ray...@intel.com>>; Lin, Du 
mailto:du....@intel.com>>
主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to 
support SP attribute

A pull request has been created for this patch: 
https://github.com/tianocore/edk2/pull/5691.

BRs,
Lin, Du

From: Ni, Ray mailto:ray...@intel.com>>
Sent: Friday, May 10, 2024 10:53 AM
To: Lin, Du mailto:du@intel.com>>; 
devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Liming Gao mailto:gaolim...@byosoft.com.cn>>
Subject: Re: [PATCH] MdeModulePkg: Update GCD attribute conversion to support 
SP attribute

Reviewed-by: Ray Ni mailto:ray...@intel.com>>

Thanks,
Ray

From: Lin, Du mailto:du@intel.com>>
Sent: Thursday, May 9, 2024 12:04
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> 
mailto:devel@edk2.groups.io>>
Cc: Lin, Du mailto:du@intel.com>>; Liming Gao 
mailto:gaolim...@byosoft.com.cn>>; Ni, Ray 
mailto:ray...@intel.com>>
Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP 
attribute

Add a new entry into GCD attribute conversion table to convert
EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP.

Cc: Liming Gao mailto:gaolim...@byosoft.com.cn>>
Cc: Ray Ni mailto:ray...@intel.com>>
Signed-off-by: Du Lin mailto:du@intel.com>>
---
 MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
index fe1bbd6974..99364508cd 100644
--- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
+++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
@@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY  mAttributeConversionTable[] = 
{
   { EFI_RESOURCE_ATTRIBUTE_TESTED,  EFI_MEMORY_TESTED,
FALSE },
   { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV,
TRUE  },
   { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE,   EFI_MEMORY_MORE_RELIABLE, 
TRUE  },
+  { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP,
TRUE  },
   { 0,  0,
FALSE }
 };

--
2.44.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119404): https://edk2.groups.io/g/devel/message/119404
Mute This Topic: https://groups.io/mt/106402173/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


--- Begin Message ---
Is there any feedback from CXL stakeholders?

It is OK if more time is needed to check with CXL stakeholders. But looks like 
we all agree that the GCD attribute conversion table shall be updated to 
convert EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP.
So could we review and merge the conversion table update first, while we are 
waiting for the feedback from CXL stakeholders? If you agree, a pull request 
has been created for the conversion table update: 
https://github.com/tianocore/edk2/pull/5691.

BRs,
Lin, Du

-Original Message-
From: Oliver Smith-Denny 
Sent: Friday, May 24, 2024 5:05 AM
To: devel@edk2.groups.io; Lin, Du ; 
mikub...@linux.microsoft.com
Cc: Liming Gao ; Kinney, Michael D 
; Ni, Ray 
Subject: Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add the 
EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute

On 5/23/2024 2:17 AM, Du Lin wrote:
> Thanks for the quick response.
>
> Agree that the PI and UEFI specs are vague on SP. That is also why I opted to 
> minimize code changes to DXE core for SP support in patch 
> https://edk2.groups.io/g/devel/message/118712.
>
> Would it make more sense to let the caller determine if SP memory is 
> available for UEFI via EFI resource types (e.g., EFI_RESOURCE_SYSTEM_MEMORY 
> vs EFI_RESOURCE_MEMORY_RESERVED)?
>
> CDAT can be read in PEI phase via DOE method and CDAT is important to support 
> CXL 2.0. I believe CDAT spec is referencing EFI_MEMORY_TYPE and Memory 
> Attributes defined in UEFI spec section 7.2. "EfiConventionalMemory Type with 
> EFI_MEMORY_S

回复: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute

2024-05-29 Thread gaoliming via groups.io 
Lin:

  I see there is some discussion. Have you made the agreement with this
change?

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Du Lin
发送时间: 2024年5月29日 21:05
收件人: devel@edk2.groups.io
抄送: Liming Gao ; Ni, Ray ;
Lin, Du 
主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion
to support SP attribute

 

A pull request has been created for this patch:
https://github.com/tianocore/edk2/pull/5691.

 

BRs,

Lin, Du

 

From: Ni, Ray mailto:ray...@intel.com> > 
Sent: Friday, May 10, 2024 10:53 AM
To: Lin, Du mailto:du@intel.com> >;
devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
Cc: Liming Gao mailto:gaolim...@byosoft.com.cn> >
Subject: Re: [PATCH] MdeModulePkg: Update GCD attribute conversion to
support SP attribute

 

Reviewed-by: Ray Ni mailto:ray...@intel.com> >

 

Thanks,

Ray

  _  

From: Lin, Du mailto:du@intel.com> >
Sent: Thursday, May 9, 2024 12:04
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
mailto:devel@edk2.groups.io> >
Cc: Lin, Du mailto:du@intel.com> >; Liming Gao
mailto:gaolim...@byosoft.com.cn> >; Ni, Ray mailto:ray...@intel.com> >
Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP
attribute 

 

Add a new entry into GCD attribute conversion table to convert
EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP.

Cc: Liming Gao mailto:gaolim...@byosoft.com.cn> >
Cc: Ray Ni mailto:ray...@intel.com> >
Signed-off-by: Du Lin mailto:du@intel.com> >
---
 MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
index fe1bbd6974..99364508cd 100644
--- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
+++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
@@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY
mAttributeConversionTable[] = {
   { EFI_RESOURCE_ATTRIBUTE_TESTED,  EFI_MEMORY_TESTED,
FALSE },
   { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV,
TRUE  },
   { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE,
EFI_MEMORY_MORE_RELIABLE, TRUE  },
+  { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP,
TRUE  },
   { 0,  0,
FALSE }
 };
 
-- 
2.44.0.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119378): https://edk2.groups.io/g/devel/message/119378
Mute This Topic: https://groups.io/mt/106383242/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute

2024-05-29 Thread Du Lin 
A pull request has been created for this patch: 
https://github.com/tianocore/edk2/pull/5691.

BRs,
Lin, Du

From: Ni, Ray 
Sent: Friday, May 10, 2024 10:53 AM
To: Lin, Du ; devel@edk2.groups.io
Cc: Liming Gao 
Subject: Re: [PATCH] MdeModulePkg: Update GCD attribute conversion to support 
SP attribute

Reviewed-by: Ray Ni mailto:ray...@intel.com>>

Thanks,
Ray

From: Lin, Du mailto:du@intel.com>>
Sent: Thursday, May 9, 2024 12:04
To: devel@edk2.groups.io 
mailto:devel@edk2.groups.io>>
Cc: Lin, Du mailto:du@intel.com>>; Liming Gao 
mailto:gaolim...@byosoft.com.cn>>; Ni, Ray 
mailto:ray...@intel.com>>
Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP 
attribute

Add a new entry into GCD attribute conversion table to convert
EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP.

Cc: Liming Gao mailto:gaolim...@byosoft.com.cn>>
Cc: Ray Ni mailto:ray...@intel.com>>
Signed-off-by: Du Lin mailto:du@intel.com>>
---
 MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
index fe1bbd6974..99364508cd 100644
--- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
+++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
@@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY  mAttributeConversionTable[] = 
{
   { EFI_RESOURCE_ATTRIBUTE_TESTED,  EFI_MEMORY_TESTED,
FALSE },
   { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV,
TRUE  },
   { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE,   EFI_MEMORY_MORE_RELIABLE, 
TRUE  },
+  { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP,
TRUE  },
   { 0,  0,
FALSE }
 };

--
2.44.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119342): https://edk2.groups.io/g/devel/message/119342
Mute This Topic: https://groups.io/mt/105995670/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute

2024-05-09 Thread Ni, Ray 
Reviewed-by: Ray Ni 

Thanks,
Ray

From: Lin, Du 
Sent: Thursday, May 9, 2024 12:04
To: devel@edk2.groups.io 
Cc: Lin, Du ; Liming Gao ; Ni, Ray 

Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP 
attribute

Add a new entry into GCD attribute conversion table to convert
EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP.

Cc: Liming Gao 
Cc: Ray Ni 
Signed-off-by: Du Lin 
---
 MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
index fe1bbd6974..99364508cd 100644
--- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
+++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
@@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY  mAttributeConversionTable[] = 
{
   { EFI_RESOURCE_ATTRIBUTE_TESTED,  EFI_MEMORY_TESTED,
FALSE },
   { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV,
TRUE  },
   { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE,   EFI_MEMORY_MORE_RELIABLE, 
TRUE  },
+  { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP,
TRUE  },
   { 0,  0,
FALSE }
 };

--
2.44.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118784): https://edk2.groups.io/g/devel/message/118784
Mute This Topic: https://groups.io/mt/105995670/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute

2024-05-08 Thread Du Lin 
Add a new entry into GCD attribute conversion table to convert
EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP.

Cc: Liming Gao 
Cc: Ray Ni 
Signed-off-by: Du Lin 
---
 MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
index fe1bbd6974..99364508cd 100644
--- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
+++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
@@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY  mAttributeConversionTable[] = 
{
   { EFI_RESOURCE_ATTRIBUTE_TESTED,  EFI_MEMORY_TESTED,
FALSE },
   { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV,
TRUE  },
   { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE,   EFI_MEMORY_MORE_RELIABLE, 
TRUE  },
+  { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP,
TRUE  },
   { 0,  0,
FALSE }
 };
 
-- 
2.44.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118712): https://edk2.groups.io/g/devel/message/118712
Mute This Topic: https://groups.io/mt/105995670/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-