Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM SMBIOS definitions

2023-04-18 Thread Chang, Abner via groups.io
[AMD Official Use Only - General]



> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Michael
> D Kinney via groups.io
> Sent: Wednesday, April 19, 2023 1:48 AM
> To: devel@edk2.groups.io; Chang, Abner 
> Cc: Gao, Liming ; Liu, Zhiguang
> ; Nickle Wang ; Igor
> Kulchytskyy ; Oram, Isaac W ;
> Attar, AbdulLateef (Abdul Lateef) ; Kinney,
> Michael D 
> Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM
> SMBIOS definitions
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Saturday, April 1, 2023 6:57 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D ; Gao, Liming
> > ; Liu, Zhiguang ;
> > Nickle Wang ; Igor Kulchytskyy ;
> > Oram, Isaac W ; Abdul Lateef Attar
> > 
> > Subject: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM SMBIOS
> > definitions
> >
> > From: Abner Chang 
> >
> > BZ #4396
> > This change adds definitions for DMTF PLDM SMBIOS Transfer
> > specification.
> >
> > Spec ref:
> >
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0246_1
> > .0.1.pdf
> >
> > Signed-off-by: Abner Chang 
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Cc: Zhiguang Liu 
> > Cc: Nickle Wang 
> > Cc: Igor Kulchytskyy 
> > Cc: Isaac Oram 
> > Cc: Abdul Lateef Attar 
> > ---
> >  .../IndustryStandard/PldmSmbiosTransfer.h | 182
> ++
> >  1 file changed, 182 insertions(+)
> >  create mode 100644
> > MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> >
> > diff --git a/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> > b/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> > new file mode 100644
> > index 000..2fcbe116abe
> > --- /dev/null
> > +++ b/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> > @@ -0,0 +1,182 @@
> > +/**
> > +  The definitions of DMTF Platform Level Data Model (PLDM)
> > +  SMBIOS Transfer Specification.
> > +
> > +  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> > +  SPDX-License-Identifier: BSD-2-Clause-Patent
> > +
> > +  @par Revision Reference:
> > +  DMTF Platform Level Data Model (PLDM) SMBIOS Transfer Specification
> > + Version 1.0.1
> > +
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0246
> > + _1.0.1.pdf
> > +
> > +**/
> > +
> > +#ifndef PLDM_SMBIOS_H_
> > +#define PLDM_SMBIOS_H_
> 
> The name of the file is PldmSmbiosTransfer.h.  Shouldn’t the include guard
> define name be PLDM_SMBIOS_TRANSFER_H_
Sure, this should be PLDM_SMBIOS_TRANSFER_H_

Thanks
Abner 


> 
> > +
> > +#include 
> > +
> > +#pragma pack(1)
> > +
> > +///
> > +/// Smbios-related definitions from PLDM for SMBIOS Transfer ///
> > +Specification (DMTF DSP0246) /// #define
> > +PLDM_GET_SMBIOS_STRUCTURE_TABLE_METADATA_COMMAND_CODE
> 0x01 #define
> > +PLDM_SET_SMBIOS_STRUCTURE_TABLE_METADATA_COMMAND_CODE
> 0x02
> > +#define PLDM_GET_SMBIOS_STRUCTURE_TABLE_COMMAND_CODE
> 0x03
> > +#define PLDM_SET_SMBIOS_STRUCTURE_TABLE_COMMAND_CODE
> 0x04
> > +#define PLDM_GET_SMBIOS_STRUCTURE_BY_TYPE_COMMAND_CODE
> 0x05
> > +#define
> PLDM_GET_SMBIOS_STRUCTURE_BY_HANDLE_COMMAND_CODE   0x06
> > +
> > +///
> > +/// PLDM SMBIOS transfer command specific completion code.
> > +///
> > +#define PLDM_COMPLETION_CODE_INVALID_DATA_TRANSFER_HANDLE
> 0x80
> > +#define
> PLDM_COMPLETION_CODE_INVALID_TRANSFER_OPERATION_FLAG 0x81
> > +#define PLDM_COMPLETION_CODE_INVALID_TRANSFER_FLAG
> 0x82
> > +#define
> PLDM_COMPLETION_CODE_NO_SMBIOS_STRUCTURE_TABLE_METADATA
> 0x83
> > +#define PLDM_COMPLETION_CODE_INVALID_DATA_INTEGRITY_CHECK
> 0x84
> > +#define
> PLDM_COMPLETION_CODE_SMBIOS_STRUCTURE_TABLE_UNAVAILABLE
> 0x85
> > +
> > +///
> > +/// Get SMBIOS Structure Table Metadata Response.
> > +///
> > +typedef struct {
> > +  UINT8 SmbiosMajorVersion;
> > +  UINT8 SmbiosMinorVersion;
> > +  UINT16MaximumStructureSize;
> > +  UINT16SmbiosStructureTableLength;
> > +  UINT16NumberOfSmbiosStructures;
> > +  UINT32SmbiosStructureTableIntegrityChecksum;
> > +} PLDM_SMBIOS_STRUCTURE_TABLE_METADATA;
> > +
> > +typedef struct {
> > +  PLDM_RESPONSE_HEADER  

Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM SMBIOS definitions

2023-04-18 Thread Michael D Kinney


> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Chang, Abner 
> via groups.io
> Sent: Saturday, April 1, 2023 6:57 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming 
> ; Liu, Zhiguang
> ; Nickle Wang ; Igor Kulchytskyy 
> ; Oram, Isaac W
> ; Abdul Lateef Attar 
> Subject: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM SMBIOS definitions
> 
> From: Abner Chang 
> 
> BZ #4396
> This change adds definitions for DMTF PLDM
> SMBIOS Transfer specification.
> 
> Spec ref:
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0246_1.0.1.pdf
> 
> Signed-off-by: Abner Chang 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Nickle Wang 
> Cc: Igor Kulchytskyy 
> Cc: Isaac Oram 
> Cc: Abdul Lateef Attar 
> ---
>  .../IndustryStandard/PldmSmbiosTransfer.h | 182 ++
>  1 file changed, 182 insertions(+)
>  create mode 100644 MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> 
> diff --git a/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> b/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> new file mode 100644
> index 000..2fcbe116abe
> --- /dev/null
> +++ b/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> @@ -0,0 +1,182 @@
> +/**
> +  The definitions of DMTF Platform Level Data Model (PLDM)
> +  SMBIOS Transfer Specification.
> +
> +  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +  @par Revision Reference:
> +  DMTF Platform Level Data Model (PLDM) SMBIOS Transfer Specification
> +  Version 1.0.1
> +  
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0246_1.0.1.pdf
> +
> +**/
> +
> +#ifndef PLDM_SMBIOS_H_
> +#define PLDM_SMBIOS_H_

The name of the file is PldmSmbiosTransfer.h.  Shouldn’t the include guard 
define name be PLDM_SMBIOS_TRANSFER_H_

> +
> +#include 
> +
> +#pragma pack(1)
> +
> +///
> +/// Smbios-related definitions from PLDM for SMBIOS Transfer
> +/// Specification (DMTF DSP0246)
> +///
> +#define PLDM_GET_SMBIOS_STRUCTURE_TABLE_METADATA_COMMAND_CODE  0x01
> +#define PLDM_SET_SMBIOS_STRUCTURE_TABLE_METADATA_COMMAND_CODE  0x02
> +#define PLDM_GET_SMBIOS_STRUCTURE_TABLE_COMMAND_CODE   0x03
> +#define PLDM_SET_SMBIOS_STRUCTURE_TABLE_COMMAND_CODE   0x04
> +#define PLDM_GET_SMBIOS_STRUCTURE_BY_TYPE_COMMAND_CODE 0x05
> +#define PLDM_GET_SMBIOS_STRUCTURE_BY_HANDLE_COMMAND_CODE   0x06
> +
> +///
> +/// PLDM SMBIOS transfer command specific completion code.
> +///
> +#define PLDM_COMPLETION_CODE_INVALID_DATA_TRANSFER_HANDLE0x80
> +#define PLDM_COMPLETION_CODE_INVALID_TRANSFER_OPERATION_FLAG 0x81
> +#define PLDM_COMPLETION_CODE_INVALID_TRANSFER_FLAG   0x82
> +#define PLDM_COMPLETION_CODE_NO_SMBIOS_STRUCTURE_TABLE_METADATA  0x83
> +#define PLDM_COMPLETION_CODE_INVALID_DATA_INTEGRITY_CHECK0x84
> +#define PLDM_COMPLETION_CODE_SMBIOS_STRUCTURE_TABLE_UNAVAILABLE  0x85
> +
> +///
> +/// Get SMBIOS Structure Table Metadata Response.
> +///
> +typedef struct {
> +  UINT8 SmbiosMajorVersion;
> +  UINT8 SmbiosMinorVersion;
> +  UINT16MaximumStructureSize;
> +  UINT16SmbiosStructureTableLength;
> +  UINT16NumberOfSmbiosStructures;
> +  UINT32SmbiosStructureTableIntegrityChecksum;
> +} PLDM_SMBIOS_STRUCTURE_TABLE_METADATA;
> +
> +typedef struct {
> +  PLDM_RESPONSE_HEADERResponseHeader;
> +  PLDM_SMBIOS_STRUCTURE_TABLE_METADATASmbiosStructureTableMetadata;
> +} PLDM_GET_SMBIOS_STRUCTURE_TABLE_METADATA_RESPONSE_FORMAT;
> +
> +///
> +/// Set SMBIOS Structure Table Metadata Request.
> +///
> +typedef struct {
> +  PLDM_REQUEST_HEADER RequestHeader;
> +  PLDM_SMBIOS_STRUCTURE_TABLE_METADATASmbiosStructureTableMetadata;
> +} PLDM_SET_SMBIOS_STRUCTURE_TABLE_METADATA_REQUEST_FORMAT;
> +
> +///
> +/// Set SMBIOS Structure Table Metadata Response.
> +///
> +typedef struct {
> +  PLDM_RESPONSE_HEADERResponseHeader;
> +} PLDM_SET_SMBIOS_STRUCTURE_TABLE_METADATA_RESPONSE_FORMAT;
> +
> +///
> +/// Get SMBIOS Structure Table Request.
> +///
> +typedef struct {
> +  UINT32DataTransferHandle;
> +  UINT8 TransferOperationFlag;
> +} PLDM_GET_SMBIOS_STRUCTURE_TABLE_REQUEST;
> +
> +typedef struct {
> +  PLDM_REQUEST_HEADERRequestHeader;
> +  PLDM_GET_SMBIOS_STRUCTURE_TABLE_REQUESTGetSmbiosStructureTableRequest;
> +} PLDM_GET_SMBIOS_STRUCTURE_TABLE_REQUEST_FORMAT;
> +
> +///
> +/// Get SMBIOS Structure Table Response.
> +///
> +typedef struct {
> +  UINT32Nex

Re: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM SMBIOS definitions

2023-04-17 Thread Chang, Abner via groups.io
[AMD Official Use Only - General]

Hi Maintainers,
Please review this.
Thanks
Abner

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Chang,
> Abner via groups.io
> Sent: Sunday, April 2, 2023 9:57 AM
> To: devel@edk2.groups.io
> Cc: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Nickle
> Wang ; Igor Kulchytskyy ; Isaac
> Oram ; Attar, AbdulLateef (Abdul Lateef)
> 
> Subject: [edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM SMBIOS
> definitions
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> From: Abner Chang 
> 
> BZ #4396
> This change adds definitions for DMTF PLDM SMBIOS Transfer specification.
> 
> Spec ref:
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0246_1
> .0.1.pdf
> 
> Signed-off-by: Abner Chang 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Nickle Wang 
> Cc: Igor Kulchytskyy 
> Cc: Isaac Oram 
> Cc: Abdul Lateef Attar 
> ---
>  .../IndustryStandard/PldmSmbiosTransfer.h | 182 ++
>  1 file changed, 182 insertions(+)
>  create mode 100644
> MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> 
> diff --git a/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> b/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> new file mode 100644
> index 000..2fcbe116abe
> --- /dev/null
> +++ b/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
> @@ -0,0 +1,182 @@
> +/**
> +  The definitions of DMTF Platform Level Data Model (PLDM)
> +  SMBIOS Transfer Specification.
> +
> +  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +  @par Revision Reference:
> +  DMTF Platform Level Data Model (PLDM) SMBIOS Transfer Specification
> + Version 1.0.1
> +
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0246_1
> + .0.1.pdf
> +
> +**/
> +
> +#ifndef PLDM_SMBIOS_H_
> +#define PLDM_SMBIOS_H_
> +
> +#include 
> +
> +#pragma pack(1)
> +
> +///
> +/// Smbios-related definitions from PLDM for SMBIOS Transfer ///
> +Specification (DMTF DSP0246) /// #define
> +PLDM_GET_SMBIOS_STRUCTURE_TABLE_METADATA_COMMAND_CODE
> 0x01 #define
> +PLDM_SET_SMBIOS_STRUCTURE_TABLE_METADATA_COMMAND_CODE
> 0x02
> +#define PLDM_GET_SMBIOS_STRUCTURE_TABLE_COMMAND_CODE
> 0x03
> +#define PLDM_SET_SMBIOS_STRUCTURE_TABLE_COMMAND_CODE
> 0x04
> +#define PLDM_GET_SMBIOS_STRUCTURE_BY_TYPE_COMMAND_CODE
> 0x05
> +#define PLDM_GET_SMBIOS_STRUCTURE_BY_HANDLE_COMMAND_CODE
> 0x06
> +
> +///
> +/// PLDM SMBIOS transfer command specific completion code.
> +///
> +#define PLDM_COMPLETION_CODE_INVALID_DATA_TRANSFER_HANDLE
> 0x80
> +#define
> PLDM_COMPLETION_CODE_INVALID_TRANSFER_OPERATION_FLAG 0x81
> +#define PLDM_COMPLETION_CODE_INVALID_TRANSFER_FLAG
> 0x82
> +#define
> PLDM_COMPLETION_CODE_NO_SMBIOS_STRUCTURE_TABLE_METADATA
> 0x83
> +#define PLDM_COMPLETION_CODE_INVALID_DATA_INTEGRITY_CHECK
> 0x84
> +#define
> PLDM_COMPLETION_CODE_SMBIOS_STRUCTURE_TABLE_UNAVAILABLE
> 0x85
> +
> +///
> +/// Get SMBIOS Structure Table Metadata Response.
> +///
> +typedef struct {
> +  UINT8 SmbiosMajorVersion;
> +  UINT8 SmbiosMinorVersion;
> +  UINT16MaximumStructureSize;
> +  UINT16SmbiosStructureTableLength;
> +  UINT16NumberOfSmbiosStructures;
> +  UINT32SmbiosStructureTableIntegrityChecksum;
> +} PLDM_SMBIOS_STRUCTURE_TABLE_METADATA;
> +
> +typedef struct {
> +  PLDM_RESPONSE_HEADERResponseHeader;
> +  PLDM_SMBIOS_STRUCTURE_TABLE_METADATA
> SmbiosStructureTableMetadata;
> +}
> PLDM_GET_SMBIOS_STRUCTURE_TABLE_METADATA_RESPONSE_FORMAT;
> +
> +///
> +/// Set SMBIOS Structure Table Metadata Request.
> +///
> +typedef struct {
> +  PLDM_REQUEST_HEADER RequestHeader;
> +  PLDM_SMBIOS_STRUCTURE_TABLE_METADATA
> SmbiosStructureTableMetadata;
> +} PLDM_SET_SMBIOS_STRUCTURE_TABLE_METADATA_REQUEST_FORMAT;
> +
> +///
> +/// Set SMBIOS Structure Table Metadata Response.
> +///
> +typedef struct {
> +  PLDM_RESPONSE_HEADERResponseHeader;
> +}
> PLDM_SET_SMBIOS_STRUCTURE_TABLE_METADATA_RESPONSE_FORMAT;
> +
> +///
> +/// Get SMBIOS Structure Table Request.
> +///
> +typedef struct {
> +  UINT32DataTransferHandle;
> +  UINT8 TransferOperationFlag;
> +} PLDM_GET_SMBIOS_STRUCTURE_TABLE_REQUEST;
> +
> +typedef struct {
> +  PLDM_REQUEST_HEADERRequestHeader;
> +  PLDM_GET_SMBIOS_STRUCTURE_TABLE_REQUEST
> GetSmbiosStructureT

[edk2-devel] [PATCH] MdePkg/Include: Add DMTF PLDM SMBIOS definitions

2023-04-01 Thread Chang, Abner via groups.io
From: Abner Chang 

BZ #4396
This change adds definitions for DMTF PLDM
SMBIOS Transfer specification.

Spec ref:
https://www.dmtf.org/sites/default/files/standards/documents/DSP0246_1.0.1.pdf

Signed-off-by: Abner Chang 
Cc: Michael D Kinney 
Cc: Liming Gao 
Cc: Zhiguang Liu 
Cc: Nickle Wang 
Cc: Igor Kulchytskyy 
Cc: Isaac Oram 
Cc: Abdul Lateef Attar 
---
 .../IndustryStandard/PldmSmbiosTransfer.h | 182 ++
 1 file changed, 182 insertions(+)
 create mode 100644 MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h

diff --git a/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h 
b/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
new file mode 100644
index 000..2fcbe116abe
--- /dev/null
+++ b/MdePkg/Include/IndustryStandard/PldmSmbiosTransfer.h
@@ -0,0 +1,182 @@
+/**
+  The definitions of DMTF Platform Level Data Model (PLDM)
+  SMBIOS Transfer Specification.
+
+  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+
+  @par Revision Reference:
+  DMTF Platform Level Data Model (PLDM) SMBIOS Transfer Specification
+  Version 1.0.1
+  
https://www.dmtf.org/sites/default/files/standards/documents/DSP0246_1.0.1.pdf
+
+**/
+
+#ifndef PLDM_SMBIOS_H_
+#define PLDM_SMBIOS_H_
+
+#include 
+
+#pragma pack(1)
+
+///
+/// Smbios-related definitions from PLDM for SMBIOS Transfer
+/// Specification (DMTF DSP0246)
+///
+#define PLDM_GET_SMBIOS_STRUCTURE_TABLE_METADATA_COMMAND_CODE  0x01
+#define PLDM_SET_SMBIOS_STRUCTURE_TABLE_METADATA_COMMAND_CODE  0x02
+#define PLDM_GET_SMBIOS_STRUCTURE_TABLE_COMMAND_CODE   0x03
+#define PLDM_SET_SMBIOS_STRUCTURE_TABLE_COMMAND_CODE   0x04
+#define PLDM_GET_SMBIOS_STRUCTURE_BY_TYPE_COMMAND_CODE 0x05
+#define PLDM_GET_SMBIOS_STRUCTURE_BY_HANDLE_COMMAND_CODE   0x06
+
+///
+/// PLDM SMBIOS transfer command specific completion code.
+///
+#define PLDM_COMPLETION_CODE_INVALID_DATA_TRANSFER_HANDLE0x80
+#define PLDM_COMPLETION_CODE_INVALID_TRANSFER_OPERATION_FLAG 0x81
+#define PLDM_COMPLETION_CODE_INVALID_TRANSFER_FLAG   0x82
+#define PLDM_COMPLETION_CODE_NO_SMBIOS_STRUCTURE_TABLE_METADATA  0x83
+#define PLDM_COMPLETION_CODE_INVALID_DATA_INTEGRITY_CHECK0x84
+#define PLDM_COMPLETION_CODE_SMBIOS_STRUCTURE_TABLE_UNAVAILABLE  0x85
+
+///
+/// Get SMBIOS Structure Table Metadata Response.
+///
+typedef struct {
+  UINT8 SmbiosMajorVersion;
+  UINT8 SmbiosMinorVersion;
+  UINT16MaximumStructureSize;
+  UINT16SmbiosStructureTableLength;
+  UINT16NumberOfSmbiosStructures;
+  UINT32SmbiosStructureTableIntegrityChecksum;
+} PLDM_SMBIOS_STRUCTURE_TABLE_METADATA;
+
+typedef struct {
+  PLDM_RESPONSE_HEADERResponseHeader;
+  PLDM_SMBIOS_STRUCTURE_TABLE_METADATASmbiosStructureTableMetadata;
+} PLDM_GET_SMBIOS_STRUCTURE_TABLE_METADATA_RESPONSE_FORMAT;
+
+///
+/// Set SMBIOS Structure Table Metadata Request.
+///
+typedef struct {
+  PLDM_REQUEST_HEADER RequestHeader;
+  PLDM_SMBIOS_STRUCTURE_TABLE_METADATASmbiosStructureTableMetadata;
+} PLDM_SET_SMBIOS_STRUCTURE_TABLE_METADATA_REQUEST_FORMAT;
+
+///
+/// Set SMBIOS Structure Table Metadata Response.
+///
+typedef struct {
+  PLDM_RESPONSE_HEADERResponseHeader;
+} PLDM_SET_SMBIOS_STRUCTURE_TABLE_METADATA_RESPONSE_FORMAT;
+
+///
+/// Get SMBIOS Structure Table Request.
+///
+typedef struct {
+  UINT32DataTransferHandle;
+  UINT8 TransferOperationFlag;
+} PLDM_GET_SMBIOS_STRUCTURE_TABLE_REQUEST;
+
+typedef struct {
+  PLDM_REQUEST_HEADERRequestHeader;
+  PLDM_GET_SMBIOS_STRUCTURE_TABLE_REQUESTGetSmbiosStructureTableRequest;
+} PLDM_GET_SMBIOS_STRUCTURE_TABLE_REQUEST_FORMAT;
+
+///
+/// Get SMBIOS Structure Table Response.
+///
+typedef struct {
+  UINT32NextDataTransferHandle;
+  UINT8 TransferFlag;
+  UINT8 Table[0];
+} PLDM_GET_SMBIOS_STRUCTURE_TABLE_RESPONSE;
+
+typedef struct {
+  PLDM_RESPONSE_HEADERResponseHeader;
+  PLDM_GET_SMBIOS_STRUCTURE_TABLE_RESPONSEGetSmbiosStructureTableResponse;
+} PLDM_GET_SMBIOS_STRUCTURE_TABLE_RESPONSE_FORMAT;
+
+///
+/// Set SMBIOS Structure Table Request.
+///
+typedef struct {
+  UINT32DataTransferHandle;
+  UINT8 TransferFlag;
+  UINT8 Table[0];
+} PLDM_SET_SMBIOS_STRUCTURE_TABLE_REQUEST;
+
+typedef struct {
+  PLDM_REQUEST_HEADERRequestHeader;
+  PLDM_SET_SMBIOS_STRUCTURE_TABLE_REQUESTSetSmbiosStructureTableRequest;
+} PLDM_SET_SMBIOS_STRUCTURE_TABLE_REQUEST_FORMAT;
+
+///
+/// Set SMBIOS Structure Table Response.
+///
+typedef struct {
+  PLDM_RESPONSE_HEADERResponseHeader;
+  UINT32  NextDataTransferHandle;
+} PLDM_SET_SMBIOS_STRUCTURE_TABLE_RESPONSE_FORMAT;
+
+///
+/// Get SMBIOS Structure by Type Request.
+///
+typedef struct {
+  UINT32DataTransferHandle;
+  UINT8 TransferOperationFlag;
+  UINT8 Type;
+  UINT16StructureInstanceId;
+}