Reviewed-by: Gua Guo
Please send two commits into one PR.
First commit "PcAtChipsetPkg: Move RTC PCD to dynamic PCD"
Second commit "UefiPayloadPkg: Move RTC PCD to dynamic PCD"
-Original Message-
From: Liu, KasimX
Sent: Wednesday, December 14, 2022 4:22 PM
To: devel@edk2.groups.io
Cc: Liu, KasimX ; Dong, Guo ; Ni, Ray
; Lu, James ; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Remove RTC_INDEX/TARGET from UplBuild macro
list
From: KasimX Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193
In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the
RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Cc: Gua Guo
Signed-off-by: KasimX Liu
---
PcAtChipsetPkg/PcAtChipsetPkg.dec | 16
UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++--
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec
b/PcAtChipsetPkg/PcAtChipsetPkg.dec
index ed2d95550b..a53ca777e8 100644
--- a/PcAtChipsetPkg/PcAtChipsetPkg.dec
+++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec
@@ -84,6 +84,14 @@
# @Prompt RTC Target Register address
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x0023 +
## Specifies RTC Index Register address in I/O space.+ # @Prompt RTC Index
Register address+
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x001E++ ##
Specifies RTC Target Register address in I/O space.+ # @Prompt RTC Target
Register address+
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x001F+
[PcdsFixedAtBuild, PcdsPatchableInModule] ## Defines the ACPI register set
base address. # The invalid 0x is as its default value. It must be
configured to the real value.@@ -146,14 +154,6 @@
# @Prompt Initial value for Register_D in RTC.
gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0x001D
- ## Specifies RTC Index Register address in I/O space.- # @Prompt RTC Index
Register address-
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x001E-- ##
Specifies RTC Target Register address in I/O space.- # @Prompt RTC Target
Register address-
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x001F- ##
RTC Update Timeout Value(microsecond). # @Prompt RTC Update Timeout Value.
gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|10|UINT32|0x0020diff
--git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 723a50a422..82cff41780 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -471,8 +471,6 @@
!endif [PcdsPatchableInModule.X64]-
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)-
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER) !if
$(NETWORK_DRIVER_ENABLE) == TRUE
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE !endif@@ -579,6
+577,9 @@
gUefiCpuPkgTokenSpaceGuid.PcdSevEsIsEnabled|0
gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|TRUE +
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)+
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER)+
# # Components Section - list of all EDK II Modules needed by this Platform.--
2.32.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97542): https://edk2.groups.io/g/devel/message/97542
Mute This Topic: https://groups.io/mt/95760072/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
