Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console.
On Thu, 23 Mar 2023 at 09:20, Gerd Hoffmann wrote: > > On Wed, Mar 22, 2023 at 10:31:32AM -0600, Rebecca Cran wrote: > > On 3/22/23 10:20 AM, Ard Biesheuvel wrote: > > > On Fri, 17 Mar 2023 at 13:19, Gerd Hoffmann wrote: > > > > Time to leave behind relics from the last century and arrive in the > > > > modern world. Drop PC-ANSI Terminal Type for the serial console, use > > > > UTF-8 instead. > > > > > > > > Signed-off-by: Gerd Hoffmann > > > No objections here but how will I be able to observe the difference? > > > > I'm not sure if it's as simple as this or if it depends on the terminal, > > TERM setting etc., > > It does. It depends on the locale the terminal application is > running in. These days that is a utf-8 locale in 99% of the cases, > i.e. "de_DE.UTF-8" for me. > > > but I saw a difference when I opened the UiApp and opened > > the drop-down "Select Language". > > > > Before the patch, it showed "Fran?ais", and after, "Français". > > Yes, essentially everything which is not ascii shows correct now, > including the line-drawing characters which you can see in alot > of places in UiApp on the serial console. > Merged as #4164 - thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101655): https://edk2.groups.io/g/devel/message/101655 Mute This Topic: https://groups.io/mt/97671520/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console.
On Wed, Mar 22, 2023 at 10:31:32AM -0600, Rebecca Cran wrote: > On 3/22/23 10:20 AM, Ard Biesheuvel wrote: > > On Fri, 17 Mar 2023 at 13:19, Gerd Hoffmann wrote: > > > Time to leave behind relics from the last century and arrive in the > > > modern world. Drop PC-ANSI Terminal Type for the serial console, use > > > UTF-8 instead. > > > > > > Signed-off-by: Gerd Hoffmann > > No objections here but how will I be able to observe the difference? > > I'm not sure if it's as simple as this or if it depends on the terminal, > TERM setting etc., It does. It depends on the locale the terminal application is running in. These days that is a utf-8 locale in 99% of the cases, i.e. "de_DE.UTF-8" for me. > but I saw a difference when I opened the UiApp and opened > the drop-down "Select Language". > > Before the patch, it showed "Fran?ais", and after, "Français". Yes, essentially everything which is not ascii shows correct now, including the line-drawing characters which you can see in alot of places in UiApp on the serial console. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101650): https://edk2.groups.io/g/devel/message/101650 Mute This Topic: https://groups.io/mt/97671520/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console.
On 3/22/23 10:20 AM, Ard Biesheuvel wrote: On Fri, 17 Mar 2023 at 13:19, Gerd Hoffmann wrote: Time to leave behind relics from the last century and arrive in the modern world. Drop PC-ANSI Terminal Type for the serial console, use UTF-8 instead. Signed-off-by: Gerd Hoffmann No objections here but how will I be able to observe the difference? I'm not sure if it's as simple as this or if it depends on the terminal, TERM setting etc., but I saw a difference when I opened the UiApp and opened the drop-down "Select Language". Before the patch, it showed "Fran?ais", and after, "Français". -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101589): https://edk2.groups.io/g/devel/message/101589 Mute This Topic: https://groups.io/mt/97671520/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console.
On Fri, 17 Mar 2023 at 13:19, Gerd Hoffmann wrote:
>
> Time to leave behind relics from the last century and arrive in the
> modern world. Drop PC-ANSI Terminal Type for the serial console, use
> UTF-8 instead.
>
> Signed-off-by: Gerd Hoffmann
No objections here but how will I be able to observe the difference?
> ---
> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 4 ++--
> OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> index 1676d61616d8..18b3deb9db59 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> @@ -126,7 +126,7 @@ extern VENDOR_DEVICE_PATHgTerminalTypeDeviceNode;
> 1 \
>}
>
> -#define gPcAnsiTerminal \
> +#define gVtUtf8Terminal \
>{ \
> { \
>MESSAGING_DEVICE_PATH, \
> @@ -136,7 +136,7 @@ extern VENDOR_DEVICE_PATHgTerminalTypeDeviceNode;
> (UINT8) ((sizeof (VENDOR_DEVICE_PATH)) >> 8) \
>} \
> }, \
> -DEVICE_PATH_MESSAGING_PC_ANSI \
> +DEVICE_PATH_MESSAGING_VT_UTF8 \
>}
>
> #define gEndEntire \
> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
> b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
> index 6536d9fe369e..c1801725c2c8 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
> @@ -47,7 +47,7 @@ typedef struct {
> ACPI_HID_DEVICE_PATH gPnpPs2KeyboardDeviceNode = gPnpPs2Keyboard;
> ACPI_HID_DEVICE_PATH gPnp16550ComPortDeviceNode = gPnp16550ComPort;
> UART_DEVICE_PATH gUartDeviceNode= gUart;
> -VENDOR_DEVICE_PATHgTerminalTypeDeviceNode= gPcAnsiTerminal;
> +VENDOR_DEVICE_PATHgTerminalTypeDeviceNode= gVtUtf8Terminal;
>
> //
> // Platform specific keyboard device path
> @@ -83,7 +83,7 @@ VENDOR_UART_DEVICE_PATH gDebugAgentUartDevicePath = {
> 0, // Parity - Default
> 0, // StopBits - Default
>},
> - gPcAnsiTerminal,
> + gVtUtf8Terminal,
>gEndEntire
> };
>
> @@ -168,7 +168,7 @@ STATIC VENDOR_UART_DEVICE_PATH gXenConsoleDevicePath = {
> FixedPcdGet8 (PcdUartDefaultParity),
> FixedPcdGet8 (PcdUartDefaultStopBits),
>},
> - gPcAnsiTerminal,
> + gVtUtf8Terminal,
>gEndEntire
> };
>
> --
> 2.39.2
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101588): https://edk2.groups.io/g/devel/message/101588
Mute This Topic: https://groups.io/mt/97671520/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console.
Time to leave behind relics from the last century and arrive in the
modern world. Drop PC-ANSI Terminal Type for the serial console, use
UTF-8 instead.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 4 ++--
OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
index 1676d61616d8..18b3deb9db59 100644
--- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
+++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
@@ -126,7 +126,7 @@ extern VENDOR_DEVICE_PATHgTerminalTypeDeviceNode;
1 \
}
-#define gPcAnsiTerminal \
+#define gVtUtf8Terminal \
{ \
{ \
MESSAGING_DEVICE_PATH, \
@@ -136,7 +136,7 @@ extern VENDOR_DEVICE_PATHgTerminalTypeDeviceNode;
(UINT8) ((sizeof (VENDOR_DEVICE_PATH)) >> 8) \
} \
}, \
-DEVICE_PATH_MESSAGING_PC_ANSI \
+DEVICE_PATH_MESSAGING_VT_UTF8 \
}
#define gEndEntire \
diff --git a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
index 6536d9fe369e..c1801725c2c8 100644
--- a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
+++ b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c
@@ -47,7 +47,7 @@ typedef struct {
ACPI_HID_DEVICE_PATH gPnpPs2KeyboardDeviceNode = gPnpPs2Keyboard;
ACPI_HID_DEVICE_PATH gPnp16550ComPortDeviceNode = gPnp16550ComPort;
UART_DEVICE_PATH gUartDeviceNode= gUart;
-VENDOR_DEVICE_PATHgTerminalTypeDeviceNode= gPcAnsiTerminal;
+VENDOR_DEVICE_PATHgTerminalTypeDeviceNode= gVtUtf8Terminal;
//
// Platform specific keyboard device path
@@ -83,7 +83,7 @@ VENDOR_UART_DEVICE_PATH gDebugAgentUartDevicePath = {
0, // Parity - Default
0, // StopBits - Default
},
- gPcAnsiTerminal,
+ gVtUtf8Terminal,
gEndEntire
};
@@ -168,7 +168,7 @@ STATIC VENDOR_UART_DEVICE_PATH gXenConsoleDevicePath = {
FixedPcdGet8 (PcdUartDefaultParity),
FixedPcdGet8 (PcdUartDefaultStopBits),
},
- gPcAnsiTerminal,
+ gVtUtf8Terminal,
gEndEntire
};
--
2.39.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101334): https://edk2.groups.io/g/devel/message/101334
Mute This Topic: https://groups.io/mt/97671520/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
