回复: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification

2022-08-11 Thread gaoliming via groups.io
Sean:

 According to the description, I agree with Pedro that this is a recommendation 
and not mandatory. Do you think so?

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Pedro Falcato
发送时间: 2022年8月5日 15:04
收件人: edk2-devel-groups-io ; sean@starlabs.systems
抄送: Liming Gao ; Zhichao Gao ; 
Ray Ni ; Jian J Wang 
主题: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow 
BGRT specification

 

Hi Sean,

 

I think it's clear from the wording that the 38.2% thing is a recommendation 
and not mandatory. I was curious and checked out the ACPI spec and they appear 
to not mention that at all. Maybe reword things to "Microsoft recommendation"?

 

Thanks,

Pedro

 

On Fri, 5 Aug 2022, 07:55 Sean Rhodes, mailto:sean@starlabs.systems> > wrote:

Hi Liming

 

Microsoft details about positioning can be found here: 
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components

 

Thanks

 

Sean

 

On Fri, 5 Aug 2022 at 07:00, gaoliming via groups.io <http://groups.io>  
mailto:byosoft.com...@groups.io> > wrote:

Sean:
  Can you give BGRT spec link? I want to check the spec description. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>  
> mailto:devel@edk2.groups.io> > 代表 Sean Rhodes
> 发送时间: 2022年7月26日 16:15
> 收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
> 抄送: Sean Rhodes mailto:sean@starlabs.systems> >; 
> Zhichao Gao
> mailto:zhichao@intel.com> >; Ray Ni 
> mailto:ray...@intel.com> >; Jian J Wang
> mailto:jian.j.w...@intel.com> >; Liming Gao 
> mailto:gaolim...@byosoft.com.cn> >
> 主题: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to
> follow BGRT specification
> 
> Add an option to position the logo 38.2% from the top of the screen,
> which follows the BGRT specification.
> 
> Cc: Zhichao Gao mailto:zhichao@intel.com> >
> Cc: Ray Ni mailto:ray...@intel.com> >
> Cc: Jian J Wang mailto:jian.j.w...@intel.com> >
> Cc: Liming Gao mailto:gaolim...@byosoft.com.cn> >
> Signed-off-by: Sean Rhodes  <mailto:sean@starlabs.systems> >
> ---
>  MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
>  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ---
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> index 08e1dc35a4..7c9ef63c66 100644
> --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> @@ -29,7 +29,8 @@ typedef enum {
>EdkiiPlatformLogoDisplayAttributeCenterBottom,
> 
>EdkiiPlatformLogoDisplayAttributeLeftBottom,
> 
>EdkiiPlatformLogoDisplayAttributeCenterLeft,
> 
> -  EdkiiPlatformLogoDisplayAttributeCenter
> 
> +  EdkiiPlatformLogoDisplayAttributeCenter,
> 
> +  EdkiiPlatformLogoDisplayAttributeBGRTSpecification
> 
>  } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
> 
> 
> 
>  /**
> 
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 478ec2d40e..ac086f9c79 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -169,7 +169,6 @@ BootLogoEnableLogo (
>  DestX = SizeOfX - Image.Width;
> 
>  DestY = 0;
> 
>  break;
> 
> -
> 
>case EdkiiPlatformLogoDisplayAttributeCenterLeft:
> 
>  DestX = 0;
> 
>  DestY = (SizeOfY - Image.Height) / 2;
> 
> @@ -182,7 +181,6 @@ BootLogoEnableLogo (
>  DestX = SizeOfX - Image.Width;
> 
>  DestY = (SizeOfY - Image.Height) / 2;
> 
>  break;
> 
> -
> 
>case EdkiiPlatformLogoDisplayAttributeLeftBottom:
> 
>  DestX = 0;
> 
>  DestY = SizeOfY - Image.Height;
> 
> @@ -195,7 +193,10 @@ BootLogoEnableLogo (
>  DestX = SizeOfX - Image.Width;
> 
>  DestY = SizeOfY - Image.Height;
> 
>  break;
> 
> -
> 
> +  case EdkiiPlatformLogoDisplayAttributeBGRTSpecification:
> 
> +DestX = (SizeOfX - Image.Width) / 2;
> 
> +DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;
> 
> +break;
> 
>default:
> 
>  ASSERT (FALSE);
> 
>  continue;
> 
> --
> 2.34.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#91842): https://edk2.groups.io/g/devel/message/91842
> Mute This Topic: https://groups.io/mt/92623125/4905953
> Group Owner: devel+ow...@edk2.groups.io <mailto:devel%2bow...@edk2.

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification

2022-08-05 Thread Pedro Falcato
Hi Sean,

I think it's clear from the wording that the 38.2% thing is a
recommendation and not mandatory. I was curious and checked out the ACPI
spec and they appear to not mention that at all. Maybe reword things to
"Microsoft recommendation"?

Thanks,
Pedro

On Fri, 5 Aug 2022, 07:55 Sean Rhodes,  wrote:

> Hi Liming
>
> Microsoft details about positioning can be found here:
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components
>
> Thanks
>
> Sean
>
> On Fri, 5 Aug 2022 at 07:00, gaoliming via groups.io  byosoft.com...@groups.io> wrote:
>
>> Sean:
>>   Can you give BGRT spec link? I want to check the spec description.
>>
>> Thanks
>> Liming
>> > -邮件原件-
>> > 发件人: devel@edk2.groups.io  代表 Sean Rhodes
>> > 发送时间: 2022年7月26日 16:15
>> > 收件人: devel@edk2.groups.io
>> > 抄送: Sean Rhodes ; Zhichao Gao
>> > ; Ray Ni ; Jian J Wang
>> > ; Liming Gao 
>> > 主题: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to
>> > follow BGRT specification
>> >
>> > Add an option to position the logo 38.2% from the top of the screen,
>> > which follows the BGRT specification.
>> >
>> > Cc: Zhichao Gao 
>> > Cc: Ray Ni 
>> > Cc: Jian J Wang 
>> > Cc: Liming Gao 
>> > Signed-off-by: Sean Rhodes 
>> > ---
>> >  MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
>> >  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ---
>> >  2 files changed, 6 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
>> > b/MdeModulePkg/Include/Protocol/PlatformLogo.h
>> > index 08e1dc35a4..7c9ef63c66 100644
>> > --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
>> > +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
>> > @@ -29,7 +29,8 @@ typedef enum {
>> >EdkiiPlatformLogoDisplayAttributeCenterBottom,
>> >
>> >EdkiiPlatformLogoDisplayAttributeLeftBottom,
>> >
>> >EdkiiPlatformLogoDisplayAttributeCenterLeft,
>> >
>> > -  EdkiiPlatformLogoDisplayAttributeCenter
>> >
>> > +  EdkiiPlatformLogoDisplayAttributeCenter,
>> >
>> > +  EdkiiPlatformLogoDisplayAttributeBGRTSpecification
>> >
>> >  } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
>> >
>> >
>> >
>> >  /**
>> >
>> > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
>> > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
>> > index 478ec2d40e..ac086f9c79 100644
>> > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
>> > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
>> > @@ -169,7 +169,6 @@ BootLogoEnableLogo (
>> >  DestX = SizeOfX - Image.Width;
>> >
>> >  DestY = 0;
>> >
>> >  break;
>> >
>> > -
>> >
>> >case EdkiiPlatformLogoDisplayAttributeCenterLeft:
>> >
>> >  DestX = 0;
>> >
>> >  DestY = (SizeOfY - Image.Height) / 2;
>> >
>> > @@ -182,7 +181,6 @@ BootLogoEnableLogo (
>> >  DestX = SizeOfX - Image.Width;
>> >
>> >  DestY = (SizeOfY - Image.Height) / 2;
>> >
>> >  break;
>> >
>> > -
>> >
>> >case EdkiiPlatformLogoDisplayAttributeLeftBottom:
>> >
>> >  DestX = 0;
>> >
>> >  DestY = SizeOfY - Image.Height;
>> >
>> > @@ -195,7 +193,10 @@ BootLogoEnableLogo (
>> >  DestX = SizeOfX - Image.Width;
>> >
>> >  DestY = SizeOfY - Image.Height;
>> >
>> >  break;
>> >
>> > -
>> >
>> > +  case EdkiiPlatformLogoDisplayAttributeBGRTSpecification:
>> >
>> > +DestX = (SizeOfX - Image.Width) / 2;
>> >
>> > +DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;
>> >
>> > +break;
>> >
>> >default:
>> >
>> >  ASSERT (FALSE);
>> >
>> >  continue;
>> >
>> > --
>> > 2.34.1
>> >
>> >
>> >
>> > -=-=-=-=-=-=
>> > Groups.io Links: You receive all messages sent to this group.
>> > View/Reply Online (#91842):
>> https://edk2.groups.io/g/devel/message/91842
>> > Mute This Topic: https://groups.io/mt/92623125/4905953
>> > Group Owner: devel+ow...@edk2.groups.io
>> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
>> > [gaolim...@byosoft.com.cn]
>> > -=-=-=-=-=-=
>> >
>>
>>
>>
>>
>>
>>
>>
>>
>> 
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92155): https://edk2.groups.io/g/devel/message/92155
Mute This Topic: https://groups.io/mt/92830609/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification

2022-08-04 Thread Sean Rhodes
Hi Liming

Microsoft details about positioning can be found here:
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components

Thanks

Sean

On Fri, 5 Aug 2022 at 07:00, gaoliming via groups.io  wrote:

> Sean:
>   Can you give BGRT spec link? I want to check the spec description.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Sean Rhodes
> > 发送时间: 2022年7月26日 16:15
> > 收件人: devel@edk2.groups.io
> > 抄送: Sean Rhodes ; Zhichao Gao
> > ; Ray Ni ; Jian J Wang
> > ; Liming Gao 
> > 主题: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to
> > follow BGRT specification
> >
> > Add an option to position the logo 38.2% from the top of the screen,
> > which follows the BGRT specification.
> >
> > Cc: Zhichao Gao 
> > Cc: Ray Ni 
> > Cc: Jian J Wang 
> > Cc: Liming Gao 
> > Signed-off-by: Sean Rhodes 
> > ---
> >  MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
> >  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ---
> >  2 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> > b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> > index 08e1dc35a4..7c9ef63c66 100644
> > --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> > +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> > @@ -29,7 +29,8 @@ typedef enum {
> >EdkiiPlatformLogoDisplayAttributeCenterBottom,
> >
> >EdkiiPlatformLogoDisplayAttributeLeftBottom,
> >
> >EdkiiPlatformLogoDisplayAttributeCenterLeft,
> >
> > -  EdkiiPlatformLogoDisplayAttributeCenter
> >
> > +  EdkiiPlatformLogoDisplayAttributeCenter,
> >
> > +  EdkiiPlatformLogoDisplayAttributeBGRTSpecification
> >
> >  } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
> >
> >
> >
> >  /**
> >
> > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > index 478ec2d40e..ac086f9c79 100644
> > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> > @@ -169,7 +169,6 @@ BootLogoEnableLogo (
> >  DestX = SizeOfX - Image.Width;
> >
> >  DestY = 0;
> >
> >  break;
> >
> > -
> >
> >case EdkiiPlatformLogoDisplayAttributeCenterLeft:
> >
> >  DestX = 0;
> >
> >  DestY = (SizeOfY - Image.Height) / 2;
> >
> > @@ -182,7 +181,6 @@ BootLogoEnableLogo (
> >  DestX = SizeOfX - Image.Width;
> >
> >  DestY = (SizeOfY - Image.Height) / 2;
> >
> >  break;
> >
> > -
> >
> >case EdkiiPlatformLogoDisplayAttributeLeftBottom:
> >
> >  DestX = 0;
> >
> >  DestY = SizeOfY - Image.Height;
> >
> > @@ -195,7 +193,10 @@ BootLogoEnableLogo (
> >  DestX = SizeOfX - Image.Width;
> >
> >  DestY = SizeOfY - Image.Height;
> >
> >  break;
> >
> > -
> >
> > +  case EdkiiPlatformLogoDisplayAttributeBGRTSpecification:
> >
> > +DestX = (SizeOfX - Image.Width) / 2;
> >
> > +DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;
> >
> > +break;
> >
> >default:
> >
> >  ASSERT (FALSE);
> >
> >  continue;
> >
> > --
> > 2.34.1
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#91842): https://edk2.groups.io/g/devel/message/91842
> > Mute This Topic: https://groups.io/mt/92623125/4905953
> > Group Owner: devel+ow...@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [gaolim...@byosoft.com.cn]
> > -=-=-=-=-=-=
> >
>
>
>
>
>
> 
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92154): https://edk2.groups.io/g/devel/message/92154
Mute This Topic: https://groups.io/mt/92830609/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




回复: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification

2022-08-04 Thread gaoliming via groups.io
Sean:
  Can you give BGRT spec link? I want to check the spec description. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Sean Rhodes
> 发送时间: 2022年7月26日 16:15
> 收件人: devel@edk2.groups.io
> 抄送: Sean Rhodes ; Zhichao Gao
> ; Ray Ni ; Jian J Wang
> ; Liming Gao 
> 主题: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to
> follow BGRT specification
> 
> Add an option to position the logo 38.2% from the top of the screen,
> which follows the BGRT specification.
> 
> Cc: Zhichao Gao 
> Cc: Ray Ni 
> Cc: Jian J Wang 
> Cc: Liming Gao 
> Signed-off-by: Sean Rhodes 
> ---
>  MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
>  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ---
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> index 08e1dc35a4..7c9ef63c66 100644
> --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> @@ -29,7 +29,8 @@ typedef enum {
>EdkiiPlatformLogoDisplayAttributeCenterBottom,
> 
>EdkiiPlatformLogoDisplayAttributeLeftBottom,
> 
>EdkiiPlatformLogoDisplayAttributeCenterLeft,
> 
> -  EdkiiPlatformLogoDisplayAttributeCenter
> 
> +  EdkiiPlatformLogoDisplayAttributeCenter,
> 
> +  EdkiiPlatformLogoDisplayAttributeBGRTSpecification
> 
>  } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
> 
> 
> 
>  /**
> 
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 478ec2d40e..ac086f9c79 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -169,7 +169,6 @@ BootLogoEnableLogo (
>  DestX = SizeOfX - Image.Width;
> 
>  DestY = 0;
> 
>  break;
> 
> -
> 
>case EdkiiPlatformLogoDisplayAttributeCenterLeft:
> 
>  DestX = 0;
> 
>  DestY = (SizeOfY - Image.Height) / 2;
> 
> @@ -182,7 +181,6 @@ BootLogoEnableLogo (
>  DestX = SizeOfX - Image.Width;
> 
>  DestY = (SizeOfY - Image.Height) / 2;
> 
>  break;
> 
> -
> 
>case EdkiiPlatformLogoDisplayAttributeLeftBottom:
> 
>  DestX = 0;
> 
>  DestY = SizeOfY - Image.Height;
> 
> @@ -195,7 +193,10 @@ BootLogoEnableLogo (
>  DestX = SizeOfX - Image.Width;
> 
>  DestY = SizeOfY - Image.Height;
> 
>  break;
> 
> -
> 
> +  case EdkiiPlatformLogoDisplayAttributeBGRTSpecification:
> 
> +DestX = (SizeOfX - Image.Width) / 2;
> 
> +DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;
> 
> +break;
> 
>default:
> 
>  ASSERT (FALSE);
> 
>  continue;
> 
> --
> 2.34.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#91842): https://edk2.groups.io/g/devel/message/91842
> Mute This Topic: https://groups.io/mt/92623125/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92147): https://edk2.groups.io/g/devel/message/92147
Mute This Topic: https://groups.io/mt/92830045/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification

2022-08-04 Thread Sean Rhodes
Hi Ray/ Jian/ Liming

Would you be able to review this patch please?

Many thanks

Sean


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92109): https://edk2.groups.io/g/devel/message/92109
Mute This Topic: https://groups.io/mt/92623125/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification

2022-07-26 Thread Sean Rhodes
Add an option to position the logo 38.2% from the top of the screen,
which follows the BGRT specification.

Cc: Zhichao Gao 
Cc: Ray Ni 
Cc: Jian J Wang 
Cc: Liming Gao 
Signed-off-by: Sean Rhodes 
---
 MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
 MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h 
b/MdeModulePkg/Include/Protocol/PlatformLogo.h
index 08e1dc35a4..7c9ef63c66 100644
--- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
+++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
@@ -29,7 +29,8 @@ typedef enum {
   EdkiiPlatformLogoDisplayAttributeCenterBottom,
   EdkiiPlatformLogoDisplayAttributeLeftBottom,
   EdkiiPlatformLogoDisplayAttributeCenterLeft,
-  EdkiiPlatformLogoDisplayAttributeCenter
+  EdkiiPlatformLogoDisplayAttributeCenter,
+  EdkiiPlatformLogoDisplayAttributeBGRTSpecification
 } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
 
 /**
diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c 
b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
index 478ec2d40e..ac086f9c79 100644
--- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
+++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
@@ -169,7 +169,6 @@ BootLogoEnableLogo (
 DestX = SizeOfX - Image.Width;
 DestY = 0;
 break;
-
   case EdkiiPlatformLogoDisplayAttributeCenterLeft:
 DestX = 0;
 DestY = (SizeOfY - Image.Height) / 2;
@@ -182,7 +181,6 @@ BootLogoEnableLogo (
 DestX = SizeOfX - Image.Width;
 DestY = (SizeOfY - Image.Height) / 2;
 break;
-
   case EdkiiPlatformLogoDisplayAttributeLeftBottom:
 DestX = 0;
 DestY = SizeOfY - Image.Height;
@@ -195,7 +193,10 @@ BootLogoEnableLogo (
 DestX = SizeOfX - Image.Width;
 DestY = SizeOfY - Image.Height;
 break;
-
+  case EdkiiPlatformLogoDisplayAttributeBGRTSpecification:
+DestX = (SizeOfX - Image.Width) / 2;
+DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;
+break;
   default:
 ASSERT (FALSE);
 continue;
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91842): https://edk2.groups.io/g/devel/message/91842
Mute This Topic: https://groups.io/mt/92623125/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-