Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection
It was merged. From: Sean Rhodes Sent: Tuesday, March 29, 2022 11:05 AM To: Dong, Guo Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection Hi Guo Merge conflict is resolved Thanks Sean On Tue, 29 Mar 2022 at 19:01, Dong, Guo mailto:guo.d...@intel.com>> wrote: Hi Sean, I would help solve merge conflict and then merge https://github.com/tianocore/edk2/pull/2654. For another patch, please contact MdeModulePkg maintainer to help merge it. Thanks, Guo From: Sean Rhodes mailto:sean@starlabs.systems>> Sent: Tuesday, March 29, 2022 10:35 AM To: Dong, Guo mailto:guo.d...@intel.com>> Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection Hey No problem and thank you. That have been reviewed, it's just these two: https://github.com/tianocore/edk2/pull/2654 https://github.com/tianocore/edk2/pull/2485 Thanks Sean On Tue, 29 Mar 2022 at 18:32, Dong, Guo mailto:guo.d...@intel.com>> wrote: Hi Sean, Sorry for late response. I merged several UEFI payload packages yesterday including this one. Please let me know if you have other patches pending to merge (The patches passed code review). Thanks, Guo From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> On Behalf Of Sean Rhodes Sent: Monday, March 21, 2022 2:49 AM To: Dong, Guo mailto:guo.d...@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection Hey Guo Can I chase when this patch will be merged? Many thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88186): https://edk2.groups.io/g/devel/message/88186 Mute This Topic: https://groups.io/mt/89056153/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection
Hi Guo Merge conflict is resolved Thanks Sean On Tue, 29 Mar 2022 at 19:01, Dong, Guo wrote: > > > Hi Sean, > > > > I would help solve merge conflict and then merge > https://github.com/tianocore/edk2/pull/2654. > > For another patch, please contact MdeModulePkg maintainer to help merge it. > > > > Thanks, > > Guo > > > > *From:* Sean Rhodes > *Sent:* Tuesday, March 29, 2022 10:35 AM > *To:* Dong, Guo > *Cc:* devel@edk2.groups.io > *Subject:* Re: [edk2-devel] [PATCH 15/18] > UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection > > > > Hey > > > > No problem and thank you. > > > > That have been reviewed, it's just these two: > > https://github.com/tianocore/edk2/pull/2654 > > https://github.com/tianocore/edk2/pull/2485 > > > > Thanks > > > > Sean > > > > > > On Tue, 29 Mar 2022 at 18:32, Dong, Guo wrote: > > > > Hi Sean, > > > > Sorry for late response. I merged several UEFI payload packages yesterday > including this one. > > Please let me know if you have other patches pending to merge (The patches > passed code review). > > > > Thanks, > > Guo > > > > *From:* devel@edk2.groups.io *On Behalf Of *Sean > Rhodes > *Sent:* Monday, March 21, 2022 2:49 AM > *To:* Dong, Guo ; devel@edk2.groups.io > *Subject:* Re: [edk2-devel] [PATCH 15/18] > UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection > > > > Hey Guo > > Can I chase when this patch will be merged? > > Many thanks > > Sean > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88184): https://edk2.groups.io/g/devel/message/88184 Mute This Topic: https://groups.io/mt/89056153/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection
Hi Sean, I would help solve merge conflict and then merge https://github.com/tianocore/edk2/pull/2654. For another patch, please contact MdeModulePkg maintainer to help merge it. Thanks, Guo From: Sean Rhodes Sent: Tuesday, March 29, 2022 10:35 AM To: Dong, Guo Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection Hey No problem and thank you. That have been reviewed, it's just these two: https://github.com/tianocore/edk2/pull/2654 https://github.com/tianocore/edk2/pull/2485 Thanks Sean On Tue, 29 Mar 2022 at 18:32, Dong, Guo mailto:guo.d...@intel.com>> wrote: Hi Sean, Sorry for late response. I merged several UEFI payload packages yesterday including this one. Please let me know if you have other patches pending to merge (The patches passed code review). Thanks, Guo From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> On Behalf Of Sean Rhodes Sent: Monday, March 21, 2022 2:49 AM To: Dong, Guo mailto:guo.d...@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection Hey Guo Can I chase when this patch will be merged? Many thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88183): https://edk2.groups.io/g/devel/message/88183 Mute This Topic: https://groups.io/mt/89056153/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection
Hey No problem and thank you. That have been reviewed, it's just these two: https://github.com/tianocore/edk2/pull/2654 https://github.com/tianocore/edk2/pull/2485 Thanks Sean On Tue, 29 Mar 2022 at 18:32, Dong, Guo wrote: > > > Hi Sean, > > > > Sorry for late response. I merged several UEFI payload packages yesterday > including this one. > > Please let me know if you have other patches pending to merge (The patches > passed code review). > > > > Thanks, > > Guo > > > > *From:* devel@edk2.groups.io * On Behalf Of *Sean > Rhodes > *Sent:* Monday, March 21, 2022 2:49 AM > *To:* Dong, Guo ; devel@edk2.groups.io > *Subject:* Re: [edk2-devel] [PATCH 15/18] > UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection > > > > Hey Guo > > Can I chase when this patch will be merged? > > Many thanks > > Sean > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88180): https://edk2.groups.io/g/devel/message/88180 Mute This Topic: https://groups.io/mt/89056153/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection
Hi Sean, Sorry for late response. I merged several UEFI payload packages yesterday including this one. Please let me know if you have other patches pending to merge (The patches passed code review). Thanks, Guo From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Monday, March 21, 2022 2:49 AM To: Dong, Guo ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection Hey Guo Can I chase when this patch will be merged? Many thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88178): https://edk2.groups.io/g/devel/message/88178 Mute This Topic: https://groups.io/mt/89056153/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection
Hey Guo Can I chase when this patch will be merged? Many thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87788): https://edk2.groups.io/g/devel/message/87788 Mute This Topic: https://groups.io/mt/89056153/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection
Reviewed-by: Guo Dong
-Original Message-
From: Sean Rhodes
Sent: Thursday, February 10, 2022 2:28 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Patrick Rudolph
Subject: [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove
broken VGA detection
From: Patrick Rudolph
This fixes an issue where the framebuffer provided by coreboot or
slimbootloader will only work on the primary VGA device. If the framebuffer
corresponds to a different device the screen will stay black.
In addition, the code doesn't work for multiple graphic cards, has reference to
non existing functions, and is a duplication of common code.
Call EfiBootManagerConnectVideoController on every display device found, not
only the legacy VGA device. This is the same as OvmfPkg does.
Allows to display output on the framebuffer set up by firmware, which might not
be the VGA device.
Signed-off-by: Patrick Rudolph
---
.../PlatformBootManagerLib/PlatformConsole.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
index c93c7c99b5..bfaf89e74c 100644
--- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
+++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
@@ -109,7 +109,7 @@ EFI_DEVICE_PATH_PROTOCOL *gPlatformRootBridges[] = {
NULL }; -BOOLEAN mDetectVgaOnly;+BOOLEAN mDetectDisplayOnly; /** Add
IsaKeyboard to ConIn; add IsaSerial to ConOut, ConIn, ErrOut.@@ -482,7 +482,7
@@ DetectAndPreparePlatformPciDevicePath (
); ASSERT_EFI_ERROR (Status); - if (!mDetectVgaOnly) {+
if (!mDetectDisplayOnly) { // // Here we decide whether it is LPC
Bridge //@@ -515,14 +515,14 @@ DetectAndPreparePlatformPciDevicePath (
}//- // Here we decide which VGA device to enable in PCI bus+ //
Enable all display devices //- if (IS_PCI_VGA (Pci)) {+ if (IS_PCI_DISPLAY
(Pci)) { // // Add them to ConOut. //-DEBUG ((DEBUG_INFO,
"Found PCI VGA device\n"));-PreparePciVgaDevicePath (Handle);+DEBUG
((DEBUG_INFO, "Found PCI Display device\n"));+
EfiBootManagerConnectVideoController (Handle); return EFI_SUCCESS; } @@
-532,7 +532,7 @@ DetectAndPreparePlatformPciDevicePath (
/** Do platform specific PCI Device check and add them to ConOut, ConIn,
ErrOut - @param[in] DetectVgaOnly - Only detect VGA device if it's TRUE.+
@param[in] DetectDisplayOnly - Only detect display device if it's TRUE.
@retval EFI_SUCCESS - PCI Device check and Console variable update
successfully. @retval EFI_STATUS - PCI Device check or Console variable
update fail.@@ -540,10 +540,10 @@ DetectAndPreparePlatformPciDevicePath (
**/ EFI_STATUS DetectAndPreparePlatformPciDevicePaths (- BOOLEAN
DetectVgaOnly+ BOOLEAN DetectDisplayOnly ) {- mDetectVgaOnly =
DetectVgaOnly;+ mDetectDisplayOnly = DetectDisplayOnly;
EfiBootManagerUpdateConsoleVariable ( ConIn,--
2.32.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86715): https://edk2.groups.io/g/devel/message/86715
Mute This Topic: https://groups.io/mt/89056153/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection
From: Patrick Rudolph
This fixes an issue where the framebuffer provided by coreboot or
slimbootloader will only work on the primary VGA device. If the
framebuffer corresponds to a different device the screen will stay black.
In addition, the code doesn't work for multiple graphic cards, has
reference to non existing functions, and is a duplication of common code.
Call EfiBootManagerConnectVideoController on every display device found,
not only the legacy VGA device. This is the same as OvmfPkg does.
Allows to display output on the framebuffer set up by firmware, which might
not be the VGA device.
Signed-off-by: Patrick Rudolph
---
.../PlatformBootManagerLib/PlatformConsole.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
index c93c7c99b5..bfaf89e74c 100644
--- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
+++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
@@ -109,7 +109,7 @@ EFI_DEVICE_PATH_PROTOCOL *gPlatformRootBridges[] = {
NULL
};
-BOOLEAN mDetectVgaOnly;
+BOOLEAN mDetectDisplayOnly;
/**
Add IsaKeyboard to ConIn; add IsaSerial to ConOut, ConIn, ErrOut.
@@ -482,7 +482,7 @@ DetectAndPreparePlatformPciDevicePath (
);
ASSERT_EFI_ERROR (Status);
- if (!mDetectVgaOnly) {
+ if (!mDetectDisplayOnly) {
//
// Here we decide whether it is LPC Bridge
//
@@ -515,14 +515,14 @@ DetectAndPreparePlatformPciDevicePath (
}
//
- // Here we decide which VGA device to enable in PCI bus
+ // Enable all display devices
//
- if (IS_PCI_VGA (Pci)) {
+ if (IS_PCI_DISPLAY (Pci)) {
//
// Add them to ConOut.
//
-DEBUG ((DEBUG_INFO, "Found PCI VGA device\n"));
-PreparePciVgaDevicePath (Handle);
+DEBUG ((DEBUG_INFO, "Found PCI Display device\n"));
+EfiBootManagerConnectVideoController (Handle);
return EFI_SUCCESS;
}
@@ -532,7 +532,7 @@ DetectAndPreparePlatformPciDevicePath (
/**
Do platform specific PCI Device check and add them to ConOut, ConIn, ErrOut
- @param[in] DetectVgaOnly - Only detect VGA device if it's TRUE.
+ @param[in] DetectDisplayOnly - Only detect display device if it's TRUE.
@retval EFI_SUCCESS - PCI Device check and Console variable update
successfully.
@retval EFI_STATUS - PCI Device check or Console variable update fail.
@@ -540,10 +540,10 @@ DetectAndPreparePlatformPciDevicePath (
**/
EFI_STATUS
DetectAndPreparePlatformPciDevicePaths (
- BOOLEAN DetectVgaOnly
+ BOOLEAN DetectDisplayOnly
)
{
- mDetectVgaOnly = DetectVgaOnly;
+ mDetectDisplayOnly = DetectDisplayOnly;
EfiBootManagerUpdateConsoleVariable (
ConIn,
--
2.32.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86586): https://edk2.groups.io/g/devel/message/86586
Mute This Topic: https://groups.io/mt/89056153/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
