Re: [edk2-devel] [PATCH 2/3] BaseTools: Replace duplicate __PcdSet prototype with __PcdGet

2023-03-23 Thread Rebecca Cran 

Hi Liming,


Could you review this patch please?

I've dropped the 3rd patch which was running Uncrustify over the code, 
so this is the only one left before I can merge the series.



Thanks.

Rebecca Cran


On 2/24/23 5:54 PM, Rebecca Cran wrote:

Replace the duplicate __PcdSet prototype in PcdValueCommon.h
with the prototype for __PcdGet.

Signed-off-by: Rebecca Cran 
---
  BaseTools/Source/C/Common/PcdValueCommon.h | 13 ++---
  1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/BaseTools/Source/C/Common/PcdValueCommon.h 
b/BaseTools/Source/C/Common/PcdValueCommon.h
index 02ef803be479..7dac5bd92dbc 100644
--- a/BaseTools/Source/C/Common/PcdValueCommon.h
+++ b/BaseTools/Source/C/Common/PcdValueCommon.h
@@ -78,13 +78,12 @@ __PcdSet (
  
@return PCD value

  **/
-VOID
-__PcdSet (
-  CHAR8   *SkuName OPTIONAL,
-  CHAR8   *DefaultValueNameOPTIONAL,
-  CHAR8   *TokenSpaceGuidName,
-  CHAR8   *TokenName,
-  UINT64  Value
+UINT64
+__PcdGet (
+  CHAR8  *SkuName OPTIONAL,
+  CHAR8  *DefaultValueNameOPTIONAL,
+  CHAR8  *TokenSpaceGuidName,
+  CHAR8  *TokenName
)
  ;
  



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101700): https://edk2.groups.io/g/devel/message/101700
Mute This Topic: https://groups.io/mt/97218961/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 2/3] BaseTools: Replace duplicate __PcdSet prototype with __PcdGet

2023-02-24 Thread Rebecca Cran 
Replace the duplicate __PcdSet prototype in PcdValueCommon.h
with the prototype for __PcdGet.

Signed-off-by: Rebecca Cran 
---
 BaseTools/Source/C/Common/PcdValueCommon.h | 13 ++---
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/BaseTools/Source/C/Common/PcdValueCommon.h 
b/BaseTools/Source/C/Common/PcdValueCommon.h
index 02ef803be479..7dac5bd92dbc 100644
--- a/BaseTools/Source/C/Common/PcdValueCommon.h
+++ b/BaseTools/Source/C/Common/PcdValueCommon.h
@@ -78,13 +78,12 @@ __PcdSet (
 
   @return PCD value
 **/
-VOID
-__PcdSet (
-  CHAR8   *SkuName OPTIONAL,
-  CHAR8   *DefaultValueNameOPTIONAL,
-  CHAR8   *TokenSpaceGuidName,
-  CHAR8   *TokenName,
-  UINT64  Value
+UINT64
+__PcdGet (
+  CHAR8  *SkuName OPTIONAL,
+  CHAR8  *DefaultValueNameOPTIONAL,
+  CHAR8  *TokenSpaceGuidName,
+  CHAR8  *TokenName
   )
 ;
 
-- 
2.37.1 (Apple Git-137.1)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100499): https://edk2.groups.io/g/devel/message/100499
Mute This Topic: https://groups.io/mt/97218961/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-