Re: [edk2-devel] [PATCH 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug message

2023-07-04 Thread Chang, Abner via groups.io
[AMD Official Use Only - General]

Hi Nickle,
Besides using REDFISH_PLATFORM_CONFIG_DEBUG, can we update 
REDFISH_PLATFORM_CONFIG_DEBUG to DEBUG_MANAGEABILITY?

Thanks
Abner

> -Original Message-
> From: Nickle Wang 
> Sent: Monday, July 3, 2023 9:20 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez 
> Subject: [PATCH 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug
> message
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Change debug message level of showing ordered list op-code
> to REDFISH_PLATFORM_CONFIG_DEBUG.
>
> Signed-off-by: Nickle Wang 
> Cc: Abner Chang 
> Cc: Igor Kulchytskyy 
> Cc: Nick Ramirez 
> ---
>  .../RedfishPlatformConfigDxe.c| 24 +--
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
> index 462f269f6a3f..f2a8e77d9b00 100644
> --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
> +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
> @@ -955,12 +955,12 @@ DumpOrderedListValue (
>  return;
>}
>
> -  DEBUG ((DEBUG_ERROR, "Value.Type= 0x%x\n", OrderedListStatement-
> >Value.Type));
> -  DEBUG ((DEBUG_ERROR, "Value.BufferValueType= 0x%x\n",
> OrderedListStatement->Value.BufferValueType));
> -  DEBUG ((DEBUG_ERROR, "Value.BufferLen= 0x%x\n",
> OrderedListStatement->Value.BufferLen));
> -  DEBUG ((DEBUG_ERROR, "Value.Buffer= 0x%x\n", OrderedListStatement-
> >Value.Buffer));
> -  DEBUG ((DEBUG_ERROR, "Value.MaxContainers= 0x%x\n",
> OrderedListStatement->ExtraData.OrderListData.MaxContainers));
> -  DEBUG ((DEBUG_ERROR, "StorageWidth= 0x%x\n", OrderedListStatement-
> >StorageWidth));
> +  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.Type= 0x%x\n",
> OrderedListStatement->Value.Type));
> +  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.BufferValueType=
> 0x%x\n", OrderedListStatement->Value.BufferValueType));
> +  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.BufferLen=
> 0x%x\n", OrderedListStatement->Value.BufferLen));
> +  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.Buffer= 0x%x\n",
> OrderedListStatement->Value.Buffer));
> +  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.MaxContainers=
> 0x%x\n", OrderedListStatement->ExtraData.OrderListData.MaxContainers));
> +  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "StorageWidth= 0x%x\n",
> OrderedListStatement->StorageWidth));
>
>if (OrderedListStatement->Value.Buffer == NULL) {
>  return;
> @@ -977,7 +977,7 @@ DumpOrderedListValue (
>Value8 = (UINT8 *)OrderedListStatement->Value.Buffer;
>Count  = OrderedListStatement->StorageWidth / sizeof (UINT8);
>for (Index = 0; Index < Count; Index++) {
> -DEBUG ((DEBUG_ERROR, "%d ", Value8[Index]));
> +DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value8[Index]));
>}
>
>break;
> @@ -985,7 +985,7 @@ DumpOrderedListValue (
>Value16 = (UINT16 *)OrderedListStatement->Value.Buffer;
>Count   = OrderedListStatement->StorageWidth / sizeof (UINT16);
>for (Index = 0; Index < Count; Index++) {
> -DEBUG ((DEBUG_ERROR, "%d ", Value16[Index]));
> +DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ",
> Value16[Index]));
>}
>
>break;
> @@ -993,7 +993,7 @@ DumpOrderedListValue (
>Value32 = (UINT32 *)OrderedListStatement->Value.Buffer;
>Count   = OrderedListStatement->StorageWidth / sizeof (UINT32);
>for (Index = 0; Index < Count; Index++) {
> -DEBUG ((DEBUG_ERROR, "%d ", Value32[Index]));
> +DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ",
> Value32[Index]));
>}
>
>break;
> @@ -1001,7 +1001,7 @@ DumpOrderedListValue (
>Value64 = (UINT64 *)OrderedListStatement->Value.Buffer;
>Count   = OrderedListStatement->StorageWidth / sizeof (UINT64);
>for (Index = 0; Index < Count; Index++) {
> -DEBUG ((DEBUG_ERROR, "%d ", Value64[Index]));
> +DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ",
> Value64[Index]));
>}
>
>break;
> @@ -1009,13 +1009,13 @@ DumpOrderedListValue (
>Value8 = (UINT8 *)OrderedListStatement->Value.Buffer;
>Count  = OrderedListStatement->StorageWidth / sizeof (UINT8);
>for (Index = 0; Index < Count; Index++) {
> -DEBUG ((DEBUG_ERROR, "%d ", Value8[Index]));
> +DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value8[Index]));
>}
>
>break;
>}
>
> -  DEBUG ((DEBUG_ERROR, "\n"));
> +  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "\n"));
>  }
>
>  /**
> --
> 2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106645): https://edk2.groups.io/g/devel/message/106645
Mute This Topic: https://groups.io/mt/99926324/21656
Group Owner: devel+o

[edk2-devel] [PATCH 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug message

2023-07-03 Thread Nickle Wang via groups.io
Change debug message level of showing ordered list op-code
to REDFISH_PLATFORM_CONFIG_DEBUG.

Signed-off-by: Nickle Wang 
Cc: Abner Chang 
Cc: Igor Kulchytskyy 
Cc: Nick Ramirez 
---
 .../RedfishPlatformConfigDxe.c| 24 +--
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c 
b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
index 462f269f6a3f..f2a8e77d9b00 100644
--- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
+++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
@@ -955,12 +955,12 @@ DumpOrderedListValue (
 return;
   }
 
-  DEBUG ((DEBUG_ERROR, "Value.Type= 0x%x\n", 
OrderedListStatement->Value.Type));
-  DEBUG ((DEBUG_ERROR, "Value.BufferValueType= 0x%x\n", 
OrderedListStatement->Value.BufferValueType));
-  DEBUG ((DEBUG_ERROR, "Value.BufferLen= 0x%x\n", 
OrderedListStatement->Value.BufferLen));
-  DEBUG ((DEBUG_ERROR, "Value.Buffer= 0x%x\n", 
OrderedListStatement->Value.Buffer));
-  DEBUG ((DEBUG_ERROR, "Value.MaxContainers= 0x%x\n", 
OrderedListStatement->ExtraData.OrderListData.MaxContainers));
-  DEBUG ((DEBUG_ERROR, "StorageWidth= 0x%x\n", 
OrderedListStatement->StorageWidth));
+  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.Type= 0x%x\n", 
OrderedListStatement->Value.Type));
+  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.BufferValueType= 0x%x\n", 
OrderedListStatement->Value.BufferValueType));
+  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.BufferLen= 0x%x\n", 
OrderedListStatement->Value.BufferLen));
+  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.Buffer= 0x%x\n", 
OrderedListStatement->Value.Buffer));
+  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.MaxContainers= 0x%x\n", 
OrderedListStatement->ExtraData.OrderListData.MaxContainers));
+  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "StorageWidth= 0x%x\n", 
OrderedListStatement->StorageWidth));
 
   if (OrderedListStatement->Value.Buffer == NULL) {
 return;
@@ -977,7 +977,7 @@ DumpOrderedListValue (
   Value8 = (UINT8 *)OrderedListStatement->Value.Buffer;
   Count  = OrderedListStatement->StorageWidth / sizeof (UINT8);
   for (Index = 0; Index < Count; Index++) {
-DEBUG ((DEBUG_ERROR, "%d ", Value8[Index]));
+DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value8[Index]));
   }
 
   break;
@@ -985,7 +985,7 @@ DumpOrderedListValue (
   Value16 = (UINT16 *)OrderedListStatement->Value.Buffer;
   Count   = OrderedListStatement->StorageWidth / sizeof (UINT16);
   for (Index = 0; Index < Count; Index++) {
-DEBUG ((DEBUG_ERROR, "%d ", Value16[Index]));
+DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value16[Index]));
   }
 
   break;
@@ -993,7 +993,7 @@ DumpOrderedListValue (
   Value32 = (UINT32 *)OrderedListStatement->Value.Buffer;
   Count   = OrderedListStatement->StorageWidth / sizeof (UINT32);
   for (Index = 0; Index < Count; Index++) {
-DEBUG ((DEBUG_ERROR, "%d ", Value32[Index]));
+DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value32[Index]));
   }
 
   break;
@@ -1001,7 +1001,7 @@ DumpOrderedListValue (
   Value64 = (UINT64 *)OrderedListStatement->Value.Buffer;
   Count   = OrderedListStatement->StorageWidth / sizeof (UINT64);
   for (Index = 0; Index < Count; Index++) {
-DEBUG ((DEBUG_ERROR, "%d ", Value64[Index]));
+DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value64[Index]));
   }
 
   break;
@@ -1009,13 +1009,13 @@ DumpOrderedListValue (
   Value8 = (UINT8 *)OrderedListStatement->Value.Buffer;
   Count  = OrderedListStatement->StorageWidth / sizeof (UINT8);
   for (Index = 0; Index < Count; Index++) {
-DEBUG ((DEBUG_ERROR, "%d ", Value8[Index]));
+DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value8[Index]));
   }
 
   break;
   }
 
-  DEBUG ((DEBUG_ERROR, "\n"));
+  DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "\n"));
 }
 
 /**
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106604): https://edk2.groups.io/g/devel/message/106604
Mute This Topic: https://groups.io/mt/99926324/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-