Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial
Just created the pull request for this patch https://github.com/tianocore/edk2/pull/2234 Thanks, Dandan > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Wednesday, December 1, 2021 9:53 AM > To: devel@edk2.groups.io; xiewen...@huawei.com; Wang, Jian J > ; Bi, Dandan > Cc: songdongku...@huawei.com > Subject: 回复: [edk2-devel] [PATCH EDK2 v1 1/1] > MdeModulePkg/DxeCorePerformanceLib:Variable Initial > > Reviewed-by: Liming Gao > > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 wenyi,xie > via > > groups.io > > 发送时间: 2021年11月30日 9:51 > > 收件人: devel@edk2.groups.io; jian.j.w...@intel.com; > > gaolim...@byosoft.com.cn; dandan...@intel.com > > 抄送: songdongku...@huawei.com; xiewen...@huawei.com > > 主题: [edk2-devel] [PATCH EDK2 v1 1/1] > > MdeModulePkg/DxeCorePerformanceLib:Variable Initial > > > > SmmBootRecordDataSize is initialized in InternalGetSmmPerData, but > > this function may fail. so to avoid using SmmBootRecordDataSize > > without intialization, set it to 0 at first. > > > > Cc: Jian J Wang > > Cc: Liming Gao > > Cc: Dandan Bi > > Signed-off-by: Wenyi Xie > > --- > > > MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c > > | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > > a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi > b. > > c > > > b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi > b. > > c > > index 532b3f8c90e2..f8778c25188a 100644 > > --- > > > a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi > b. > > c > > +++ > > > b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi > b. > > c > > @@ -1373,6 +1373,8 @@ UpdateBootPerformanceTable ( > >UINTNAppendSize; > >UINT8*FirmwarePerformanceTablePtr; > > > > + SmmBootRecordDataSize = 0; > > + > >// > >// Get SMM performance data. > >// > > -- > > 2.20.1.windows.1 > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84300): https://edk2.groups.io/g/devel/message/84300 Mute This Topic: https://groups.io/mt/87473787/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial
Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: devel@edk2.groups.io On Behalf Of > wenyi,xie via groups.io > Sent: Tuesday, November 30, 2021 9:51 AM > To: devel@edk2.groups.io; Wang, Jian J ; > gaolim...@byosoft.com.cn; Bi, Dandan > Cc: songdongku...@huawei.com; xiewen...@huawei.com > Subject: [edk2-devel] [PATCH EDK2 v1 1/1] > MdeModulePkg/DxeCorePerformanceLib:Variable Initial > > SmmBootRecordDataSize is initialized in InternalGetSmmPerData, but this > function may fail. so to avoid using SmmBootRecordDataSize without > intialization, set it to 0 at first. > > Cc: Jian J Wang > Cc: Liming Gao > Cc: Dandan Bi > Signed-off-by: Wenyi Xie > --- > > MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c > | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi > b.c > b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi > b.c > index 532b3f8c90e2..f8778c25188a 100644 > --- > a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi > b.c > +++ > b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi > b.c > @@ -1373,6 +1373,8 @@ UpdateBootPerformanceTable ( >UINTNAppendSize; >UINT8*FirmwarePerformanceTablePtr; > > + SmmBootRecordDataSize = 0; > + >// >// Get SMM performance data. >// > -- > 2.20.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84183): https://edk2.groups.io/g/devel/message/84183 Mute This Topic: https://groups.io/mt/87393967/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 wenyi,xie via > groups.io > 发送时间: 2021年11月30日 9:51 > 收件人: devel@edk2.groups.io; jian.j.w...@intel.com; > gaolim...@byosoft.com.cn; dandan...@intel.com > 抄送: songdongku...@huawei.com; xiewen...@huawei.com > 主题: [edk2-devel] [PATCH EDK2 v1 1/1] > MdeModulePkg/DxeCorePerformanceLib:Variable Initial > > SmmBootRecordDataSize is initialized in InternalGetSmmPerData, > but this function may fail. so to avoid using SmmBootRecordDataSize > without intialization, set it to 0 at first. > > Cc: Jian J Wang > Cc: Liming Gao > Cc: Dandan Bi > Signed-off-by: Wenyi Xie > --- > MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c > | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib. > c > b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib. > c > index 532b3f8c90e2..f8778c25188a 100644 > --- > a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib. > c > +++ > b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib. > c > @@ -1373,6 +1373,8 @@ UpdateBootPerformanceTable ( >UINTNAppendSize; >UINT8*FirmwarePerformanceTablePtr; > > + SmmBootRecordDataSize = 0; > + >// >// Get SMM performance data. >// > -- > 2.20.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84177): https://edk2.groups.io/g/devel/message/84177 Mute This Topic: https://groups.io/mt/87418734/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial
SmmBootRecordDataSize is initialized in InternalGetSmmPerData, but this function may fail. so to avoid using SmmBootRecordDataSize without intialization, set it to 0 at first. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Wenyi Xie --- MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c index 532b3f8c90e2..f8778c25188a 100644 --- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c +++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c @@ -1373,6 +1373,8 @@ UpdateBootPerformanceTable ( UINTNAppendSize; UINT8*FirmwarePerformanceTablePtr; + SmmBootRecordDataSize = 0; + // // Get SMM performance data. // -- 2.20.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84144): https://edk2.groups.io/g/devel/message/84144 Mute This Topic: https://groups.io/mt/87393967/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
