Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block

2021-09-02 Thread Dandan Bi 
PR is created for this change:
https://github.com/tianocore/edk2/pull/1945




Thanks,
Dandan
> -Original Message-
> From: Bi, Dandan
> Sent: Friday, August 27, 2021 11:58 AM
> To: Wenyi Xie ; devel@edk2.groups.io; Wang, Jian
> J ; Wu, Hao A ; Dong, Eric
> 
> Cc: songdongku...@huawei.com
> Subject: RE: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove
> dead code block
> 
> Reviewed-by: Dandan Bi 
> 
> 
> Thanks,
> Dandan
> 
> > -Original Message-
> > From: Wenyi Xie 
> > Sent: Thursday, August 26, 2021 9:16 AM
> > To: devel@edk2.groups.io; Wang, Jian J ; Wu,
> > Hao A ; Bi, Dandan ; Dong,
> > Eric 
> > Cc: songdongku...@huawei.com; xiewen...@huawei.com
> > Subject: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove
> dead
> > code block
> >
> > As the if statement outside has confirmed that
> > BlockData->Name == NULL, so the if statement inside
> > is always false.
> >
> > Cc: Jian J Wang 
> > Cc: Hao A Wu 
> > Cc: Dandan Bi 
> > Cc: Eric Dong 
> > Signed-off-by: Wenyi Xie 
> > ---
> >  MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > index d492b769d51c..17a914208c6d 100644
> > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > @@ -2871,9 +2871,6 @@ ParseIfrData (
> >  //
> >  if ((BlockData->Name == NULL) && ((BlockData->Offset +
> > BlockData-
> > >Width) > VarStorageData->Size)) {
> >Status = EFI_INVALID_PARAMETER;
> > -  if (BlockData->Name != NULL) {
> > -FreePool (BlockData->Name);
> > -  }
> >FreePool (BlockData);
> >goto Done;
> >  }
> > --
> > 2.20.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80152): https://edk2.groups.io/g/devel/message/80152
Mute This Topic: https://groups.io/mt/85151741/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block

2021-08-26 Thread Dandan Bi 
Reviewed-by: Dandan Bi 


Thanks,
Dandan

> -Original Message-
> From: Wenyi Xie 
> Sent: Thursday, August 26, 2021 9:16 AM
> To: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A
> ; Bi, Dandan ; Dong, Eric
> 
> Cc: songdongku...@huawei.com; xiewen...@huawei.com
> Subject: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead
> code block
> 
> As the if statement outside has confirmed that
> BlockData->Name == NULL, so the if statement inside
> is always false.
> 
> Cc: Jian J Wang 
> Cc: Hao A Wu 
> Cc: Dandan Bi 
> Cc: Eric Dong 
> Signed-off-by: Wenyi Xie 
> ---
>  MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index d492b769d51c..17a914208c6d 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -2871,9 +2871,6 @@ ParseIfrData (
>  //
>  if ((BlockData->Name == NULL) && ((BlockData->Offset + BlockData-
> >Width) > VarStorageData->Size)) {
>Status = EFI_INVALID_PARAMETER;
> -  if (BlockData->Name != NULL) {
> -FreePool (BlockData->Name);
> -  }
>FreePool (BlockData);
>goto Done;
>  }
> --
> 2.20.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79877): https://edk2.groups.io/g/devel/message/79877
Mute This Topic: https://groups.io/mt/85151741/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block

2021-08-25 Thread wenyi,xie via groups.io 
As the if statement outside has confirmed that
BlockData->Name == NULL, so the if statement inside
is always false.

Cc: Jian J Wang 
Cc: Hao A Wu 
Cc: Dandan Bi 
Cc: Eric Dong 
Signed-off-by: Wenyi Xie 
---
 MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c 
b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
index d492b769d51c..17a914208c6d 100644
--- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
@@ -2871,9 +2871,6 @@ ParseIfrData (
 //
 if ((BlockData->Name == NULL) && ((BlockData->Offset + 
BlockData->Width) > VarStorageData->Size)) {
   Status = EFI_INVALID_PARAMETER;
-  if (BlockData->Name != NULL) {
-FreePool (BlockData->Name);
-  }
   FreePool (BlockData);
   goto Done;
 }
-- 
2.20.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79816): https://edk2.groups.io/g/devel/message/79816
Mute This Topic: https://groups.io/mt/85151741/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-