[edk2-devel] [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' descriptor to the global variables that only used in a single file to minimize the name collisions. This is only for the varable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Zhichao Gao --- IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c index fe344a5327..459acc694b 100644 --- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c +++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c @@ -39,7 +39,7 @@ extern EFI_GUID gAddPerfRecordProtocolGuid; extern EFI_GUID gFspHobGuid; extern EFI_GUID gFspApiPerformanceGuid; -EFI_EVENT mExitBootServicesEvent = NULL; +static EFI_EVENT mExitBootServicesEvent = NULL; /** Relocate this image under 4G memory. -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39451): https://edk2.groups.io/g/devel/message/39451 Mute This Topic: https://groups.io/mt/31318891/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, April 24, 2019 12:58 PM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > ; Gao, Liming ; Bi, Dandan > > Subject: [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease > the name collisions > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 > > Add a 'static' descriptor to the global variables that only used in a single > file to > minimize the name collisions. > This is only for the varable named 'mExitBootServicesEvent'. > > Cc: Laszlo Ersek > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Liming Gao > Cc: Dandan Bi > Signed-off-by: Zhichao Gao > --- > IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > index fe344a5327..459acc694b 100644 > --- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > +++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > @@ -39,7 +39,7 @@ extern EFI_GUID gAddPerfRecordProtocolGuid; extern > EFI_GUID gFspHobGuid; extern EFI_GUID gFspApiPerformanceGuid; > > -EFI_EVENT mExitBootServicesEvent = NULL; > +static EFI_EVENT mExitBootServicesEvent = NULL; > > /** >Relocate this image under 4G memory. > -- > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39455): https://edk2.groups.io/g/devel/message/39455 Mute This Topic: https://groups.io/mt/31318891/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions
Update copyright year from 2016 to 2019. After that is done... Reviewed-by: Nate DeSimone -Original Message- From: Gao, Zhichao Sent: Tuesday, April 23, 2019 9:58 PM To: devel@edk2.groups.io Cc: Laszlo Ersek ; Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star ; Gao, Liming ; Bi, Dandan Subject: [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' descriptor to the global variables that only used in a single file to minimize the name collisions. This is only for the varable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Zhichao Gao --- IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c index fe344a5327..459acc694b 100644 --- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c +++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c @@ -39,7 +39,7 @@ extern EFI_GUID gAddPerfRecordProtocolGuid; extern EFI_GUID gFspHobGuid; extern EFI_GUID gFspApiPerformanceGuid; -EFI_EVENT mExitBootServicesEvent = NULL; +static EFI_EVENT mExitBootServicesEvent = NULL; /** Relocate this image under 4G memory. -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39456): https://edk2.groups.io/g/devel/message/39456 Mute This Topic: https://groups.io/mt/31318891/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-