Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions
Judah, The readme update was not complete. I provided a pointer to the Table at the beginning of the readme that need to be updated too. Thanks, Mike > -Original Message- > From: Vang, Judah > Sent: Tuesday, December 20, 2022 10:43 AM > To: Yao, Jiewen ; Kinney, Michael D > ; devel@edk2.groups.io > Cc: Wang, Jian J ; Xiaoyu Lu ; > Jiang, Guomin ; > Mistry, Nishant C > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto > functions > > The readme was updated, however, I did miss the .dsc. > Will submit another patch to address the .dsc file > > Judah > > -Original Message- > From: Yao, Jiewen > Sent: Monday, December 19, 2022 6:52 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Vang, Judah > Cc: Wang, Jian J ; Xiaoyu Lu ; > Jiang, Guomin ; > Mistry, Nishant C > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto > functions > > Hi Mike > You are right. I missed that part. > > Hi Judah > Would you please file another patch to update DSC file, to make it align with > readme? > > Thank you > Yao, Jiewen > > > -Original Message- > > From: Kinney, Michael D > > Sent: Tuesday, December 20, 2022 9:55 AM > > To: devel@edk2.groups.io; Yao, Jiewen ; Vang, > > Judah > > Cc: Wang, Jian J ; Xiaoyu Lu > > ; Jiang, Guomin ; > > Mistry, Nishant C ; Kinney, Michael D > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable > > crypto functions > > > > Hi Jiewen, > > > > I noticed that this patch is missing the update to the table in > > ReadMe.md to show the new PEI and SMM crypto services enabled by > > default in *CryptLib library instances. > > > > https://github.com/tianocore/edk2/tree/master/CryptoPkg#supported- > > cryptographic-families-and-services > > > > It did update the recommended PCD settings at the end of the ReadMe, > > but missed the update to CryptoPkg.dsc file to actually enable the PEI > > and SMM services in the Crypto Drivers. > > > > Mike > > > > > -Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Yao, > > Jiewen > > > Sent: Monday, December 19, 2022 5:40 PM > > > To: Vang, Judah ; devel@edk2.groups.io > > > Cc: Wang, Jian J ; Xiaoyu Lu > > ; Jiang, Guomin ; > > > Mistry, Nishant C > > > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable > > > crypto > > functions > > > > > > Just merged - https://github.com/tianocore/edk2/pull/3796 > > > > > > > > > > -Original Message- > > > > From: Vang, Judah > > > > Sent: Tuesday, December 20, 2022 8:44 AM > > > > To: devel@edk2.groups.io; Vang, Judah > > > > Cc: Yao, Jiewen ; Wang, Jian J > > > > ; Xiaoyu Lu ; Jiang, > > Guomin > > > > ; Mistry, Nishant C > > > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable > > crypto > > > > functions > > > > > > > > Hi Jiewen, > > > > > > > > Has this patch been merged? > > > > This is an important change for the UEFI Protected Variable feature. > > > > > > > > Judah > > > > > > > > -Original Message- > > > > From: devel@edk2.groups.io On Behalf Of > > Judah > > > > Vang > > > > Sent: Monday, November 7, 2022 2:16 PM > > > > To: devel@edk2.groups.io > > > > Cc: Yao, Jiewen ; Wang, Jian J > > > > ; Xiaoyu Lu ; Jiang, > > Guomin > > > > ; Mistry, Nishant C > > > > > > Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable > > > > crypto functions > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 > > > > > > > > V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. > > > > Update Readme.md > > > > > > > > Cc: Jiewen Yao > > > > Cc: Jian J Wang > > > > Cc: Xiaoyu Lu > > > > Cc: Guomin Jiang > > > > Cc: Nishant C Mistry > > > > Signed-off-by: Jian J Wang > > > > Signed-off-by: Nishant C Mistry > > > > Signed-off-by: Judah Vang > > > > --- > > > > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- > > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > > CryptoPkg/Readme.md
Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions
The readme was updated, however, I did miss the .dsc. Will submit another patch to address the .dsc file Judah -Original Message- From: Yao, Jiewen Sent: Monday, December 19, 2022 6:52 PM To: Kinney, Michael D ; devel@edk2.groups.io; Vang, Judah Cc: Wang, Jian J ; Xiaoyu Lu ; Jiang, Guomin ; Mistry, Nishant C Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions Hi Mike You are right. I missed that part. Hi Judah Would you please file another patch to update DSC file, to make it align with readme? Thank you Yao, Jiewen > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, December 20, 2022 9:55 AM > To: devel@edk2.groups.io; Yao, Jiewen ; Vang, > Judah > Cc: Wang, Jian J ; Xiaoyu Lu > ; Jiang, Guomin ; > Mistry, Nishant C ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable > crypto functions > > Hi Jiewen, > > I noticed that this patch is missing the update to the table in > ReadMe.md to show the new PEI and SMM crypto services enabled by > default in *CryptLib library instances. > > https://github.com/tianocore/edk2/tree/master/CryptoPkg#supported- > cryptographic-families-and-services > > It did update the recommended PCD settings at the end of the ReadMe, > but missed the update to CryptoPkg.dsc file to actually enable the PEI > and SMM services in the Crypto Drivers. > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > > Sent: Monday, December 19, 2022 5:40 PM > > To: Vang, Judah ; devel@edk2.groups.io > > Cc: Wang, Jian J ; Xiaoyu Lu > ; Jiang, Guomin ; > > Mistry, Nishant C > > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable > > crypto > functions > > > > Just merged - https://github.com/tianocore/edk2/pull/3796 > > > > > > > -Original Message- > > > From: Vang, Judah > > > Sent: Tuesday, December 20, 2022 8:44 AM > > > To: devel@edk2.groups.io; Vang, Judah > > > Cc: Yao, Jiewen ; Wang, Jian J > > > ; Xiaoyu Lu ; Jiang, > Guomin > > > ; Mistry, Nishant C > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable > crypto > > > functions > > > > > > Hi Jiewen, > > > > > > Has this patch been merged? > > > This is an important change for the UEFI Protected Variable feature. > > > > > > Judah > > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of > Judah > > > Vang > > > Sent: Monday, November 7, 2022 2:16 PM > > > To: devel@edk2.groups.io > > > Cc: Yao, Jiewen ; Wang, Jian J > > > ; Xiaoyu Lu ; Jiang, > Guomin > > > ; Mistry, Nishant C > > > > Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable > > > crypto functions > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 > > > > > > V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. > > > Update Readme.md > > > > > > Cc: Jiewen Yao > > > Cc: Jian J Wang > > > Cc: Xiaoyu Lu > > > Cc: Guomin Jiang > > > Cc: Nishant C Mistry > > > Signed-off-by: Jian J Wang > > > Signed-off-by: Nishant C Mistry > > > Signed-off-by: Judah Vang > > > --- > > > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > CryptoPkg/Readme.md| 27 +++- > > > 3 files changed, 17 insertions(+), 14 deletions(-) > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > > index b1629647f9c6..ee5f3cd5d4b6 100644 > > > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > > @@ -43,7 +43,7 @@ [Sources] > > >Hash/CryptParallelHashNull.c > > >Hmac/CryptHmac.c > > >Kdf/CryptHkdf.c > > > - Cipher/CryptAesNull.c > > > + Cipher/CryptAes.c > > >Cipher/CryptAeadAesGcmNull.c > > >Pk/CryptRsaBasic.c > > >Pk/CryptRsaExtNull.c > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > index 0af7a3f96e8f..cc5a53ca92cd 100644 > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > &g
Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions
Hi Mike You are right. I missed that part. Hi Judah Would you please file another patch to update DSC file, to make it align with readme? Thank you Yao, Jiewen > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, December 20, 2022 9:55 AM > To: devel@edk2.groups.io; Yao, Jiewen ; Vang, > Judah > Cc: Wang, Jian J ; Xiaoyu Lu ; > Jiang, Guomin ; Mistry, Nishant C > ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto > functions > > Hi Jiewen, > > I noticed that this patch is missing the update to the table in ReadMe.md to > show the new PEI and SMM crypto services enabled by default in *CryptLib > library instances. > > https://github.com/tianocore/edk2/tree/master/CryptoPkg#supported- > cryptographic-families-and-services > > It did update the recommended PCD settings at the end of the > ReadMe, but missed the update to CryptoPkg.dsc file to actually > enable the PEI and SMM services in the Crypto Drivers. > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > > Sent: Monday, December 19, 2022 5:40 PM > > To: Vang, Judah ; devel@edk2.groups.io > > Cc: Wang, Jian J ; Xiaoyu Lu > ; Jiang, Guomin ; > > Mistry, Nishant C > > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto > functions > > > > Just merged - https://github.com/tianocore/edk2/pull/3796 > > > > > > > -Original Message- > > > From: Vang, Judah > > > Sent: Tuesday, December 20, 2022 8:44 AM > > > To: devel@edk2.groups.io; Vang, Judah > > > Cc: Yao, Jiewen ; Wang, Jian J > > > ; Xiaoyu Lu ; Jiang, > Guomin > > > ; Mistry, Nishant C > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable > crypto > > > functions > > > > > > Hi Jiewen, > > > > > > Has this patch been merged? > > > This is an important change for the UEFI Protected Variable feature. > > > > > > Judah > > > > > > -----Original Message- > > > From: devel@edk2.groups.io On Behalf Of > Judah > > > Vang > > > Sent: Monday, November 7, 2022 2:16 PM > > > To: devel@edk2.groups.io > > > Cc: Yao, Jiewen ; Wang, Jian J > > > ; Xiaoyu Lu ; Jiang, > Guomin > > > ; Mistry, Nishant C > > > > Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto > > > functions > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 > > > > > > V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. > > > Update Readme.md > > > > > > Cc: Jiewen Yao > > > Cc: Jian J Wang > > > Cc: Xiaoyu Lu > > > Cc: Guomin Jiang > > > Cc: Nishant C Mistry > > > Signed-off-by: Jian J Wang > > > Signed-off-by: Nishant C Mistry > > > Signed-off-by: Judah Vang > > > --- > > > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > CryptoPkg/Readme.md| 27 +++- > > > 3 files changed, 17 insertions(+), 14 deletions(-) > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > > index b1629647f9c6..ee5f3cd5d4b6 100644 > > > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > > @@ -43,7 +43,7 @@ [Sources] > > >Hash/CryptParallelHashNull.c > > >Hmac/CryptHmac.c > > >Kdf/CryptHkdf.c > > > - Cipher/CryptAesNull.c > > > + Cipher/CryptAes.c > > >Cipher/CryptAeadAesGcmNull.c > > >Pk/CryptRsaBasic.c > > >Pk/CryptRsaExtNull.c > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > index 0af7a3f96e8f..cc5a53ca92cd 100644 > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > @@ -43,7 +43,7 @@ [Sources] > > >Hash/CryptCShake256.c > > >Hash/CryptParallelHash.c > > >Hmac/CryptHmac.c > > > - Kdf/CryptHkdfNull.c > > > + Kdf/CryptHkdf.c > > >Cipher/CryptAes.c > > >Cipher/CryptAeadAesGcmNull.c > > >Pk/CryptRsa
Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions
Hi Jiewen, I noticed that this patch is missing the update to the table in ReadMe.md to show the new PEI and SMM crypto services enabled by default in *CryptLib library instances. https://github.com/tianocore/edk2/tree/master/CryptoPkg#supported-cryptographic-families-and-services It did update the recommended PCD settings at the end of the ReadMe, but missed the update to CryptoPkg.dsc file to actually enable the PEI and SMM services in the Crypto Drivers. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Monday, December 19, 2022 5:40 PM > To: Vang, Judah ; devel@edk2.groups.io > Cc: Wang, Jian J ; Xiaoyu Lu ; > Jiang, Guomin ; > Mistry, Nishant C > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto > functions > > Just merged - https://github.com/tianocore/edk2/pull/3796 > > > > -Original Message- > > From: Vang, Judah > > Sent: Tuesday, December 20, 2022 8:44 AM > > To: devel@edk2.groups.io; Vang, Judah > > Cc: Yao, Jiewen ; Wang, Jian J > > ; Xiaoyu Lu ; Jiang, Guomin > > ; Mistry, Nishant C > > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto > > functions > > > > Hi Jiewen, > > > > Has this patch been merged? > > This is an important change for the UEFI Protected Variable feature. > > > > Judah > > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Judah > > Vang > > Sent: Monday, November 7, 2022 2:16 PM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen ; Wang, Jian J > > ; Xiaoyu Lu ; Jiang, Guomin > > ; Mistry, Nishant C > > Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto > > functions > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 > > > > V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. > > Update Readme.md > > > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Xiaoyu Lu > > Cc: Guomin Jiang > > Cc: Nishant C Mistry > > Signed-off-by: Jian J Wang > > Signed-off-by: Nishant C Mistry > > Signed-off-by: Judah Vang > > --- > > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > CryptoPkg/Readme.md| 27 +++- > > 3 files changed, 17 insertions(+), 14 deletions(-) > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > index b1629647f9c6..ee5f3cd5d4b6 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > > @@ -43,7 +43,7 @@ [Sources] > >Hash/CryptParallelHashNull.c > >Hmac/CryptHmac.c > >Kdf/CryptHkdf.c > > - Cipher/CryptAesNull.c > > + Cipher/CryptAes.c > >Cipher/CryptAeadAesGcmNull.c > >Pk/CryptRsaBasic.c > >Pk/CryptRsaExtNull.c > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > index 0af7a3f96e8f..cc5a53ca92cd 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > @@ -43,7 +43,7 @@ [Sources] > >Hash/CryptCShake256.c > >Hash/CryptParallelHash.c > >Hmac/CryptHmac.c > > - Kdf/CryptHkdfNull.c > > + Kdf/CryptHkdf.c > >Cipher/CryptAes.c > >Cipher/CryptAeadAesGcmNull.c > >Pk/CryptRsaBasic.c > > diff --git a/CryptoPkg/Readme.md b/CryptoPkg/Readme.md index > > 067465b8eb7d..cb072db72397 100644 > > --- a/CryptoPkg/Readme.md > > +++ b/CryptoPkg/Readme.md > > @@ -447,18 +447,20 @@ and CryptoSmm modules. > > Common PEI PcdCryptoServiceFamilyEnable Settings > > > > ``` > > - > > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.F > > amily | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > > - > > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha384.F > > amily | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > > - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > > - > > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > > - > > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family > > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > > - > > gEfiCryptoPkgTokenSpaceGuid.PcdCry
Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions
Just merged - https://github.com/tianocore/edk2/pull/3796 > -Original Message- > From: Vang, Judah > Sent: Tuesday, December 20, 2022 8:44 AM > To: devel@edk2.groups.io; Vang, Judah > Cc: Yao, Jiewen ; Wang, Jian J > ; Xiaoyu Lu ; Jiang, Guomin > ; Mistry, Nishant C > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto > functions > > Hi Jiewen, > > Has this patch been merged? > This is an important change for the UEFI Protected Variable feature. > > Judah > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Judah > Vang > Sent: Monday, November 7, 2022 2:16 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Xiaoyu Lu ; Jiang, Guomin > ; Mistry, Nishant C > Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto > functions > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 > > V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. > Update Readme.md > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Nishant C Mistry > Signed-off-by: Jian J Wang > Signed-off-by: Nishant C Mistry > Signed-off-by: Judah Vang > --- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > CryptoPkg/Readme.md| 27 +++- > 3 files changed, 17 insertions(+), 14 deletions(-) > > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > index b1629647f9c6..ee5f3cd5d4b6 100644 > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > @@ -43,7 +43,7 @@ [Sources] >Hash/CryptParallelHashNull.c >Hmac/CryptHmac.c >Kdf/CryptHkdf.c > - Cipher/CryptAesNull.c > + Cipher/CryptAes.c >Cipher/CryptAeadAesGcmNull.c >Pk/CryptRsaBasic.c >Pk/CryptRsaExtNull.c > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > index 0af7a3f96e8f..cc5a53ca92cd 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > @@ -43,7 +43,7 @@ [Sources] >Hash/CryptCShake256.c >Hash/CryptParallelHash.c >Hmac/CryptHmac.c > - Kdf/CryptHkdfNull.c > + Kdf/CryptHkdf.c >Cipher/CryptAes.c >Cipher/CryptAeadAesGcmNull.c >Pk/CryptRsaBasic.c > diff --git a/CryptoPkg/Readme.md b/CryptoPkg/Readme.md index > 067465b8eb7d..cb072db72397 100644 > --- a/CryptoPkg/Readme.md > +++ b/CryptoPkg/Readme.md > @@ -447,18 +447,20 @@ and CryptoSmm modules. > Common PEI PcdCryptoServiceFamilyEnable Settings > > ``` > - > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.F > amily | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > - > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha384.F > amily | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > - > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > - > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > - > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha512.Family > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sm3.Family > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > - > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Pk > cs1Verify| TRUE > - > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.N > ew| TRUE > - > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Fr > ee | TRUE > - > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Se > tKey | TRUE > - > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services.P > kcs5HashPassword | TRUE > + > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.F > amily| PCD_CRYPTO_SERVICE_ENABLE_FAMILY > + > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha384.F > amily| PCD_CRYPTO_SERVICE_ENABLE_FAMILY > + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > + > gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family > | PCD_CRYPTO_SERVICE_ENABLE_FAMILY > + > gEfiCryptoPkgT
Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions
Hi Jiewen, Has this patch been merged? This is an important change for the UEFI Protected Variable feature. Judah -Original Message- From: devel@edk2.groups.io On Behalf Of Judah Vang Sent: Monday, November 7, 2022 2:16 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Wang, Jian J ; Xiaoyu Lu ; Jiang, Guomin ; Mistry, Nishant C Subject: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. Update Readme.md Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- CryptoPkg/Readme.md| 27 +++- 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf index b1629647f9c6..ee5f3cd5d4b6 100644 --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf @@ -43,7 +43,7 @@ [Sources] Hash/CryptParallelHashNull.c Hmac/CryptHmac.c Kdf/CryptHkdf.c - Cipher/CryptAesNull.c + Cipher/CryptAes.c Cipher/CryptAeadAesGcmNull.c Pk/CryptRsaBasic.c Pk/CryptRsaExtNull.c diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf index 0af7a3f96e8f..cc5a53ca92cd 100644 --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf @@ -43,7 +43,7 @@ [Sources] Hash/CryptCShake256.c Hash/CryptParallelHash.c Hmac/CryptHmac.c - Kdf/CryptHkdfNull.c + Kdf/CryptHkdf.c Cipher/CryptAes.c Cipher/CryptAeadAesGcmNull.c Pk/CryptRsaBasic.c diff --git a/CryptoPkg/Readme.md b/CryptoPkg/Readme.md index 067465b8eb7d..cb072db72397 100644 --- a/CryptoPkg/Readme.md +++ b/CryptoPkg/Readme.md @@ -447,18 +447,20 @@ and CryptoSmm modules. Common PEI PcdCryptoServiceFamilyEnable Settings ``` - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha384.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha512.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sm3.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Pkcs1Verify | TRUE - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.New | TRUE - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Free | TRUE - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.SetKey | TRUE - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services.Pkcs5HashPassword | TRUE + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha384.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha512.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sm3.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Pkcs1Verify | TRUE + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.New | TRUE + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Free | TRUE
[edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. Update Readme.md Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- CryptoPkg/Readme.md| 27 +++- 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf index b1629647f9c6..ee5f3cd5d4b6 100644 --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf @@ -43,7 +43,7 @@ [Sources] Hash/CryptParallelHashNull.c Hmac/CryptHmac.c Kdf/CryptHkdf.c - Cipher/CryptAesNull.c + Cipher/CryptAes.c Cipher/CryptAeadAesGcmNull.c Pk/CryptRsaBasic.c Pk/CryptRsaExtNull.c diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf index 0af7a3f96e8f..cc5a53ca92cd 100644 --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf @@ -43,7 +43,7 @@ [Sources] Hash/CryptCShake256.c Hash/CryptParallelHash.c Hmac/CryptHmac.c - Kdf/CryptHkdfNull.c + Kdf/CryptHkdf.c Cipher/CryptAes.c Cipher/CryptAeadAesGcmNull.c Pk/CryptRsaBasic.c diff --git a/CryptoPkg/Readme.md b/CryptoPkg/Readme.md index 067465b8eb7d..cb072db72397 100644 --- a/CryptoPkg/Readme.md +++ b/CryptoPkg/Readme.md @@ -447,18 +447,20 @@ and CryptoSmm modules. Common PEI PcdCryptoServiceFamilyEnable Settings ``` - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha384.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha512.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sm3.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Pkcs1Verify | TRUE - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.New | TRUE - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Free | TRUE - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.SetKey | TRUE - gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services.Pkcs5HashPassword | TRUE + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.HmacSha384.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha1.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha256.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha384.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sha512.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Sm3.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Aes.Family | PCD_CRYPTO_SERVICE_ENABLE_FAMILY + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Pkcs1Verify | TRUE + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.New | TRUE + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.Free | TRUE + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Rsa.Services.SetKey | TRUE + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Pkcs.Services.Pkcs5HashPassword | TRUE + gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceFamilyEnable.Hkdf.Services.Sha256ExtractAndExpand | TRUE ``` Common DXE and SMM PcdCryptoServiceFamilyEnable Settings @@ -466,6 +468,7 @@ and CryptoSmm modules. ``` gEfiCrypto
