Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2

2022-03-15 Thread Sami Mujawar
Hi All,

The GCC download link is now restored and the EDK2 CI is functional again.
This patch has been merged as a13dfc769bd7..c8ea48bdf955

Regards,

Sami Mujawar

On 14/03/2022, 15:00, "Sami Mujawar"  wrote:

Hi All,

Azure pipeline jobs are failing due to broken download link for the GCC Arm 
10.3-2021.07 compiler, see 
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=44398=logs=9b8d87a5-bd93-5358-8ffa-588e312c4376=aacec3cc-93ca-52e0-9354-41df8e192656

I am working to get the download links fixed. In the meantime, some patches 
may not get merged in edk2. 
Apologies for the inconvenience.  

Regards,

Sami Mujawar


On 14/03/2022, 11:49, "Sunny Wang"  wrote:

I tested this patch as well and confirmed this patch fixed the FWTS 
failure below. Thanks, Sami.
- dbg2: DBG2 Device 'COM0' not found in ACPI object name space.

Tested-by: Sunny Wang 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of 
Jagadeesh Ujja via groups.io
Sent: 14 March 2022 05:01
To: devel@edk2.groups.io; Sami Mujawar 
Cc: Alexei Fedorov ; Matteo Carlini 
; Akanksha Jain ; Ben Adderson 
; Pierre Gondois 
    Subject: Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial 
port namespace path in DBG2

Hi Sami,
The patch is tested and looks good to me:

Tested-by: Jagadeesh Ujja 

On Fri, Mar 11, 2022 at 6:38 PM PierreGondois  
wrote:
>
> Hi Sami,
> The patch looks good to me:
>
> Reviewed-by: Pierre Gondois 
>
> On 3/10/22 18:39, Sami Mujawar wrote:
> > According to the Debug Port Table 2 (DBG2) specification,
> > February 17, 2021, the NamespaceString is a NULL terminated
> > ASCII string that consists of a fully qualified reference
> > to the object that represents the serial port device in the
> > ACPI namespace.
> >
> > The DBG2 table generator did not populate the full device
> > path for the serial port device, and this results in a FWTS
> > test failure.
> >
> > Therefore, populate the full namespace device path for the
> > serial port in DBG2 table.
> >
> > Signed-off-by: Sami Mujawar 
> > ---
> > The changes can be seen at:
> > 
https://github.com/samimujawar/edk2/tree/2105_dbg2_generator_namestring_issue_v1
> >
> >   DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c 
| 10 +++---
> >   1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git 
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > index 
3d513dbd1fbe8c47d270a9e639b2797098201d91..f6dfb3d94c10980a0e7712ce9427648b69974061
 100644
> > --- 
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > +++ 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > @@ -1,7 +1,7 @@
> >   /** @file
> > DBG2 Table Generator
> >
> > -  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
> > +  Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.
> >
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -55,13 +55,17 @@ Requirements:
> >   */
> >   #define NAME_STR_DBG_PORT0  "COM0"
> >
> > +/** A string representing the full path name of the debug port 0.
> > +*/
> > +#define NAMESPACE_STR_DBG_PORT0  "\\_SB_.COM0"
> > +
> >   /** An UID representing the debug port 0.
> >   */
> >   #define UID_DBG_PORT0  0
> >
> >   /** The length of the namespace string.
> >   */
> > -#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof 
(NAME_STR_DBG_PORT0)
> > +#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof 
(NAMESPACE_STR_DBG_PORT0)
> >
> >   /** The PL011 UART address range length.
> >   */
> > @@ -166,7 +170,7 @@ DBG2_TABLE  AcpiDbg2 = {
> > 0,// {Template}: Serial Port Subtype
> > 0,// {Template}: Serial Port Base 
Address
> > PL011_UART_LENGTH,
> > -  NAME_STR_DBG_PORT0
> > +  NAMESPACE_STR_DBG_PORT0
> > )
> > }
> >   };
>
>
>
>
>









-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87601): https://edk2.groups.io/g/devel/message/87601
Mute This Topic: https://groups.io/mt/89691998/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2

2022-03-14 Thread Sami Mujawar
Hi All,

Azure pipeline jobs are failing due to broken download link for the GCC Arm 
10.3-2021.07 compiler, see 
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=44398=logs=9b8d87a5-bd93-5358-8ffa-588e312c4376=aacec3cc-93ca-52e0-9354-41df8e192656

I am working to get the download links fixed. In the meantime, some patches may 
not get merged in edk2.
Apologies for the inconvenience.

Regards,

Sami Mujawar


On 14/03/2022, 11:49, "Sunny Wang"  wrote:

I tested this patch as well and confirmed this patch fixed the FWTS failure 
below. Thanks, Sami.
- dbg2: DBG2 Device 'COM0' not found in ACPI object name space.

Tested-by: Sunny Wang 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Jagadeesh 
Ujja via groups.io
Sent: 14 March 2022 05:01
To: devel@edk2.groups.io; Sami Mujawar 
Cc: Alexei Fedorov ; Matteo Carlini 
; Akanksha Jain ; Ben Adderson 
; Pierre Gondois 
Subject: Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port 
namespace path in DBG2

Hi Sami,
The patch is tested and looks good to me:

Tested-by: Jagadeesh Ujja 

On Fri, Mar 11, 2022 at 6:38 PM PierreGondois  
wrote:
>
> Hi Sami,
> The patch looks good to me:
>
> Reviewed-by: Pierre Gondois 
>
> On 3/10/22 18:39, Sami Mujawar wrote:
> > According to the Debug Port Table 2 (DBG2) specification,
> > February 17, 2021, the NamespaceString is a NULL terminated
> > ASCII string that consists of a fully qualified reference
> > to the object that represents the serial port device in the
> > ACPI namespace.
> >
> > The DBG2 table generator did not populate the full device
> > path for the serial port device, and this results in a FWTS
> > test failure.
> >
> > Therefore, populate the full namespace device path for the
> > serial port in DBG2 table.
> >
> > Signed-off-by: Sami Mujawar 
> > ---
> > The changes can be seen at:
> > 
https://github.com/samimujawar/edk2/tree/2105_dbg2_generator_namestring_issue_v1
> >
> >   DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 10 
+++---
> >   1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git 
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > index 
3d513dbd1fbe8c47d270a9e639b2797098201d91..f6dfb3d94c10980a0e7712ce9427648b69974061
 100644
> > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > @@ -1,7 +1,7 @@
> >   /** @file
> > DBG2 Table Generator
> >
> > -  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
> > +  Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.
> >
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -55,13 +55,17 @@ Requirements:
> >   */
> >   #define NAME_STR_DBG_PORT0  "COM0"
> >
> > +/** A string representing the full path name of the debug port 0.
> > +*/
> > +#define NAMESPACE_STR_DBG_PORT0  "\\_SB_.COM0"
> > +
> >   /** An UID representing the debug port 0.
> >   */
> >   #define UID_DBG_PORT0  0
> >
> >   /** The length of the namespace string.
> >   */
> > -#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof (NAME_STR_DBG_PORT0)
> > +#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof 
(NAMESPACE_STR_DBG_PORT0)
> >
> >   /** The PL011 UART address range length.
> >   */
> > @@ -166,7 +170,7 @@ DBG2_TABLE  AcpiDbg2 = {
> > 0,// {Template}: Serial Port Subtype
> > 0,// {Template}: Serial Port Base Address
> > PL011_UART_LENGTH,
> > -  NAME_STR_DBG_PORT0
> > +  NAMESPACE_STR_DBG_PORT0
> > )
> > }
> >   };
>
>
>
>
>






IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87538): https://edk2.groups.io/g/devel/message/87538
Mute This Topic: https://groups.io/mt/89691998/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2

2022-03-14 Thread Sunny Wang
I tested this patch as well and confirmed this patch fixed the FWTS failure 
below. Thanks, Sami.
- dbg2: DBG2 Device 'COM0' not found in ACPI object name space.

Tested-by: Sunny Wang 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Jagadeesh Ujja 
via groups.io
Sent: 14 March 2022 05:01
To: devel@edk2.groups.io; Sami Mujawar 
Cc: Alexei Fedorov ; Matteo Carlini 
; Akanksha Jain ; Ben Adderson 
; Pierre Gondois 
Subject: Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port 
namespace path in DBG2

Hi Sami,
The patch is tested and looks good to me:

Tested-by: Jagadeesh Ujja 

On Fri, Mar 11, 2022 at 6:38 PM PierreGondois  wrote:
>
> Hi Sami,
> The patch looks good to me:
>
> Reviewed-by: Pierre Gondois 
>
> On 3/10/22 18:39, Sami Mujawar wrote:
> > According to the Debug Port Table 2 (DBG2) specification,
> > February 17, 2021, the NamespaceString is a NULL terminated
> > ASCII string that consists of a fully qualified reference
> > to the object that represents the serial port device in the
> > ACPI namespace.
> >
> > The DBG2 table generator did not populate the full device
> > path for the serial port device, and this results in a FWTS
> > test failure.
> >
> > Therefore, populate the full namespace device path for the
> > serial port in DBG2 table.
> >
> > Signed-off-by: Sami Mujawar 
> > ---
> > The changes can be seen at:
> > https://github.com/samimujawar/edk2/tree/2105_dbg2_generator_namestring_issue_v1
> >
> >   DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 10 
> > +++---
> >   1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git 
> > a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c 
> > b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > index 
> > 3d513dbd1fbe8c47d270a9e639b2797098201d91..f6dfb3d94c10980a0e7712ce9427648b69974061
> >  100644
> > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > @@ -1,7 +1,7 @@
> >   /** @file
> > DBG2 Table Generator
> >
> > -  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
> > +  Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.
> >
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -55,13 +55,17 @@ Requirements:
> >   */
> >   #define NAME_STR_DBG_PORT0  "COM0"
> >
> > +/** A string representing the full path name of the debug port 0.
> > +*/
> > +#define NAMESPACE_STR_DBG_PORT0  "\\_SB_.COM0"
> > +
> >   /** An UID representing the debug port 0.
> >   */
> >   #define UID_DBG_PORT0  0
> >
> >   /** The length of the namespace string.
> >   */
> > -#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof (NAME_STR_DBG_PORT0)
> > +#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof (NAMESPACE_STR_DBG_PORT0)
> >
> >   /** The PL011 UART address range length.
> >   */
> > @@ -166,7 +170,7 @@ DBG2_TABLE  AcpiDbg2 = {
> > 0,// {Template}: Serial Port Subtype
> > 0,// {Template}: Serial Port Base Address
> > PL011_UART_LENGTH,
> > -  NAME_STR_DBG_PORT0
> > +  NAMESPACE_STR_DBG_PORT0
> > )
> > }
> >   };
>
>
>
>
>





IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87536): https://edk2.groups.io/g/devel/message/87536
Mute This Topic: https://groups.io/mt/89691998/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2

2022-03-13 Thread Jagadeesh Ujja
Hi Sami,
The patch is tested and looks good to me:

Tested-by: Jagadeesh Ujja 

On Fri, Mar 11, 2022 at 6:38 PM PierreGondois  wrote:
>
> Hi Sami,
> The patch looks good to me:
>
> Reviewed-by: Pierre Gondois 
>
> On 3/10/22 18:39, Sami Mujawar wrote:
> > According to the Debug Port Table 2 (DBG2) specification,
> > February 17, 2021, the NamespaceString is a NULL terminated
> > ASCII string that consists of a fully qualified reference
> > to the object that represents the serial port device in the
> > ACPI namespace.
> >
> > The DBG2 table generator did not populate the full device
> > path for the serial port device, and this results in a FWTS
> > test failure.
> >
> > Therefore, populate the full namespace device path for the
> > serial port in DBG2 table.
> >
> > Signed-off-by: Sami Mujawar 
> > ---
> > The changes can be seen at:
> > https://github.com/samimujawar/edk2/tree/2105_dbg2_generator_namestring_issue_v1
> >
> >   DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 10 
> > +++---
> >   1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git 
> > a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c 
> > b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > index 
> > 3d513dbd1fbe8c47d270a9e639b2797098201d91..f6dfb3d94c10980a0e7712ce9427648b69974061
> >  100644
> > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > @@ -1,7 +1,7 @@
> >   /** @file
> > DBG2 Table Generator
> >
> > -  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
> > +  Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.
> >
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -55,13 +55,17 @@ Requirements:
> >   */
> >   #define NAME_STR_DBG_PORT0  "COM0"
> >
> > +/** A string representing the full path name of the debug port 0.
> > +*/
> > +#define NAMESPACE_STR_DBG_PORT0  "\\_SB_.COM0"
> > +
> >   /** An UID representing the debug port 0.
> >   */
> >   #define UID_DBG_PORT0  0
> >
> >   /** The length of the namespace string.
> >   */
> > -#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof (NAME_STR_DBG_PORT0)
> > +#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof (NAMESPACE_STR_DBG_PORT0)
> >
> >   /** The PL011 UART address range length.
> >   */
> > @@ -166,7 +170,7 @@ DBG2_TABLE  AcpiDbg2 = {
> > 0,// {Template}: Serial Port Subtype
> > 0,// {Template}: Serial Port Base Address
> > PL011_UART_LENGTH,
> > -  NAME_STR_DBG_PORT0
> > +  NAMESPACE_STR_DBG_PORT0
> > )
> > }
> >   };
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87529): https://edk2.groups.io/g/devel/message/87529
Mute This Topic: https://groups.io/mt/89691998/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2

2022-03-11 Thread PierreGondois

Hi Sami,
The patch looks good to me:

Reviewed-by: Pierre Gondois 

On 3/10/22 18:39, Sami Mujawar wrote:

According to the Debug Port Table 2 (DBG2) specification,
February 17, 2021, the NamespaceString is a NULL terminated
ASCII string that consists of a fully qualified reference
to the object that represents the serial port device in the
ACPI namespace.

The DBG2 table generator did not populate the full device
path for the serial port device, and this results in a FWTS
test failure.

Therefore, populate the full namespace device path for the
serial port in DBG2 table.

Signed-off-by: Sami Mujawar 
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2105_dbg2_generator_namestring_issue_v1

  DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 10 
+++---
  1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
index 
3d513dbd1fbe8c47d270a9e639b2797098201d91..f6dfb3d94c10980a0e7712ce9427648b69974061
 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
@@ -1,7 +1,7 @@
  /** @file
DBG2 Table Generator
  
-  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.

+  Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.
  
SPDX-License-Identifier: BSD-2-Clause-Patent
  
@@ -55,13 +55,17 @@ Requirements:

  */
  #define NAME_STR_DBG_PORT0  "COM0"
  
+/** A string representing the full path name of the debug port 0.

+*/
+#define NAMESPACE_STR_DBG_PORT0  "\\_SB_.COM0"
+
  /** An UID representing the debug port 0.
  */
  #define UID_DBG_PORT0  0
  
  /** The length of the namespace string.

  */
-#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof (NAME_STR_DBG_PORT0)
+#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof (NAMESPACE_STR_DBG_PORT0)
  
  /** The PL011 UART address range length.

  */
@@ -166,7 +170,7 @@ DBG2_TABLE  AcpiDbg2 = {
0,// {Template}: Serial Port Subtype
0,// {Template}: Serial Port Base Address
PL011_UART_LENGTH,
-  NAME_STR_DBG_PORT0
+  NAMESPACE_STR_DBG_PORT0
)
}
  };



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87462): https://edk2.groups.io/g/devel/message/87462
Mute This Topic: https://groups.io/mt/89691998/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2

2022-03-10 Thread Sami Mujawar
According to the Debug Port Table 2 (DBG2) specification,
February 17, 2021, the NamespaceString is a NULL terminated
ASCII string that consists of a fully qualified reference
to the object that represents the serial port device in the
ACPI namespace.

The DBG2 table generator did not populate the full device
path for the serial port device, and this results in a FWTS
test failure.

Therefore, populate the full namespace device path for the
serial port in DBG2 table.

Signed-off-by: Sami Mujawar 
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2105_dbg2_generator_namestring_issue_v1

 DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 10 
+++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
index 
3d513dbd1fbe8c47d270a9e639b2797098201d91..f6dfb3d94c10980a0e7712ce9427648b69974061
 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
@@ -1,7 +1,7 @@
 /** @file
   DBG2 Table Generator
 
-  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
+  Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -55,13 +55,17 @@ Requirements:
 */
 #define NAME_STR_DBG_PORT0  "COM0"
 
+/** A string representing the full path name of the debug port 0.
+*/
+#define NAMESPACE_STR_DBG_PORT0  "\\_SB_.COM0"
+
 /** An UID representing the debug port 0.
 */
 #define UID_DBG_PORT0  0
 
 /** The length of the namespace string.
 */
-#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof (NAME_STR_DBG_PORT0)
+#define DBG2_NAMESPACESTRING_FIELD_SIZE  sizeof (NAMESPACE_STR_DBG_PORT0)
 
 /** The PL011 UART address range length.
 */
@@ -166,7 +170,7 @@ DBG2_TABLE  AcpiDbg2 = {
   0,// {Template}: Serial Port Subtype
   0,// {Template}: Serial Port Base Address
   PL011_UART_LENGTH,
-  NAME_STR_DBG_PORT0
+  NAMESPACE_STR_DBG_PORT0
   )
   }
 };
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87421): https://edk2.groups.io/g/devel/message/87421
Mute This Topic: https://groups.io/mt/89691998/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-