Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from UPL entryfunc

2023-03-02 Thread Ni, Ray
Curious about the background of this change.

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Dhaval
> Sharma
> Sent: Friday, March 3, 2023 2:12 AM
> To: devel@edk2.groups.io
> Cc: Guo, Gua 
> Subject: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from
> UPL entryfunc
> 
> Signed-off-by: Dhaval Sharma 
> Cc: Gua Guo 
> ---
>  UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
> b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
> index 46ee27c905e9..07f4c1d29686 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
> +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
> @@ -470,9 +470,6 @@ _ModuleEntryPoint (
>  PrintHob (mHobList);
>  );
> 
> -  // Initialize floating point operating environment to be compliant with 
> UEFI
> spec.
> -  InitializeFloatingPointUnits ();
> -
>// Build HOB based on information from Bootloader
>Status = BuildHobs (BootloaderParameter, );
>ASSERT_EFI_ERROR (Status);
> --
> 2.40.0.rc0.57.g454dfcbddf
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100649): https://edk2.groups.io/g/devel/message/100649
Mute This Topic: https://groups.io/mt/97345074/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: 
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from UPL entryfunc

2023-03-02 Thread Guo Dong
Reviewed-by: Guo Dong 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Dhaval Sharma
Sent: Thursday, March 2, 2023 11:12 AM
To: devel@edk2.groups.io
Cc: Guo, Gua 
Subject: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from UPL 
entryfunc

Signed-off-by: Dhaval Sharma 
Cc: Gua Guo 
---
 UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c 
b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
index 46ee27c905e9..07f4c1d29686 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
@@ -470,9 +470,6 @@ _ModuleEntryPoint (
 PrintHob (mHobList);
 );
 
-  // Initialize floating point operating environment to be compliant with UEFI 
spec.
-  InitializeFloatingPointUnits ();
-
   // Build HOB based on information from Bootloader
   Status = BuildHobs (BootloaderParameter, );
   ASSERT_EFI_ERROR (Status);
-- 
2.40.0.rc0.57.g454dfcbddf








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100644): https://edk2.groups.io/g/devel/message/100644
Mute This Topic: https://groups.io/mt/97345074/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from UPL entryfunc

2023-03-02 Thread Dhaval Sharma
Signed-off-by: Dhaval Sharma 
Cc: Gua Guo 
---
 UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c 
b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
index 46ee27c905e9..07f4c1d29686 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
@@ -470,9 +470,6 @@ _ModuleEntryPoint (
 PrintHob (mHobList);
 );
 
-  // Initialize floating point operating environment to be compliant with UEFI 
spec.
-  InitializeFloatingPointUnits ();
-
   // Build HOB based on information from Bootloader
   Status = BuildHobs (BootloaderParameter, );
   ASSERT_EFI_ERROR (Status);
-- 
2.40.0.rc0.57.g454dfcbddf



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100643): https://edk2.groups.io/g/devel/message/100643
Mute This Topic: https://groups.io/mt/97345074/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-