Re: [edk2-devel] [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit

2022-02-14 Thread Kowalewski, Robert 
Reviewed-by: Robert Kowalewski 

-Original Message-
From: Sheng, W  
Sent: Tuesday, February 15, 2022 7:58 AM
To: Kuo, Ted ; devel@edk2.groups.io
Cc: Ni, Ray ; Chaganty, Rangasai V 
; Huang, Jenny ; 
Kowalewski, Robert 
Subject: RE: [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 
64bit

The change is good to me.
Reviewed-by: Sheng Wei 


> -Original Message-
> From: Kuo, Ted 
> Sent: 2022年2月15日 14:47
> To: devel@edk2.groups.io
> Cc: Sheng, W ; Ni, Ray ; 
> Chaganty, Rangasai V ; Huang, Jenny 
> ; Kowalewski, Robert 
> 
> Subject: [PATCH v2] IntelSiliconPkg/VTd: Fix to support 
> IntelVTdDmarPei in 64bit
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3836
> Changed VtdIndex defined in PROCESS_DRHD_CALLBACK_FUNC from
> UINT32 to UINTN to avoid type incompatible error when enable PEI in 64bit.
> 
> Cc: Sheng Wei 
> Cc: Ray Ni 
> Cc: Rangasai V Chaganty 
> Cc: Jenny Huang 
> Cc: Robert Kowalewski 
> Signed-off-by: Ted Kuo 
> ---
>  .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c | 4
> ++--
>  .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.h | 2
> +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm
> ar
> Pei.c
> b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm
> ar
> Pei.c
> index f97d627eca..2844f366bb 100644
> ---
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm
> ar
> Pei.c
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelV
> +++ Td
> +++ DmarPei.c
> @@ -434,7 +434,7 @@ GetVTdInfoHob (
>  VOID
>  ProcessDhrdPreMemory (
>IN OUT VOID   *Context,
> -  IN UINT32 VTdIndex,
> +  IN UINTN  VTdIndex,
>IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>)
>  {
> @@ -454,7 +454,7 @@ ProcessDhrdPreMemory (  VOID ProcessDrhdPostMemory 
> (
>IN OUT VOID   *Context,
> -  IN UINT32 VTdIndex,
> +  IN UINTN  VTdIndex,
>IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>)
>  {
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm
> ar
> Pei.h
> b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm
> ar
> Pei.h
> index 351a7810d8..7bed0a5363 100644
> ---
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDm
> ar
> Pei.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelV
> +++ Td
> +++ DmarPei.h
> @@ -49,7 +49,7 @@ typedef
>  VOID
>  (*PROCESS_DRHD_CALLBACK_FUNC) (
>IN OUT VOID   *Context,
> -  IN UINT32 VTdIndex,
> +  IN UINTN  VTdIndex,
>IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>);
> 
> --
> 2.16.2.windows.1

-
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial 
Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | 
Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i 
moze zawierac informacje poufne. W razie przypadkowego otrzymania tej 
wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; 
jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole 
use of the intended recipient(s). If you are not the intended recipient, please 
contact the sender and delete all copies; any review or distribution by others 
is strictly prohibited.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86676): https://edk2.groups.io/g/devel/message/86676
Mute This Topic: https://groups.io/mt/89156060/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit

2022-02-14 Thread Sheng Wei 
The change is good to me.
Reviewed-by: Sheng Wei 


> -Original Message-
> From: Kuo, Ted 
> Sent: 2022年2月15日 14:47
> To: devel@edk2.groups.io
> Cc: Sheng, W ; Ni, Ray ; Chaganty,
> Rangasai V ; Huang, Jenny
> ; Kowalewski, Robert
> 
> Subject: [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in
> 64bit
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3836
> Changed VtdIndex defined in PROCESS_DRHD_CALLBACK_FUNC from
> UINT32 to UINTN to avoid type incompatible error when enable PEI in 64bit.
> 
> Cc: Sheng Wei 
> Cc: Ray Ni 
> Cc: Rangasai V Chaganty 
> Cc: Jenny Huang 
> Cc: Robert Kowalewski 
> Signed-off-by: Ted Kuo 
> ---
>  .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c | 4
> ++--
>  .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.h | 2
> +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.c
> b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.c
> index f97d627eca..2844f366bb 100644
> ---
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.c
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTd
> +++ DmarPei.c
> @@ -434,7 +434,7 @@ GetVTdInfoHob (
>  VOID
>  ProcessDhrdPreMemory (
>IN OUT VOID   *Context,
> -  IN UINT32 VTdIndex,
> +  IN UINTN  VTdIndex,
>IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>)
>  {
> @@ -454,7 +454,7 @@ ProcessDhrdPreMemory (  VOID
> ProcessDrhdPostMemory (
>IN OUT VOID   *Context,
> -  IN UINT32 VTdIndex,
> +  IN UINTN  VTdIndex,
>IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>)
>  {
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.h
> b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.h
> index 351a7810d8..7bed0a5363 100644
> ---
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTd
> +++ DmarPei.h
> @@ -49,7 +49,7 @@ typedef
>  VOID
>  (*PROCESS_DRHD_CALLBACK_FUNC) (
>IN OUT VOID   *Context,
> -  IN UINT32 VTdIndex,
> +  IN UINTN  VTdIndex,
>IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>);
> 
> --
> 2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86674): https://edk2.groups.io/g/devel/message/86674
Mute This Topic: https://groups.io/mt/89156060/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit

2022-02-14 Thread Sheng Wei 
Hi Ted,
Since we use UINTN as the return type of ParseDmarAcpiTableDrhd (), Could we 
keep UINTN here and change define of PROCESS_DRHD_CALLBACK_FUNC ?
typedef
VOID
(*PROCESS_DRHD_CALLBACK_FUNC) (
  IN OUT VOID   *Context,
  IN UINT32 VTdIndex, // change to UINTN
  IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
  );
And it also related to below 2 functions.
ProcessDrhdPostMemory ()
ProcessDhrdPreMemory ()
Need change the second parameter.
  IN UINT32 VTdIndex, // change to UINTN

Thank you
BR
Sheng Wei

> -Original Message-
> From: Kuo, Ted 
> Sent: 2022年2月15日 14:47
> To: devel@edk2.groups.io
> Cc: Sheng, W ; Ni, Ray ; Chaganty,
> Rangasai V ; Huang, Jenny
> ; Kowalewski, Robert
> 
> Subject: [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in
> 64bit
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3836
> Changed VtdIndex defined in PROCESS_DRHD_CALLBACK_FUNC from
> UINT32 to UINTN to avoid type incompatible error when enable PEI in 64bit.
> 
> Cc: Sheng Wei 
> Cc: Ray Ni 
> Cc: Rangasai V Chaganty 
> Cc: Jenny Huang 
> Cc: Robert Kowalewski 
> Signed-off-by: Ted Kuo 
> ---
>  .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c | 4
> ++--
>  .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.h | 2
> +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.c
> b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.c
> index f97d627eca..2844f366bb 100644
> ---
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.c
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTd
> +++ DmarPei.c
> @@ -434,7 +434,7 @@ GetVTdInfoHob (
>  VOID
>  ProcessDhrdPreMemory (
>IN OUT VOID   *Context,
> -  IN UINT32 VTdIndex,
> +  IN UINTN  VTdIndex,
>IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>)
>  {
> @@ -454,7 +454,7 @@ ProcessDhrdPreMemory (  VOID
> ProcessDrhdPostMemory (
>IN OUT VOID   *Context,
> -  IN UINT32 VTdIndex,
> +  IN UINTN  VTdIndex,
>IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>)
>  {
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.h
> b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.h
> index 351a7810d8..7bed0a5363 100644
> ---
> a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmar
> Pei.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTd
> +++ DmarPei.h
> @@ -49,7 +49,7 @@ typedef
>  VOID
>  (*PROCESS_DRHD_CALLBACK_FUNC) (
>IN OUT VOID   *Context,
> -  IN UINT32 VTdIndex,
> +  IN UINTN  VTdIndex,
>IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
>);
> 
> --
> 2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86673): https://edk2.groups.io/g/devel/message/86673
Mute This Topic: https://groups.io/mt/89156060/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit

2022-02-14 Thread Kuo, Ted 
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3836
Changed VtdIndex defined in PROCESS_DRHD_CALLBACK_FUNC from UINT32 to UINTN
to avoid type incompatible error when enable PEI in 64bit.

Cc: Sheng Wei 
Cc: Ray Ni 
Cc: Rangasai V Chaganty 
Cc: Jenny Huang 
Cc: Robert Kowalewski 
Signed-off-by: Ted Kuo 
---
 .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c | 4 ++--
 .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c 
b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c
index f97d627eca..2844f366bb 100644
--- 
a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c
+++ 
b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c
@@ -434,7 +434,7 @@ GetVTdInfoHob (
 VOID
 ProcessDhrdPreMemory (
   IN OUT VOID   *Context,
-  IN UINT32 VTdIndex,
+  IN UINTN  VTdIndex,
   IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
   )
 {
@@ -454,7 +454,7 @@ ProcessDhrdPreMemory (
 VOID
 ProcessDrhdPostMemory (
   IN OUT VOID   *Context,
-  IN UINT32 VTdIndex,
+  IN UINTN  VTdIndex,
   IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
   )
 {
diff --git 
a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.h 
b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.h
index 351a7810d8..7bed0a5363 100644
--- 
a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.h
+++ 
b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.h
@@ -49,7 +49,7 @@ typedef
 VOID
 (*PROCESS_DRHD_CALLBACK_FUNC) (
   IN OUT VOID   *Context,
-  IN UINT32 VTdIndex,
+  IN UINTN  VTdIndex,
   IN EFI_ACPI_DMAR_DRHD_HEADER  *DmarDrhd
   );
 
-- 
2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86672): https://edk2.groups.io/g/devel/message/86672
Mute This Topic: https://groups.io/mt/89156060/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-