Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

2022-09-26 Thread Chiu, Chasel 


Patch 4 Fspw to adopt FSP 2.4 MultiPhase has been merged:
https://github.com/tianocore/edk2/commit/96f3efbd991db83c608909c1c861a77fe26982f1

Thanks,
Chasel


> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Chiu, Chasel
> Sent: Tuesday, September 6, 2022 9:28 PM
> To: devel@edk2.groups.io; Chiu, Chasel 
> Cc: Desimone, Nathaniel L ; Zeng, Star
> 
> Subject: Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP
> 2.4 MultiPhase.
> 
> 
> patch3 Fsp24SecCore modules have been merged:
> https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfee9
> 6f462676e7
> 
> Thanks,
> Chasel
> 
> 
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of Chiu,
> > Chasel
> > Sent: Wednesday, August 31, 2022 11:13 AM
> > To: devel@edk2.groups.io
> > Cc: Desimone, Nathaniel L ; Zeng, Star
> > 
> > Subject: Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg:
> > Support FSP
> > 2.4 MultiPhase.
> >
> >
> > Patch1 and patch2 have been merged:
> >
> https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfee
> > 9
> > 6f462676e7
> >
> https://github.com/tianocore/edk2/commit/31a94f7fba2a2c1244fc35b6f631e
> > 2
> > 35e267715b
> >
> > Rest of the patches will be merged later.
> >
> > Thanks,
> > Chasel
> >
> >
> > > -Original Message-
> > > From: Chiu, Chasel 
> > > Sent: Tuesday, August 9, 2022 5:48 PM
> > > To: devel@edk2.groups.io
> > > Cc: Chiu, Chasel ; Desimone, Nathaniel L
> > > ; Zeng, Star 
> > > Subject: [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
> > >
> > > Add FSP 2.4 MultiPhase interfaces and implementation.
> > >
> > > Cc: Nate DeSimone 
> > > Cc: Star Zeng 
> > > Signed-off-by: Chasel Chiu 
> > >
> > > V2:
> > > . Add FspMultiPhasePlatformGetNumberOfPhases() and
> > > FspWrapperPlatformMultiPhaseHandler() to support platform porting.
> > >
> > > . Add FSP reset support in FspWrapperVariableRequestHandler()
> > >
> > > . Fix bug that wrong parameter given when calling
> > > FspWrapperVariableRequestHandler()
> > >
> > > . Corrected code comments.
> > >
> > > Chasel Chiu (4):
> > >   IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.
> > >   IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase interface.
> > >   IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions.
> > >   IntelFsp2WrapperPkg: Implement FSP 2.4 MultiPhase wrapper handlers.
> > >
> > >  IntelFsp2Pkg/FspSecCore/SecFsp.c
> > > |   4 
> > >  IntelFsp2Pkg/FspSecCore/SecFspApiChk.c
> > > |   9 +
> > >  IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c
> > > | 184
> > >
> >
> +
> > >
> >
> +
> > > ++
> > >  IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c
> > > |  30 ++
> > >  IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> > > |  33 +
> > >  IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > > |  27 +--
> > >
> > >
> > IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/
> > Fs
> > > pWrapperPlatformMultiPhaseLibSample.c   |  49
> > > +
> > >
> > >
> > IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapp
> > er
> > > MultiPhaseProcessLib.c  | 355
> > >
> >
> +
> > >
> >
> +
> > >
> >
> +
> > >
> >
> +
> > >
> >
> +
> > > ++
> > >  IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> > > |  75
> > >
> >
> +++

Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

2022-09-06 Thread Chiu, Chasel 


patch3 Fsp24SecCore modules have been merged:
https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfee96f462676e7

Thanks,
Chasel


> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Chiu, Chasel
> Sent: Wednesday, August 31, 2022 11:13 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Zeng, Star
> 
> Subject: Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP
> 2.4 MultiPhase.
> 
> 
> Patch1 and patch2 have been merged:
> https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfee9
> 6f462676e7
> https://github.com/tianocore/edk2/commit/31a94f7fba2a2c1244fc35b6f631e2
> 35e267715b
> 
> Rest of the patches will be merged later.
> 
> Thanks,
> Chasel
> 
> 
> > -Original Message-
> > From: Chiu, Chasel 
> > Sent: Tuesday, August 9, 2022 5:48 PM
> > To: devel@edk2.groups.io
> > Cc: Chiu, Chasel ; Desimone, Nathaniel L
> > ; Zeng, Star 
> > Subject: [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
> >
> > Add FSP 2.4 MultiPhase interfaces and implementation.
> >
> > Cc: Nate DeSimone 
> > Cc: Star Zeng 
> > Signed-off-by: Chasel Chiu 
> >
> > V2:
> > . Add FspMultiPhasePlatformGetNumberOfPhases() and
> > FspWrapperPlatformMultiPhaseHandler() to support platform porting.
> >
> > . Add FSP reset support in FspWrapperVariableRequestHandler()
> >
> > . Fix bug that wrong parameter given when calling
> > FspWrapperVariableRequestHandler()
> >
> > . Corrected code comments.
> >
> > Chasel Chiu (4):
> >   IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.
> >   IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase interface.
> >   IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions.
> >   IntelFsp2WrapperPkg: Implement FSP 2.4 MultiPhase wrapper handlers.
> >
> >  IntelFsp2Pkg/FspSecCore/SecFsp.c
> > |   4 
> >  IntelFsp2Pkg/FspSecCore/SecFspApiChk.c
> > |   9 +
> >  IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c
> > | 184
> >
> +
> >
> +
> > ++
> >  IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c
> > |  30 ++
> >  IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> > |  33 +
> >  IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> > |  27 +--
> >
> >
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/Fs
> > pWrapperPlatformMultiPhaseLibSample.c   |  49
> > +
> >
> >
> IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapper
> > MultiPhaseProcessLib.c  | 355
> >
> +
> >
> +
> >
> +
> >
> +
> >
> +
> > ++
> >  IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> > |  75
> >
> +
> > ++
> >  IntelFsp2Pkg/FspSecCore/Fsp24SecCoreS.inf
> > |  59 +++
> >  IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> > | 304
> >
> +
> >
> +
> >
> +
> >
> +
> > 
> >  IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryS.nasm
> > | 101
> >
> +
> > 
> >  IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm
> > |   3 +++
> >  IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> > | 303
> >
> +
> >
> +++

Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

2022-08-31 Thread Chiu, Chasel 


Patch1 and patch2 have been merged:
https://github.com/tianocore/edk2/commit/df25a5457f04ec465dce97428cfee96f462676e7
https://github.com/tianocore/edk2/commit/31a94f7fba2a2c1244fc35b6f631e235e267715b

Rest of the patches will be merged later.

Thanks,
Chasel


> -Original Message-
> From: Chiu, Chasel 
> Sent: Tuesday, August 9, 2022 5:48 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star 
> Subject: [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
> 
> Add FSP 2.4 MultiPhase interfaces and implementation.
> 
> Cc: Nate DeSimone 
> Cc: Star Zeng 
> Signed-off-by: Chasel Chiu 
> 
> V2:
> . Add FspMultiPhasePlatformGetNumberOfPhases() and
> FspWrapperPlatformMultiPhaseHandler() to support platform porting.
> 
> . Add FSP reset support in FspWrapperVariableRequestHandler()
> 
> . Fix bug that wrong parameter given when calling
> FspWrapperVariableRequestHandler()
> 
> . Corrected code comments.
> 
> Chasel Chiu (4):
>   IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.
>   IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase interface.
>   IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions.
>   IntelFsp2WrapperPkg: Implement FSP 2.4 MultiPhase wrapper handlers.
> 
>  IntelFsp2Pkg/FspSecCore/SecFsp.c
> |   4 
>  IntelFsp2Pkg/FspSecCore/SecFspApiChk.c
> |   9 +
>  IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c
> | 184
> +
> +
> ++
>  IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c
> |  30 ++
>  IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> |  33 +
>  IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> |  27 +--
> 
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/Fs
> pWrapperPlatformMultiPhaseLibSample.c   |  49
> +
> 
> IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapper
> MultiPhaseProcessLib.c  | 355
> +
> +
> +
> +
> +
> ++
>  IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> |  75
> +
> ++
>  IntelFsp2Pkg/FspSecCore/Fsp24SecCoreS.inf
> |  59 +++
>  IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> | 304
> +
> +
> +
> +
> 
>  IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryS.nasm
> | 101
> +
> 
>  IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm
> |   3 +++
>  IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> | 303
> +
> +
> +
> +
> +++
>  IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryS.nasm
> | 108
> +
> +++
>  IntelFsp2Pkg/FspSecCore/X64/FspApiEntryCommon.nasm
> |   3 +++
>  IntelFsp2Pkg/Include/FspEas/FspApi.h
> |  62 -
> -
>  IntelFsp2Pkg/Include/FspGlobalData.h
> |   5 -
>  IntelFsp2Pkg/Include/Library/FspMultiPhaseLib.h
> |  54 ++
>  IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h
> |  19 +++
>  IntelFsp2Pkg/IntelFsp2Pkg.dec
>|
> 12 ++--
>  IntelFsp2Pkg/IntelFsp2Pkg.dsc
>|
> 4 
>  IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
> |  50 ++
>  IntelFsp2Pkg/Tools/SplitFspBin.py
> |  48 +---
>

Re: [edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

2022-08-30 Thread Nate DeSimone 
Hi Chasel,

I have some minor feedback on PATCH 1/4. Specifically, some improvements are 
needed in the comments. The code itself looks good! For that reason, there is 
no need to send a V3 patch series. Please fix the comments then you are free to 
push the change.

With those changes...

Reviewed-by: Nate DeSimone 

> -Original Message-
> From: Chiu, Chasel 
> Sent: Tuesday, August 9, 2022 5:48 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star 
> Subject: [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916
> 
> Add FSP 2.4 MultiPhase interfaces and implementation.
> 
> Cc: Nate DeSimone 
> Cc: Star Zeng 
> Signed-off-by: Chasel Chiu 
> 
> V2:
> . Add FspMultiPhasePlatformGetNumberOfPhases() and
> FspWrapperPlatformMultiPhaseHandler() to support platform porting.
> 
> . Add FSP reset support in FspWrapperVariableRequestHandler()
> 
> . Fix bug that wrong parameter given when calling
> FspWrapperVariableRequestHandler()
> 
> . Corrected code comments.
> 
> Chasel Chiu (4):
>   IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.
>   IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase interface.
>   IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions.
>   IntelFsp2WrapperPkg: Implement FSP 2.4 MultiPhase wrapper handlers.
> 
>  IntelFsp2Pkg/FspSecCore/SecFsp.c
> |   4 
>  IntelFsp2Pkg/FspSecCore/SecFspApiChk.c
> |   9 +
>  IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c
> | 184
> ++
> ++
> ++
> ++
>  IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c
> |  30 ++
>  IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
> |  33 +
>  IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> |  27 +--
> 
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSampl
> e/FspWrapperPlatformMultiPhaseLibSample.c   |  49
> +
> 
> IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWra
> pperMultiPhaseProcessLib.c  | 355
> ++
> ++
> ++
> ++
> ++
> ++
> +++
>  IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf
> |  75
> ++
> +
>  IntelFsp2Pkg/FspSecCore/Fsp24SecCoreS.inf
> |  59
> ++
> +
>  IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> | 304
> ++
> ++
> ++
> ++
> ++
> ++
>  IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryS.nasm
> | 101
> ++
> +++
>  IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm
> |   3 +++
>  IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> | 303
> ++
> ++
> ++
> ++
> ++
> +
>  IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryS.nasm
> | 108
> ++
> ++
>  IntelFsp2Pkg/FspSecCore/X64/FspApiEntryCommon.nasm
> |   3 +++
>  IntelFsp2Pkg/Include/FspEas/FspApi.h
> |  62
> ++
> ++--
>  IntelFsp2Pkg/Include/FspGlobalData.h
> |   5 -
>  IntelFsp2Pkg/Include/Library/FspMultiPhaseLib.h
> |  54 ++
>  IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h
> |  19 +++
>  IntelFsp2Pkg/IntelFsp2Pkg.dec
>|
> 12 ++--
>  IntelFsp2Pkg/IntelFsp2Pkg.dsc
>|
> 4 
>  IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
> |  50 ++
>

[edk2-devel] [PATCH v2 0/4] IntelFsp2(Wrapper)Pkg: Support FSP 2.4 MultiPhase.

2022-08-09 Thread Chiu, Chasel 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916

Add FSP 2.4 MultiPhase interfaces and implementation.

Cc: Nate DeSimone 
Cc: Star Zeng 
Signed-off-by: Chasel Chiu 

V2:
. Add FspMultiPhasePlatformGetNumberOfPhases() and
FspWrapperPlatformMultiPhaseHandler() to support
platform porting.

. Add FSP reset support in FspWrapperVariableRequestHandler()

. Fix bug that wrong parameter given when calling
FspWrapperVariableRequestHandler()

. Corrected code comments.

Chasel Chiu (4):
  IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.
  IntelFsp2WrapperPkg: Add FSP 2.4 MultiPhase interface.
  IntelFsp2Pkg: Adopt FSP 2.4 MultiPhase functions.
  IntelFsp2WrapperPkg: Implement FSP 2.4 MultiPhase wrapper handlers.

 IntelFsp2Pkg/FspSecCore/SecFsp.c   
 |   4 
 IntelFsp2Pkg/FspSecCore/SecFspApiChk.c 
 |   9 +
 IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c   
 | 184 

 IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/PlatformSecLibNull.c 
 |  30 ++
 IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c  
 |  33 +
 IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c  
 |  27 +--
 
IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibSample/FspWrapperPlatformMultiPhaseLibSample.c
   |  49 +
 
IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c
  | 355 
+++
 IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf  
 |  75 
+++
 IntelFsp2Pkg/FspSecCore/Fsp24SecCoreS.inf  
 |  59 
+++
 IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm   
 | 304 

 IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryS.nasm   
 | 101 
+
 IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryCommon.nasm
 |   3 +++
 IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
 | 303 
+++
 IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryS.nasm
 | 108 

 IntelFsp2Pkg/FspSecCore/X64/FspApiEntryCommon.nasm 
 |   3 +++
 IntelFsp2Pkg/Include/FspEas/FspApi.h   
 |  62 
--
 IntelFsp2Pkg/Include/FspGlobalData.h   
 |   5 -
 IntelFsp2Pkg/Include/Library/FspMultiPhaseLib.h
 |  54 
++
 IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h   
 |