Re: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache

2019-05-30 Thread Steven Shi 
Yes. The "entend" should be "extend", please help to fix it when pushing. 
Thanks!

Steven Shi


> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, May 30, 2019 10:44 AM
> To: devel@edk2.groups.io; Shi, Steven 
> Cc: Gao, Liming ; Rodriguez, Christian
> ; Fan, ZhijuX 
> Subject: RE: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to
> support library cache
> 
> The "entend" should be "extend", right? I can fix it when I push this patch.
> 
> Reviewed-by: Bob Feng 
> 
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Steven Shi
> Sent: Thursday, May 30, 2019 10:31 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C ;
> Rodriguez, Christian ; Fan, ZhijuX
> 
> Subject: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to
> support library cache
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1797
> 
> Current binary cache doesn't support to save and restore the library module.
> If a driver module cache miss happen, all its dependency library modules
> need rebuild which is very time-consuming. This patch is to entend the binary
> cache to support library.
> 
> Cc: Liming Gao 
> Cc: Bob Feng 
> Cc: Christian Rodriguez 
> Signed-off-by: Steven Shi 
> ---
>  BaseTools/Source/Python/AutoGen/AutoGen.py | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py
> b/BaseTools/Source/Python/AutoGen/AutoGen.py
> index a5bef4f7c6..7b35f837f5 100644
> --- a/BaseTools/Source/Python/AutoGen/AutoGen.py
> +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
> @@ -3906,6 +3906,12 @@ class ModuleAutoGen(AutoGen):
>  ModuleFile = path.join(self.OutputDir, self.Name + '.inf')
>  if os.path.exists(ModuleFile):
>  shutil.copy2(ModuleFile, FileDir)
> +else:
> +OutputDir = self.OutputDir.replace('\\', '/').strip('/')
> +DebugDir = self.DebugDir.replace('\\', '/').strip('/')
> +for Item in self.CodaTargetList:
> +File = Item.Target.Path.replace('\\', 
> '/').strip('/').replace(DebugDir,
> '').replace(OutputDir, '').strip('/')
> +self.OutputFile.add(File)
>  if not self.OutputFile:
>  Ma = self.BuildDatabase[self.MetaFile, self.Arch, 
> self.BuildTarget,
> self.ToolChain]
>  self.OutputFile = Ma.Binaries
> --
> 2.17.1.windows.2
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41665): https://edk2.groups.io/g/devel/message/41665
Mute This Topic: https://groups.io/mt/31843505/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache

2019-05-29 Thread Bob Feng 
The "entend" should be "extend", right? I can fix it when I push this patch.

Reviewed-by: Bob Feng 

-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi
Sent: Thursday, May 30, 2019 10:31 AM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C ; 
Rodriguez, Christian ; Fan, ZhijuX 

Subject: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to 
support library cache

https://bugzilla.tianocore.org/show_bug.cgi?id=1797

Current binary cache doesn't support to save and restore the library module. If 
a driver module cache miss happen, all its dependency library modules need 
rebuild which is very time-consuming. This patch is to entend the binary cache 
to support library.

Cc: Liming Gao 
Cc: Bob Feng 
Cc: Christian Rodriguez 
Signed-off-by: Steven Shi 
---
 BaseTools/Source/Python/AutoGen/AutoGen.py | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py 
b/BaseTools/Source/Python/AutoGen/AutoGen.py
index a5bef4f7c6..7b35f837f5 100644
--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
@@ -3906,6 +3906,12 @@ class ModuleAutoGen(AutoGen):
 ModuleFile = path.join(self.OutputDir, self.Name + '.inf')
 if os.path.exists(ModuleFile):
 shutil.copy2(ModuleFile, FileDir)
+else:
+OutputDir = self.OutputDir.replace('\\', '/').strip('/')
+DebugDir = self.DebugDir.replace('\\', '/').strip('/')
+for Item in self.CodaTargetList:
+File = Item.Target.Path.replace('\\', 
'/').strip('/').replace(DebugDir, '').replace(OutputDir, '').strip('/')
+self.OutputFile.add(File)
 if not self.OutputFile:
 Ma = self.BuildDatabase[self.MetaFile, self.Arch, 
self.BuildTarget, self.ToolChain]
 self.OutputFile = Ma.Binaries
--
2.17.1.windows.2





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41656): https://edk2.groups.io/g/devel/message/41656
Mute This Topic: https://groups.io/mt/31843505/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache

2019-05-29 Thread Steven Shi 
https://bugzilla.tianocore.org/show_bug.cgi?id=1797

Current binary cache doesn't support to save and restore
the library module. If a driver module cache miss happen,
all its dependency library modules need rebuild which
is very time-consuming. This patch is to entend the binary
cache to support library.

Cc: Liming Gao 
Cc: Bob Feng 
Cc: Christian Rodriguez 
Signed-off-by: Steven Shi 
---
 BaseTools/Source/Python/AutoGen/AutoGen.py | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py 
b/BaseTools/Source/Python/AutoGen/AutoGen.py
index a5bef4f7c6..7b35f837f5 100644
--- a/BaseTools/Source/Python/AutoGen/AutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
@@ -3906,6 +3906,12 @@ class ModuleAutoGen(AutoGen):
 ModuleFile = path.join(self.OutputDir, self.Name + '.inf')
 if os.path.exists(ModuleFile):
 shutil.copy2(ModuleFile, FileDir)
+else:
+OutputDir = self.OutputDir.replace('\\', '/').strip('/')
+DebugDir = self.DebugDir.replace('\\', '/').strip('/')
+for Item in self.CodaTargetList:
+File = Item.Target.Path.replace('\\', 
'/').strip('/').replace(DebugDir, '').replace(OutputDir, '').strip('/')
+self.OutputFile.add(File)
 if not self.OutputFile:
 Ma = self.BuildDatabase[self.MetaFile, self.Arch, 
self.BuildTarget, self.ToolChain]
 self.OutputFile = Ma.Binaries
-- 
2.17.1.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41655): https://edk2.groups.io/g/devel/message/41655
Mute This Topic: https://groups.io/mt/31843505/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-