Re: [edk2-devel] [PATCH v4 0/8] Add Variable Flash Info HOB

2022-04-21 Thread Michael Kubacki

Hello MdeModulePkg maintainers,

This patch series has received reviews for all patches. I have placed a 
rebased branch with up-to-date review tags in the following PR:


https://github.com/tianocore/edk2/pull/2812

Please let me know if anything further is needed for you to merge the PR.

Thanks,
Michael

On 4/12/2022 12:29 PM, Michael Kubacki wrote:

From: Michael Kubacki 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm,
VariableStandaloneMm, etc. (and their dependent protocol/library
stack), typically acquire UEFI variable store flash information
with PCDs declared in MdeModulePkg.

For example:
[Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize

These PCDs work as-is in the StandaloneMm driver if they are not
dynamic such as Dynamic or DynamicEx because PCD services are not
readily available in the Standalone MM environment. Platforms that
use Standalone MM today, must define these PCDs as FixedAtBuild in
their platform build. However, the PCDs do allow platforms to treat
the PCDs as Dynamic/DynamicEx and being able to support that is
currently a gap for Standalone MM.

This patch series introduces a HOB that can be produced by the
platform to provide the same information. The HOB list is
available to Standalone MM.

The PCD declarations are left as-is in MdeModulePkg for backward
compatibility. This means unless a platform wants to use the HOB,
their code will continue to work with no change (they do not need
to produce the HOB). Only if the HOB is found, is its value used
instead of the PCDs.

Due to the large number of consumers of this information, access
to the base address and size values is abstracted in a new library
class (as requested in the v1 series) called VariableFlashInfoLib.

The API of VariableFlashInfoLib does not bind the underlying data
structure to the information returned to library users to allow
flexibility in the library implementation in the future.

V4 changes:
1. Add a UINT32 "Reserved" field to VARIABLE_FLASH_INFO.
2. Add a descriptive comment to VariableFlashInfo.h to explain
HOB usage.

V3 changes:
1. To better clarify usage, renamed the members
"NvStorageBaseAddress" and "NvStorageLength" in
"VARIABLE_FLASH_INFO" to "NvVariableBaseAddress" and
"NvVariableLength".
2. Added description comments to the fields in "VARIABLE_FLASH_INFO".

V2 changes:
1. Abstracted flash info data access with VariableFlashInfoLib.
2. Updated package builds in the repo that build the variable and
FTW drivers to include VariableFlashInfoLib.
3. Removed a redundant variable assignment in VariableSmm.c.
4. Updated comments in FtwMisc.c and FaultTolerantWritePei.c to
indicate driver assumption is UINTN (not UINT32)
5. Added a version field to the VARIABLE_FLASH_INFO structure.

Cc: Abner Chang 
Cc: Andrew Fish 
Cc: Anthony Perard 
Cc: Ard Biesheuvel 
Cc: Benjamin You 
Cc: Brijesh Singh 
Cc: Erdem Aktas 
Cc: Gerd Hoffmann 
Cc: Guo Dong 
Cc: Hao A Wu 
Cc: James Bottomley 
Cc: Jian J Wang 
Cc: Jiewen Yao 
Cc: Jordan Justen 
Cc: Julien Grall 
Cc: Leif Lindholm 
Cc: Liming Gao 
Cc: Maurice Ma 
Cc: Min Xu 
Cc: Nickle Wang 
Cc: Peter Grehan 
Cc: Ray Ni 
Cc: Rebecca Cran 
Cc: Sami Mujawar 
Cc: Sean Rhodes 
Cc: Sebastien Boeuf 
Cc: Tom Lendacky 
Signed-off-by: Michael Kubacki 

Michael Kubacki (8):
   MdeModulePkg: Add Variable Flash Info HOB
   MdeModulePkg/VariableFlashInfoLib: Add initial library
   MdeModulePkg/Variable: Consume Variable Flash Info
   MdeModulePkg/FaultTolerantWrite: Consume Variable Flash Info
   ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib
   EmulatorPkg: Add VariableFlashInfoLib
   OvmfPkg: Add VariableFlashInfoLib
   UefiPayloadPkg: Add VariableFlashInfoLib

  MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.c  
  | 178 
  MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c
  |  41 +++--
  MdeModulePkg/Universal/FaultTolerantWriteDxe/UpdateWorkingBlock.c 
  |   7 +-
  MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c  
  |  28 +--
  MdeModulePkg/Universal/Variable/Pei/Variable.c
  |  14 +-
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c  
  |  16 +-
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c  
  |  14 +-
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c  
  |  17 +-
  ArmVirtPkg/ArmVirt.dsc.inc
  |   1 +
  EmulatorPkg/EmulatorPkg.dsc   
  |   1 +
  MdeModulePkg/Include/Guid/VariableFlashInfo.h 
  | 111 
  

Re: [edk2-devel] [PATCH v4 0/8] Add Variable Flash Info HOB

2022-04-20 Thread Ard Biesheuvel
On Tue, 12 Apr 2022 at 18:30,  wrote:
>
> From: Michael Kubacki 
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm,
> VariableStandaloneMm, etc. (and their dependent protocol/library
> stack), typically acquire UEFI variable store flash information
> with PCDs declared in MdeModulePkg.
>
> For example:
> [Pcd]
>   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase
>   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64
>   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize
>
> These PCDs work as-is in the StandaloneMm driver if they are not
> dynamic such as Dynamic or DynamicEx because PCD services are not
> readily available in the Standalone MM environment. Platforms that
> use Standalone MM today, must define these PCDs as FixedAtBuild in
> their platform build. However, the PCDs do allow platforms to treat
> the PCDs as Dynamic/DynamicEx and being able to support that is
> currently a gap for Standalone MM.
>
> This patch series introduces a HOB that can be produced by the
> platform to provide the same information. The HOB list is
> available to Standalone MM.
>
> The PCD declarations are left as-is in MdeModulePkg for backward
> compatibility. This means unless a platform wants to use the HOB,
> their code will continue to work with no change (they do not need
> to produce the HOB). Only if the HOB is found, is its value used
> instead of the PCDs.
>
> Due to the large number of consumers of this information, access
> to the base address and size values is abstracted in a new library
> class (as requested in the v1 series) called VariableFlashInfoLib.
>
> The API of VariableFlashInfoLib does not bind the underlying data
> structure to the information returned to library users to allow
> flexibility in the library implementation in the future.
>
> V4 changes:
> 1. Add a UINT32 "Reserved" field to VARIABLE_FLASH_INFO.
> 2. Add a descriptive comment to VariableFlashInfo.h to explain
>HOB usage.
>
> V3 changes:
> 1. To better clarify usage, renamed the members
>"NvStorageBaseAddress" and "NvStorageLength" in
>"VARIABLE_FLASH_INFO" to "NvVariableBaseAddress" and
>"NvVariableLength".
> 2. Added description comments to the fields in "VARIABLE_FLASH_INFO".
>
> V2 changes:
> 1. Abstracted flash info data access with VariableFlashInfoLib.
> 2. Updated package builds in the repo that build the variable and
>FTW drivers to include VariableFlashInfoLib.
> 3. Removed a redundant variable assignment in VariableSmm.c.
> 4. Updated comments in FtwMisc.c and FaultTolerantWritePei.c to
>indicate driver assumption is UINTN (not UINT32)
> 5. Added a version field to the VARIABLE_FLASH_INFO structure.
>
> Cc: Abner Chang 
> Cc: Andrew Fish 
> Cc: Anthony Perard 
> Cc: Ard Biesheuvel 
> Cc: Benjamin You 
> Cc: Brijesh Singh 
> Cc: Erdem Aktas 
> Cc: Gerd Hoffmann 
> Cc: Guo Dong 
> Cc: Hao A Wu 
> Cc: James Bottomley 
> Cc: Jian J Wang 
> Cc: Jiewen Yao 
> Cc: Jordan Justen 
> Cc: Julien Grall 
> Cc: Leif Lindholm 
> Cc: Liming Gao 
> Cc: Maurice Ma 
> Cc: Min Xu 
> Cc: Nickle Wang 
> Cc: Peter Grehan 
> Cc: Ray Ni 
> Cc: Rebecca Cran 
> Cc: Sami Mujawar 
> Cc: Sean Rhodes 
> Cc: Sebastien Boeuf 
> Cc: Tom Lendacky 
> Signed-off-by: Michael Kubacki 
>
> Michael Kubacki (8):
>   MdeModulePkg: Add Variable Flash Info HOB
>   MdeModulePkg/VariableFlashInfoLib: Add initial library
>   MdeModulePkg/Variable: Consume Variable Flash Info
>   MdeModulePkg/FaultTolerantWrite: Consume Variable Flash Info
>   ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib
>   EmulatorPkg: Add VariableFlashInfoLib
>   OvmfPkg: Add VariableFlashInfoLib
>   UefiPayloadPkg: Add VariableFlashInfoLib
>

For the series,

Acked-by: Ard Biesheuvel 

>  MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.c 
>| 178 
>  MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c   
>|  41 +++--
>  MdeModulePkg/Universal/FaultTolerantWriteDxe/UpdateWorkingBlock.c
>|   7 +-
>  MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c 
>|  28 +--
>  MdeModulePkg/Universal/Variable/Pei/Variable.c   
>|  14 +-
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c 
>|  16 +-
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c 
>|  14 +-
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c 
>|  17 +-
>  ArmVirtPkg/ArmVirt.dsc.inc   
>|   1 +
>  EmulatorPkg/EmulatorPkg.dsc  
>|   1 +
>  MdeModulePkg/Include/Guid/VariableFlashInfo.h
>| 111 
>  MdeModulePkg/Include/Library/VariableFlashInfoLib.h  
>|  68 
>  

Re: [edk2-devel] [PATCH v4 0/8] Add Variable Flash Info HOB

2022-04-19 Thread Michael Kubacki
This patch series is still missing reviews from some package 
maintainers. Please review it when possible.


Thanks,
Michael

On 4/13/2022 10:21 PM, Michael Kubacki wrote:
A friendly reminder to those on the CC line to help review your 
respective packages in this patch series.


Some of the patches are just minor changes to DSC files and others do 
not have a significant number of changes.


Thanks,
Michael

On 4/12/2022 12:29 PM, Michael Kubacki wrote:

From: Michael Kubacki 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm,
VariableStandaloneMm, etc. (and their dependent protocol/library
stack), typically acquire UEFI variable store flash information
with PCDs declared in MdeModulePkg.

For example:
[Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize

These PCDs work as-is in the StandaloneMm driver if they are not
dynamic such as Dynamic or DynamicEx because PCD services are not
readily available in the Standalone MM environment. Platforms that
use Standalone MM today, must define these PCDs as FixedAtBuild in
their platform build. However, the PCDs do allow platforms to treat
the PCDs as Dynamic/DynamicEx and being able to support that is
currently a gap for Standalone MM.

This patch series introduces a HOB that can be produced by the
platform to provide the same information. The HOB list is
available to Standalone MM.

The PCD declarations are left as-is in MdeModulePkg for backward
compatibility. This means unless a platform wants to use the HOB,
their code will continue to work with no change (they do not need
to produce the HOB). Only if the HOB is found, is its value used
instead of the PCDs.

Due to the large number of consumers of this information, access
to the base address and size values is abstracted in a new library
class (as requested in the v1 series) called VariableFlashInfoLib.

The API of VariableFlashInfoLib does not bind the underlying data
structure to the information returned to library users to allow
flexibility in the library implementation in the future.

V4 changes:
1. Add a UINT32 "Reserved" field to VARIABLE_FLASH_INFO.
2. Add a descriptive comment to VariableFlashInfo.h to explain
    HOB usage.

V3 changes:
1. To better clarify usage, renamed the members
    "NvStorageBaseAddress" and "NvStorageLength" in
    "VARIABLE_FLASH_INFO" to "NvVariableBaseAddress" and
    "NvVariableLength".
2. Added description comments to the fields in "VARIABLE_FLASH_INFO".

V2 changes:
1. Abstracted flash info data access with VariableFlashInfoLib.
2. Updated package builds in the repo that build the variable and
    FTW drivers to include VariableFlashInfoLib.
3. Removed a redundant variable assignment in VariableSmm.c.
4. Updated comments in FtwMisc.c and FaultTolerantWritePei.c to
    indicate driver assumption is UINTN (not UINT32)
5. Added a version field to the VARIABLE_FLASH_INFO structure.

Cc: Abner Chang 
Cc: Andrew Fish 
Cc: Anthony Perard 
Cc: Ard Biesheuvel 
Cc: Benjamin You 
Cc: Brijesh Singh 
Cc: Erdem Aktas 
Cc: Gerd Hoffmann 
Cc: Guo Dong 
Cc: Hao A Wu 
Cc: James Bottomley 
Cc: Jian J Wang 
Cc: Jiewen Yao 
Cc: Jordan Justen 
Cc: Julien Grall 
Cc: Leif Lindholm 
Cc: Liming Gao 
Cc: Maurice Ma 
Cc: Min Xu 
Cc: Nickle Wang 
Cc: Peter Grehan 
Cc: Ray Ni 
Cc: Rebecca Cran 
Cc: Sami Mujawar 
Cc: Sean Rhodes 
Cc: Sebastien Boeuf 
Cc: Tom Lendacky 
Signed-off-by: Michael Kubacki 

Michael Kubacki (8):
   MdeModulePkg: Add Variable Flash Info HOB
   MdeModulePkg/VariableFlashInfoLib: Add initial library
   MdeModulePkg/Variable: Consume Variable Flash Info
   MdeModulePkg/FaultTolerantWrite: Consume Variable Flash Info
   ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib
   EmulatorPkg: Add VariableFlashInfoLib
   OvmfPkg: Add VariableFlashInfoLib
   UefiPayloadPkg: Add VariableFlashInfoLib

  
MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.c
| 178 
  
MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c  
|  41 +++--
  
MdeModulePkg/Universal/FaultTolerantWriteDxe/UpdateWorkingBlock.c   
|   7 +-
  
MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c
|  28 +--
  
MdeModulePkg/Universal/Variable/Pei/Variable.c  
|  14 +-
  
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c
|  16 +-
  
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c
|  14 +-
  
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c
|  17 +-
  
ArmVirtPkg/ArmVirt.dsc.inc  
|   1 +
  
EmulatorPkg/EmulatorPkg.dsc 
|   1 +
  

Re: [edk2-devel] [PATCH v4 0/8] Add Variable Flash Info HOB

2022-04-13 Thread Michael Kubacki
A friendly reminder to those on the CC line to help review your 
respective packages in this patch series.


Some of the patches are just minor changes to DSC files and others do 
not have a significant number of changes.


Thanks,
Michael

On 4/12/2022 12:29 PM, Michael Kubacki wrote:

From: Michael Kubacki 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm,
VariableStandaloneMm, etc. (and their dependent protocol/library
stack), typically acquire UEFI variable store flash information
with PCDs declared in MdeModulePkg.

For example:
[Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize

These PCDs work as-is in the StandaloneMm driver if they are not
dynamic such as Dynamic or DynamicEx because PCD services are not
readily available in the Standalone MM environment. Platforms that
use Standalone MM today, must define these PCDs as FixedAtBuild in
their platform build. However, the PCDs do allow platforms to treat
the PCDs as Dynamic/DynamicEx and being able to support that is
currently a gap for Standalone MM.

This patch series introduces a HOB that can be produced by the
platform to provide the same information. The HOB list is
available to Standalone MM.

The PCD declarations are left as-is in MdeModulePkg for backward
compatibility. This means unless a platform wants to use the HOB,
their code will continue to work with no change (they do not need
to produce the HOB). Only if the HOB is found, is its value used
instead of the PCDs.

Due to the large number of consumers of this information, access
to the base address and size values is abstracted in a new library
class (as requested in the v1 series) called VariableFlashInfoLib.

The API of VariableFlashInfoLib does not bind the underlying data
structure to the information returned to library users to allow
flexibility in the library implementation in the future.

V4 changes:
1. Add a UINT32 "Reserved" field to VARIABLE_FLASH_INFO.
2. Add a descriptive comment to VariableFlashInfo.h to explain
HOB usage.

V3 changes:
1. To better clarify usage, renamed the members
"NvStorageBaseAddress" and "NvStorageLength" in
"VARIABLE_FLASH_INFO" to "NvVariableBaseAddress" and
"NvVariableLength".
2. Added description comments to the fields in "VARIABLE_FLASH_INFO".

V2 changes:
1. Abstracted flash info data access with VariableFlashInfoLib.
2. Updated package builds in the repo that build the variable and
FTW drivers to include VariableFlashInfoLib.
3. Removed a redundant variable assignment in VariableSmm.c.
4. Updated comments in FtwMisc.c and FaultTolerantWritePei.c to
indicate driver assumption is UINTN (not UINT32)
5. Added a version field to the VARIABLE_FLASH_INFO structure.

Cc: Abner Chang 
Cc: Andrew Fish 
Cc: Anthony Perard 
Cc: Ard Biesheuvel 
Cc: Benjamin You 
Cc: Brijesh Singh 
Cc: Erdem Aktas 
Cc: Gerd Hoffmann 
Cc: Guo Dong 
Cc: Hao A Wu 
Cc: James Bottomley 
Cc: Jian J Wang 
Cc: Jiewen Yao 
Cc: Jordan Justen 
Cc: Julien Grall 
Cc: Leif Lindholm 
Cc: Liming Gao 
Cc: Maurice Ma 
Cc: Min Xu 
Cc: Nickle Wang 
Cc: Peter Grehan 
Cc: Ray Ni 
Cc: Rebecca Cran 
Cc: Sami Mujawar 
Cc: Sean Rhodes 
Cc: Sebastien Boeuf 
Cc: Tom Lendacky 
Signed-off-by: Michael Kubacki 

Michael Kubacki (8):
   MdeModulePkg: Add Variable Flash Info HOB
   MdeModulePkg/VariableFlashInfoLib: Add initial library
   MdeModulePkg/Variable: Consume Variable Flash Info
   MdeModulePkg/FaultTolerantWrite: Consume Variable Flash Info
   ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib
   EmulatorPkg: Add VariableFlashInfoLib
   OvmfPkg: Add VariableFlashInfoLib
   UefiPayloadPkg: Add VariableFlashInfoLib

  MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.c  
  | 178 
  MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c
  |  41 +++--
  MdeModulePkg/Universal/FaultTolerantWriteDxe/UpdateWorkingBlock.c 
  |   7 +-
  MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c  
  |  28 +--
  MdeModulePkg/Universal/Variable/Pei/Variable.c
  |  14 +-
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c  
  |  16 +-
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c  
  |  14 +-
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c  
  |  17 +-
  ArmVirtPkg/ArmVirt.dsc.inc
  |   1 +
  EmulatorPkg/EmulatorPkg.dsc   
  |   1 +
  MdeModulePkg/Include/Guid/VariableFlashInfo.h 
  | 111 
  MdeModulePkg/Include/Library/VariableFlashInfoLib.h   
  |  68 
  

[edk2-devel] [PATCH v4 0/8] Add Variable Flash Info HOB

2022-04-12 Thread Michael Kubacki
From: Michael Kubacki 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm,
VariableStandaloneMm, etc. (and their dependent protocol/library
stack), typically acquire UEFI variable store flash information
with PCDs declared in MdeModulePkg.

For example:
[Pcd]
  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase
  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64
  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize

These PCDs work as-is in the StandaloneMm driver if they are not
dynamic such as Dynamic or DynamicEx because PCD services are not
readily available in the Standalone MM environment. Platforms that
use Standalone MM today, must define these PCDs as FixedAtBuild in
their platform build. However, the PCDs do allow platforms to treat
the PCDs as Dynamic/DynamicEx and being able to support that is
currently a gap for Standalone MM.

This patch series introduces a HOB that can be produced by the
platform to provide the same information. The HOB list is
available to Standalone MM.

The PCD declarations are left as-is in MdeModulePkg for backward
compatibility. This means unless a platform wants to use the HOB,
their code will continue to work with no change (they do not need
to produce the HOB). Only if the HOB is found, is its value used
instead of the PCDs.

Due to the large number of consumers of this information, access
to the base address and size values is abstracted in a new library
class (as requested in the v1 series) called VariableFlashInfoLib.

The API of VariableFlashInfoLib does not bind the underlying data
structure to the information returned to library users to allow
flexibility in the library implementation in the future.

V4 changes:
1. Add a UINT32 "Reserved" field to VARIABLE_FLASH_INFO.
2. Add a descriptive comment to VariableFlashInfo.h to explain
   HOB usage.

V3 changes:
1. To better clarify usage, renamed the members
   "NvStorageBaseAddress" and "NvStorageLength" in
   "VARIABLE_FLASH_INFO" to "NvVariableBaseAddress" and
   "NvVariableLength".
2. Added description comments to the fields in "VARIABLE_FLASH_INFO".

V2 changes:
1. Abstracted flash info data access with VariableFlashInfoLib.
2. Updated package builds in the repo that build the variable and
   FTW drivers to include VariableFlashInfoLib.
3. Removed a redundant variable assignment in VariableSmm.c.
4. Updated comments in FtwMisc.c and FaultTolerantWritePei.c to
   indicate driver assumption is UINTN (not UINT32)
5. Added a version field to the VARIABLE_FLASH_INFO structure.

Cc: Abner Chang 
Cc: Andrew Fish 
Cc: Anthony Perard 
Cc: Ard Biesheuvel 
Cc: Benjamin You 
Cc: Brijesh Singh 
Cc: Erdem Aktas 
Cc: Gerd Hoffmann 
Cc: Guo Dong 
Cc: Hao A Wu 
Cc: James Bottomley 
Cc: Jian J Wang 
Cc: Jiewen Yao 
Cc: Jordan Justen 
Cc: Julien Grall 
Cc: Leif Lindholm 
Cc: Liming Gao 
Cc: Maurice Ma 
Cc: Min Xu 
Cc: Nickle Wang 
Cc: Peter Grehan 
Cc: Ray Ni 
Cc: Rebecca Cran 
Cc: Sami Mujawar 
Cc: Sean Rhodes 
Cc: Sebastien Boeuf 
Cc: Tom Lendacky 
Signed-off-by: Michael Kubacki 

Michael Kubacki (8):
  MdeModulePkg: Add Variable Flash Info HOB
  MdeModulePkg/VariableFlashInfoLib: Add initial library
  MdeModulePkg/Variable: Consume Variable Flash Info
  MdeModulePkg/FaultTolerantWrite: Consume Variable Flash Info
  ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib
  EmulatorPkg: Add VariableFlashInfoLib
  OvmfPkg: Add VariableFlashInfoLib
  UefiPayloadPkg: Add VariableFlashInfoLib

 MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.c   
 | 178 
 MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c 
 |  41 +++--
 MdeModulePkg/Universal/FaultTolerantWriteDxe/UpdateWorkingBlock.c  
 |   7 +-
 MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c   
 |  28 +--
 MdeModulePkg/Universal/Variable/Pei/Variable.c 
 |  14 +-
 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c   
 |  16 +-
 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c   
 |  14 +-
 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c   
 |  17 +-
 ArmVirtPkg/ArmVirt.dsc.inc 
 |   1 +
 EmulatorPkg/EmulatorPkg.dsc
 |   1 +
 MdeModulePkg/Include/Guid/VariableFlashInfo.h  
 | 111 
 MdeModulePkg/Include/Library/VariableFlashInfoLib.h
 |  68 
 MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf 
 |  48 ++
 MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.uni 
 |  12 ++
 MdeModulePkg/MdeModulePkg.dec  
 |   8 +
 MdeModulePkg/MdeModulePkg.dsc