Re: [edk2-devel] [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

2019-08-11 Thread Gary Lin 
On Fri, Aug 09, 2019 at 12:34:03PM -0700,  Kinney, Michael D  wrote:
> The following commit removed the call to SetupInfo() from
> SystemConfigExtractConfig().  This caused the BIOS, Processor,
> Platform, and Memory information strings from being filled
> in with their proper values.
> 
> https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5
> 
> The call to SetupInfo() is added back.
> 
The system info is back after applying this patch.

Tested-by: Gary Lin 

> Cc: Zailiang Sun 
> Cc: Gary Lin 
> Signed-off-by: Michael D Kinney 
> ---
>  .../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c  | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git 
> a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c 
> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
> index 7a4987f656..f3850b2aff 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
> @@ -150,6 +150,7 @@ SystemConfigExtractConfig (
>OUT EFI_STRING *Results
>)
>  {
> +  SetupInfo();
>return EFI_UNSUPPORTED;
>  }
>
> -- 
> 2.21.0.windows.1
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45346): https://edk2.groups.io/g/devel/message/45346
Mute This Topic: https://groups.io/mt/32814191/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

2019-08-11 Thread Sun, Zailiang 
Reviewed-by: Zailiang Sun 

-Original Message-
From: Kinney, Michael D 
Sent: Saturday, August 10, 2019 3:34 AM
To: devel@edk2.groups.io
Cc: Sun, Zailiang ; Gary Lin 
Subject: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

The following commit removed the call to SetupInfo() from
SystemConfigExtractConfig().  This caused the BIOS, Processor,
Platform, and Memory information strings from being filled
in with their proper values.

https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5

The call to SetupInfo() is added back.

Cc: Zailiang Sun 
Cc: Gary Lin 
Signed-off-by: Michael D Kinney 
---
 .../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c  | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c 
b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
index 7a4987f656..f3850b2aff 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
@@ -150,6 +150,7 @@ SystemConfigExtractConfig (
   OUT EFI_STRING *Results
   )
 {
+  SetupInfo();
   return EFI_UNSUPPORTED;
 }
 
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45319): https://edk2.groups.io/g/devel/message/45319
Mute This Topic: https://groups.io/mt/32814191/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

2019-08-09 Thread Michael D Kinney 
The following commit removed the call to SetupInfo() from
SystemConfigExtractConfig().  This caused the BIOS, Processor,
Platform, and Memory information strings from being filled
in with their proper values.

https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5

The call to SetupInfo() is added back.

Cc: Zailiang Sun 
Cc: Gary Lin 
Signed-off-by: Michael D Kinney 
---
 .../Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c  | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c 
b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
index 7a4987f656..f3850b2aff 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/PlatformSetupDxe.c
@@ -150,6 +150,7 @@ SystemConfigExtractConfig (
   OUT EFI_STRING *Results
   )
 {
+  SetupInfo();
   return EFI_UNSUPPORTED;
 }
 
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45291): https://edk2.groups.io/g/devel/message/45291
Mute This Topic: https://groups.io/mt/32814191/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-