Re: [edk2-devel] [Patch 0/7] Revert new added BfmLib/FCE/FMMT

2019-07-11 Thread Leif Lindholm
On Thu, Jul 11, 2019 at 09:44:33AM +0800, Liming Gao wrote:
> Rewrite those tools for review again.
> Now, move them into edk2-staging/FceFmmt branch.
> 
> Cc: Leif Lindholm 
> Cc: Feng Bob C 

Thanks for this. For the series:
Reviewed-by: Leif Lindholm 

> Liming Gao (7):
>   Revert "BaseTools/FCE: Change FCE script type in PosixLike"
>   Revert "BaseTools/BfmLib: Change BfmLib script type in PosixLike"
>   Revert "BaseTools/FMMT: Change FMMT script type in PosixLike"
>   Revert "BaseTools: fix FCE build when edksetup not executed"
>   Revert "BaseTools/FMMT: Add a tool FMMT"
>   Revert "BaseTools/FCE: Add a tool FCE"
>   Revert "BaseTools/BfmLib: Add a tool BfmLib"
> 
>  BaseTools/Source/C/BfmLib/BfmLib.c | 4355 -
>  BaseTools/Source/C/BfmLib/BinFileManager.c | 1024 
>  BaseTools/Source/C/FCE/BinaryCreate.c  |  216 -
>  BaseTools/Source/C/FCE/BinaryParse.c   | 1326 
>  BaseTools/Source/C/FCE/Common.c| 2183 ---
>  BaseTools/Source/C/FCE/Expression.c| 2367 ---
>  BaseTools/Source/C/FCE/Fce.c   | 6449 
> 
>  BaseTools/Source/C/FCE/IfrParse.c  | 4836 ---
>  BaseTools/Source/C/FCE/MonotonicBasedVariable.c|  874 ---
>  BaseTools/Source/C/FCE/TimeBasedVariable.c |  878 ---
>  BaseTools/Source/C/FCE/Variable.c  | 1091 
>  BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 2559 
>  BaseTools/Source/C/FMMT/FmmtLib.c  | 5051 ---
>  BaseTools/Source/C/FMMT/Rebase.c   |  846 ---
>  BaseTools/BinWrappers/PosixLike/BfmLib |   29 -
>  BaseTools/BinWrappers/PosixLike/FCE|   29 -
>  BaseTools/BinWrappers/PosixLike/FMMT   |   29 -
>  BaseTools/Source/C/BfmLib/BinFileManager.h |  439 --
>  BaseTools/Source/C/BfmLib/GNUmakefile  |   15 -
>  BaseTools/Source/C/BfmLib/Makefile |   17 -
>  BaseTools/Source/C/FCE/BinaryCreate.h  |  157 -
>  BaseTools/Source/C/FCE/BinaryParse.h   |  187 -
>  BaseTools/Source/C/FCE/Common.h|  999 ---
>  BaseTools/Source/C/FCE/Fce.h   |  447 --
>  BaseTools/Source/C/FCE/GNUmakefile |   55 -
>  BaseTools/Source/C/FCE/IfrParse.h  |  789 ---
>  BaseTools/Source/C/FCE/Makefile|   19 -
>  BaseTools/Source/C/FCE/MonotonicBasedVariable.h|  162 -
>  BaseTools/Source/C/FCE/TimeBasedVariable.h |  166 -
>  BaseTools/Source/C/FCE/Variable.h  |  154 -
>  BaseTools/Source/C/FCE/VariableCommon.h|   55 -
>  BaseTools/Source/C/FMMT/FirmwareModuleManagement.h |  479 --
>  BaseTools/Source/C/FMMT/FmmtConf.ini   |6 -
>  BaseTools/Source/C/FMMT/GNUmakefile|   16 -
>  BaseTools/Source/C/FMMT/Makefile   |   17 -
>  BaseTools/Source/C/FMMT/Rebase.h   |   31 -
>  BaseTools/Source/C/GNUmakefile |5 +-
>  BaseTools/Source/C/Makefile|5 +-
>  38 files changed, 2 insertions(+), 38360 deletions(-)
>  delete mode 100644 BaseTools/Source/C/BfmLib/BfmLib.c
>  delete mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.c
>  delete mode 100644 BaseTools/Source/C/FCE/BinaryCreate.c
>  delete mode 100644 BaseTools/Source/C/FCE/BinaryParse.c
>  delete mode 100644 BaseTools/Source/C/FCE/Common.c
>  delete mode 100644 BaseTools/Source/C/FCE/Expression.c
>  delete mode 100644 BaseTools/Source/C/FCE/Fce.c
>  delete mode 100644 BaseTools/Source/C/FCE/IfrParse.c
>  delete mode 100644 BaseTools/Source/C/FCE/MonotonicBasedVariable.c
>  delete mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.c
>  delete mode 100644 BaseTools/Source/C/FCE/Variable.c
>  delete mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.c
>  delete mode 100644 BaseTools/Source/C/FMMT/FmmtLib.c
>  delete mode 100644 BaseTools/Source/C/FMMT/Rebase.c
>  delete mode 100755 BaseTools/BinWrappers/PosixLike/BfmLib
>  delete mode 100755 BaseTools/BinWrappers/PosixLike/FCE
>  delete mode 100755 BaseTools/BinWrappers/PosixLike/FMMT
>  delete mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.h
>  delete mode 100644 BaseTools/Source/C/BfmLib/GNUmakefile
>  delete mode 100644 BaseTools/Source/C/BfmLib/Makefile
>  delete mode 100644 BaseTools/Source/C/FCE/BinaryCreate.h
>  delete mode 100644 BaseTools/Source/C/FCE/BinaryParse.h
>  delete mode 100644 BaseTools/Source/C/FCE/Common.h
>  delete mode 100644 BaseTools/Source/C/FCE/Fce.h
>  delete mode 100644 BaseTools/Source/C/FCE/GNUmakefile
>  delete mode 100644 BaseTools/Source/C/FCE/IfrParse.h
>  delete mode 100644 BaseTools/Source/C/FCE/Makefile
>  delete mode 100644 BaseTools/Source/C/FCE/MonotonicBasedVariable.h
>  delete mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.h
>  delete mode 100644 

Re: [edk2-devel] [Patch 0/7] Revert new added BfmLib/FCE/FMMT

2019-07-10 Thread Bob Feng
Reviewed-by: Feng Bob C 

-Original Message-
From: Gao, Liming 
Sent: Thursday, July 11, 2019 9:45 AM
To: devel@edk2.groups.io
Cc: Leif Lindholm ; Feng, Bob C 
Subject: [Patch 0/7] Revert new added BfmLib/FCE/FMMT

Rewrite those tools for review again.
Now, move them into edk2-staging/FceFmmt branch.

Cc: Leif Lindholm 
Cc: Feng Bob C 

Liming Gao (7):
  Revert "BaseTools/FCE: Change FCE script type in PosixLike"
  Revert "BaseTools/BfmLib: Change BfmLib script type in PosixLike"
  Revert "BaseTools/FMMT: Change FMMT script type in PosixLike"
  Revert "BaseTools: fix FCE build when edksetup not executed"
  Revert "BaseTools/FMMT: Add a tool FMMT"
  Revert "BaseTools/FCE: Add a tool FCE"
  Revert "BaseTools/BfmLib: Add a tool BfmLib"

 BaseTools/Source/C/BfmLib/BfmLib.c | 4355 -
 BaseTools/Source/C/BfmLib/BinFileManager.c | 1024 
 BaseTools/Source/C/FCE/BinaryCreate.c  |  216 -
 BaseTools/Source/C/FCE/BinaryParse.c   | 1326 
 BaseTools/Source/C/FCE/Common.c| 2183 ---
 BaseTools/Source/C/FCE/Expression.c| 2367 ---
 BaseTools/Source/C/FCE/Fce.c   | 6449 
 BaseTools/Source/C/FCE/IfrParse.c  | 4836 ---
 BaseTools/Source/C/FCE/MonotonicBasedVariable.c|  874 ---
 BaseTools/Source/C/FCE/TimeBasedVariable.c |  878 ---
 BaseTools/Source/C/FCE/Variable.c  | 1091 
 BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 2559 
 BaseTools/Source/C/FMMT/FmmtLib.c  | 5051 ---
 BaseTools/Source/C/FMMT/Rebase.c   |  846 ---
 BaseTools/BinWrappers/PosixLike/BfmLib |   29 -
 BaseTools/BinWrappers/PosixLike/FCE|   29 -
 BaseTools/BinWrappers/PosixLike/FMMT   |   29 -
 BaseTools/Source/C/BfmLib/BinFileManager.h |  439 --
 BaseTools/Source/C/BfmLib/GNUmakefile  |   15 -
 BaseTools/Source/C/BfmLib/Makefile |   17 -
 BaseTools/Source/C/FCE/BinaryCreate.h  |  157 -
 BaseTools/Source/C/FCE/BinaryParse.h   |  187 -
 BaseTools/Source/C/FCE/Common.h|  999 ---
 BaseTools/Source/C/FCE/Fce.h   |  447 --
 BaseTools/Source/C/FCE/GNUmakefile |   55 -
 BaseTools/Source/C/FCE/IfrParse.h  |  789 ---
 BaseTools/Source/C/FCE/Makefile|   19 -
 BaseTools/Source/C/FCE/MonotonicBasedVariable.h|  162 -
 BaseTools/Source/C/FCE/TimeBasedVariable.h |  166 -
 BaseTools/Source/C/FCE/Variable.h  |  154 -
 BaseTools/Source/C/FCE/VariableCommon.h|   55 -
 BaseTools/Source/C/FMMT/FirmwareModuleManagement.h |  479 --
 BaseTools/Source/C/FMMT/FmmtConf.ini   |6 -
 BaseTools/Source/C/FMMT/GNUmakefile|   16 -
 BaseTools/Source/C/FMMT/Makefile   |   17 -
 BaseTools/Source/C/FMMT/Rebase.h   |   31 -
 BaseTools/Source/C/GNUmakefile |5 +-
 BaseTools/Source/C/Makefile|5 +-
 38 files changed, 2 insertions(+), 38360 deletions(-)  delete mode 100644 
BaseTools/Source/C/BfmLib/BfmLib.c
 delete mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.c
 delete mode 100644 BaseTools/Source/C/FCE/BinaryCreate.c
 delete mode 100644 BaseTools/Source/C/FCE/BinaryParse.c
 delete mode 100644 BaseTools/Source/C/FCE/Common.c  delete mode 100644 
BaseTools/Source/C/FCE/Expression.c
 delete mode 100644 BaseTools/Source/C/FCE/Fce.c  delete mode 100644 
BaseTools/Source/C/FCE/IfrParse.c  delete mode 100644 
BaseTools/Source/C/FCE/MonotonicBasedVariable.c
 delete mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.c
 delete mode 100644 BaseTools/Source/C/FCE/Variable.c  delete mode 100644 
BaseTools/Source/C/FMMT/FirmwareModuleManagement.c
 delete mode 100644 BaseTools/Source/C/FMMT/FmmtLib.c  delete mode 100644 
BaseTools/Source/C/FMMT/Rebase.c  delete mode 100755 
BaseTools/BinWrappers/PosixLike/BfmLib
 delete mode 100755 BaseTools/BinWrappers/PosixLike/FCE
 delete mode 100755 BaseTools/BinWrappers/PosixLike/FMMT
 delete mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.h
 delete mode 100644 BaseTools/Source/C/BfmLib/GNUmakefile
 delete mode 100644 BaseTools/Source/C/BfmLib/Makefile
 delete mode 100644 BaseTools/Source/C/FCE/BinaryCreate.h
 delete mode 100644 BaseTools/Source/C/FCE/BinaryParse.h
 delete mode 100644 BaseTools/Source/C/FCE/Common.h  delete mode 100644 
BaseTools/Source/C/FCE/Fce.h  delete mode 100644 
BaseTools/Source/C/FCE/GNUmakefile
 delete mode 100644 BaseTools/Source/C/FCE/IfrParse.h  delete mode 100644 
BaseTools/Source/C/FCE/Makefile  delete mode 100644 
BaseTools/Source/C/FCE/MonotonicBasedVariable.h
 delete mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.h
 delete mode 100644 BaseTools/Source/C/FCE/Variable.h  delete mode 100644 

[edk2-devel] [Patch 0/7] Revert new added BfmLib/FCE/FMMT

2019-07-10 Thread Liming Gao
Rewrite those tools for review again.
Now, move them into edk2-staging/FceFmmt branch.

Cc: Leif Lindholm 
Cc: Feng Bob C 

Liming Gao (7):
  Revert "BaseTools/FCE: Change FCE script type in PosixLike"
  Revert "BaseTools/BfmLib: Change BfmLib script type in PosixLike"
  Revert "BaseTools/FMMT: Change FMMT script type in PosixLike"
  Revert "BaseTools: fix FCE build when edksetup not executed"
  Revert "BaseTools/FMMT: Add a tool FMMT"
  Revert "BaseTools/FCE: Add a tool FCE"
  Revert "BaseTools/BfmLib: Add a tool BfmLib"

 BaseTools/Source/C/BfmLib/BfmLib.c | 4355 -
 BaseTools/Source/C/BfmLib/BinFileManager.c | 1024 
 BaseTools/Source/C/FCE/BinaryCreate.c  |  216 -
 BaseTools/Source/C/FCE/BinaryParse.c   | 1326 
 BaseTools/Source/C/FCE/Common.c| 2183 ---
 BaseTools/Source/C/FCE/Expression.c| 2367 ---
 BaseTools/Source/C/FCE/Fce.c   | 6449 
 BaseTools/Source/C/FCE/IfrParse.c  | 4836 ---
 BaseTools/Source/C/FCE/MonotonicBasedVariable.c|  874 ---
 BaseTools/Source/C/FCE/TimeBasedVariable.c |  878 ---
 BaseTools/Source/C/FCE/Variable.c  | 1091 
 BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 2559 
 BaseTools/Source/C/FMMT/FmmtLib.c  | 5051 ---
 BaseTools/Source/C/FMMT/Rebase.c   |  846 ---
 BaseTools/BinWrappers/PosixLike/BfmLib |   29 -
 BaseTools/BinWrappers/PosixLike/FCE|   29 -
 BaseTools/BinWrappers/PosixLike/FMMT   |   29 -
 BaseTools/Source/C/BfmLib/BinFileManager.h |  439 --
 BaseTools/Source/C/BfmLib/GNUmakefile  |   15 -
 BaseTools/Source/C/BfmLib/Makefile |   17 -
 BaseTools/Source/C/FCE/BinaryCreate.h  |  157 -
 BaseTools/Source/C/FCE/BinaryParse.h   |  187 -
 BaseTools/Source/C/FCE/Common.h|  999 ---
 BaseTools/Source/C/FCE/Fce.h   |  447 --
 BaseTools/Source/C/FCE/GNUmakefile |   55 -
 BaseTools/Source/C/FCE/IfrParse.h  |  789 ---
 BaseTools/Source/C/FCE/Makefile|   19 -
 BaseTools/Source/C/FCE/MonotonicBasedVariable.h|  162 -
 BaseTools/Source/C/FCE/TimeBasedVariable.h |  166 -
 BaseTools/Source/C/FCE/Variable.h  |  154 -
 BaseTools/Source/C/FCE/VariableCommon.h|   55 -
 BaseTools/Source/C/FMMT/FirmwareModuleManagement.h |  479 --
 BaseTools/Source/C/FMMT/FmmtConf.ini   |6 -
 BaseTools/Source/C/FMMT/GNUmakefile|   16 -
 BaseTools/Source/C/FMMT/Makefile   |   17 -
 BaseTools/Source/C/FMMT/Rebase.h   |   31 -
 BaseTools/Source/C/GNUmakefile |5 +-
 BaseTools/Source/C/Makefile|5 +-
 38 files changed, 2 insertions(+), 38360 deletions(-)
 delete mode 100644 BaseTools/Source/C/BfmLib/BfmLib.c
 delete mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.c
 delete mode 100644 BaseTools/Source/C/FCE/BinaryCreate.c
 delete mode 100644 BaseTools/Source/C/FCE/BinaryParse.c
 delete mode 100644 BaseTools/Source/C/FCE/Common.c
 delete mode 100644 BaseTools/Source/C/FCE/Expression.c
 delete mode 100644 BaseTools/Source/C/FCE/Fce.c
 delete mode 100644 BaseTools/Source/C/FCE/IfrParse.c
 delete mode 100644 BaseTools/Source/C/FCE/MonotonicBasedVariable.c
 delete mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.c
 delete mode 100644 BaseTools/Source/C/FCE/Variable.c
 delete mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.c
 delete mode 100644 BaseTools/Source/C/FMMT/FmmtLib.c
 delete mode 100644 BaseTools/Source/C/FMMT/Rebase.c
 delete mode 100755 BaseTools/BinWrappers/PosixLike/BfmLib
 delete mode 100755 BaseTools/BinWrappers/PosixLike/FCE
 delete mode 100755 BaseTools/BinWrappers/PosixLike/FMMT
 delete mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.h
 delete mode 100644 BaseTools/Source/C/BfmLib/GNUmakefile
 delete mode 100644 BaseTools/Source/C/BfmLib/Makefile
 delete mode 100644 BaseTools/Source/C/FCE/BinaryCreate.h
 delete mode 100644 BaseTools/Source/C/FCE/BinaryParse.h
 delete mode 100644 BaseTools/Source/C/FCE/Common.h
 delete mode 100644 BaseTools/Source/C/FCE/Fce.h
 delete mode 100644 BaseTools/Source/C/FCE/GNUmakefile
 delete mode 100644 BaseTools/Source/C/FCE/IfrParse.h
 delete mode 100644 BaseTools/Source/C/FCE/Makefile
 delete mode 100644 BaseTools/Source/C/FCE/MonotonicBasedVariable.h
 delete mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.h
 delete mode 100644 BaseTools/Source/C/FCE/Variable.h
 delete mode 100644 BaseTools/Source/C/FCE/VariableCommon.h
 delete mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.h
 delete mode 100644 BaseTools/Source/C/FMMT/FmmtConf.ini
 delete mode 100644 BaseTools/Source/C/FMMT/GNUmakefile
 delete mode 100644