[edk2-devel] [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Clean up useless parameter.

2019-08-08 Thread Dong, Eric 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2060

Remove the useless parameter.

Signed-off-by: Eric Dong 
Cc: Ray Ni 
Cc: Laszlo Ersek 
---
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h  | 1 -
 .../Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h 
b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
index a25dd69292..7c48b0a645 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
@@ -58,7 +58,6 @@ typedef struct {
 // Flags used when program the register.
 //
 typedef struct {
-  volatile UINTN   ConsoleLogLock;  // Spinlock used to 
control console.
   volatile UINTN   MemoryMappedLock;// Spinlock used to 
program mmio
   volatile UINT32  *CoreSemaphoreCount; // Semaphore containers 
used to program Core semaphore.
   volatile UINT32  *PackageSemaphoreCount;  // Semaphore containers 
used to program Package semaphore.
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c 
b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
index 493566de5d..67885bf69b 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
@@ -839,7 +839,6 @@ RegisterCpuFeature (
   if (CpuFeaturesData->FeaturesCount == 0) {
 InitializeListHead (&CpuFeaturesData->FeatureList);
 InitializeSpinLock (&CpuFeaturesData->CpuFlags.MemoryMappedLock);
-InitializeSpinLock (&CpuFeaturesData->CpuFlags.ConsoleLogLock);
 //
 // Code assumes below three PCDs have PCD same buffer size.
 //
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45180): https://edk2.groups.io/g/devel/message/45180
Mute This Topic: https://groups.io/mt/32798207/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Clean up useless parameter.

2019-08-08 Thread Laszlo Ersek 
On 08/08/19 15:24, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2060
> 
> Remove the useless parameter.
> 
> Signed-off-by: Eric Dong 
> Cc: Ray Ni 
> Cc: Laszlo Ersek 
> ---
>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h  | 1 -
>  .../Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h 
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> index a25dd69292..7c48b0a645 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
> @@ -58,7 +58,6 @@ typedef struct {
>  // Flags used when program the register.
>  //
>  typedef struct {
> -  volatile UINTN   ConsoleLogLock;  // Spinlock used to 
> control console.
>volatile UINTN   MemoryMappedLock;// Spinlock used to 
> program mmio
>volatile UINT32  *CoreSemaphoreCount; // Semaphore containers 
> used to program Core semaphore.
>volatile UINT32  *PackageSemaphoreCount;  // Semaphore containers 
> used to program Package semaphore.
> diff --git 
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c 
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> index 493566de5d..67885bf69b 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> @@ -839,7 +839,6 @@ RegisterCpuFeature (
>if (CpuFeaturesData->FeaturesCount == 0) {
>  InitializeListHead (&CpuFeaturesData->FeatureList);
>  InitializeSpinLock (&CpuFeaturesData->CpuFlags.MemoryMappedLock);
> -InitializeSpinLock (&CpuFeaturesData->CpuFlags.ConsoleLogLock);
>  //
>  // Code assumes below three PCDs have PCD same buffer size.
>  //
> 

Please replace "useless parameter" in the subject and in the commit
message body also, with "useless ConsoleLogLock spinlock".

With that:

Reviewed-by: Laszlo Ersek 


Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45219): https://edk2.groups.io/g/devel/message/45219
Mute This Topic: https://groups.io/mt/32798207/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-