Re: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg.
On 12/12/23 02:20, Tan, Dun wrote: > Hi Laszlo, > > Thanks for your reply. Sorry that I didn't add you in the reviewer list from > the beginning of this patch series review. About the patch review, please > take your time. Also take care your body! > > The patch set was reviewed-by Ray last week. So I think we can merge the > patch set first. You can ping me if you have any comments about this patch > set later. Right, I think you should just go ahead and merge the series with Ray's R-b at this time. Thanks! Laszlo > > Thanks, > Dun > > -Original Message- > From: Laszlo Ersek > Sent: Monday, December 11, 2023 9:50 PM > To: Tan, Dun ; devel@edk2.groups.io > Cc: Ni, Ray ; Ard Biesheuvel ; Kinney, > Michael D ; Gerd Hoffmann > Subject: Re: [edk2-devel] [Patch V3 0/6] Create and consume a new > gMpInformationHobGuid2 in UefiCpuPkg. > > Hi Dun, > > On 12/11/23 04:16, Tan, Dun wrote: >> Hi Laszlo, >> >> Previously I sent a patch set " Move gMpInformationHobGuid from >> StandaloneMmPkg to UefiCpuPkg. " and thanks for your review. To solve the >> issue that the maximum length of one HOB might not be enough when CPU count >> is 1-2000 or bigger and extend the HOB, we decide to create a new MpInfo2Hob >> in UefiCpuPkg in this patch set. Do you have any comments about the patch >> set? >> >> Thanks, >> Dun > > A few days ago I made an effort to at least identify the newest patch sets I > should "sometime" review on edk2, including those that apparently superseded > older versions. Thus, although not with 100% certainty, I did deduce the > above "change of plan", i.e., that the movement of the existent info HOB > between packages would be superseded by a brand new HOB. However, all I could > do at the time was simply tagging the new version for review -- and that's > where I stand now. > > For reference, I have approx. 14+ patch sets tagged for review on edk2-devel > -- these have accumulated due to my 2 weeks long sick leave. > I'm back to work for 4 days this week, but then I'll disappear again until > the end of the year. So, I think I had best declare "email bankruptcy". > > Apologies for blocking you -- I had made some efforts to inform my > co-maintainers of my status meanwhile. So, please don't wait for my feedback > at this time; I might catch up, if I'm lucky, but I probably won't be able > to. So if Ray is pleased with your patches, please go ahead and merge them. > > I might make comments on smaller patches this week; rest assured that that > kind of "preference" is just practicality, not laziness. It feels hopeless > for me to make a serious "dent" in reviewing any larger patch set this week, > so I'll try to spend review effort where it has a fleeting chance at enabling > actual progress. > > Best regards, > Laszlo > > >> >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of duntan >> Sent: Friday, December 8, 2023 5:55 PM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [Patch V3 0/6] Create and consume a new >> gMpInformationHobGuid2 in UefiCpuPkg. >> >> In the V3 patch set, >> In patch "UefiCpuPkg: Build MpInfo2HOB in CpuMpPei", the DEBUG message >> format is modified In patch "UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe", >> remove unneccesary assert check. >> In patch "UefiCpuPkg: Avoid assuming only one smmbasehob", free allocated >> buffer when error returning case happen. >> >> Dun Tan (6): >> UefiCpuPkg: Create gMpInformationHobGuid2 in UefiCpuPkg >> UefiCpuPkg: Build MpInfo2HOB in CpuMpPei >> UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe >> UefiCpuPkg: Add a new field in MpInfo2 HOB >> UefiCpuPkg: Cache core type in MpInfo2 HOB >> UefiCpuPkg: Avoid assuming only one smmbasehob >> >> UefiCpuPkg/CpuMpPei/CpuMpPei.c | 146 >> ++ >> UefiCpuPkg/CpuMpPei/CpuMpPei.h | 6 +- >> UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 ++- >> UefiCpuPkg/Include/Guid/MpInformation2.h | 58 >> ++ >> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 354 >>
Re: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg.
Hi Laszlo, Thanks for your reply. Sorry that I didn't add you in the reviewer list from the beginning of this patch series review. About the patch review, please take your time. Also take care your body! The patch set was reviewed-by Ray last week. So I think we can merge the patch set first. You can ping me if you have any comments about this patch set later. Thanks, Dun -Original Message- From: Laszlo Ersek Sent: Monday, December 11, 2023 9:50 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Ni, Ray ; Ard Biesheuvel ; Kinney, Michael D ; Gerd Hoffmann Subject: Re: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg. Hi Dun, On 12/11/23 04:16, Tan, Dun wrote: > Hi Laszlo, > > Previously I sent a patch set " Move gMpInformationHobGuid from > StandaloneMmPkg to UefiCpuPkg. " and thanks for your review. To solve the > issue that the maximum length of one HOB might not be enough when CPU count > is 1-2000 or bigger and extend the HOB, we decide to create a new MpInfo2Hob > in UefiCpuPkg in this patch set. Do you have any comments about the patch set? > > Thanks, > Dun A few days ago I made an effort to at least identify the newest patch sets I should "sometime" review on edk2, including those that apparently superseded older versions. Thus, although not with 100% certainty, I did deduce the above "change of plan", i.e., that the movement of the existent info HOB between packages would be superseded by a brand new HOB. However, all I could do at the time was simply tagging the new version for review -- and that's where I stand now. For reference, I have approx. 14+ patch sets tagged for review on edk2-devel -- these have accumulated due to my 2 weeks long sick leave. I'm back to work for 4 days this week, but then I'll disappear again until the end of the year. So, I think I had best declare "email bankruptcy". Apologies for blocking you -- I had made some efforts to inform my co-maintainers of my status meanwhile. So, please don't wait for my feedback at this time; I might catch up, if I'm lucky, but I probably won't be able to. So if Ray is pleased with your patches, please go ahead and merge them. I might make comments on smaller patches this week; rest assured that that kind of "preference" is just practicality, not laziness. It feels hopeless for me to make a serious "dent" in reviewing any larger patch set this week, so I'll try to spend review effort where it has a fleeting chance at enabling actual progress. Best regards, Laszlo > > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Friday, December 8, 2023 5:55 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V3 0/6] Create and consume a new > gMpInformationHobGuid2 in UefiCpuPkg. > > In the V3 patch set, > In patch "UefiCpuPkg: Build MpInfo2HOB in CpuMpPei", the DEBUG message format > is modified In patch "UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe", remove > unneccesary assert check. > In patch "UefiCpuPkg: Avoid assuming only one smmbasehob", free allocated > buffer when error returning case happen. > > Dun Tan (6): > UefiCpuPkg: Create gMpInformationHobGuid2 in UefiCpuPkg > UefiCpuPkg: Build MpInfo2HOB in CpuMpPei > UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe > UefiCpuPkg: Add a new field in MpInfo2 HOB > UefiCpuPkg: Cache core type in MpInfo2 HOB > UefiCpuPkg: Avoid assuming only one smmbasehob > > UefiCpuPkg/CpuMpPei/CpuMpPei.c | 146 > ++ > UefiCpuPkg/CpuMpPei/CpuMpPei.h | 6 +- > UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 ++- > UefiCpuPkg/Include/Guid/MpInformation2.h | 58 > ++ > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 354 > ++ > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 8 > UefiCpuPkg/UefiCpuPkg.dec| 3 +++ > 8 files changed, 513 insertions(+), 67 deletions(-) create mode > 100644 UefiCpuPkg/Include/Guid/MpInformation2.h > > -- > 2.31.1.windows.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112353): https://edk2.groups.io/g/devel/message/112353 Mute This Topic: https://groups.io/mt/103052268/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg.
Hi Dun, On 12/11/23 04:16, Tan, Dun wrote: > Hi Laszlo, > > Previously I sent a patch set " Move gMpInformationHobGuid from > StandaloneMmPkg to UefiCpuPkg. " and thanks for your review. To solve the > issue that the maximum length of one HOB might not be enough when CPU count > is 1-2000 or bigger and extend the HOB, we decide to create a new MpInfo2Hob > in UefiCpuPkg in this patch set. Do you have any comments about the patch set? > > Thanks, > Dun A few days ago I made an effort to at least identify the newest patch sets I should "sometime" review on edk2, including those that apparently superseded older versions. Thus, although not with 100% certainty, I did deduce the above "change of plan", i.e., that the movement of the existent info HOB between packages would be superseded by a brand new HOB. However, all I could do at the time was simply tagging the new version for review -- and that's where I stand now. For reference, I have approx. 14+ patch sets tagged for review on edk2-devel -- these have accumulated due to my 2 weeks long sick leave. I'm back to work for 4 days this week, but then I'll disappear again until the end of the year. So, I think I had best declare "email bankruptcy". Apologies for blocking you -- I had made some efforts to inform my co-maintainers of my status meanwhile. So, please don't wait for my feedback at this time; I might catch up, if I'm lucky, but I probably won't be able to. So if Ray is pleased with your patches, please go ahead and merge them. I might make comments on smaller patches this week; rest assured that that kind of "preference" is just practicality, not laziness. It feels hopeless for me to make a serious "dent" in reviewing any larger patch set this week, so I'll try to spend review effort where it has a fleeting chance at enabling actual progress. Best regards, Laszlo > > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Friday, December 8, 2023 5:55 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V3 0/6] Create and consume a new > gMpInformationHobGuid2 in UefiCpuPkg. > > In the V3 patch set, > In patch "UefiCpuPkg: Build MpInfo2HOB in CpuMpPei", the DEBUG message format > is modified In patch "UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe", remove > unneccesary assert check. > In patch "UefiCpuPkg: Avoid assuming only one smmbasehob", free allocated > buffer when error returning case happen. > > Dun Tan (6): > UefiCpuPkg: Create gMpInformationHobGuid2 in UefiCpuPkg > UefiCpuPkg: Build MpInfo2HOB in CpuMpPei > UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe > UefiCpuPkg: Add a new field in MpInfo2 HOB > UefiCpuPkg: Cache core type in MpInfo2 HOB > UefiCpuPkg: Avoid assuming only one smmbasehob > > UefiCpuPkg/CpuMpPei/CpuMpPei.c | 146 > ++ > UefiCpuPkg/CpuMpPei/CpuMpPei.h | 6 +- > UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 ++- > UefiCpuPkg/Include/Guid/MpInformation2.h | 58 > ++ > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 354 > ++ > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 8 > UefiCpuPkg/UefiCpuPkg.dec| 3 +++ > 8 files changed, 513 insertions(+), 67 deletions(-) create mode 100644 > UefiCpuPkg/Include/Guid/MpInformation2.h > > -- > 2.31.1.windows.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112298): https://edk2.groups.io/g/devel/message/112298 Mute This Topic: https://groups.io/mt/103052268/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg.
Hi Laszlo, Previously I sent a patch set " Move gMpInformationHobGuid from StandaloneMmPkg to UefiCpuPkg. " and thanks for your review. To solve the issue that the maximum length of one HOB might not be enough when CPU count is 1-2000 or bigger and extend the HOB, we decide to create a new MpInfo2Hob in UefiCpuPkg in this patch set. Do you have any comments about the patch set? Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of duntan Sent: Friday, December 8, 2023 5:55 PM To: devel@edk2.groups.io Subject: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg. In the V3 patch set, In patch "UefiCpuPkg: Build MpInfo2HOB in CpuMpPei", the DEBUG message format is modified In patch "UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe", remove unneccesary assert check. In patch "UefiCpuPkg: Avoid assuming only one smmbasehob", free allocated buffer when error returning case happen. Dun Tan (6): UefiCpuPkg: Create gMpInformationHobGuid2 in UefiCpuPkg UefiCpuPkg: Build MpInfo2HOB in CpuMpPei UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe UefiCpuPkg: Add a new field in MpInfo2 HOB UefiCpuPkg: Cache core type in MpInfo2 HOB UefiCpuPkg: Avoid assuming only one smmbasehob UefiCpuPkg/CpuMpPei/CpuMpPei.c | 146 ++ UefiCpuPkg/CpuMpPei/CpuMpPei.h | 6 +- UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 ++- UefiCpuPkg/Include/Guid/MpInformation2.h | 58 ++ UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 354 ++ UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 8 UefiCpuPkg/UefiCpuPkg.dec| 3 +++ 8 files changed, 513 insertions(+), 67 deletions(-) create mode 100644 UefiCpuPkg/Include/Guid/MpInformation2.h -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112267): https://edk2.groups.io/g/devel/message/112267 Mute This Topic: https://groups.io/mt/103052268/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg.
In the V3 patch set, In patch "UefiCpuPkg: Build MpInfo2HOB in CpuMpPei", the DEBUG message format is modified In patch "UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe", remove unneccesary assert check. In patch "UefiCpuPkg: Avoid assuming only one smmbasehob", free allocated buffer when error returning case happen. Dun Tan (6): UefiCpuPkg: Create gMpInformationHobGuid2 in UefiCpuPkg UefiCpuPkg: Build MpInfo2HOB in CpuMpPei UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe UefiCpuPkg: Add a new field in MpInfo2 HOB UefiCpuPkg: Cache core type in MpInfo2 HOB UefiCpuPkg: Avoid assuming only one smmbasehob UefiCpuPkg/CpuMpPei/CpuMpPei.c | 146 ++ UefiCpuPkg/CpuMpPei/CpuMpPei.h | 6 +- UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 ++- UefiCpuPkg/Include/Guid/MpInformation2.h | 58 ++ UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 354 ++ UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 8 UefiCpuPkg/UefiCpuPkg.dec| 3 +++ 8 files changed, 513 insertions(+), 67 deletions(-) create mode 100644 UefiCpuPkg/Include/Guid/MpInformation2.h -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112221): https://edk2.groups.io/g/devel/message/112221 Mute This Topic: https://groups.io/mt/103052268/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
