Re: [edk2-devel] [Patch v2 05/11] ShellPkg: Remove All UGA Support

2022-07-14 Thread Ni, Ray
Reviewed-by: Ray Ni 

> -Original Message-
> From: Jiang, Guomin 
> Sent: Friday, July 15, 2022 9:51 AM
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Ni, Ray ; Gao, 
> Zhichao 
> Subject: [Patch v2 05/11] ShellPkg: Remove All UGA Support
> 
> From: GuoMinJ 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
> 
> Remove All UGA Support in ShellPkg.
> 
> Signed-off-by: Guomin Jiang 
> Cc: Ray Ni 
> Cc: Zhichao Gao 
> ---
>  ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c  | 4 +---
>  ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h  | 4 +---
>  .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +---
>  .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +---
>  4 files changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index aa0115bdd498..08215ab8039c 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -1,7 +1,7 @@
>  /** @file
>Provides interface to advanced shell functionality for parsing both handle 
> and protocol database.
> 
> -  Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
> +  Copyright (c) 2010 - 2022, Intel Corporation. All rights reserved.
>(C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
>(C) Copyright 2015-2021 Hewlett Packard Enterprise Development LP
>SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -2238,8 +2238,6 @@ STATIC CONST GUID_INFO_BLOCK  mGuidStringList[] = {
>{ STRING_TOKEN (STR_SHELL_ENV2),  &gEfiShellEnvironment2Guid,  
>   NULL },
>{ STRING_TOKEN (STR_SHELL_ENV),   &gEfiShellEnvironment2Guid,  
>   NULL },
>{ STRING_TOKEN (STR_DEVICE_IO),   &gEfiDeviceIoProtocolGuid,   
>   NULL },
> -  { STRING_TOKEN (STR_UGA_DRAW),&gEfiUgaDrawProtocolGuid,
>   NULL },
> -  { STRING_TOKEN (STR_UGA_IO),  &gEfiUgaIoProtocolGuid,  
>   NULL },
>{ STRING_TOKEN (STR_ESP), &gEfiPartTypeSystemPartGuid, 
>   NULL },
>{ STRING_TOKEN (STR_GPT_NBR), &gEfiPartTypeLegacyMbrGuid,  
>   NULL },
>{ STRING_TOKEN (STR_DRIVER_CONFIG),   
> &gEfiDriverConfigurationProtocolGuid,
> NULL },
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h
> index 6be0d78c4c5a..b3433eda029b 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h
> @@ -1,7 +1,7 @@
>  /** @file
>Provides interface to advanced shell functionality for parsing both handle 
> and protocol database.
> 
> -  Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.
> +  Copyright (c) 2011 - 2022, Intel Corporation. All rights reserved.
>(C) Copyright 2016 Hewlett Packard Enterprise Development LP
>(C) Copyright 2013-2016 Hewlett-Packard Development Company, L.P.
>SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -94,8 +94,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
> -#include 
>  #include 
>  #include 
>  #include 
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> index 0d483805e712..af16569b07bd 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> @@ -1,6 +1,6 @@
>  ##  @file
>  #  Provides interface to advanced shell functionality for parsing both 
> handle and protocol database.
> -#  Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. 
> +#  Copyright (c) 2010 - 2022, Intel Corporation. All rights reserved. 
>  #  (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
>  #  (C) Copyright 2015-2021 Hewlett Packard Enterprise Development LP
>  #
> @@ -129,8 +129,6 @@
>gEfiHiiConfigAccessProtocolGuid ## UNDEFINED
>gEfiFormBrowser2ProtocolGuid## UNDEFINED
>gEfiDeviceIoProtocolGuid## UNDEFINED
> -  gEfiUgaDrawProtocolGuid ## UNDEFINED
> -  gEfiUgaIoProtocolGuid   ## UNDEFINED
>gEfiDriverConfigurationProtocolGuid  

[edk2-devel] [Patch v2 05/11] ShellPkg: Remove All UGA Support

2022-07-14 Thread Guomin Jiang
From: GuoMinJ 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368

Remove All UGA Support in ShellPkg.

Signed-off-by: Guomin Jiang 
Cc: Ray Ni 
Cc: Zhichao Gao 
---
 ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c  | 4 +---
 ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h  | 4 +---
 .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +---
 .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +---
 4 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c 
b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index aa0115bdd498..08215ab8039c 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -1,7 +1,7 @@
 /** @file
   Provides interface to advanced shell functionality for parsing both handle 
and protocol database.
 
-  Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
+  Copyright (c) 2010 - 2022, Intel Corporation. All rights reserved.
   (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
   (C) Copyright 2015-2021 Hewlett Packard Enterprise Development LP
   SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -2238,8 +2238,6 @@ STATIC CONST GUID_INFO_BLOCK  mGuidStringList[] = {
   { STRING_TOKEN (STR_SHELL_ENV2),  &gEfiShellEnvironment2Guid,
NULL },
   { STRING_TOKEN (STR_SHELL_ENV),   &gEfiShellEnvironment2Guid,
NULL },
   { STRING_TOKEN (STR_DEVICE_IO),   &gEfiDeviceIoProtocolGuid, 
NULL },
-  { STRING_TOKEN (STR_UGA_DRAW),&gEfiUgaDrawProtocolGuid,  
NULL },
-  { STRING_TOKEN (STR_UGA_IO),  &gEfiUgaIoProtocolGuid,
NULL },
   { STRING_TOKEN (STR_ESP), &gEfiPartTypeSystemPartGuid,   
NULL },
   { STRING_TOKEN (STR_GPT_NBR), &gEfiPartTypeLegacyMbrGuid,
NULL },
   { STRING_TOKEN (STR_DRIVER_CONFIG),   
&gEfiDriverConfigurationProtocolGuid,  NULL 
},
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h 
b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h
index 6be0d78c4c5a..b3433eda029b 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.h
@@ -1,7 +1,7 @@
 /** @file
   Provides interface to advanced shell functionality for parsing both handle 
and protocol database.
 
-  Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.
+  Copyright (c) 2011 - 2022, Intel Corporation. All rights reserved.
   (C) Copyright 2016 Hewlett Packard Enterprise Development LP
   (C) Copyright 2013-2016 Hewlett-Packard Development Company, L.P.
   SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -94,8 +94,6 @@
 #include 
 #include 
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf 
b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
index 0d483805e712..af16569b07bd 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
@@ -1,6 +1,6 @@
 ##  @file
 #  Provides interface to advanced shell functionality for parsing both handle 
and protocol database.
-#  Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. 
+#  Copyright (c) 2010 - 2022, Intel Corporation. All rights reserved. 
 #  (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
 #  (C) Copyright 2015-2021 Hewlett Packard Enterprise Development LP
 #
@@ -129,8 +129,6 @@
   gEfiHiiConfigAccessProtocolGuid ## UNDEFINED
   gEfiFormBrowser2ProtocolGuid## UNDEFINED
   gEfiDeviceIoProtocolGuid## UNDEFINED
-  gEfiUgaDrawProtocolGuid ## UNDEFINED
-  gEfiUgaIoProtocolGuid   ## UNDEFINED
   gEfiDriverConfigurationProtocolGuid ## UNDEFINED
   gEfiDriverConfiguration2ProtocolGuid## UNDEFINED
   gEfiSimpleTextInputExProtocolGuid   ## UNDEFINED
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni 
b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
index aa3396cea94d..04beea8e7f3e 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.