Re: [edk2-devel] [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator

2019-04-15 Thread Leif Lindholm
On Mon, Apr 15, 2019 at 10:57:53AM -0700, Ard Biesheuvel wrote:
> On Mon, 15 Apr 2019 at 02:17, Leif Lindholm  wrote:
> >
> > Some bikeshedding below:
> >
> > On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote:
> > > Repo:   http://github.com/ardbiesheuvel/X86EmulatorPkg.git
> > > Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97
> >
> > Does this permit execution of both IA32 and X64 code? If so, the name
> > makes sense (but the README.md in the above repo suggests otherwise,
> > and the readme here says nothing on the topic).
> >
> 
> I don't know whether the emulator itself supports IA32 execution, but
> the driver definitely only registers itself for the X64 machine type.
> 
> But since the naming of the upstream repo is not really under review
> here, I will add a mention that only X64 is supported.

Thanks. (Yes, what I meant was that since the name is ambiguous, more
detail may be required in the commit message.)

> > > Repo:   http://github.com/tiancore/edk2.git
> > > Commit: 2e21e8c4b89656897797019a9c56bc5ccbf12df1
> > >
> > > Note that the X86EmulatorPkg project's license is _L_GPL not GPL,
> > > and so it could arguably be incorporated into edk2-non-osi in source
> > > form. However, the emulator is a rather sizable chunk of code, and
> > > providing a known working binary is preferred over having each
> > > platform build it from scratch, so providing just the binary should
> > > be sufficient for the time being.
> > >
> > > Cc: Andrew Fish 
> > > Cc: Laszlo Ersek 
> > > Cc: Leif Lindholm 
> > > Cc: Michael D Kinney 
> > > Signed-off-by: Ard Biesheuvel 
> > > ---
> > > Note that this patch is against the edk2-non-osi repository, not EDK2
> > > itself.
> > >
> > > Binaries are omitted from this patch. The complete patch can be found 
> > > here:
> > > https://git.linaro.org/leg/noupstream/edk2-non-osi.git/commit/?h=upstream
> > >
> > >  Emulator/X86EmulatorDxe/LICENSE  | 504 
> > >  Emulator/X86EmulatorDxe/README   |   9 +
> >
> > Could this be Readme.md?
> >
> 
> Of course. What does the .md stand for actually?

MarkDown (I.e. https://en.wikipedia.org/wiki/Markdown)

Doesn't make a difference for this version, but could for future ones.
Also means you get it auto-displayed on the github page.

/
Leif

> > >  Emulator/X86EmulatorDxe/X86EmulatorDxe.depex | Bin 0 -> 54 bytes
> > >  Emulator/X86EmulatorDxe/X86EmulatorDxe.efi   | Bin 0 -> 913408 bytes
> > >  Emulator/X86EmulatorDxe/X86EmulatorDxe.inf   |  21 +
> > >  5 files changed, 534 insertions(+)
> >
> > /
> > Leif

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39112): https://edk2.groups.io/g/devel/message/39112
Mute This Topic: https://groups.io/mt/31137158/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [edk2-devel] [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator

2019-04-15 Thread Ard Biesheuvel
On Mon, 15 Apr 2019 at 02:17, Leif Lindholm  wrote:
>
> Some bikeshedding below:
>
> On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote:
> > Repo:   http://github.com/ardbiesheuvel/X86EmulatorPkg.git
> > Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97
>
> Does this permit execution of both IA32 and X64 code? If so, the name
> makes sense (but the README.md in the above repo suggests otherwise,
> and the readme here says nothing on the topic).
>

I don't know whether the emulator itself supports IA32 execution, but
the driver definitely only registers itself for the X64 machine type.

But since the naming of the upstream repo is not really under review
here, I will add a mention that only X64 is supported.

> > Repo:   http://github.com/tiancore/edk2.git
> > Commit: 2e21e8c4b89656897797019a9c56bc5ccbf12df1
> >
> > Note that the X86EmulatorPkg project's license is _L_GPL not GPL,
> > and so it could arguably be incorporated into edk2-non-osi in source
> > form. However, the emulator is a rather sizable chunk of code, and
> > providing a known working binary is preferred over having each
> > platform build it from scratch, so providing just the binary should
> > be sufficient for the time being.
> >
> > Cc: Andrew Fish 
> > Cc: Laszlo Ersek 
> > Cc: Leif Lindholm 
> > Cc: Michael D Kinney 
> > Signed-off-by: Ard Biesheuvel 
> > ---
> > Note that this patch is against the edk2-non-osi repository, not EDK2
> > itself.
> >
> > Binaries are omitted from this patch. The complete patch can be found here:
> > https://git.linaro.org/leg/noupstream/edk2-non-osi.git/commit/?h=upstream
> >
> >  Emulator/X86EmulatorDxe/LICENSE  | 504 
> >  Emulator/X86EmulatorDxe/README   |   9 +
>
> Could this be Readme.md?
>

Of course. What does the .md stand for actually?

> >  Emulator/X86EmulatorDxe/X86EmulatorDxe.depex | Bin 0 -> 54 bytes
> >  Emulator/X86EmulatorDxe/X86EmulatorDxe.efi   | Bin 0 -> 913408 bytes
> >  Emulator/X86EmulatorDxe/X86EmulatorDxe.inf   |  21 +
> >  5 files changed, 534 insertions(+)
>
> /
> Leif

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39111): https://edk2.groups.io/g/devel/message/39111
Mute This Topic: https://groups.io/mt/31137158/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [edk2-devel] [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator

2019-04-15 Thread Leif Lindholm
Some bikeshedding below:

On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote:
> Repo:   http://github.com/ardbiesheuvel/X86EmulatorPkg.git
> Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97

Does this permit execution of both IA32 and X64 code? If so, the name
makes sense (but the README.md in the above repo suggests otherwise,
and the readme here says nothing on the topic).

> Repo:   http://github.com/tiancore/edk2.git
> Commit: 2e21e8c4b89656897797019a9c56bc5ccbf12df1
> 
> Note that the X86EmulatorPkg project's license is _L_GPL not GPL,
> and so it could arguably be incorporated into edk2-non-osi in source
> form. However, the emulator is a rather sizable chunk of code, and
> providing a known working binary is preferred over having each
> platform build it from scratch, so providing just the binary should
> be sufficient for the time being.
> 
> Cc: Andrew Fish 
> Cc: Laszlo Ersek 
> Cc: Leif Lindholm 
> Cc: Michael D Kinney 
> Signed-off-by: Ard Biesheuvel 
> ---
> Note that this patch is against the edk2-non-osi repository, not EDK2
> itself.
> 
> Binaries are omitted from this patch. The complete patch can be found here:
> https://git.linaro.org/leg/noupstream/edk2-non-osi.git/commit/?h=upstream
> 
>  Emulator/X86EmulatorDxe/LICENSE  | 504 
>  Emulator/X86EmulatorDxe/README   |   9 +

Could this be Readme.md?

>  Emulator/X86EmulatorDxe/X86EmulatorDxe.depex | Bin 0 -> 54 bytes
>  Emulator/X86EmulatorDxe/X86EmulatorDxe.efi   | Bin 0 -> 913408 bytes
>  Emulator/X86EmulatorDxe/X86EmulatorDxe.inf   |  21 +
>  5 files changed, 534 insertions(+)

/
Leif

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39066): https://edk2.groups.io/g/devel/message/39066
Mute This Topic: https://groups.io/mt/31137158/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[edk2-devel] [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator

2019-04-14 Thread Ard Biesheuvel
Repo:   http://github.com/ardbiesheuvel/X86EmulatorPkg.git
Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97

Repo:   http://github.com/tiancore/edk2.git
Commit: 2e21e8c4b89656897797019a9c56bc5ccbf12df1

Note that the X86EmulatorPkg project's license is _L_GPL not GPL,
and so it could arguably be incorporated into edk2-non-osi in source
form. However, the emulator is a rather sizable chunk of code, and
providing a known working binary is preferred over having each
platform build it from scratch, so providing just the binary should
be sufficient for the time being.

Cc: Andrew Fish 
Cc: Laszlo Ersek 
Cc: Leif Lindholm 
Cc: Michael D Kinney 
Signed-off-by: Ard Biesheuvel 
---
Note that this patch is against the edk2-non-osi repository, not EDK2
itself.

Binaries are omitted from this patch. The complete patch can be found here:
https://git.linaro.org/leg/noupstream/edk2-non-osi.git/commit/?h=upstream

 Emulator/X86EmulatorDxe/LICENSE  | 504 
 Emulator/X86EmulatorDxe/README   |   9 +
 Emulator/X86EmulatorDxe/X86EmulatorDxe.depex | Bin 0 -> 54 bytes
 Emulator/X86EmulatorDxe/X86EmulatorDxe.efi   | Bin 0 -> 913408 bytes
 Emulator/X86EmulatorDxe/X86EmulatorDxe.inf   |  21 +
 5 files changed, 534 insertions(+)

diff --git a/Emulator/X86EmulatorDxe/LICENSE b/Emulator/X86EmulatorDxe/LICENSE
new file mode 100644
index ..0c1c7025ac89
--- /dev/null
+++ b/Emulator/X86EmulatorDxe/LICENSE
@@ -0,0 +1,504 @@
+  GNU LESSER GENERAL PUBLIC LICENSE
+   Version 2.1, February 1999
+
+ Copyright (C) 1991, 1999 Free Software Foundation, Inc.
+ 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+(This is the first released version of the Lesser GPL.  It also counts
+ as the successor of the GNU Library Public License, version 2, hence
+ the version number 2.1.)
+
+Preamble
+
+  The licenses for most software are designed to take away your
+freedom to share and change it.  By contrast, the GNU General Public
+Licenses are intended to guarantee your freedom to share and change
+free software--to make sure the software is free for all its users.
+
+  This license, the Lesser General Public License, applies to some
+specially designated software packages--typically libraries--of the
+Free Software Foundation and other authors who decide to use it.  You
+can use it too, but we suggest you first think carefully about whether
+this license or the ordinary General Public License is the better
+strategy to use in any particular case, based on the explanations below.
+
+  When we speak of free software, we are referring to freedom of use,
+not price.  Our General Public Licenses are designed to make sure that
+you have the freedom to distribute copies of free software (and charge
+for this service if you wish); that you receive source code or can get
+it if you want it; that you can change the software and use pieces of
+it in new free programs; and that you are informed that you can do
+these things.
+
+  To protect your rights, we need to make restrictions that forbid
+distributors to deny you these rights or to ask you to surrender these
+rights.  These restrictions translate to certain responsibilities for
+you if you distribute copies of the library or if you modify it.
+
+  For example, if you distribute copies of the library, whether gratis
+or for a fee, you must give the recipients all the rights that we gave
+you.  You must make sure that they, too, receive or can get the source
+code.  If you link other code with the library, you must provide
+complete object files to the recipients, so that they can relink them
+with the library after making changes to the library and recompiling
+it.  And you must show them these terms so they know their rights.
+
+  We protect your rights with a two-step method: (1) we copyright the
+library, and (2) we offer you this license, which gives you legal
+permission to copy, distribute and/or modify the library.
+
+  To protect each distributor, we want to make it very clear that
+there is no warranty for the free library.  Also, if the library is
+modified by someone else and passed on, the recipients should know
+that what they have is not the original version, so that the original
+author's reputation will not be affected by problems that might be
+introduced by others.
+
+  Finally, software patents pose a constant threat to the existence of
+any free program.  We wish to make sure that a company cannot
+effectively restrict the users of a free program by obtaining a
+restrictive license from a patent holder.  Therefore, we insist that
+any patent license obtained for a version of the library must be
+consistent with the full freedom of use specified in this license.
+
+  Most GNU software, including some libraries, is covered by the
+ordinary GNU