Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py uefi app name

2022-10-31 Thread Michael D Kinney 
Pushed a806ea1062c254bd6e09db7d0f7beb4d14bc3ed0

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Monday, October 31, 2022 7:36 AM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Rebecca Cran 
> Subject: RE: [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py 
> uefi app name
> 
> Hi Mike,
> 
> Thanks for reviewing the PR😊
> 
> Could you merge this PR?
> 
> Regards,
> JP
> -Original Message-
> From: Kinney, Michael D 
> Sent: 27 October 2022 21:25
> To: Jayaprakash, N ; devel@edk2.groups.io; Kinney, 
> Michael D 
> Cc: Rebecca Cran 
> Subject: RE: [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py 
> uefi app name
> 
> Reviewed-by: Michael D Kinney 
> 
> > -Original Message-
> > From: Jayaprakash, N 
> > Sent: Thursday, October 27, 2022 2:53 AM
> > To: devel@edk2.groups.io
> > Cc: Rebecca Cran ; Kinney, Michael D
> > ; Jayaprakash, N 
> > Subject: [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py
> > uefi app name
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4124
> >
> > This patch contains the changes to remove the substring
> > 368 from the name of the python uefi interpreter app.
> > With the changes in this patch the python interpreter app name will be
> > changed from python368.efi to python.efi.
> > This change was requested by chipsec team.
> >
> > Cc: Rebecca Cran 
> > Cc: Michael D Kinney 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Jayaprakash N 
> > ---
> >  .../Python-3.6.8/GCCCompilationBKMs.rst   | 10 +--
> >  .../Python/Python-3.6.8/Py368ReadMe.txt   | 14 ++--
> >  .../Python/Python-3.6.8/Python368.inf |  2 +-
> >  ...ython368_pkg.bat => create_python_pkg.bat} | 78
> > +--  ..._python368_pkg.sh => create_python_pkg.sh} |
> > 7 +-
> >  5 files changed, 54 insertions(+), 57 deletions(-)  rename
> > AppPkg/Applications/Python/Python-3.6.8/{create_python368_pkg.bat =>
> > create_python_pkg.bat} (87%)  rename
> > AppPkg/Applications/Python/Python-3.6.8/{create_python368_pkg.sh =>
> > create_python_pkg.sh} (92%)
> >
> > diff --git
> > a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> > b/AppPkg/Applications/Python/Python-
> > 3.6.8/GCCCompilationBKMs.rst
> > index c72788f..525bef8 100644
> > --- a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> > +++ b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> > @@ -167,24 +167,24 @@ Execute the below command to build the X64
> > version of the Python 3.6.8 interpret
> >  -
> >
> >  To create an usable Python UEFI package with all the dependencies
> > from the build environment, -you can use the bash shell script
> > create_python368_pkg.sh available under
> > /AppPkg/Applications/Python/Python-3.6.8
> > +you can use the bash shell script create_python_pkg.sh available
> > +under /AppPkg/Applications/Python/Python-3.6.8
> >  folder.
> >
> >  Use the following commands to create Python UEFI package::
> >
> >  bash$ cd ~/src/edk2/AppPkg/Applications/Python/Python-3.6.8/
> > -bash$ chmod 777 create_python368_pkg.sh
> > -./create_python368_pkg.sh GCC5 RELEASE X64 myPyUEFI
> > +bash$ chmod 777 create_python_pkg.sh
> > +./create_python_pkg.sh GCC5 RELEASE X64 myPyUEFI
> >
> >  where GCC5 refers to the tool chain, RELEASE refers to the build
> > type, X64 refers to the architecture  myPyUEFI refers to the name of the 
> > folder where the Python UEFI package needs to
> be created.
> >
> > -When you run the create_python368_pkg.sh without any parameters it
> > lists the help
> > +When you run the create_python_pkg.sh without any parameters it lists
> > +the help
> >  information as shown below:
> >
> >  Shell Script to create Python EFI Package.
> >
> > -Usage: ./create_python368_pkg.sh   
> > 
> > +Usage: ./create_python_pkg.sh   
> > +
> >
> >  Where
> >  * ToolChain :  name of the tool chain such as GCC5
> > diff --git a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> > b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> > index 94dbccc..8c69210 100644
> > --- a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> > +++ b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> > @@ -98,7 +98,7 @@ target system.
> >  These directories, on the target system, are populated from the
> > development  system as follows:
> >
> > -  * \Efi\Tools receives a copy of 
> > Build/AppPkg/RELEASE_VS2017/X64/Python368.efi.
> > +  * \Efi\Tools receives a copy of 
> > Build/AppPkg/RELEASE_VS2017/X64/Python.efi.
> > 
> >  Modify the host path to match your build type and compiler.
> >
> > @@ -115,12 +115,12 @@ system as follows:
> >  the \Efi\StdLib\lib\python36.8\lib-dynload directory.  This 
> > functionality is not
> >  yet implemented.
> >
> > -  A script, create_python368_pkg.ba

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py uefi app name

2022-10-31 Thread Jayaprakash, N 
Hi Mike,

Thanks for reviewing the PR😊

Could you merge this PR?

Regards,
JP
-Original Message-
From: Kinney, Michael D  
Sent: 27 October 2022 21:25
To: Jayaprakash, N ; devel@edk2.groups.io; Kinney, 
Michael D 
Cc: Rebecca Cran 
Subject: RE: [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py uefi 
app name

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Jayaprakash, N 
> Sent: Thursday, October 27, 2022 2:53 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Kinney, Michael D 
> ; Jayaprakash, N 
> Subject: [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py 
> uefi app name
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4124
> 
> This patch contains the changes to remove the substring
> 368 from the name of the python uefi interpreter app.
> With the changes in this patch the python interpreter app name will be 
> changed from python368.efi to python.efi.
> This change was requested by chipsec team.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jayaprakash N 
> ---
>  .../Python-3.6.8/GCCCompilationBKMs.rst   | 10 +--
>  .../Python/Python-3.6.8/Py368ReadMe.txt   | 14 ++--
>  .../Python/Python-3.6.8/Python368.inf |  2 +-
>  ...ython368_pkg.bat => create_python_pkg.bat} | 78 
> +--  ..._python368_pkg.sh => create_python_pkg.sh} |  
> 7 +-
>  5 files changed, 54 insertions(+), 57 deletions(-)  rename 
> AppPkg/Applications/Python/Python-3.6.8/{create_python368_pkg.bat => 
> create_python_pkg.bat} (87%)  rename 
> AppPkg/Applications/Python/Python-3.6.8/{create_python368_pkg.sh => 
> create_python_pkg.sh} (92%)
> 
> diff --git 
> a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst 
> b/AppPkg/Applications/Python/Python-
> 3.6.8/GCCCompilationBKMs.rst
> index c72788f..525bef8 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> +++ b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> @@ -167,24 +167,24 @@ Execute the below command to build the X64 
> version of the Python 3.6.8 interpret
>  -
> 
>  To create an usable Python UEFI package with all the dependencies 
> from the build environment, -you can use the bash shell script 
> create_python368_pkg.sh available under 
> /AppPkg/Applications/Python/Python-3.6.8
> +you can use the bash shell script create_python_pkg.sh available 
> +under /AppPkg/Applications/Python/Python-3.6.8
>  folder.
> 
>  Use the following commands to create Python UEFI package::
> 
>  bash$ cd ~/src/edk2/AppPkg/Applications/Python/Python-3.6.8/
> -bash$ chmod 777 create_python368_pkg.sh
> -./create_python368_pkg.sh GCC5 RELEASE X64 myPyUEFI
> +bash$ chmod 777 create_python_pkg.sh
> +./create_python_pkg.sh GCC5 RELEASE X64 myPyUEFI
> 
>  where GCC5 refers to the tool chain, RELEASE refers to the build 
> type, X64 refers to the architecture  myPyUEFI refers to the name of the 
> folder where the Python UEFI package needs to be created.
> 
> -When you run the create_python368_pkg.sh without any parameters it 
> lists the help
> +When you run the create_python_pkg.sh without any parameters it lists 
> +the help
>  information as shown below:
> 
>  Shell Script to create Python EFI Package.
> 
> -Usage: ./create_python368_pkg.sh
> 
> +Usage: ./create_python_pkg.sh
> +
> 
>  Where
>  * ToolChain :  name of the tool chain such as GCC5
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt 
> b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> index 94dbccc..8c69210 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> +++ b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> @@ -98,7 +98,7 @@ target system.
>  These directories, on the target system, are populated from the 
> development  system as follows:
> 
> -  * \Efi\Tools receives a copy of 
> Build/AppPkg/RELEASE_VS2017/X64/Python368.efi.
> +  * \Efi\Tools receives a copy of Build/AppPkg/RELEASE_VS2017/X64/Python.efi.
> 
>  Modify the host path to match your build type and compiler.
> 
> @@ -115,12 +115,12 @@ system as follows:
>  the \Efi\StdLib\lib\python36.8\lib-dynload directory.  This 
> functionality is not
>  yet implemented.
> 
> -  A script, create_python368_pkg.bat , is provided which facilitates 
> the population
> +  A script, create_python_pkg.bat , is provided which facilitates the 
> + population
>of the target EFI package.  Execute this script from within the
>AppPkg/Applications/Python/Python-3.6.8 directory, providing the Tool 
> Chain, Target
>Build and destination directory which is the path to the destination 
> directory.
>The appropriate contents of the 
> AppPkg/Applications/Python/Python-3.6.8/Lib and
> -  Python368.efi Application from Build/

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py uefi app name

2022-10-27 Thread Michael D Kinney 
Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Jayaprakash, N 
> Sent: Thursday, October 27, 2022 2:53 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Kinney, Michael D 
> ; Jayaprakash, N
> 
> Subject: [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py uefi 
> app name
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4124
> 
> This patch contains the changes to remove the substring
> 368 from the name of the python uefi interpreter app.
> With the changes in this patch the python interpreter app
> name will be changed from python368.efi to python.efi.
> This change was requested by chipsec team.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jayaprakash N 
> ---
>  .../Python-3.6.8/GCCCompilationBKMs.rst   | 10 +--
>  .../Python/Python-3.6.8/Py368ReadMe.txt   | 14 ++--
>  .../Python/Python-3.6.8/Python368.inf |  2 +-
>  ...ython368_pkg.bat => create_python_pkg.bat} | 78 +--
>  ..._python368_pkg.sh => create_python_pkg.sh} |  7 +-
>  5 files changed, 54 insertions(+), 57 deletions(-)
>  rename AppPkg/Applications/Python/Python-3.6.8/{create_python368_pkg.bat => 
> create_python_pkg.bat} (87%)
>  rename AppPkg/Applications/Python/Python-3.6.8/{create_python368_pkg.sh => 
> create_python_pkg.sh} (92%)
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst 
> b/AppPkg/Applications/Python/Python-
> 3.6.8/GCCCompilationBKMs.rst
> index c72788f..525bef8 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> +++ b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> @@ -167,24 +167,24 @@ Execute the below command to build the X64 version of 
> the Python 3.6.8 interpret
>  -
> 
>  To create an usable Python UEFI package with all the dependencies from the 
> build environment,
> -you can use the bash shell script create_python368_pkg.sh available under 
> /AppPkg/Applications/Python/Python-3.6.8
> +you can use the bash shell script create_python_pkg.sh available under 
> /AppPkg/Applications/Python/Python-3.6.8
>  folder.
> 
>  Use the following commands to create Python UEFI package::
> 
>  bash$ cd ~/src/edk2/AppPkg/Applications/Python/Python-3.6.8/
> -bash$ chmod 777 create_python368_pkg.sh
> -./create_python368_pkg.sh GCC5 RELEASE X64 myPyUEFI
> +bash$ chmod 777 create_python_pkg.sh
> +./create_python_pkg.sh GCC5 RELEASE X64 myPyUEFI
> 
>  where GCC5 refers to the tool chain, RELEASE refers to the build type, X64 
> refers to the architecture
>  myPyUEFI refers to the name of the folder where the Python UEFI package 
> needs to be created.
> 
> -When you run the create_python368_pkg.sh without any parameters it lists the 
> help
> +When you run the create_python_pkg.sh without any parameters it lists the 
> help
>  information as shown below:
> 
>  Shell Script to create Python EFI Package.
> 
> -Usage: ./create_python368_pkg.sh
> 
> +Usage: ./create_python_pkg.sh
> 
>  Where
>  * ToolChain :  name of the tool chain such as GCC5
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt 
> b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> index 94dbccc..8c69210 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> +++ b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> @@ -98,7 +98,7 @@ target system.
>  These directories, on the target system, are populated from the development
>  system as follows:
> 
> -  * \Efi\Tools receives a copy of 
> Build/AppPkg/RELEASE_VS2017/X64/Python368.efi.
> +  * \Efi\Tools receives a copy of Build/AppPkg/RELEASE_VS2017/X64/Python.efi.
> 
>  Modify the host path to match your build type and compiler.
> 
> @@ -115,12 +115,12 @@ system as follows:
>  the \Efi\StdLib\lib\python36.8\lib-dynload directory.  This 
> functionality is not
>  yet implemented.
> 
> -  A script, create_python368_pkg.bat , is provided which facilitates the 
> population
> +  A script, create_python_pkg.bat , is provided which facilitates the 
> population
>of the target EFI package.  Execute this script from within the
>AppPkg/Applications/Python/Python-3.6.8 directory, providing the Tool 
> Chain, Target
>Build and destination directory which is the path to the destination 
> directory.
>The appropriate contents of the 
> AppPkg/Applications/Python/Python-3.6.8/Lib and
> -  Python368.efi Application from Build/AppPkg/RELEASE_VS2017/X64/ will be
> +  Python.efi Application from Build/AppPkg/RELEASE_VS2017/X64/ will be
>^^
>copied into the specified destination directory.
> 
> @@ -130,10 +130,10 @@ system as follows:
>  6. Example: Enabling socket support
>

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove substring 368 from py uefi app name

2022-10-27 Thread Jayaprakash, N 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4124

This patch contains the changes to remove the substring
368 from the name of the python uefi interpreter app.
With the changes in this patch the python interpreter app
name will be changed from python368.efi to python.efi.
This change was requested by chipsec team.

Cc: Rebecca Cran 
Cc: Michael D Kinney 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jayaprakash N 
---
 .../Python-3.6.8/GCCCompilationBKMs.rst   | 10 +--
 .../Python/Python-3.6.8/Py368ReadMe.txt   | 14 ++--
 .../Python/Python-3.6.8/Python368.inf |  2 +-
 ...ython368_pkg.bat => create_python_pkg.bat} | 78 +--
 ..._python368_pkg.sh => create_python_pkg.sh} |  7 +-
 5 files changed, 54 insertions(+), 57 deletions(-)
 rename AppPkg/Applications/Python/Python-3.6.8/{create_python368_pkg.bat => 
create_python_pkg.bat} (87%)
 rename AppPkg/Applications/Python/Python-3.6.8/{create_python368_pkg.sh => 
create_python_pkg.sh} (92%)

diff --git a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst 
b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
index c72788f..525bef8 100644
--- a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
+++ b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
@@ -167,24 +167,24 @@ Execute the below command to build the X64 version of the 
Python 3.6.8 interpret
 -
 
 To create an usable Python UEFI package with all the dependencies from the 
build environment,
-you can use the bash shell script create_python368_pkg.sh available under 
/AppPkg/Applications/Python/Python-3.6.8
+you can use the bash shell script create_python_pkg.sh available under 
/AppPkg/Applications/Python/Python-3.6.8
 folder.
 
 Use the following commands to create Python UEFI package::
 
 bash$ cd ~/src/edk2/AppPkg/Applications/Python/Python-3.6.8/
-bash$ chmod 777 create_python368_pkg.sh
-./create_python368_pkg.sh GCC5 RELEASE X64 myPyUEFI
+bash$ chmod 777 create_python_pkg.sh
+./create_python_pkg.sh GCC5 RELEASE X64 myPyUEFI
 
 where GCC5 refers to the tool chain, RELEASE refers to the build type, X64 
refers to the architecture
 myPyUEFI refers to the name of the folder where the Python UEFI package needs 
to be created.
 
-When you run the create_python368_pkg.sh without any parameters it lists the 
help
+When you run the create_python_pkg.sh without any parameters it lists the help
 information as shown below:
 
 Shell Script to create Python EFI Package.
 
-Usage: ./create_python368_pkg.sh

+Usage: ./create_python_pkg.sh
 
 Where
 * ToolChain :  name of the tool chain such as GCC5
diff --git a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt 
b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
index 94dbccc..8c69210 100644
--- a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
+++ b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
@@ -98,7 +98,7 @@ target system.
 These directories, on the target system, are populated from the development
 system as follows:
 
-  * \Efi\Tools receives a copy of 
Build/AppPkg/RELEASE_VS2017/X64/Python368.efi.
+  * \Efi\Tools receives a copy of Build/AppPkg/RELEASE_VS2017/X64/Python.efi.

 Modify the host path to match your build type and compiler.
 
@@ -115,12 +115,12 @@ system as follows:
 the \Efi\StdLib\lib\python36.8\lib-dynload directory.  This functionality 
is not
 yet implemented.
 
-  A script, create_python368_pkg.bat , is provided which facilitates the 
population
+  A script, create_python_pkg.bat , is provided which facilitates the 
population
   of the target EFI package.  Execute this script from within the
   AppPkg/Applications/Python/Python-3.6.8 directory, providing the Tool Chain, 
Target
   Build and destination directory which is the path to the destination 
directory.  
   The appropriate contents of the AppPkg/Applications/Python/Python-3.6.8/Lib 
and
-  Python368.efi Application from Build/AppPkg/RELEASE_VS2017/X64/ will be
+  Python.efi Application from Build/AppPkg/RELEASE_VS2017/X64/ will be
   ^^   
   copied into the specified destination directory.
 
@@ -130,10 +130,10 @@ system as follows:
 6. Example: Enabling socket support
 ===
   1.  enable {"_socket", init_socket}, in PyMod-3.6.8\Modules\config.c
-  2.  enable LibraryClasses BsdSocketLib and EfiSocketLib in Python368.inf.
-  3.  Build Python368
+  2.  enable LibraryClasses BsdSocketLib and EfiSocketLib in Python368.inf
+  3.  Build Python interpreter application using below command
   build -a X64 -p AppPkg\AppPkg.dsc
-  6.  copy Build\AppPkg\RELEASE_VS2017\X64\Python368.efi to \Efi\Tools on your
+  6.  copy Build\AppPkg\RELEASE_VS2017\X64\Python.efi to \Efi\Tools o