Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Jayaprakash, N > Sent: Wednesday, April 24, 2024 11:14 AM > To: devel@edk2.groups.io; Jayaprakash, N ; > Kinney, Michael D > Cc: Rebecca Cran > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & > wrmsr_ex functions to read/write cpu specific msrs > > Hi Mike, > > I have sent an updated patch v2 for review which uses the MP Services > protocol API StarupThisAP() to read / write MSRs specific to CPU cores. > Please review and do the needful. > > Regards, > JP > > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Jayaprakash, N > Sent: Thursday, April 18, 2024 11:49 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Rebecca Cran > Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & > wrmsr_ex functions to read/write cpu specific msrs > > Thanks Mike. I shall make necessary changes and submit the PR again for > review. > > Regards, > JP > > -Original Message- > From: Kinney, Michael D > Sent: Thursday, April 18, 2024 10:46 AM > To: Jayaprakash, N ; devel@edk2.groups.io > Cc: Rebecca Cran ; Kinney, Michael D > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & > wrmsr_ex functions to read/write cpu specific msrs > > Please use MP Services Protocol APIs StartupAllAPs() or StarupThisAP() > to read/write MSRs on other logical processors. > > There and many examples of this in the UefiCpuPkg to programming MSRs on > all the logical processors. > > Mike > > > -Original Message- > > From: Jayaprakash, N > > Sent: Wednesday, April 17, 2024 8:16 PM > > To: Kinney, Michael D ; > > devel@edk2.groups.io > > Cc: Rebecca Cran > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex > > & wrmsr_ex functions to read/write cpu specific msrs > > > > In the validation and debug scenarios, engineers tend to read MSRs and > > write to MSRs of different CPUs. > > So we are providing a simple mechanism through these APIs to enable > > them to do these operations. > > > > These APIs will be part of the edk2 module of the Python interpreter > > and will be used during the validation and debug scenarios only. > > > > This is not for switching the BSP for OS boot. This is only used > > during the validation and debug use cases. > > > > Regards, > > JP > > -----Original Message- > > From: Kinney, Michael D > > Sent: Thursday, April 18, 2024 12:08 AM > > To: Jayaprakash, N ; devel@edk2.groups.io > > Cc: Rebecca Cran ; Kinney, Michael D > > > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex > > & wrmsr_ex functions to read/write cpu specific msrs > > > > Hi JP, > > > > Is there a reason switch BSP is being used. That is not a common > > operation and is typically used if the current BSP is not stable or > > there is a good reason to switch the BSP for OS boot. > > > > The MP Services can be used to execute a C function on APs to execute > > MSR related instructions. > > > > Mike > > > > > -Original Message- > > > From: Jayaprakash, N > > > Sent: Sunday, April 14, 2024 10:33 PM > > > To: devel@edk2.groups.io; Jayaprakash, N > > > Cc: Rebecca Cran ; Kinney, Michael D > > > > > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add > > rdmsr_ex > > > & wrmsr_ex functions to read/write cpu specific msrs > > > > > > + Rebecca and Mike, > > > > > > Would you be able to review this PR? > > > > > > Regards, > > > JP > > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of > > > Jayaprakash, N > > > Sent: Wednesday, April 10, 2024 11:49 AM > > > To: devel@edk2.groups.io > > > Cc: Jayaprakash, N ; Rebecca Cran > > > ; Kinney, Michael D > > > Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & > > > wrmsr_ex functions to read/write cpu specific msrs > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746 > > > > > > The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr > > > APIs supported in edk2 module. These extension APIs makes it > > possible > > > to read / write MSRs from specific processors and fills an existing > > > gap in this area. > > > > > > Cc: Rebe
Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs
Hi Mike, I have sent an updated patch v2 for review which uses the MP Services protocol API StarupThisAP() to read / write MSRs specific to CPU cores. Please review and do the needful. Regards, JP -Original Message- From: devel@edk2.groups.io On Behalf Of Jayaprakash, N Sent: Thursday, April 18, 2024 11:49 AM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Rebecca Cran Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs Thanks Mike. I shall make necessary changes and submit the PR again for review. Regards, JP -Original Message- From: Kinney, Michael D Sent: Thursday, April 18, 2024 10:46 AM To: Jayaprakash, N ; devel@edk2.groups.io Cc: Rebecca Cran ; Kinney, Michael D Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs Please use MP Services Protocol APIs StartupAllAPs() or StarupThisAP() to read/write MSRs on other logical processors. There and many examples of this in the UefiCpuPkg to programming MSRs on all the logical processors. Mike > -Original Message- > From: Jayaprakash, N > Sent: Wednesday, April 17, 2024 8:16 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Rebecca Cran > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex > & wrmsr_ex functions to read/write cpu specific msrs > > In the validation and debug scenarios, engineers tend to read MSRs and > write to MSRs of different CPUs. > So we are providing a simple mechanism through these APIs to enable > them to do these operations. > > These APIs will be part of the edk2 module of the Python interpreter > and will be used during the validation and debug scenarios only. > > This is not for switching the BSP for OS boot. This is only used > during the validation and debug use cases. > > Regards, > JP > -Original Message- > From: Kinney, Michael D > Sent: Thursday, April 18, 2024 12:08 AM > To: Jayaprakash, N ; devel@edk2.groups.io > Cc: Rebecca Cran ; Kinney, Michael D > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex > & wrmsr_ex functions to read/write cpu specific msrs > > Hi JP, > > Is there a reason switch BSP is being used. That is not a common > operation and is typically used if the current BSP is not stable or > there is a good reason to switch the BSP for OS boot. > > The MP Services can be used to execute a C function on APs to execute > MSR related instructions. > > Mike > > > -Original Message- > > From: Jayaprakash, N > > Sent: Sunday, April 14, 2024 10:33 PM > > To: devel@edk2.groups.io; Jayaprakash, N > > Cc: Rebecca Cran ; Kinney, Michael D > > > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add > rdmsr_ex > > & wrmsr_ex functions to read/write cpu specific msrs > > > > + Rebecca and Mike, > > > > Would you be able to review this PR? > > > > Regards, > > JP > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > Jayaprakash, N > > Sent: Wednesday, April 10, 2024 11:49 AM > > To: devel@edk2.groups.io > > Cc: Jayaprakash, N ; Rebecca Cran > > ; Kinney, Michael D > > Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & > > wrmsr_ex functions to read/write cpu specific msrs > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746 > > > > The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr > > APIs supported in edk2 module. These extension APIs makes it > possible > > to read / write MSRs from specific processors and fills an existing > > gap in this area. > > > > Cc: Rebecca Cran > > Cc: Michael D Kinney > > Cc: Jayaprakash N > > Signed-off-by: Jayaprakash N > > --- > > .../PyMod-3.6.8/Modules/edk2module.c | 159 > > +- > > .../Python/Python-3.6.8/Python368.inf | 3 + > > 2 files changed, 158 insertions(+), 4 deletions(-) > > > > diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod- > > 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python- > > 3.6.8/PyMod-3.6.8/Modules/edk2module.c > > index d6af8da..f1b13a6 100644 > > --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod- > > 3.6.8/Modules/edk2module.c > > +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod- > > 3.6.8/Modules/edk2mo > > +++ dule.c > > @@ -3,7 +3,7 @@ > > Derived from posixmodule.c in Python 2.7.2. > > > > Copyright (c) 2015, Daryl McDani
Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs
Thanks Mike. I shall make necessary changes and submit the PR again for review. Regards, JP -Original Message- From: Kinney, Michael D Sent: Thursday, April 18, 2024 10:46 AM To: Jayaprakash, N ; devel@edk2.groups.io Cc: Rebecca Cran ; Kinney, Michael D Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs Please use MP Services Protocol APIs StartupAllAPs() or StarupThisAP() to read/write MSRs on other logical processors. There and many examples of this in the UefiCpuPkg to programming MSRs on all the logical processors. Mike > -Original Message- > From: Jayaprakash, N > Sent: Wednesday, April 17, 2024 8:16 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Rebecca Cran > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex > & wrmsr_ex functions to read/write cpu specific msrs > > In the validation and debug scenarios, engineers tend to read MSRs and > write to MSRs of different CPUs. > So we are providing a simple mechanism through these APIs to enable > them to do these operations. > > These APIs will be part of the edk2 module of the Python interpreter > and will be used during the validation and debug scenarios only. > > This is not for switching the BSP for OS boot. This is only used > during the validation and debug use cases. > > Regards, > JP > -Original Message- > From: Kinney, Michael D > Sent: Thursday, April 18, 2024 12:08 AM > To: Jayaprakash, N ; devel@edk2.groups.io > Cc: Rebecca Cran ; Kinney, Michael D > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex > & wrmsr_ex functions to read/write cpu specific msrs > > Hi JP, > > Is there a reason switch BSP is being used. That is not a common > operation and is typically used if the current BSP is not stable or > there is a good reason to switch the BSP for OS boot. > > The MP Services can be used to execute a C function on APs to execute > MSR related instructions. > > Mike > > > -Original Message- > > From: Jayaprakash, N > > Sent: Sunday, April 14, 2024 10:33 PM > > To: devel@edk2.groups.io; Jayaprakash, N > > Cc: Rebecca Cran ; Kinney, Michael D > > > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add > rdmsr_ex > > & wrmsr_ex functions to read/write cpu specific msrs > > > > + Rebecca and Mike, > > > > Would you be able to review this PR? > > > > Regards, > > JP > > > > -----Original Message- > > From: devel@edk2.groups.io On Behalf Of > > Jayaprakash, N > > Sent: Wednesday, April 10, 2024 11:49 AM > > To: devel@edk2.groups.io > > Cc: Jayaprakash, N ; Rebecca Cran > > ; Kinney, Michael D > > Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & > > wrmsr_ex functions to read/write cpu specific msrs > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746 > > > > The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr > > APIs supported in edk2 module. These extension APIs makes it > possible > > to read / write MSRs from specific processors and fills an existing > > gap in this area. > > > > Cc: Rebecca Cran > > Cc: Michael D Kinney > > Cc: Jayaprakash N > > Signed-off-by: Jayaprakash N > > --- > > .../PyMod-3.6.8/Modules/edk2module.c | 159 > > +- > > .../Python/Python-3.6.8/Python368.inf | 3 + > > 2 files changed, 158 insertions(+), 4 deletions(-) > > > > diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod- > > 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python- > > 3.6.8/PyMod-3.6.8/Modules/edk2module.c > > index d6af8da..f1b13a6 100644 > > --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod- > > 3.6.8/Modules/edk2module.c > > +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod- > > 3.6.8/Modules/edk2mo > > +++ dule.c > > @@ -3,7 +3,7 @@ > > Derived from posixmodule.c in Python 2.7.2. > > > > Copyright (c) 2015, Daryl McDaniel. All rights reserved. > > -Copyright (c) 2011 - 2023, Intel Corporation. All rights > > reserved. > > +Copyright (c) 2011 - 2024, Intel Corporation. All rights > > + reserved. > > This program and the accompanying materials are licensed and > made > > available under > > the terms and conditions of the BSD License that accompanies > this > > distribution. > > The full text of the license may be found at @@ -22,16 +22,23 > @@ >
Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs
Please use MP Services Protocol APIs StartupAllAPs() or StarupThisAP()
to read/write MSRs on other logical processors.
There and many examples of this in the UefiCpuPkg to programming MSRs
on all the logical processors.
Mike
> -Original Message-
> From: Jayaprakash, N
> Sent: Wednesday, April 17, 2024 8:16 PM
> To: Kinney, Michael D ;
> devel@edk2.groups.io
> Cc: Rebecca Cran
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex
> & wrmsr_ex functions to read/write cpu specific msrs
>
> In the validation and debug scenarios, engineers tend to read MSRs and
> write to MSRs of different CPUs.
> So we are providing a simple mechanism through these APIs to enable
> them to do these operations.
>
> These APIs will be part of the edk2 module of the Python interpreter
> and will be used during the validation and debug scenarios only.
>
> This is not for switching the BSP for OS boot. This is only used
> during the validation and debug use cases.
>
> Regards,
> JP
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, April 18, 2024 12:08 AM
> To: Jayaprakash, N ; devel@edk2.groups.io
> Cc: Rebecca Cran ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex
> & wrmsr_ex functions to read/write cpu specific msrs
>
> Hi JP,
>
> Is there a reason switch BSP is being used. That is not a common
> operation and is typically used if the current BSP is not stable or
> there is a good reason to switch the BSP for OS boot.
>
> The MP Services can be used to execute a C function on APs to execute
> MSR related instructions.
>
> Mike
>
> > -Original Message-
> > From: Jayaprakash, N
> > Sent: Sunday, April 14, 2024 10:33 PM
> > To: devel@edk2.groups.io; Jayaprakash, N
> > Cc: Rebecca Cran ; Kinney, Michael D
> >
> > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add
> rdmsr_ex
> > & wrmsr_ex functions to read/write cpu specific msrs
> >
> > + Rebecca and Mike,
> >
> > Would you be able to review this PR?
> >
> > Regards,
> > JP
> >
> > -----Original Message-
> > From: devel@edk2.groups.io On Behalf Of
> > Jayaprakash, N
> > Sent: Wednesday, April 10, 2024 11:49 AM
> > To: devel@edk2.groups.io
> > Cc: Jayaprakash, N ; Rebecca Cran
> > ; Kinney, Michael D
> > Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex &
> > wrmsr_ex functions to read/write cpu specific msrs
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
> >
> > The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr
> > APIs supported in edk2 module. These extension APIs makes it
> possible
> > to read / write MSRs from specific processors and fills an existing
> > gap in this area.
> >
> > Cc: Rebecca Cran
> > Cc: Michael D Kinney
> > Cc: Jayaprakash N
> > Signed-off-by: Jayaprakash N
> > ---
> > .../PyMod-3.6.8/Modules/edk2module.c | 159
> > +-
> > .../Python/Python-3.6.8/Python368.inf | 3 +
> > 2 files changed, 158 insertions(+), 4 deletions(-)
> >
> > diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> > 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-
> > 3.6.8/PyMod-3.6.8/Modules/edk2module.c
> > index d6af8da..f1b13a6 100644
> > --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> > 3.6.8/Modules/edk2module.c
> > +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> > 3.6.8/Modules/edk2mo
> > +++ dule.c
> > @@ -3,7 +3,7 @@
> > Derived from posixmodule.c in Python 2.7.2.
> >
> > Copyright (c) 2015, Daryl McDaniel. All rights reserved.
> > -Copyright (c) 2011 - 2023, Intel Corporation. All rights
> > reserved.
> > +Copyright (c) 2011 - 2024, Intel Corporation. All rights
> > + reserved.
> > This program and the accompanying materials are licensed and
> made
> > available under
> > the terms and conditions of the BSD License that accompanies
> this
> > distribution.
> > The full text of the license may be found at @@ -22,16 +22,23
> @@
> > #include#include#include
> > +#include// Needed for the definition of
> > EFI_AP_PROCEDURE
> > #include
> > #include
> > #include
> > #include
> > +#include
> > +#include
> >
> > #ifdef __cplusplus
> > extern "C" {
> > #endif
> >
> > PyTypeObject EfiGuidType;
> > +EFI_MP_S
Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs
In the validation and debug scenarios, engineers tend to read MSRs and write to
MSRs of different CPUs.
So we are providing a simple mechanism through these APIs to enable them to do
these operations.
These APIs will be part of the edk2 module of the Python interpreter and will
be used during the validation and debug scenarios only.
This is not for switching the BSP for OS boot. This is only used during the
validation and debug use cases.
Regards,
JP
-Original Message-
From: Kinney, Michael D
Sent: Thursday, April 18, 2024 12:08 AM
To: Jayaprakash, N ; devel@edk2.groups.io
Cc: Rebecca Cran ; Kinney, Michael D
Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex &
wrmsr_ex functions to read/write cpu specific msrs
Hi JP,
Is there a reason switch BSP is being used. That is not a common operation and
is typically used if the current BSP is not stable or there is a good reason to
switch the BSP for OS boot.
The MP Services can be used to execute a C function on APs to execute MSR
related instructions.
Mike
> -Original Message-
> From: Jayaprakash, N
> Sent: Sunday, April 14, 2024 10:33 PM
> To: devel@edk2.groups.io; Jayaprakash, N
> Cc: Rebecca Cran ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex
> & wrmsr_ex functions to read/write cpu specific msrs
>
> + Rebecca and Mike,
>
> Would you be able to review this PR?
>
> Regards,
> JP
>
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Jayaprakash, N
> Sent: Wednesday, April 10, 2024 11:49 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D
> Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex &
> wrmsr_ex functions to read/write cpu specific msrs
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
>
> The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr
> APIs supported in edk2 module. These extension APIs makes it possible
> to read / write MSRs from specific processors and fills an existing
> gap in this area.
>
> Cc: Rebecca Cran
> Cc: Michael D Kinney
> Cc: Jayaprakash N
> Signed-off-by: Jayaprakash N
> ---
> .../PyMod-3.6.8/Modules/edk2module.c | 159
> +-
> .../Python/Python-3.6.8/Python368.inf | 3 +
> 2 files changed, 158 insertions(+), 4 deletions(-)
>
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-
> 3.6.8/PyMod-3.6.8/Modules/edk2module.c
> index d6af8da..f1b13a6 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2mo
> +++ dule.c
> @@ -3,7 +3,7 @@
> Derived from posixmodule.c in Python 2.7.2.
>
> Copyright (c) 2015, Daryl McDaniel. All rights reserved.
> -Copyright (c) 2011 - 2023, Intel Corporation. All rights
> reserved.
> +Copyright (c) 2011 - 2024, Intel Corporation. All rights
> + reserved.
> This program and the accompanying materials are licensed and made
> available under
> the terms and conditions of the BSD License that accompanies this
> distribution.
> The full text of the license may be found at @@ -22,16 +22,23 @@
> #include#include#include
> +#include// Needed for the definition of
> EFI_AP_PROCEDURE
> #include
> #include
> #include
> #include
> +#include
> +#include
>
> #ifdef __cplusplus
> extern "C" {
> #endif
>
> PyTypeObject EfiGuidType;
> +EFI_MP_SERVICES_PROTOCOL *gpMpService = NULL;
> +UINTN gBSPProcessorNumber = 0;
> +UINTN gNumberOfProcessors = 0;
> +UINTN gNumberOfEnabledProcessors = 0;
>
> extern void _swsmi( unsigned int smi_code_data, unsigned int
> rax_value, unsigned int rbx_value, unsigned int rcx_value, unsigned
> int rdx_value, unsigned int rsi_value, unsigned int rdi_value ); // -
> - Support routines @@ -169,6 +176,35 @@ PyDoc_STRVAR(edk2__doc__,
> /* dummy version. _PyVerify_fd() is already defined in fileobject.h
> */ #define _PyVerify_fd_dup2(A, B) (1)
>
> +static EFI_STATUS
> +MpServicesWhoAmI (
> + IN EFI_MP_SERVICES_PROTOCOL *pMpService,
> + OUT UINTN*pProcessorNumber
> + )
> +{
> + return pMpService->WhoAmI (pMpService, pProcessorNumber); }
> +
> +static EFI_STATUS
> +MpServicesGetNumberOfProcessors (
> + IN EFI_MP_SERVICES_PROTOCOL *pMpService,
> + OUT UINTN*pNumberOfProcessors,
> + OUT UINTN*pNumberOfEn
Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs
Hi JP,
Is there a reason switch BSP is being used. That is not a common operation
and is typically used if the current BSP is not stable or there is a good
reason to switch the BSP for OS boot.
The MP Services can be used to execute a C function on APs to execute
MSR related instructions.
Mike
> -Original Message-
> From: Jayaprakash, N
> Sent: Sunday, April 14, 2024 10:33 PM
> To: devel@edk2.groups.io; Jayaprakash, N
> Cc: Rebecca Cran ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex
> & wrmsr_ex functions to read/write cpu specific msrs
>
> + Rebecca and Mike,
>
> Would you be able to review this PR?
>
> Regards,
> JP
>
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Jayaprakash, N
> Sent: Wednesday, April 10, 2024 11:49 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D
> Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex &
> wrmsr_ex functions to read/write cpu specific msrs
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
>
> The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr
> APIs supported in edk2 module. These extension APIs makes it possible
> to read / write MSRs from specific processors and fills an existing
> gap in this area.
>
> Cc: Rebecca Cran
> Cc: Michael D Kinney
> Cc: Jayaprakash N
> Signed-off-by: Jayaprakash N
> ---
> .../PyMod-3.6.8/Modules/edk2module.c | 159
> +-
> .../Python/Python-3.6.8/Python368.inf | 3 +
> 2 files changed, 158 insertions(+), 4 deletions(-)
>
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-
> 3.6.8/PyMod-3.6.8/Modules/edk2module.c
> index d6af8da..f1b13a6 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2mo
> +++ dule.c
> @@ -3,7 +3,7 @@
> Derived from posixmodule.c in Python 2.7.2.
>
> Copyright (c) 2015, Daryl McDaniel. All rights reserved.
> -Copyright (c) 2011 - 2023, Intel Corporation. All rights
> reserved.
> +Copyright (c) 2011 - 2024, Intel Corporation. All rights
> + reserved.
> This program and the accompanying materials are licensed and made
> available under
> the terms and conditions of the BSD License that accompanies this
> distribution.
> The full text of the license may be found at @@ -22,16 +22,23 @@
> #include#include#include
> +#include// Needed for the definition of
> EFI_AP_PROCEDURE
> #include
> #include
> #include
> #include
> +#include
> +#include
>
> #ifdef __cplusplus
> extern "C" {
> #endif
>
> PyTypeObject EfiGuidType;
> +EFI_MP_SERVICES_PROTOCOL *gpMpService = NULL;
> +UINTN gBSPProcessorNumber = 0;
> +UINTN gNumberOfProcessors = 0;
> +UINTN gNumberOfEnabledProcessors = 0;
>
> extern void _swsmi( unsigned int smi_code_data, unsigned int
> rax_value, unsigned int rbx_value, unsigned int rcx_value, unsigned
> int rdx_value, unsigned int rsi_value, unsigned int rdi_value ); // -
> - Support routines @@ -169,6 +176,35 @@ PyDoc_STRVAR(edk2__doc__,
> /* dummy version. _PyVerify_fd() is already defined in fileobject.h
> */ #define _PyVerify_fd_dup2(A, B) (1)
>
> +static EFI_STATUS
> +MpServicesWhoAmI (
> + IN EFI_MP_SERVICES_PROTOCOL *pMpService,
> + OUT UINTN*pProcessorNumber
> + )
> +{
> + return pMpService->WhoAmI (pMpService, pProcessorNumber); }
> +
> +static EFI_STATUS
> +MpServicesGetNumberOfProcessors (
> + IN EFI_MP_SERVICES_PROTOCOL *pMpService,
> + OUT UINTN*pNumberOfProcessors,
> + OUT UINTN*pNumberOfEnabledProcessors
> +
> + )
> +{
> + return pMpService->GetNumberOfProcessors (pMpService,
> +pNumberOfProcessors, pNumberOfEnabledProcessors); }
> +
> +static EFI_STATUS
> +MpServicesSwitchBSP (
> + IN EFI_MP_SERVICES_PROTOCOL *pMpService,
> + IN UINTN ProcessorNumber
> + )
> +{
> + return pMpService->SwitchBSP(pMpService, ProcessorNumber, TRUE); }
> +
> #ifndef UEFI_C_SOURCE
> /* Return a dictionary corresponding to the POSIX environment table
> */ extern char **environ; @@ -3865,6 +3901,56 @@ edk2_rdmsr(PyObject
> *self, PyObject *args)
>return Py_BuildValue("(II)", (unsigned long)veax, (unsigned
> long)vedx); }
>
> +PyDoc_STRVAR(efi_rdmsr_ex__doc__,
>
Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs
+ Rebecca and Mike,
Would you be able to review this PR?
Regards,
JP
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jayaprakash, N
Sent: Wednesday, April 10, 2024 11:49 AM
To: devel@edk2.groups.io
Cc: Jayaprakash, N ; Rebecca Cran ;
Kinney, Michael D
Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex
functions to read/write cpu specific msrs
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr APIs
supported in edk2 module. These extension APIs makes it possible to read /
write MSRs from specific processors and fills an existing gap in this area.
Cc: Rebecca Cran
Cc: Michael D Kinney
Cc: Jayaprakash N
Signed-off-by: Jayaprakash N
---
.../PyMod-3.6.8/Modules/edk2module.c | 159 +-
.../Python/Python-3.6.8/Python368.inf | 3 +
2 files changed, 158 insertions(+), 4 deletions(-)
diff --git
a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
index d6af8da..f1b13a6 100644
--- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
+++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2mo
+++ dule.c
@@ -3,7 +3,7 @@
Derived from posixmodule.c in Python 2.7.2.
Copyright (c) 2015, Daryl McDaniel. All rights reserved.
-Copyright (c) 2011 - 2023, Intel Corporation. All rights reserved.
+Copyright (c) 2011 - 2024, Intel Corporation. All rights
+ reserved.
This program and the accompanying materials are licensed and made
available under
the terms and conditions of the BSD License that accompanies this
distribution.
The full text of the license may be found at @@ -22,16 +22,23 @@ #include
#include#include
+#include// Needed for the definition of EFI_AP_PROCEDURE
#include
#include
#include
#include
+#include
+#include
#ifdef __cplusplus
extern "C" {
#endif
PyTypeObject EfiGuidType;
+EFI_MP_SERVICES_PROTOCOL *gpMpService = NULL;
+UINTN gBSPProcessorNumber = 0;
+UINTN gNumberOfProcessors = 0;
+UINTN gNumberOfEnabledProcessors = 0;
extern void _swsmi( unsigned int smi_code_data, unsigned int rax_value,
unsigned int rbx_value, unsigned int rcx_value, unsigned int rdx_value,
unsigned int rsi_value, unsigned int rdi_value ); // -- Support routines @@
-169,6 +176,35 @@ PyDoc_STRVAR(edk2__doc__,
/* dummy version. _PyVerify_fd() is already defined in fileobject.h */
#define _PyVerify_fd_dup2(A, B) (1)
+static EFI_STATUS
+MpServicesWhoAmI (
+ IN EFI_MP_SERVICES_PROTOCOL *pMpService,
+ OUT UINTN*pProcessorNumber
+ )
+{
+ return pMpService->WhoAmI (pMpService, pProcessorNumber); }
+
+static EFI_STATUS
+MpServicesGetNumberOfProcessors (
+ IN EFI_MP_SERVICES_PROTOCOL *pMpService,
+ OUT UINTN*pNumberOfProcessors,
+ OUT UINTN*pNumberOfEnabledProcessors
+
+ )
+{
+ return pMpService->GetNumberOfProcessors (pMpService,
+pNumberOfProcessors, pNumberOfEnabledProcessors); }
+
+static EFI_STATUS
+MpServicesSwitchBSP (
+ IN EFI_MP_SERVICES_PROTOCOL *pMpService,
+ IN UINTN ProcessorNumber
+ )
+{
+ return pMpService->SwitchBSP(pMpService, ProcessorNumber, TRUE); }
+
#ifndef UEFI_C_SOURCE
/* Return a dictionary corresponding to the POSIX environment table */ extern
char **environ; @@ -3865,6 +3901,56 @@ edk2_rdmsr(PyObject *self, PyObject
*args)
return Py_BuildValue("(II)", (unsigned long)veax, (unsigned long)vedx); }
+PyDoc_STRVAR(efi_rdmsr_ex__doc__,
+"rdmsr_ex(cpu, msr) -> (lower_32bits, higher_32bits)\n\ \n\ Read the
+given msr by switching to cpu and return the data as tuple.\n\ \n\
+Parameters:\n\
+cpu - The cpu number in hex or int format\n\
+msr - The msr in hex or int format\n\ \n\ Return Value:\n\
+a tuple with lower and higher 32 bit values read from the msr\n\
+");
+
+static PyObject *
+edk2_rdmsr_ex(PyObject *self, PyObject *args) {
+ unsigned int cpu, vecx, veax, vedx;
+ unsigned int bsp_switched = 0;
+ EFI_STATUS status = 0;
+ UINT64 data = 0;
+
+ if (!PyArg_ParseTuple(args, "II", &cpu, &vecx))
+return NULL;
+
+ Py_BEGIN_ALLOW_THREADS
+ if (cpu != gBSPProcessorNumber && cpu < gNumberOfProcessors) {
+//switch the BSP to the cpu
+status = MpServicesSwitchBSP(gpMpService, cpu);
+if (!EFI_ERROR(status))
+{
+bsp_switched = 1;
+}
+ }
+
+ data = AsmReadMsr64(vecx);
+
+ if (bsp_switched)
+ {
+// switch BSP to the saved BSP processor
+MpServicesSwitchBSP(gpMpService, gBSPProcessorNumber);
+// update the saved BSP processor
+MpServicesWhoAmI(gpMpService, &gBSPProcessorNumber);
+ }
+ Py_END_ALLOW_THREADS
+ veax = (UINT3
[edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr APIs
supported in edk2 module. These extension APIs makes it possible
to read / write MSRs from specific processors and fills an existing gap
in this area.
Cc: Rebecca Cran
Cc: Michael D Kinney
Cc: Jayaprakash N
Signed-off-by: Jayaprakash N
---
.../PyMod-3.6.8/Modules/edk2module.c | 159 +-
.../Python/Python-3.6.8/Python368.inf | 3 +
2 files changed, 158 insertions(+), 4 deletions(-)
diff --git
a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
index d6af8da..f1b13a6 100644
--- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
+++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
@@ -3,7 +3,7 @@
Derived from posixmodule.c in Python 2.7.2.
Copyright (c) 2015, Daryl McDaniel. All rights reserved.
-Copyright (c) 2011 - 2023, Intel Corporation. All rights reserved.
+Copyright (c) 2011 - 2024, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made
available under
the terms and conditions of the BSD License that accompanies this
distribution.
The full text of the license may be found at
@@ -22,16 +22,23 @@
#include
#include
#include
+#include// Needed for the definition of EFI_AP_PROCEDURE
#include
#include
#include
#include
+#include
+#include
#ifdef __cplusplus
extern "C" {
#endif
PyTypeObject EfiGuidType;
+EFI_MP_SERVICES_PROTOCOL *gpMpService = NULL;
+UINTN gBSPProcessorNumber = 0;
+UINTN gNumberOfProcessors = 0;
+UINTN gNumberOfEnabledProcessors = 0;
extern void _swsmi( unsigned int smi_code_data, unsigned int rax_value,
unsigned int rbx_value, unsigned int rcx_value, unsigned int rdx_value,
unsigned int rsi_value, unsigned int rdi_value );
// -- Support routines
@@ -169,6 +176,35 @@ PyDoc_STRVAR(edk2__doc__,
/* dummy version. _PyVerify_fd() is already defined in fileobject.h */
#define _PyVerify_fd_dup2(A, B) (1)
+static EFI_STATUS
+MpServicesWhoAmI (
+ IN EFI_MP_SERVICES_PROTOCOL *pMpService,
+ OUT UINTN*pProcessorNumber
+ )
+{
+ return pMpService->WhoAmI (pMpService, pProcessorNumber);
+}
+
+static EFI_STATUS
+MpServicesGetNumberOfProcessors (
+ IN EFI_MP_SERVICES_PROTOCOL *pMpService,
+ OUT UINTN*pNumberOfProcessors,
+ OUT UINTN*pNumberOfEnabledProcessors
+
+ )
+{
+ return pMpService->GetNumberOfProcessors (pMpService, pNumberOfProcessors,
pNumberOfEnabledProcessors);
+}
+
+static EFI_STATUS
+MpServicesSwitchBSP (
+ IN EFI_MP_SERVICES_PROTOCOL *pMpService,
+ IN UINTN ProcessorNumber
+ )
+{
+ return pMpService->SwitchBSP(pMpService, ProcessorNumber, TRUE);
+}
+
#ifndef UEFI_C_SOURCE
/* Return a dictionary corresponding to the POSIX environment table */
extern char **environ;
@@ -3865,6 +3901,56 @@ edk2_rdmsr(PyObject *self, PyObject *args)
return Py_BuildValue("(II)", (unsigned long)veax, (unsigned long)vedx);
}
+PyDoc_STRVAR(efi_rdmsr_ex__doc__,
+"rdmsr_ex(cpu, msr) -> (lower_32bits, higher_32bits)\n\
+\n\
+Read the given msr by switching to cpu and return the data as tuple.\n\
+\n\
+Parameters:\n\
+cpu - The cpu number in hex or int format\n\
+msr - The msr in hex or int format\n\
+\n\
+Return Value:\n\
+a tuple with lower and higher 32 bit values read from the msr\n\
+");
+
+static PyObject *
+edk2_rdmsr_ex(PyObject *self, PyObject *args)
+{
+ unsigned int cpu, vecx, veax, vedx;
+ unsigned int bsp_switched = 0;
+ EFI_STATUS status = 0;
+ UINT64 data = 0;
+
+ if (!PyArg_ParseTuple(args, "II", &cpu, &vecx))
+return NULL;
+
+ Py_BEGIN_ALLOW_THREADS
+ if (cpu != gBSPProcessorNumber && cpu < gNumberOfProcessors)
+ {
+//switch the BSP to the cpu
+status = MpServicesSwitchBSP(gpMpService, cpu);
+if (!EFI_ERROR(status))
+{
+bsp_switched = 1;
+}
+ }
+
+ data = AsmReadMsr64(vecx);
+
+ if (bsp_switched)
+ {
+// switch BSP to the saved BSP processor
+MpServicesSwitchBSP(gpMpService, gBSPProcessorNumber);
+// update the saved BSP processor
+MpServicesWhoAmI(gpMpService, &gBSPProcessorNumber);
+ }
+ Py_END_ALLOW_THREADS
+ veax = (UINT32)data;
+ vedx = (UINT64)data >> 32;
+ return Py_BuildValue("(II)", (unsigned long)veax, (unsigned long)vedx);
+}
+
PyDoc_STRVAR(efi_wrmsr__doc__,
"wrmsr(msr, lower_32bits, higher_32bits) -> None\n\
\n\
@@ -3889,6 +3975,58 @@ edk2_wrmsr(PyObject *self, PyObject *args)
data = vedx << 32 | veax;
Py_BEGIN_ALLOW_THREADS
AsmWriteMsr64(vecx, data);
+ Py_END_ALLOW_THREADS
+ Py_INCREF(Py_None);
+ return Py_None;
+}
+
+PyDoc_STRVAR(efi_wrmsr_ex__doc__,
+"wrmsr_ex(cpu, msr, lower
