Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard
On 10/26/23 16:17, Jayaprakash, N wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4574
>
> This commit is for processing the below PR on edk2-libc repo
> https://github.com/tianocore/edk2-libc/pull/10
> The realpath function signature in stdlib of edk2-libc doesn't match
> signature as per the standard definition of this function given below
> https://pubs.opengroup.org/onlinepubs/009695399/functions/realpath.html
> This patch extracted from the above pull request fixes this issue.
>
> Cc: Rebecca Cran
> Cc: Michael D Kinney
> Cc: Jayaprakash N
> Signed-off-by: Kloper Dimitry
> ---
> StdLib/Include/stdlib.h | 4 ++--
> StdLib/LibC/StdLib/realpath.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/StdLib/Include/stdlib.h b/StdLib/Include/stdlib.h
> index 0b9dfd3..022ddbd 100644
> --- a/StdLib/Include/stdlib.h
> +++ b/StdLib/Include/stdlib.h
> @@ -74,7 +74,7 @@
> const wchar_t * __restrict src, size_t limit);
>
> Miscelaneous functions for *nix compatibility
> -char *realpath(char *file_name, char *resolved_name);
> +char *realpath(const char *file_name, char *resolved_name);
> const char *getprogname (void);
> voidsetprogname (const char *progname);
>
> @@ -875,7 +875,7 @@ size_t wcstombs(char * __restrict Dest, const wchar_t *
> __restrict Src, size_t
> @retval NULLAn error occured.
> @retval resolved_name.
> **/
> -char * realpath(char *file_name, char *resolved_name);
> +char * realpath(const char *file_name, char *resolved_name);
>
> /** The getprogname() function returns the name of the program. If the name
> has not been set yet, it will return NULL.
> diff --git a/StdLib/LibC/StdLib/realpath.c b/StdLib/LibC/StdLib/realpath.c
> index 3d4118d..29abe9a 100644
> --- a/StdLib/LibC/StdLib/realpath.c
> +++ b/StdLib/LibC/StdLib/realpath.c
> @@ -34,7 +34,7 @@
> **/
> char *
> realpath(
> - char *file_name,
> + const char *file_name,
>char *resolved_name
>)
> {
Reviewed-by: Laszlo Ersek
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110124): https://edk2.groups.io/g/devel/message/110124
Mute This Topic: https://groups.io/mt/102200532/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard
Reviewed-by: Jayaprakash Nevara
It's simple fix to align the function signature as per the standards.
Regards,
JP
-Original Message-
From: Jayaprakash, N
Sent: Thursday, October 26, 2023 7:47 PM
To: devel@edk2.groups.io
Cc: Jayaprakash, N ; Rebecca Cran ;
Kinney, Michael D ; Kloper, Dimitry
Subject: [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't
match the standard
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4574
This commit is for processing the below PR on edk2-libc repo
https://github.com/tianocore/edk2-libc/pull/10
The realpath function signature in stdlib of edk2-libc doesn't match signature
as per the standard definition of this function given below
https://pubs.opengroup.org/onlinepubs/009695399/functions/realpath.html
This patch extracted from the above pull request fixes this issue.
Cc: Rebecca Cran
Cc: Michael D Kinney
Cc: Jayaprakash N
Signed-off-by: Kloper Dimitry
---
StdLib/Include/stdlib.h | 4 ++--
StdLib/LibC/StdLib/realpath.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/StdLib/Include/stdlib.h b/StdLib/Include/stdlib.h index
0b9dfd3..022ddbd 100644
--- a/StdLib/Include/stdlib.h
+++ b/StdLib/Include/stdlib.h
@@ -74,7 +74,7 @@
const wchar_t * __restrict src, size_t limit);
Miscelaneous functions for *nix compatibility
-char *realpath(char *file_name, char *resolved_name);
+char *realpath(const char *file_name, char *resolved_name);
const char *getprogname (void);
voidsetprogname (const char *progname);
@@ -875,7 +875,7 @@ size_t wcstombs(char * __restrict Dest, const wchar_t *
__restrict Src, size_t
@retval NULLAn error occured.
@retval resolved_name.
**/
-char * realpath(char *file_name, char *resolved_name);
+char * realpath(const char *file_name, char *resolved_name);
/** The getprogname() function returns the name of the program. If the name
has not been set yet, it will return NULL.
diff --git a/StdLib/LibC/StdLib/realpath.c b/StdLib/LibC/StdLib/realpath.c
index 3d4118d..29abe9a 100644
--- a/StdLib/LibC/StdLib/realpath.c
+++ b/StdLib/LibC/StdLib/realpath.c
@@ -34,7 +34,7 @@
**/
char *
realpath(
- char *file_name,
+ const char *file_name,
char *resolved_name
)
{
--
2.40.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110121): https://edk2.groups.io/g/devel/message/110121
Mute This Topic: https://groups.io/mt/102200532/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4574
This commit is for processing the below PR on edk2-libc repo
https://github.com/tianocore/edk2-libc/pull/10
The realpath function signature in stdlib of edk2-libc doesn't match
signature as per the standard definition of this function given below
https://pubs.opengroup.org/onlinepubs/009695399/functions/realpath.html
This patch extracted from the above pull request fixes this issue.
Cc: Rebecca Cran
Cc: Michael D Kinney
Cc: Jayaprakash N
Signed-off-by: Kloper Dimitry
---
StdLib/Include/stdlib.h | 4 ++--
StdLib/LibC/StdLib/realpath.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/StdLib/Include/stdlib.h b/StdLib/Include/stdlib.h
index 0b9dfd3..022ddbd 100644
--- a/StdLib/Include/stdlib.h
+++ b/StdLib/Include/stdlib.h
@@ -74,7 +74,7 @@
const wchar_t * __restrict src, size_t limit);
Miscelaneous functions for *nix compatibility
-char *realpath(char *file_name, char *resolved_name);
+char *realpath(const char *file_name, char *resolved_name);
const char *getprogname (void);
voidsetprogname (const char *progname);
@@ -875,7 +875,7 @@ size_t wcstombs(char * __restrict Dest, const wchar_t *
__restrict Src, size_t
@retval NULLAn error occured.
@retval resolved_name.
**/
-char * realpath(char *file_name, char *resolved_name);
+char * realpath(const char *file_name, char *resolved_name);
/** The getprogname() function returns the name of the program. If the name
has not been set yet, it will return NULL.
diff --git a/StdLib/LibC/StdLib/realpath.c b/StdLib/LibC/StdLib/realpath.c
index 3d4118d..29abe9a 100644
--- a/StdLib/LibC/StdLib/realpath.c
+++ b/StdLib/LibC/StdLib/realpath.c
@@ -34,7 +34,7 @@
**/
char *
realpath(
- char *file_name,
+ const char *file_name,
char *resolved_name
)
{
--
2.40.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110106): https://edk2.groups.io/g/devel/message/110106
Mute This Topic: https://groups.io/mt/102200532/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
