Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: socket module of python UEFI fails to compile with GCC

2023-08-31 Thread Michael D Kinney
Reviewed-by: Michael D Kinney 

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Thursday, August 31, 2023 9:13 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch 1/1] ek2-libc: socket module of python UEFI
> fails to compile with GCC
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4545
> 
> The compilation issues reported in the BZ are fixed by
> defining below 2 macros in pyconfig.h
> HAVE_ADDRINFO
> HAVE_SOCKADDR_STORAGE
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h| 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h
> index 3b9eceb..983cfda 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Include/pyconfig.h
> @@ -66,7 +66,7 @@
>  #undef HAVE_ACOSH
> 
>  /* struct addrinfo (netdb.h) */
> -#undef HAVE_ADDRINFO
> +#define HAVE_ADDRINFO   1
> 
>  /* Define to 1 if you have the 'alarm' function. */
>  #undef HAVE_ALARM
> @@ -683,7 +683,7 @@
>  #undef HAVE_SOCKADDR_SA_LEN
> 
>  /* struct sockaddr_storage (sys/socket.h) */
> -#undef HAVE_SOCKADDR_STORAGE
> +#define HAVE_SOCKADDR_STORAGE   1
> 
>  /* Define if you have the 'socketpair' function. */
>  #undef HAVE_SOCKETPAIR
> --
> 2.40.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108202): https://edk2.groups.io/g/devel/message/108202
Mute This Topic: https://groups.io/mt/101077159/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: 
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [edk2-libc Patch 1/1] ek2-libc: socket module of python UEFI fails to compile with GCC

2023-08-31 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4545

The compilation issues reported in the BZ are fixed by
defining below 2 macros in pyconfig.h
HAVE_ADDRINFO
HAVE_SOCKADDR_STORAGE

Cc: Rebecca Cran 
Cc: Michael D Kinney 
Cc: Jayaprakash N 
Signed-off-by: Jayaprakash N 
---
 .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h| 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h 
b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
index 3b9eceb..983cfda 100644
--- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
+++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h
@@ -66,7 +66,7 @@
 #undef HAVE_ACOSH
 
 /* struct addrinfo (netdb.h) */
-#undef HAVE_ADDRINFO
+#define HAVE_ADDRINFO   1
 
 /* Define to 1 if you have the 'alarm' function. */
 #undef HAVE_ALARM
@@ -683,7 +683,7 @@
 #undef HAVE_SOCKADDR_SA_LEN
 
 /* struct sockaddr_storage (sys/socket.h) */
-#undef HAVE_SOCKADDR_STORAGE
+#define HAVE_SOCKADDR_STORAGE   1
 
 /* Define if you have the 'socketpair' function. */
 #undef HAVE_SOCKETPAIR
-- 
2.40.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108200): https://edk2.groups.io/g/devel/message/108200
Mute This Topic: https://groups.io/mt/101077159/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-