Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jayaprakash, N
> Sent: Saturday, December 9, 2023 9:43 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D
> Subject: [edk2-libc Patch 1/1] ek2-libc: writeio function in
> edk2module.c not working as expected
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4619
>
> This commit fixes the issue reported in the BZ4619.
> The order of passing the parameters to IoWrite* functions
> called within writeio function in edk2module.c has been corrected
> Also verified the changes by writing reset command to 0xCF9 port
> using writeio function in edk2module.c
>
> Cc: Rebecca Cran
> Cc: Michael D Kinney
> Cc: Jayaprakash N
> Signed-off-by: Jayaprakash N
> ---
> .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c| 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-
> 3.6.8/PyMod-3.6.8/Modules/edk2module.c
> index 8786df8..d6af8da 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> @@ -3985,9 +3985,9 @@ edk2_writeio(PyObject *self, PyObject *args)
>
>Py_BEGIN_ALLOW_THREADS
>addrs = (short)(addr & 0x);
> - if (1 == sz) IoWrite8((unsigned char)(value & 0xFF), addrs);
> - else if (2 == sz) IoWrite16((unsigned short)(value & 0x), addrs);
> - else if (4 == sz) IoWrite32(value, addrs);
> + if (1 == sz) IoWrite8(addrs, (unsigned char)(value & 0xFF));
> + else if (2 == sz) IoWrite16(addrs, (unsigned short)(value & 0x));
> + else if (4 == sz) IoWrite32(addrs, value);
>Py_END_ALLOW_THREADS
>
>Py_INCREF(Py_None);
> --
> 2.40.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112256): https://edk2.groups.io/g/devel/message/112256
Mute This Topic: https://groups.io/mt/103077058/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
