Re: [edk2-devel] [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

2024-05-23 Thread Abdul Lateef Attar via groups.io
Reviewed-by: Abdul Lateef Attar 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119205): https://edk2.groups.io/g/devel/message/119205
Mute This Topic: https://groups.io/mt/106257080/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

2024-05-23 Thread Paul via groups.io
[AMD Official Use Only - AMD Internal Distribution Only]

Thanks for the up-stream, Abner.

Looks good to me.

Reviewed-by: Paul Grimes 

From: Yao, Ken 
Sent: Thursday, May 23, 2024 1:30:48 AM
To: Zhai, MingXin (Duke) ; Chang, Abner 
; devel@edk2.groups.io 
Cc: Grimes, Paul ; Attar, AbdulLateef (Abdul Lateef) 
; Fu, Igniculus ; Xing, Eric 

Subject: RE: [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

[AMD Official Use Only - AMD Internal Distribution Only]

[AMD Official Use Only - AMD Internal Distribution Only]

Thanks Abner for the up-stream.

Looks good to me.

Reviewed-by: Ken Yao 
-Original Message-
From: Zhai, MingXin (Duke) 
Sent: Thursday, May 23, 2024 3:47 PM
To: Chang, Abner ; devel@edk2.groups.io
Cc: Grimes, Paul ; Attar, AbdulLateef (Abdul Lateef) 
; Fu, Igniculus ; Yao, Ken 
; Xing, Eric 
Subject: RE: [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

[AMD Official Use Only - AMD Internal Distribution Only]

Thanks Abner for the up-stream.

Looks good to me.

-Original Message-
From: Chang, Abner 
Sent: Thursday, May 23, 2024 12:12 PM
To: devel@edk2.groups.io
Cc: Grimes, Paul ; Attar, AbdulLateef (Abdul Lateef) 
; Fu, Igniculus ; Yao, Ken 
; Xing, Eric ; Zhai, MingXin (Duke) 

Subject: [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

From: Abner Chang 

Cc: Paul Grimes 
Cc: Abdul Lateef Attar 
Cc: Igniculus Fu 
Cc: Ken Yao 
Cc: Eric Xing 
Cc: Duke Zhai 
Signed-off-by: Abner Chang 
---
 Platform/AMD/Readme.md | 64 --
 1 file changed, 49 insertions(+), 15 deletions(-)

diff --git a/Platform/AMD/Readme.md b/Platform/AMD/Readme.md index 
99d2b990c7..3297c6ba59 100644
--- a/Platform/AMD/Readme.md
+++ b/Platform/AMD/Readme.md
@@ -7,18 +7,25 @@ booting certain AMD platforms. The definition of sub-folders 
is described in bel

 ## Term and Definitions

+* **AGESA**
+
+  AMD Generic Encapsulated Software Architecture that are executed as
+ part of a  host platform BIOS.
+
 * **AMD Platform** (platform in short)

-  AMD platform refers to a platform that supports the particular AMD SoC 
(processor), such as AMD EPYC Milan and Genoa processors.
+  AMD platform refers to a platform that supports the particular AMD
+ SoC (processor), such as  AMD EPYC Milan and Genoa processors.

 * **AMD Board** (board in short)

   AMD board is a generic terminology refers to a board that is designed based 
on a
   specific AMD SoC architecture (also referred as AMD platform). More than one 
boards
-  are possibly designed to support an AMD platform with different 
configuration, such as 1-processor socket or 2-processor sockets board.
+  are possibly designed to support an AMD platform with different
+ configuration, such as  1-processor socket or 2-processor sockets board.

 * **AMD edk2 Platform Package** (platform package in short)
-
+
   The folder has the AMD edk2 platform common modules.

 * **AMD edk2 Board Package** (board package in short) @@ -28,29 +35,52 @@ 
booting certain AMD platforms. The definition of sub-folders is described in bel

 ## Package Definition

+* **AgesaModulePkg**
+
+  This package contains all of the private interfaces and build
+ configuration files for the  AGESA support.
+
+* **AgesaPkg**
+
+  This package contains all of the public interfaces and build
+ configuration files  for the AGESA support.
+
+* **AmdCbsPkg**
+
+  AMD Configurable BIOS Setting. Provides the edk2 formset following
+ the UEFI HII  spec to configure BIOS settings.
+
+* **AmdCpmPkg**
+
+  AMD Common Platform Module software is a BIOS procedure library
+ designed to aid  AMD customers to quickly implement AMD platform technology 
into their products.
+
 * **AmdPlatformPkg**

-  AMD platform edk2 package under this folder provides the common edk2 modules 
those
-  are leverage by platforms. Usually those modules have no dependencies with
-  particular platforms. The module under this scope can provides a common 
implementation
-  for all platforms, or it may just provide a framework but the differences of 
implementation could be configured through the PCDs declared in 
AmdPlatformPkg.dec, or
-  the board level library provided in the \Pkg.
+  AMD platform edk2 package under this folder provides the common edk2
+ modules that are leveraged by platforms. Usually those modules have no
+ dependencies with  particular platforms. Modules under this scope can
+ provide a common implementation  for all platforms, or may just
+ provide a framework but the differences of implementation  could be
+ configured through the PCDs declared in AmdPlatformPkg.dec, or the board 
level  library provided in the \Pkg.

 * **AmdMinBoardPkg**

-  This package provides the common edk2 modules those can be leverage across 
AMD boards those use MinPlatformPkg framework.
+  This package provides the common edk2 modules that can be leveraged
+ across AMD boards using  the MinPlatform framework.

 * **\Board**

-  This is 

Re: [edk2-devel] [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

2024-05-23 Thread Yao, Ken via groups.io
[AMD Official Use Only - AMD Internal Distribution Only]

[AMD Official Use Only - AMD Internal Distribution Only]

Thanks Abner for the up-stream.

Looks good to me.

Reviewed-by: Ken Yao 
-Original Message-
From: Zhai, MingXin (Duke) 
Sent: Thursday, May 23, 2024 3:47 PM
To: Chang, Abner ; devel@edk2.groups.io
Cc: Grimes, Paul ; Attar, AbdulLateef (Abdul Lateef) 
; Fu, Igniculus ; Yao, Ken 
; Xing, Eric 
Subject: RE: [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

[AMD Official Use Only - AMD Internal Distribution Only]

Thanks Abner for the up-stream.

Looks good to me.

-Original Message-
From: Chang, Abner 
Sent: Thursday, May 23, 2024 12:12 PM
To: devel@edk2.groups.io
Cc: Grimes, Paul ; Attar, AbdulLateef (Abdul Lateef) 
; Fu, Igniculus ; Yao, Ken 
; Xing, Eric ; Zhai, MingXin (Duke) 

Subject: [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

From: Abner Chang 

Cc: Paul Grimes 
Cc: Abdul Lateef Attar 
Cc: Igniculus Fu 
Cc: Ken Yao 
Cc: Eric Xing 
Cc: Duke Zhai 
Signed-off-by: Abner Chang 
---
 Platform/AMD/Readme.md | 64 --
 1 file changed, 49 insertions(+), 15 deletions(-)

diff --git a/Platform/AMD/Readme.md b/Platform/AMD/Readme.md index 
99d2b990c7..3297c6ba59 100644
--- a/Platform/AMD/Readme.md
+++ b/Platform/AMD/Readme.md
@@ -7,18 +7,25 @@ booting certain AMD platforms. The definition of sub-folders 
is described in bel

 ## Term and Definitions

+* **AGESA**
+
+  AMD Generic Encapsulated Software Architecture that are executed as
+ part of a  host platform BIOS.
+
 * **AMD Platform** (platform in short)

-  AMD platform refers to a platform that supports the particular AMD SoC 
(processor), such as AMD EPYC Milan and Genoa processors.
+  AMD platform refers to a platform that supports the particular AMD
+ SoC (processor), such as  AMD EPYC Milan and Genoa processors.

 * **AMD Board** (board in short)

   AMD board is a generic terminology refers to a board that is designed based 
on a
   specific AMD SoC architecture (also referred as AMD platform). More than one 
boards
-  are possibly designed to support an AMD platform with different 
configuration, such as 1-processor socket or 2-processor sockets board.
+  are possibly designed to support an AMD platform with different
+ configuration, such as  1-processor socket or 2-processor sockets board.

 * **AMD edk2 Platform Package** (platform package in short)
-
+
   The folder has the AMD edk2 platform common modules.

 * **AMD edk2 Board Package** (board package in short) @@ -28,29 +35,52 @@ 
booting certain AMD platforms. The definition of sub-folders is described in bel

 ## Package Definition

+* **AgesaModulePkg**
+
+  This package contains all of the private interfaces and build
+ configuration files for the  AGESA support.
+
+* **AgesaPkg**
+
+  This package contains all of the public interfaces and build
+ configuration files  for the AGESA support.
+
+* **AmdCbsPkg**
+
+  AMD Configurable BIOS Setting. Provides the edk2 formset following
+ the UEFI HII  spec to configure BIOS settings.
+
+* **AmdCpmPkg**
+
+  AMD Common Platform Module software is a BIOS procedure library
+ designed to aid  AMD customers to quickly implement AMD platform technology 
into their products.
+
 * **AmdPlatformPkg**

-  AMD platform edk2 package under this folder provides the common edk2 modules 
those
-  are leverage by platforms. Usually those modules have no dependencies with
-  particular platforms. The module under this scope can provides a common 
implementation
-  for all platforms, or it may just provide a framework but the differences of 
implementation could be configured through the PCDs declared in 
AmdPlatformPkg.dec, or
-  the board level library provided in the \Pkg.
+  AMD platform edk2 package under this folder provides the common edk2
+ modules that are leveraged by platforms. Usually those modules have no
+ dependencies with  particular platforms. Modules under this scope can
+ provide a common implementation  for all platforms, or may just
+ provide a framework but the differences of implementation  could be
+ configured through the PCDs declared in AmdPlatformPkg.dec, or the board 
level  library provided in the \Pkg.

 * **AmdMinBoardPkg**

-  This package provides the common edk2 modules those can be leverage across 
AMD boards those use MinPlatformPkg framework.
+  This package provides the common edk2 modules that can be leveraged
+ across AMD boards using  the MinPlatform framework.

 * **\Board**

-  This is the folder named by SoC and accommodate one or multiple board 
packages those
-  are designed base on the same SoC platform. Board folder may 
contain edk2
-  package meta files directly or the sub-folders named by \Pkg 
for a
-  variety configurations of a platform.
+  This is the folder named by SoC and accommodates one or multiple
+ board packages  that are designed based on the same SoC platform. Board folder may  contain edk2 package meta 

Re: [edk2-devel] [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

2024-05-23 Thread Zhai, MingXin (Duke) via groups.io
[AMD Official Use Only - AMD Internal Distribution Only]

Thanks Abner for the up-stream.

Looks good to me.

-Original Message-
From: Chang, Abner 
Sent: Thursday, May 23, 2024 12:12 PM
To: devel@edk2.groups.io
Cc: Grimes, Paul ; Attar, AbdulLateef (Abdul Lateef) 
; Fu, Igniculus ; Yao, Ken 
; Xing, Eric ; Zhai, MingXin (Duke) 

Subject: [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

From: Abner Chang 

Cc: Paul Grimes 
Cc: Abdul Lateef Attar 
Cc: Igniculus Fu 
Cc: Ken Yao 
Cc: Eric Xing 
Cc: Duke Zhai 
Signed-off-by: Abner Chang 
---
 Platform/AMD/Readme.md | 64 --
 1 file changed, 49 insertions(+), 15 deletions(-)

diff --git a/Platform/AMD/Readme.md b/Platform/AMD/Readme.md index 
99d2b990c7..3297c6ba59 100644
--- a/Platform/AMD/Readme.md
+++ b/Platform/AMD/Readme.md
@@ -7,18 +7,25 @@ booting certain AMD platforms. The definition of sub-folders 
is described in bel

 ## Term and Definitions

+* **AGESA**
+
+  AMD Generic Encapsulated Software Architecture that are executed as
+ part of a  host platform BIOS.
+
 * **AMD Platform** (platform in short)

-  AMD platform refers to a platform that supports the particular AMD SoC 
(processor), such as AMD EPYC Milan and Genoa processors.
+  AMD platform refers to a platform that supports the particular AMD
+ SoC (processor), such as  AMD EPYC Milan and Genoa processors.

 * **AMD Board** (board in short)

   AMD board is a generic terminology refers to a board that is designed based 
on a
   specific AMD SoC architecture (also referred as AMD platform). More than one 
boards
-  are possibly designed to support an AMD platform with different 
configuration, such as 1-processor socket or 2-processor sockets board.
+  are possibly designed to support an AMD platform with different
+ configuration, such as  1-processor socket or 2-processor sockets board.

 * **AMD edk2 Platform Package** (platform package in short)
-
+
   The folder has the AMD edk2 platform common modules.

 * **AMD edk2 Board Package** (board package in short) @@ -28,29 +35,52 @@ 
booting certain AMD platforms. The definition of sub-folders is described in bel

 ## Package Definition

+* **AgesaModulePkg**
+
+  This package contains all of the private interfaces and build
+ configuration files for the  AGESA support.
+
+* **AgesaPkg**
+
+  This package contains all of the public interfaces and build
+ configuration files  for the AGESA support.
+
+* **AmdCbsPkg**
+
+  AMD Configurable BIOS Setting. Provides the edk2 formset following
+ the UEFI HII  spec to configure BIOS settings.
+
+* **AmdCpmPkg**
+
+  AMD Common Platform Module software is a BIOS procedure library
+ designed to aid  AMD customers to quickly implement AMD platform technology 
into their products.
+
 * **AmdPlatformPkg**

-  AMD platform edk2 package under this folder provides the common edk2 modules 
those
-  are leverage by platforms. Usually those modules have no dependencies with
-  particular platforms. The module under this scope can provides a common 
implementation
-  for all platforms, or it may just provide a framework but the differences of 
implementation could be configured through the PCDs declared in 
AmdPlatformPkg.dec, or
-  the board level library provided in the \Pkg.
+  AMD platform edk2 package under this folder provides the common edk2
+ modules that are leveraged by platforms. Usually those modules have no
+ dependencies with  particular platforms. Modules under this scope can
+ provide a common implementation  for all platforms, or may just
+ provide a framework but the differences of implementation  could be
+ configured through the PCDs declared in AmdPlatformPkg.dec, or the board 
level  library provided in the \Pkg.

 * **AmdMinBoardPkg**

-  This package provides the common edk2 modules those can be leverage across 
AMD boards those use MinPlatformPkg framework.
+  This package provides the common edk2 modules that can be leveraged
+ across AMD boards using  the MinPlatform framework.

 * **\Board**

-  This is the folder named by SoC and accommodate one or multiple board 
packages those
-  are designed base on the same SoC platform. Board folder may 
contain edk2
-  package meta files directly or the sub-folders named by \Pkg 
for a
-  variety configurations of a platform.
+  This is the folder named by SoC and accommodates one or multiple
+ board packages  that are designed based on the same SoC platform. Board folder may  contain edk2 package meta files directly or the
+ sub-folders named by \Pkg for  a variety configurations of a 
platform.

 * **Pkg**

-  This is the folder that contains edk2 package meta files for a board which 
is designed base on a platform. Besides the edk2 meta files, Pkg 
may also provides
-  edk2 modules which are specifically to a board.
+  This is the folder that contains edk2 package meta files for a board
+ which is designed base  on a platform. Besides the edk2 meta files,
+ Pkg may also provides edk2 

Re: [edk2-devel] [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

2024-05-23 Thread Xing, Eric via groups.io
[AMD Official Use Only - AMD Internal Distribution Only]

Thanks Abner for the up-stream.

Looks good to me.
Reviewed-by: Eric Xing 


> -Original Message-
> From: Chang, Abner 
> Sent: Thursday, May 23, 2024 12:12 PM
> To: devel@edk2.groups.io
> Cc: Grimes, Paul ; Attar, AbdulLateef (Abdul Lateef)
> ; Fu, Igniculus ; Yao,
> Ken ; Xing, Eric ; Zhai, MingXin
> (Duke) 
> Subject: [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md
>
> From: Abner Chang 
>
> Cc: Paul Grimes 
> Cc: Abdul Lateef Attar 
> Cc: Igniculus Fu 
> Cc: Ken Yao 
> Cc: Eric Xing 
> Cc: Duke Zhai 
> Signed-off-by: Abner Chang 
> ---
>  Platform/AMD/Readme.md | 64 
> --
>  1 file changed, 49 insertions(+), 15 deletions(-)
>
> diff --git a/Platform/AMD/Readme.md b/Platform/AMD/Readme.md index
> 99d2b990c7..3297c6ba59 100644
> --- a/Platform/AMD/Readme.md
> +++ b/Platform/AMD/Readme.md
> @@ -7,18 +7,25 @@ booting certain AMD platforms. The definition of sub-
> folders is described in bel
>
>  ## Term and Definitions
>
> +* **AGESA**
> +
> +  AMD Generic Encapsulated Software Architecture that are executed as
> + part of a  host platform BIOS.
> +
>  * **AMD Platform** (platform in short)
>
> -  AMD platform refers to a platform that supports the particular AMD SoC
> (processor), such as AMD EPYC Milan and Genoa processors.
> +  AMD platform refers to a platform that supports the particular AMD
> + SoC (processor), such as  AMD EPYC Milan and Genoa processors.
>
>  * **AMD Board** (board in short)
>
>AMD board is a generic terminology refers to a board that is designed based
> on a
>specific AMD SoC architecture (also referred as AMD platform). More than
> one boards
> -  are possibly designed to support an AMD platform with different
> configuration, such as 1-processor socket or 2-processor sockets board.
> +  are possibly designed to support an AMD platform with different
> + configuration, such as  1-processor socket or 2-processor sockets board.
>
>  * **AMD edk2 Platform Package** (platform package in short)
> -
> +
>The folder has the AMD edk2 platform common modules.
>
>  * **AMD edk2 Board Package** (board package in short) @@ -28,29 +35,52
> @@ booting certain AMD platforms. The definition of sub-folders is described
> in bel
>
>  ## Package Definition
>
> +* **AgesaModulePkg**
> +
> +  This package contains all of the private interfaces and build
> + configuration files for the  AGESA support.
> +
> +* **AgesaPkg**
> +
> +  This package contains all of the public interfaces and build
> + configuration files  for the AGESA support.
> +
> +* **AmdCbsPkg**
> +
> +  AMD Configurable BIOS Setting. Provides the edk2 formset following
> + the UEFI HII  spec to configure BIOS settings.
> +
> +* **AmdCpmPkg**
> +
> +  AMD Common Platform Module software is a BIOS procedure library
> + designed to aid  AMD customers to quickly implement AMD platform
> technology into their products.
> +
>  * **AmdPlatformPkg**
>
> -  AMD platform edk2 package under this folder provides the common edk2
> modules those
> -  are leverage by platforms. Usually those modules have no dependencies
> with
> -  particular platforms. The module under this scope can provides a common
> implementation
> -  for all platforms, or it may just provide a framework but the differences 
> of
> implementation could be configured through the PCDs declared in
> AmdPlatformPkg.dec, or
> -  the board level library provided in the \Pkg.
> +  AMD platform edk2 package under this folder provides the common edk2
> + modules that are leveraged by platforms. Usually those modules have no
> + dependencies with  particular platforms. Modules under this scope can
> + provide a common implementation  for all platforms, or may just
> + provide a framework but the differences of implementation  could be
> + configured through the PCDs declared in AmdPlatformPkg.dec, or the board
> level  library provided in the \Pkg.
>
>  * **AmdMinBoardPkg**
>
> -  This package provides the common edk2 modules those can be leverage
> across AMD boards those use MinPlatformPkg framework.
> +  This package provides the common edk2 modules that can be leveraged
> + across AMD boards using  the MinPlatform framework.
>
>  * **\Board**
>
> -  This is the folder named by SoC and accommodate one or multiple board
> packages those
> -  are designed base on the same SoC platform. Board folder may
> contain edk2
> -  package meta files directly or the sub-folders named by \Pkg
> for a
> -  variety configurations of a platform.
> +  This is the folder named by SoC and accommodates one or multiple
> + board packages  that are designed based on the same SoC platform.  + name>Board folder may  contain edk2 package meta files directly or the
> + sub-folders named by \Pkg for  a variety configurations of a
> platform.
>
>  * **Pkg**
>
> -  This is the folder that contains edk2 package meta files for a board which 
> is
> designed base on a platform. Besides 

[edk2-devel] [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

2024-05-22 Thread Chang, Abner via groups.io
From: Abner Chang 

Cc: Paul Grimes 
Cc: Abdul Lateef Attar 
Cc: Igniculus Fu 
Cc: Ken Yao 
Cc: Eric Xing 
Cc: Duke Zhai 
Signed-off-by: Abner Chang 
---
 Platform/AMD/Readme.md | 64 --
 1 file changed, 49 insertions(+), 15 deletions(-)

diff --git a/Platform/AMD/Readme.md b/Platform/AMD/Readme.md
index 99d2b990c7..3297c6ba59 100644
--- a/Platform/AMD/Readme.md
+++ b/Platform/AMD/Readme.md
@@ -7,18 +7,25 @@ booting certain AMD platforms. The definition of sub-folders 
is described in bel
 
 ## Term and Definitions
 
+* **AGESA**
+
+  AMD Generic Encapsulated Software Architecture that are executed as part of a
+  host platform BIOS.
+
 * **AMD Platform** (platform in short)
 
-  AMD platform refers to a platform that supports the particular AMD SoC 
(processor), such as AMD EPYC Milan and Genoa processors.
+  AMD platform refers to a platform that supports the particular AMD SoC 
(processor), such as
+  AMD EPYC Milan and Genoa processors.
 
 * **AMD Board** (board in short)
 
   AMD board is a generic terminology refers to a board that is designed based 
on a
   specific AMD SoC architecture (also referred as AMD platform). More than one 
boards
-  are possibly designed to support an AMD platform with different 
configuration, such as 1-processor socket or 2-processor sockets board.
+  are possibly designed to support an AMD platform with different 
configuration, such as
+  1-processor socket or 2-processor sockets board.
 
 * **AMD edk2 Platform Package** (platform package in short)
-  
+
   The folder has the AMD edk2 platform common modules.
 
 * **AMD edk2 Board Package** (board package in short)
@@ -28,29 +35,52 @@ booting certain AMD platforms. The definition of 
sub-folders is described in bel
 
 ## Package Definition
 
+* **AgesaModulePkg**
+
+  This package contains all of the private interfaces and build configuration 
files for the
+  AGESA support.
+
+* **AgesaPkg**
+
+  This package contains all of the public interfaces and build configuration 
files
+  for the AGESA support.
+
+* **AmdCbsPkg**
+
+  AMD Configurable BIOS Setting. Provides the edk2 formset following the UEFI 
HII
+  spec to configure BIOS settings.
+
+* **AmdCpmPkg**
+
+  AMD Common Platform Module software is a BIOS procedure library designed to 
aid
+  AMD customers to quickly implement AMD platform technology into their 
products.
+
 * **AmdPlatformPkg**
 
-  AMD platform edk2 package under this folder provides the common edk2 modules 
those
-  are leverage by platforms. Usually those modules have no dependencies with
-  particular platforms. The module under this scope can provides a common 
implementation
-  for all platforms, or it may just provide a framework but the differences of 
implementation could be configured through the PCDs declared in 
AmdPlatformPkg.dec, or
-  the board level library provided in the \Pkg.
+  AMD platform edk2 package under this folder provides the common edk2
+  modules that are leveraged by platforms. Usually those modules have no 
dependencies with
+  particular platforms. Modules under this scope can provide a common 
implementation
+  for all platforms, or may just provide a framework but the differences of 
implementation
+  could be configured through the PCDs declared in AmdPlatformPkg.dec, or the 
board level
+  library provided in the \Pkg.
 
 * **AmdMinBoardPkg**
 
-  This package provides the common edk2 modules those can be leverage across 
AMD boards those use MinPlatformPkg framework.
+  This package provides the common edk2 modules that can be leveraged across 
AMD boards using
+  the MinPlatform framework.
 
 * **\Board**
 
-  This is the folder named by SoC and accommodate one or multiple board 
packages those
-  are designed base on the same SoC platform. Board folder may 
contain edk2
-  package meta files directly or the sub-folders named by \Pkg 
for a 
-  variety configurations of a platform.
+  This is the folder named by SoC and accommodates one or multiple board 
packages
+  that are designed based on the same SoC platform. Board folder may
+  contain edk2 package meta files directly or the sub-folders named by \Pkg for
+  a variety configurations of a platform.
 
 * **Pkg**
 
-  This is the folder that contains edk2 package meta files for a board which 
is designed base on a platform. Besides the edk2 meta files, Pkg 
may also provides
-  edk2 modules which are specifically to a board.
+  This is the folder that contains edk2 package meta files for a board which 
is designed base
+  on a platform. Besides the edk2 meta files, Pkg may also 
provides edk2 modules
+  which are specifically to a board.
 
   ```
   e.g. OverdriveBoard
@@ -63,6 +93,10 @@ booting certain AMD platforms. The definition of sub-folders 
is described in bel
 
   ```
   Platform/AMD
+|AgesaModulePkg
+|AgesaPkg
+|AmdCbsPkg
+|AmdCpmPkg
 |AmdPlatformPkg