[edk2-devel] [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 Adds the modules used for System 76 Galago Pro 3 board support. This override should be removed in a future cleanup change. That is outside the scope of this change which is to move the contents from ClevoOpenBoardPkg/N1xxWU to KabylakeOpenBoardPkg/GalagoPro3. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Ankit Sinha Cc: Jeremy Soller Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | 67 ++ Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c | 640 2 files changed, 707 insertions(+) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf new file mode 100644 index 00..76dd67d1a8 --- /dev/null +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf @@ -0,0 +1,67 @@ +### @file +# Component information file for the Platform Init Pre-Memory PEI module. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +### + +[Defines] + INF_VERSION= 0x00010017 + BASE_NAME = PlatformInitPreMem + FILE_GUID = 611D-F78F-4FB9-B868-55907F169280 + VERSION_STRING = 1.0 + MODULE_TYPE= PEIM + ENTRY_POINT= PlatformInitPreMemEntryPoint + +[LibraryClasses] + BaseMemoryLib + BoardInitLib + DebugLib + HobLib + IoLib + MemoryAllocationLib + MtrrLib + PeimEntryPoint + PeiServicesLib + ReportFvLib + TestPointCheckLib + TimerLib + +[Packages] + MinPlatformPkg/MinPlatformPkg.dec + MdeModulePkg/MdeModulePkg.dec + MdePkg/MdePkg.dec + UefiCpuPkg/UefiCpuPkg.dec + +[Pcd] + gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit## CONSUMES + +[FixedPcd] + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiReservedMemorySize ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiRtDataMemorySize ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiRtCodeMemorySize ## CONSUMES + +[Sources] + PlatformInitPreMem.c + +[Ppis] + gEfiPeiMemoryDiscoveredPpiGuid + gEfiPeiMasterBootModePpiGuid ## PRODUCES + gEfiPeiBootInRecoveryModePpiGuid ## PRODUCES + gEfiPeiReadOnlyVariable2PpiGuid + gPeiBaseMemoryTestPpiGuid + gPeiPlatformMemorySizePpiGuid + +[Guids] + gEfiMemoryTypeInformationGuid + +[Depex] + gEfiPeiReadOnlyVariable2PpiGuid diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c new file mode 100644 index 00..b784026c1b --- /dev/null +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c @@ -0,0 +1,640 @@ +/** @file + Source code file for Platform Init Pre-Memory PEI module + +Copyright (c) 2019, Intel Corporation. All rights reserved. +SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +EFI_STATUS +EFIAPI +MemoryDiscoveredPpiNotifyCallback ( + IN CONST EFI_PEI_SERVICES **PeiServices, + IN EFI_PEI_NOTIFY_DESCRIPTOR *NotifyDescriptor, + IN VOID*Ppi + ); + +EFI_STATUS +EFIAPI +GetPlatformMemorySize ( + IN EFI_PEI_SERVICES **PeiServices, + IN PEI_PLATFORM_MEMORY_SIZE_PPI *This, + IN OUT UINT64 *MemorySize + ); + +/** + + This function checks the memory range in PEI. + + @param PeiServices Pointer to PEI Services. + @param ThisPei memory test PPI pointer. + @param BeginAddressBeginning of th
Re: [edk2-devel] [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules
I would like us to re-evaluate whether an override of PlatformInitPreMem is really needed... but I understand that is not in scope for this patch series. Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 Adds the modules used for System 76 Galago Pro 3 board support. This override should be removed in a future cleanup change. That is outside the scope of this change which is to move the contents from ClevoOpenBoardPkg/N1xxWU to KabylakeOpenBoardPkg/GalagoPro3. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Ankit Sinha Cc: Jeremy Soller Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | 67 ++ Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c | 640 2 files changed, 707 insertions(+) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf new file mode 100644 index 00..76dd67d1a8 --- /dev/null +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/I +++ ntel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem. +++ inf @@ -0,0 +1,67 @@ +### @file +# Component information file for the Platform Init Pre-Memory PEI module. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved. # # +SPDX-License-Identifier: BSD-2-Clause-Patent # ### + +[Defines] + INF_VERSION= 0x00010017 + BASE_NAME = PlatformInitPreMem + FILE_GUID = 611D-F78F-4FB9-B868-55907F169280 + VERSION_STRING = 1.0 + MODULE_TYPE= PEIM + ENTRY_POINT= PlatformInitPreMemEntryPoint + +[LibraryClasses] + BaseMemoryLib + BoardInitLib + DebugLib + HobLib + IoLib + MemoryAllocationLib + MtrrLib + PeimEntryPoint + PeiServicesLib + ReportFvLib + TestPointCheckLib + TimerLib + +[Packages] + MinPlatformPkg/MinPlatformPkg.dec + MdeModulePkg/MdeModulePkg.dec + MdePkg/MdePkg.dec + UefiCpuPkg/UefiCpuPkg.dec + +[Pcd] + gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit## CONSUMES + +[FixedPcd] + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiReservedMemorySize ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiRtDataMemorySize ## CONSUMES + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiRtCodeMemorySize ## CONSUMES + +[Sources] + PlatformInitPreMem.c + +[Ppis] + gEfiPeiMemoryDiscoveredPpiGuid + gEfiPeiMasterBootModePpiGuid ## PRODUCES + gEfiPeiBootInRecoveryModePpiGuid ## PRODUCES + gEfiPeiReadOnlyVariable2PpiGuid + gPeiBaseMemoryTestPpiGuid + gPeiPlatformMemorySizePpiGuid + +[Guids] + gEfiMemoryTypeInformationGuid + +[Depex] + gEfiPeiReadOnlyVariable2PpiGuid diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c new file mode 100644 index 00..b784026c1b --- /dev/null +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/I +++ ntel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem. +++ c @@ -0,0 +1,640 @@ +/** @file + Source code file for Platform Init Pre-Memory PEI module + +Copyright (c) 2019, Intel Corporation. All rights reserved. +SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include + #include + +EFI_STATUS +EFIAPI +MemoryDiscoveredPpiNotifyCallback ( + IN CONST EFI_PEI_SERVICES **PeiServices, + IN EFI_PEI_NOTIFY_DESCRIPTOR *NotifyDescriptor, +
Re: [edk2-devel] [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-platforms][PATCH V1 10/12] > KabylakeOpenBoardPkg/GalagoPro3: Add modules > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > Adds the modules used for System 76 Galago Pro 3 board support. > > This override should be removed in a future cleanup change. That is outside > the scope of this change which is to move the contents from > ClevoOpenBoardPkg/N1xxWU to KabylakeOpenBoardPkg/GalagoPro3. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/ > MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | 67 > ++ > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/ > MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c | 640 > > 2 files changed, 707 insertions(+) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Inte > l/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Inte > l/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > new file mode 100644 > index 00..76dd67d1a8 > --- /dev/null > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/I > +++ ntel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem. > +++ inf > @@ -0,0 +1,67 @@ > +### @file > +# Component information file for the Platform Init Pre-Memory PEI module. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved. # # > +SPDX-License-Identifier: BSD-2-Clause-Patent # ### > + > +[Defines] > + INF_VERSION= 0x00010017 > + BASE_NAME = PlatformInitPreMem > + FILE_GUID = > 611D-F78F-4FB9-B868-55907F169280 > + VERSION_STRING = 1.0 > + MODULE_TYPE= PEIM > + ENTRY_POINT= PlatformInitPreMemEntryPoint > + > +[LibraryClasses] > + BaseMemoryLib > + BoardInitLib > + DebugLib > + HobLib > + IoLib > + MemoryAllocationLib > + MtrrLib > + PeimEntryPoint > + PeiServicesLib > + ReportFvLib > + TestPointCheckLib > + TimerLib > + > +[Packages] > + MinPlatformPkg/MinPlatformPkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + UefiCpuPkg/UefiCpuPkg.dec > + > +[Pcd] > + gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress## > CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize ## > CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit ## > CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit## > CONSUMES > + > +[FixedPcd] > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiReservedMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiRtDataMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiRtCodeMemorySize > ## CONSUMES > + > +[Sources] > + PlatformInitPreMem.c > + > +[Ppis] > + gEfiPeiMemoryDiscoveredPpiGuid > + gEfiPeiMasterBootModePpiGuid ## PRODUCES > + gEfiPeiBootInRecoveryModePpiGuid ## PRODUCES > + gEfiPeiReadOnlyVariable2PpiGuid > + gPeiBaseMemoryTestPpiGuid > + gPeiPlatformMemorySizePpiGuid > + > +[Guids] > + gEfiMemoryTypeInformationGuid > + > +[Depex] > + gEfiPeiReadOnlyVariable2PpiGuid > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Inte > l/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Inte > l/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c > new file mode 100644 > index 00..b784026c1b > --- /dev/null > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/I > +++ ntel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem. > +++ c > @@ -0,0 +1,640 @@ > +/** @file > + Source code file for Platform Init Pre-Memory PEI module > + > +Copyright (c) 2019, Intel Corporation. All rights reserved. > +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include #include > + #include > + > +EFI_STATUS > +EFIAPI > +Memory
Re: [edk2-devel] [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules
Agree as noted in the patch commit message. At the very least an alternative solution must be used that eliminates the override copy. Thanks, Michael > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Monday, September 23, 2019 1:16 AM > To: Kubacki, Michael A ; > devel@edk2.groups.io > Cc: Chiu, Chasel ; Sinha, Ankit > ; Jeremy Soller > Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 10/12] > KabylakeOpenBoardPkg/GalagoPro3: Add modules > > I would like us to re-evaluate whether an override of PlatformInitPreMem is > really needed... but I understand that is not in scope for this patch series. > > Reviewed-by: Nate DeSimone > > -Original Message- > From: Kubacki, Michael A > Sent: Friday, September 20, 2019 11:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-platforms][PATCH V1 10/12] > KabylakeOpenBoardPkg/GalagoPro3: Add modules > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > Adds the modules used for System 76 Galago Pro 3 board support. > > This override should be removed in a future cleanup change. That is outside > the scope of this change which is to move the contents from > ClevoOpenBoardPkg/N1xxWU to KabylakeOpenBoardPkg/GalagoPro3. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | 67 > ++ > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel > /MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c | 640 > > 2 files changed, 707 insertions(+) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/In > tel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/In > tel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > new file mode 100644 > index 00..76dd67d1a8 > --- /dev/null > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/I > +++ ntel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem. > +++ inf > @@ -0,0 +1,67 @@ > +### @file > +# Component information file for the Platform Init Pre-Memory PEI > module. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved. # # > +SPDX-License-Identifier: BSD-2-Clause-Patent # ### > + > +[Defines] > + INF_VERSION= 0x00010017 > + BASE_NAME = PlatformInitPreMem > + FILE_GUID = 611D-F78F-4FB9-B868-55907F169280 > + VERSION_STRING = 1.0 > + MODULE_TYPE= PEIM > + ENTRY_POINT= PlatformInitPreMemEntryPoint > + > +[LibraryClasses] > + BaseMemoryLib > + BoardInitLib > + DebugLib > + HobLib > + IoLib > + MemoryAllocationLib > + MtrrLib > + PeimEntryPoint > + PeiServicesLib > + ReportFvLib > + TestPointCheckLib > + TimerLib > + > +[Packages] > + MinPlatformPkg/MinPlatformPkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + UefiCpuPkg/UefiCpuPkg.dec > + > +[Pcd] > + gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode ## > CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress## > CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit ## > CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit## > CONSUMES > + > +[FixedPcd] > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiReservedMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiRtDataMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiRtCodeMemorySize > ## CONSUMES > + > +[Sources] > + PlatformInitPreMem.c > + > +[Ppis] > + gEfiPeiMemoryDiscoveredPpiGuid > + gEfiPeiMasterBootModePpiGuid ## PRODUCES > + gEfiPeiBootInRecoveryModePpiGuid ## PRODUCES > + gEfiPeiReadOnlyVariable2PpiGuid > + gPeiBaseMemoryTestPpiGuid > + gPeiPlatformMemorySizePpiGuid > + > +[Guids] > + gEfiMemoryTypeInformationGuid > + > +[Depex] > + gEfiPeiReadOnlyVariable2PpiGuid >
Re: [edk2-devel] [edk2-platforms][PATCH V1 10/12] KabylakeOpenBoardPkg/GalagoPro3: Add modules
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > Adds the modules used for System 76 Galago Pro 3 board support. > > This override should be removed in a future cleanup change. That is > outside the scope of this change which is to move the contents from > ClevoOpenBoardPkg/N1xxWU to KabylakeOpenBoardPkg/GalagoPro3. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > | 67 ++ > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c >| 640 > 2 files changed, 707 insertions(+) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > new file mode 100644 > index 00..76dd67d1a8 > --- /dev/null > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf > @@ -0,0 +1,67 @@ > +### @file > +# Component information file for the Platform Init Pre-Memory PEI > module. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +### > + > +[Defines] > + INF_VERSION= 0x00010017 > + BASE_NAME = PlatformInitPreMem > + FILE_GUID = 611D-F78F-4FB9-B868-55907F169280 > + VERSION_STRING = 1.0 > + MODULE_TYPE= PEIM > + ENTRY_POINT= PlatformInitPreMemEntryPoint > + > +[LibraryClasses] > + BaseMemoryLib > + BoardInitLib > + DebugLib > + HobLib > + IoLib > + MemoryAllocationLib > + MtrrLib > + PeimEntryPoint > + PeiServicesLib > + ReportFvLib > + TestPointCheckLib > + TimerLib > + > +[Packages] > + MinPlatformPkg/MinPlatformPkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + UefiCpuPkg/UefiCpuPkg.dec > + > +[Pcd] > + gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode ## > CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress## > CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize ## > CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit ## > CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit## > CONSUMES > + > +[FixedPcd] > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiReservedMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiRtDataMemorySize > ## CONSUMES > + gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiRtCodeMemorySize > ## CONSUMES > + > +[Sources] > + PlatformInitPreMem.c > + > +[Ppis] > + gEfiPeiMemoryDiscoveredPpiGuid > + gEfiPeiMasterBootModePpiGuid ## PRODUCES > + gEfiPeiBootInRecoveryModePpiGuid ## PRODUCES > + gEfiPeiReadOnlyVariable2PpiGuid > + gPeiBaseMemoryTestPpiGuid > + gPeiPlatformMemorySizePpiGuid > + > +[Guids] > + gEfiMemoryTypeInformationGuid > + > +[Depex] > + gEfiPeiReadOnlyVariable2PpiGuid > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c > > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c > new file mode 100644 > index 00..b784026c1b > --- /dev/null > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c > @@ -0,0 +1,640 @@ > +/** @file > + Source code file for Platform Init Pre-Memory PEI module > + > +Copyright (c) 2019, Intel Corporation. All rights reserved. > +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +EFI_STATUS > +EFIAPI > +MemoryDiscoveredPpiNotifyCallback ( > + IN CONST EFI_PEI_SERVICES **PeiServices, > + IN EFI_PEI_NOTIFY_DESCRIPTOR *NotifyDescriptor, > + IN VOID*Ppi > + ); > + > +EFI_STATUS > +EFIAPI > +Ge