Re: [edk2-devel] [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files
Reviewed-by: Jeremy Soller On Fri, Sep 20, 2019, at 12:40 PM, Kubacki, Michael A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > * Adds files required to build the GalagoPro3 board to the board >directory. > * Updates KabylakeOpenBoardPkg/OpenBoardPkg.dec to reference >the new GalagoPro3 board directory. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > | 4 +- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > | 385 +++ > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgBuildOption.dsc > | 151 + > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgConfig.dsc > | 132 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > | 265 > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude.fdf > | 48 ++ > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > | 716 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > | 33 + > 8 files changed, 1732 insertions(+), 2 deletions(-) > > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > index 383c34537d..bdaf728af1 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > @@ -1,5 +1,5 @@ > ## @file > -# Module describe the entire platform configuration. > +# Declaration file for Kaby Lake based boards. > # > # The DEC files are used by the utilities that parse DSC and > # INF files to generate AutoGen.c and AutoGen.h files > @@ -20,6 +20,7 @@ PACKAGE_GUID = 0A8BA6E8-C8AC-4AC1-87AC-52772FA6AE5E > > [Includes] > Include > +GalagoPro3/Include > KabylakeRvp3/Include > Features/Tbt/Include > > @@ -303,7 +304,6 @@ > gBoardModuleTokenSpaceGuid.PcdIoExpanderPresent|FALSE|BOOLEAN|0x00EC > >gBoardModuleTokenSpaceGuid.PcdAcpiGnvsAddress|0|UINT64|0x4013 > > - # gIntelPeiGraphicsVbtGuid = {0x4ad46122, 0xffeb, 0x4a52, {0xbf, > 0xb0, 0x51, 0x8c, 0xfc, 0xa0, 0x2d, 0xb0}} >gBoardModuleTokenSpaceGuid.PcdGraphicsVbtGuid|{0x22, 0x61, 0xd4, > 0x4a, 0xeb, 0xff, 0x52, 0x4a, 0xbf, 0xb0, 0x51, 0x8c, 0xfc, 0xa0, 0x2d, > 0xb0}|VOID*|0x4014 > > [PcdsDynamicEx] > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > new file mode 100644 > index 00..3e7f5c6b8a > --- /dev/null > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -0,0 +1,385 @@ > +## @file > +# System 76 GalagoPro3 board description file. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > +[Defines] > + # > + # Set platform specific package/folder name, same as passed from > PREBUILD script. > + # PLATFORM_PACKAGE would be the same as PLATFORM_NAME as well as > package build folder > + # DEFINE only takes effect at R9 DSC and FDF. > + # > + DEFINE PLATFORM_PACKAGE= MinPlatformPkg > + DEFINE PLATFORM_SI_PACKAGE = KabylakeSiliconPkg > + DEFINE PLATFORM_SI_BIN_PACKAGE = KabylakeSiliconBinPkg > + DEFINE PLATFORM_FSP_BIN_PACKAGE= KabylakeFspBinPkg > + DEFINE PLATFORM_BOARD_PACKAGE = KabylakeOpenBoardPkg > + DEFINE BOARD = GalagoPro3 > + DEFINE PROJECT = > $(PLATFORM_BOARD_PACKAGE)/$(BOARD) > + > + # > + # Platform On/Off features are defined here > + # > + !include OpenBoardPkgConfig.dsc > + > + > +# > +# Defines Section - statements that will be processed to create a > Makefile. > +# > + > +[Defines] > + PLATFORM_NAME = $(PLATFORM_PACKAGE) > + PLATFORM_GUID = > 7324F33D-4E96-4F8B-A550-544DE6162AB7 > + PLATFORM_VERSION= 0.1 > + DSC_SPECIFICATION = 0x00010005 > + OUTPUT_DIRECTORY= Build/$(PROJECT) > + SUPPORTED_ARCHITECTURES = IA32|X64 > + BUILD_TARGETS = DEBUG|RELEASE > + SKUID_IDENTIFIER= ALL > + > + > + FLASH_DEFINITION= $(PROJECT)/OpenBoardPkg.fdf > + > + FIX_LOAD_TOP_MEMORY_ADDRESS = 0x0 > + DEFINE TOP_MEMORY_ADDRESS = 0x0 > + > + # > + # Default value for OpenBoardPkg.fdf use > + # > + DEFINE BIOS_SIZE_OPTION = SIZE_60 > + >
Re: [edk2-devel] [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Saturday, September 21, 2019 2:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Jeremy Soller > Subject: [edk2-devel] [edk2-platforms][PATCH V1 11/12] > KabylakeOpenBoardPkg/GalagoPro3: Add build files > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > * Adds files required to build the GalagoPro3 board to the board >directory. > * Updates KabylakeOpenBoardPkg/OpenBoardPkg.dec to reference >the new GalagoPro3 board directory. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > | 4 +- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > | 385 +++ > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgBuildOpti > on.dsc | 151 + > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgConfig.dsc > | 132 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc > | 265 > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInc > lude.fdf | 48 ++ > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > | 716 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > | 33 + > 8 files changed, 1732 insertions(+), 2 deletions(-) > > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > index 383c34537d..bdaf728af1 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > @@ -1,5 +1,5 @@ > ## @file > -# Module describe the entire platform configuration. > +# Declaration file for Kaby Lake based boards. > # > # The DEC files are used by the utilities that parse DSC and > # INF files to generate AutoGen.c and AutoGen.h files > @@ -20,6 +20,7 @@ PACKAGE_GUID = > 0A8BA6E8-C8AC-4AC1-87AC-52772FA6AE5E > > [Includes] > Include > +GalagoPro3/Include > KabylakeRvp3/Include > Features/Tbt/Include > > @@ -303,7 +304,6 @@ > gBoardModuleTokenSpaceGuid.PcdIoExpanderPresent|FALSE|BOOLEAN|0x0 > 0EC > > > gBoardModuleTokenSpaceGuid.PcdAcpiGnvsAddress|0|UINT64|0x4013 > > - # gIntelPeiGraphicsVbtGuid = {0x4ad46122, 0xffeb, 0x4a52, {0xbf, 0xb0, > 0x51, 0x8c, 0xfc, 0xa0, 0x2d, 0xb0}} >gBoardModuleTokenSpaceGuid.PcdGraphicsVbtGuid|{0x22, 0x61, 0xd4, > 0x4a, 0xeb, 0xff, 0x52, 0x4a, 0xbf, 0xb0, 0x51, 0x8c, 0xfc, 0xa0, 0x2d, > 0xb0}|VOID*|0x4014 > > [PcdsDynamicEx] > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > new file mode 100644 > index 00..3e7f5c6b8a > --- /dev/null > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -0,0 +1,385 @@ > +## @file > +# System 76 GalagoPro3 board description file. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > +[Defines] > + # > + # Set platform specific package/folder name, same as passed from > PREBUILD script. > + # PLATFORM_PACKAGE would be the same as PLATFORM_NAME as well > as package build folder > + # DEFINE only takes effect at R9 DSC and FDF. > + # > + DEFINE PLATFORM_PACKAGE= MinPlatformPkg > + DEFINE PLATFORM_SI_PACKAGE = > KabylakeSiliconPkg > + DEFINE PLATFORM_SI_BIN_PACKAGE = > KabylakeSiliconBinPkg > + DEFINE PLATFORM_FSP_BIN_PACKAGE= > KabylakeFspBinPkg > + DEFINE PLATFORM_BOARD_PACKAGE = > KabylakeOpenBoardPkg > + DEFINE BOARD = GalagoPro3 > + DEFINE PROJECT = > $(PLATFORM_BOARD_PACKAGE)/$(BOARD) > + > + # > + # Platform On/Off features are defined here > + # > + !include OpenBoardPkgConfig.dsc > + > +### > # > +# > +# Defines Section - statements that will be processed to create a Makefile. > +# > +### > # > +[Defines] > + PLATFORM_NAME = $(PLATFORM_PACKAGE) > + PLATFORM_GUID = > 7324F33D-4E96-4F8B-A550-544DE6162AB7 > + PLATFORM_VERSION= 0.1 > + DSC
Re: [edk2-devel] [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller Subject: [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 * Adds files required to build the GalagoPro3 board to the board directory. * Updates KabylakeOpenBoardPkg/OpenBoardPkg.dec to reference the new GalagoPro3 board directory. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Ankit Sinha Cc: Jeremy Soller Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec | 4 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 385 +++ Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgBuildOption.dsc | 151 + Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgConfig.dsc | 132 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc | 265 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude.fdf | 48 ++ Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf | 716 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg | 33 + 8 files changed, 1732 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec index 383c34537d..bdaf728af1 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec +++ b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec @@ -1,5 +1,5 @@ ## @file -# Module describe the entire platform configuration. +# Declaration file for Kaby Lake based boards. # # The DEC files are used by the utilities that parse DSC and # INF files to generate AutoGen.c and AutoGen.h files @@ -20,6 +20,7 @@ PACKAGE_GUID = 0A8BA6E8-C8AC-4AC1-87AC-52772FA6AE5E [Includes] Include +GalagoPro3/Include KabylakeRvp3/Include Features/Tbt/Include @@ -303,7 +304,6 @@ gBoardModuleTokenSpaceGuid.PcdIoExpanderPresent|FALSE|BOOLEAN|0x00EC gBoardModuleTokenSpaceGuid.PcdAcpiGnvsAddress|0|UINT64|0x4013 - # gIntelPeiGraphicsVbtGuid = {0x4ad46122, 0xffeb, 0x4a52, {0xbf, 0xb0, 0x51, 0x8c, 0xfc, 0xa0, 0x2d, 0xb0}} gBoardModuleTokenSpaceGuid.PcdGraphicsVbtGuid|{0x22, 0x61, 0xd4, 0x4a, 0xeb, 0xff, 0x52, 0x4a, 0xbf, 0xb0, 0x51, 0x8c, 0xfc, 0xa0, 0x2d, 0xb0}|VOID*|0x4014 [PcdsDynamicEx] diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc new file mode 100644 index 00..3e7f5c6b8a --- /dev/null +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc @@ -0,0 +1,385 @@ +## @file +# System 76 GalagoPro3 board description file. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +## +[Defines] + # + # Set platform specific package/folder name, same as passed from PREBUILD script. + # PLATFORM_PACKAGE would be the same as PLATFORM_NAME as well as package build folder + # DEFINE only takes effect at R9 DSC and FDF. + # + DEFINE PLATFORM_PACKAGE= MinPlatformPkg + DEFINE PLATFORM_SI_PACKAGE = KabylakeSiliconPkg + DEFINE PLATFORM_SI_BIN_PACKAGE = KabylakeSiliconBinPkg + DEFINE PLATFORM_FSP_BIN_PACKAGE= KabylakeFspBinPkg + DEFINE PLATFORM_BOARD_PACKAGE = KabylakeOpenBoardPkg + DEFINE BOARD = GalagoPro3 + DEFINE PROJECT = $(PLATFORM_BOARD_PACKAGE)/$(BOARD) + + # + # Platform On/Off features are defined here + # + !include OpenBoardPkgConfig.dsc + + +# +# Defines Section - statements that will be processed to create a Makefile. +# + +[Defines] + PLATFORM_NAME = $(PLATFORM_PACKAGE) + PLATFORM_GUID = 7324F33D-4E96-4F8B-A550-544DE6162AB7 + PLATFORM_VERSION= 0.1 + DSC_SPECIFICATION = 0x00010005 + OUTPUT_DIRECTORY= Build/$(PROJECT) + SUPPORTED_ARCHITECTURES = IA32|X64 + BUILD_TARGETS = DEBUG|RELEASE + SKUID_IDENTIFIER= ALL + + + FLASH_DEFINITION= $(PROJECT)/OpenBoardPkg.fdf + + FIX_LOAD_TOP_MEMORY_ADDRESS = 0x0 + DEFINE TOP_MEMORY_ADDRESS = 0x0 + + # + # Default value for OpenBoardPkg.fdf use + # + DEFINE BIOS_SIZE_OPTION = SIZE_60 + + +# +# SKU Identification
[edk2-devel] [edk2-platforms][PATCH V1 11/12] KabylakeOpenBoardPkg/GalagoPro3: Add build files
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 * Adds files required to build the GalagoPro3 board to the board directory. * Updates KabylakeOpenBoardPkg/OpenBoardPkg.dec to reference the new GalagoPro3 board directory. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Ankit Sinha Cc: Jeremy Soller Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec | 4 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 385 +++ Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgBuildOption.dsc | 151 + Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgConfig.dsc | 132 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc | 265 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude.fdf | 48 ++ Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf | 716 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg | 33 + 8 files changed, 1732 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec index 383c34537d..bdaf728af1 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec +++ b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec @@ -1,5 +1,5 @@ ## @file -# Module describe the entire platform configuration. +# Declaration file for Kaby Lake based boards. # # The DEC files are used by the utilities that parse DSC and # INF files to generate AutoGen.c and AutoGen.h files @@ -20,6 +20,7 @@ PACKAGE_GUID = 0A8BA6E8-C8AC-4AC1-87AC-52772FA6AE5E [Includes] Include +GalagoPro3/Include KabylakeRvp3/Include Features/Tbt/Include @@ -303,7 +304,6 @@ gBoardModuleTokenSpaceGuid.PcdIoExpanderPresent|FALSE|BOOLEAN|0x00EC gBoardModuleTokenSpaceGuid.PcdAcpiGnvsAddress|0|UINT64|0x4013 - # gIntelPeiGraphicsVbtGuid = {0x4ad46122, 0xffeb, 0x4a52, {0xbf, 0xb0, 0x51, 0x8c, 0xfc, 0xa0, 0x2d, 0xb0}} gBoardModuleTokenSpaceGuid.PcdGraphicsVbtGuid|{0x22, 0x61, 0xd4, 0x4a, 0xeb, 0xff, 0x52, 0x4a, 0xbf, 0xb0, 0x51, 0x8c, 0xfc, 0xa0, 0x2d, 0xb0}|VOID*|0x4014 [PcdsDynamicEx] diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc new file mode 100644 index 00..3e7f5c6b8a --- /dev/null +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc @@ -0,0 +1,385 @@ +## @file +# System 76 GalagoPro3 board description file. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +## +[Defines] + # + # Set platform specific package/folder name, same as passed from PREBUILD script. + # PLATFORM_PACKAGE would be the same as PLATFORM_NAME as well as package build folder + # DEFINE only takes effect at R9 DSC and FDF. + # + DEFINE PLATFORM_PACKAGE= MinPlatformPkg + DEFINE PLATFORM_SI_PACKAGE = KabylakeSiliconPkg + DEFINE PLATFORM_SI_BIN_PACKAGE = KabylakeSiliconBinPkg + DEFINE PLATFORM_FSP_BIN_PACKAGE= KabylakeFspBinPkg + DEFINE PLATFORM_BOARD_PACKAGE = KabylakeOpenBoardPkg + DEFINE BOARD = GalagoPro3 + DEFINE PROJECT = $(PLATFORM_BOARD_PACKAGE)/$(BOARD) + + # + # Platform On/Off features are defined here + # + !include OpenBoardPkgConfig.dsc + + +# +# Defines Section - statements that will be processed to create a Makefile. +# + +[Defines] + PLATFORM_NAME = $(PLATFORM_PACKAGE) + PLATFORM_GUID = 7324F33D-4E96-4F8B-A550-544DE6162AB7 + PLATFORM_VERSION= 0.1 + DSC_SPECIFICATION = 0x00010005 + OUTPUT_DIRECTORY= Build/$(PROJECT) + SUPPORTED_ARCHITECTURES = IA32|X64 + BUILD_TARGETS = DEBUG|RELEASE + SKUID_IDENTIFIER= ALL + + + FLASH_DEFINITION= $(PROJECT)/OpenBoardPkg.fdf + + FIX_LOAD_TOP_MEMORY_ADDRESS = 0x0 + DEFINE TOP_MEMORY_ADDRESS = 0x0 + + # + # Default value for OpenBoardPkg.fdf use + # + DEFINE BIOS_SIZE_OPTION = SIZE_60 + + +# +# SKU Identification section - list of all SKU IDs supported by this +# Platform. +# + +[SkuIds] + 0|DEFAULT # The entry: 0|DEFAULT is reserved and always required. + 0x60|GalagoPro3 +