Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
Thanks for pointing those out. It looks like ArmVExpress.dsc.inc can include it for both of those platforms. I'll add that in a V2. Regards, Michael On 4/25/2022 12:06 PM, Sami Mujawar wrote: Hi Michael, There are other platforms in edk2-platforms that would possibly require similar changes. e.g. Platform\ARM\VExpressPkg\ArmVExpress-FVP-AArch64.dsc, Platform\ARM\JunoPkg\ArmJuno.dsc, etc. Do you plan to submit patches to update these platforms as well? Regards, Sami Mujawar On 20/04/2022 09:44 pm, mikub...@linux.microsoft.com wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This change is made to allow the new variable driver to build that has a dependency on this library class and does not require any further platform changes. Note that this series is for an upcoming change in MdeModulePkg and requires that change to be present locally for testing. https://edk2.groups.io/g/devel/message/88787 Cc: Abner Chang Cc: Ard Biesheuvel Cc: Chasel Chiu Cc: Daniel Schaefer Cc: Eric Dong Cc: Gilbert Chen Cc: Graeme Gregory Cc: Ilias Apalodimas Cc: Jeremy Linton Cc: Leif Lindholm Cc: Liming Gao Cc: Masami Hiramatsu Cc: Nate DeSimone Cc: Radoslaw Biernacki Cc: Sami Mujawar Signed-off-by: Michael Kubacki Michael Kubacki (10): OverdriveBoard: Add VariableFlashInfoLib BeagleBoardPkg: Add VariableFlashInfoLib MinPlatformPkg: Add VariableFlashInfoLib CelloBoard: Add VariableFlashInfoLib SbsaQemu: Add VariableFlashInfoLib RaspberryPi: Add VariableFlashInfoLib U5SeriesPkg: Add VariableFlashInfoLib Socionext: Add VariableFlashInfoLib Softiron: Add VariableFlashInfoLib PlatformStandaloneMmPkg: Add VariableFlashInfoLib Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 + Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 + Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 + Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 + Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 + Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 + Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 + 12 files changed, 12 insertions(+) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89290): https://edk2.groups.io/g/devel/message/89290 Mute This Topic: https://groups.io/mt/90592905/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
Hi Michael, There are other platforms in edk2-platforms that would possibly require similar changes. e.g. Platform\ARM\VExpressPkg\ArmVExpress-FVP-AArch64.dsc, Platform\ARM\JunoPkg\ArmJuno.dsc, etc. Do you plan to submit patches to update these platforms as well? Regards, Sami Mujawar On 20/04/2022 09:44 pm, mikub...@linux.microsoft.com wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This change is made to allow the new variable driver to build that has a dependency on this library class and does not require any further platform changes. Note that this series is for an upcoming change in MdeModulePkg and requires that change to be present locally for testing. https://edk2.groups.io/g/devel/message/88787 Cc: Abner Chang Cc: Ard Biesheuvel Cc: Chasel Chiu Cc: Daniel Schaefer Cc: Eric Dong Cc: Gilbert Chen Cc: Graeme Gregory Cc: Ilias Apalodimas Cc: Jeremy Linton Cc: Leif Lindholm Cc: Liming Gao Cc: Masami Hiramatsu Cc: Nate DeSimone Cc: Radoslaw Biernacki Cc: Sami Mujawar Signed-off-by: Michael Kubacki Michael Kubacki (10): OverdriveBoard: Add VariableFlashInfoLib BeagleBoardPkg: Add VariableFlashInfoLib MinPlatformPkg: Add VariableFlashInfoLib CelloBoard: Add VariableFlashInfoLib SbsaQemu: Add VariableFlashInfoLib RaspberryPi: Add VariableFlashInfoLib U5SeriesPkg: Add VariableFlashInfoLib Socionext: Add VariableFlashInfoLib Softiron: Add VariableFlashInfoLib PlatformStandaloneMmPkg: Add VariableFlashInfoLib Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 + Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 + Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc| 1 + Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + Platform/Qemu/SbsaQemu/SbsaQemu.dsc| 1 + Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 + Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 + Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc| 1 + Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 + 12 files changed, 12 insertions(+) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89279): https://edk2.groups.io/g/devel/message/89279 Mute This Topic: https://groups.io/mt/90592905/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
Hi Michael, 1) This patch series is dependent on the edk2 repo patch series that adds the VariableFlashInfoLib. This patch series cannot be committed until the edk2 changes are committed because it will break all the edk2-platforms if this one is committed first. 2) The related edk2 changes are a breaking change for all downstream platforms that also need to add VariableFlashInfoLib to their DSC files. Should breaking changes like this also require a separate email that is sent to devel@edk2.groups.io, annou...@edk2.groups.io, and disc...@edk2.groups.io to increase the visibility of breaking changes? Series Reviewed-by: Michael D Kinney Best regards, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Wednesday, April 20, 2022 1:44 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Ard Biesheuvel > ; Chiu, Chasel ; > Schaefer, Daniel ; Dong, Eric ; > Gilbert Chen ; Graeme Gregory > ; Ilias Apalodimas ; Jeremy > Linton ; Leif Lindholm > ; Gao, Liming ; Masami > Hiramatsu ; Desimone, > Nathaniel L ; Radoslaw Biernacki > ; Sami Mujawar > Subject: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add > variableFlashInfoLib > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 > > Adds an instance for the library class VariableFlashInfoLib that > was recently introduced in MdeModulePkg. This change is made to > allow the new variable driver to build that has a dependency on > this library class and does not require any further platform > changes. > > Note that this series is for an upcoming change in MdeModulePkg > and requires that change to be present locally for testing. > > https://edk2.groups.io/g/devel/message/88787 > > Cc: Abner Chang > Cc: Ard Biesheuvel > Cc: Chasel Chiu > Cc: Daniel Schaefer > Cc: Eric Dong > Cc: Gilbert Chen > Cc: Graeme Gregory > Cc: Ilias Apalodimas > Cc: Jeremy Linton > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Masami Hiramatsu > Cc: Nate DeSimone > Cc: Radoslaw Biernacki > Cc: Sami Mujawar > Signed-off-by: Michael Kubacki > > Michael Kubacki (10): > OverdriveBoard: Add VariableFlashInfoLib > BeagleBoardPkg: Add VariableFlashInfoLib > MinPlatformPkg: Add VariableFlashInfoLib > CelloBoard: Add VariableFlashInfoLib > SbsaQemu: Add VariableFlashInfoLib > RaspberryPi: Add VariableFlashInfoLib > U5SeriesPkg: Add VariableFlashInfoLib > Socionext: Add VariableFlashInfoLib > Softiron: Add VariableFlashInfoLib > PlatformStandaloneMmPkg: Add VariableFlashInfoLib > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | > 1 + > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | > 1 + > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc| > 1 + > Platform/LeMaker/CelloBoard/CelloBoard.dsc | > 1 + > Platform/Qemu/SbsaQemu/SbsaQemu.dsc| > 1 + > Platform/RaspberryPi/RPi3/RPi3.dsc | > 1 + > Platform/RaspberryPi/RPi4/RPi4.dsc | > 1 + > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | > 1 + > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | > 1 + > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | > 1 + > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc| > 1 + > Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | > 1 + > 12 files changed, 12 insertions(+) > > -- > 2.28.0.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#89148): https://edk2.groups.io/g/devel/message/89148 > Mute This Topic: https://groups.io/mt/90592905/1643496 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kin...@intel.com] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89240): https://edk2.groups.io/g/devel/message/89240 Mute This Topic: https://groups.io/mt/90592905/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
Reminder to all to review this series for your package. It is a simple change needed to keep your package building. So far, only Abner Chang has responded for U5SeriesPkg. On 4/20/2022 4:44 PM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This change is made to allow the new variable driver to build that has a dependency on this library class and does not require any further platform changes. Note that this series is for an upcoming change in MdeModulePkg and requires that change to be present locally for testing. https://edk2.groups.io/g/devel/message/88787 Cc: Abner Chang Cc: Ard Biesheuvel Cc: Chasel Chiu Cc: Daniel Schaefer Cc: Eric Dong Cc: Gilbert Chen Cc: Graeme Gregory Cc: Ilias Apalodimas Cc: Jeremy Linton Cc: Leif Lindholm Cc: Liming Gao Cc: Masami Hiramatsu Cc: Nate DeSimone Cc: Radoslaw Biernacki Cc: Sami Mujawar Signed-off-by: Michael Kubacki Michael Kubacki (10): OverdriveBoard: Add VariableFlashInfoLib BeagleBoardPkg: Add VariableFlashInfoLib MinPlatformPkg: Add VariableFlashInfoLib CelloBoard: Add VariableFlashInfoLib SbsaQemu: Add VariableFlashInfoLib RaspberryPi: Add VariableFlashInfoLib U5SeriesPkg: Add VariableFlashInfoLib Socionext: Add VariableFlashInfoLib Softiron: Add VariableFlashInfoLib PlatformStandaloneMmPkg: Add VariableFlashInfoLib Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 + Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 + Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc| 1 + Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + Platform/Qemu/SbsaQemu/SbsaQemu.dsc| 1 + Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 + Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 + Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc| 1 + Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 + 12 files changed, 12 insertions(+) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89227): https://edk2.groups.io/g/devel/message/89227 Mute This Topic: https://groups.io/mt/90592905/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This change is made to allow the new variable driver to build that has a dependency on this library class and does not require any further platform changes. Note that this series is for an upcoming change in MdeModulePkg and requires that change to be present locally for testing. https://edk2.groups.io/g/devel/message/88787 Cc: Abner Chang Cc: Ard Biesheuvel Cc: Chasel Chiu Cc: Daniel Schaefer Cc: Eric Dong Cc: Gilbert Chen Cc: Graeme Gregory Cc: Ilias Apalodimas Cc: Jeremy Linton Cc: Leif Lindholm Cc: Liming Gao Cc: Masami Hiramatsu Cc: Nate DeSimone Cc: Radoslaw Biernacki Cc: Sami Mujawar Signed-off-by: Michael Kubacki Michael Kubacki (10): OverdriveBoard: Add VariableFlashInfoLib BeagleBoardPkg: Add VariableFlashInfoLib MinPlatformPkg: Add VariableFlashInfoLib CelloBoard: Add VariableFlashInfoLib SbsaQemu: Add VariableFlashInfoLib RaspberryPi: Add VariableFlashInfoLib U5SeriesPkg: Add VariableFlashInfoLib Socionext: Add VariableFlashInfoLib Softiron: Add VariableFlashInfoLib PlatformStandaloneMmPkg: Add VariableFlashInfoLib Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 + Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 + Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc| 1 + Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + Platform/Qemu/SbsaQemu/SbsaQemu.dsc| 1 + Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 + Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 + Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc| 1 + Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc | 1 + 12 files changed, 12 insertions(+) -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89148): https://edk2.groups.io/g/devel/message/89148 Mute This Topic: https://groups.io/mt/90592905/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
