Re: [edk2-devel] [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs
I found two locations: Silicon\Intel\CoffeelakeSiliconPkg\Cpu\Library\PeiCpuPolicyLib\PeiCpuPolicyLib.c Silicon\Intel\IntelSiliconPkg\Feature\Flash\SpiFvbService\SpiFvbServiceMm.c On 6/30/2021 2:45 AM, Ni, Ray wrote: Ok. I understand your patch just merges the existing PCDs from individual XXSIliconPkgs to IntelSiliconPkg. Are there any modules that use these PCDs in XXSiliconPkgs? -Original Message- From: Michael Kubacki Sent: Wednesday, June 30, 2021 10:27 AM To: Ni, Ray Cc: devel@edk2.groups.io; Chaganty, Rangasai V ; Lou, Yun ; Oram, Isaac W Subject: Re: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs Unfortunately, those cannot be used in the silicon packages. This is not new to this series, see existing code: https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec#L460 https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec#L481 https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec#L845 This series consolidates them to one silicon package declaration. We can clean up further but this series has been out for 2+ months, rebasing 40 patches is costly, and incremental changes can continue to be made in the future. I originally made this series to prepare the code for some Standalone MM changes and those are still waiting to be rebased. On 6/29/2021 1:09 AM, Ni, Ray wrote: Michael, Below PCDs are in MinPlatformPkg. Can you use them instead of adding new ones in IntelSiliconPkg? ## Indicates the MMIO base address of the microcode FV in flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0xFFE6|UINT3 2|0x3004 ## Indicates the size of the microcode FV in flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize|0x000A|UINT3 2|0x3005 ## Indicates the offset of the microcode FV relative to the beginning of flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset|0x0066|UIN T32|0x3006 ## Indicates the offset of the actual microcode content relative to the beginning of the microcode FV. gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv|0x90|UINT32|0x300 7 -Original Message- From: mikub...@linux.microsoft.com Sent: Friday, June 25, 2021 2:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the following PCDs to IntelSiliconPkg.dec to consolidate the PCD to a single silicon declaration file. This allows libraries modules in IntelSiliconPkg to be able to use this PCD. gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec index 097c4ca4d795..fb8391000347 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -91,6 +91,9 @@ [PcdsFeatureFlag] [PcdsFixedAtBuild] gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF80|UINT32|0x0007 gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize|0x0080|UINT32|0x000 8 + + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE6|UI + NT + 32|0x0009 + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A|UI + NT + 32|0x000A + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x0066| + UI + NT32|0x000B [PcdsFixedAtBuild, PcdsPatchableInModule] ## Error code for VTd error. -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77368): https://edk2.groups.io/g/devel/message/77368 Mute This Topic: https://groups.io/mt/83794784/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs
Ok. I understand your patch just merges the existing PCDs from individual XXSIliconPkgs to IntelSiliconPkg. Are there any modules that use these PCDs in XXSiliconPkgs? -Original Message- From: Michael Kubacki Sent: Wednesday, June 30, 2021 10:27 AM To: Ni, Ray Cc: devel@edk2.groups.io; Chaganty, Rangasai V ; Lou, Yun ; Oram, Isaac W Subject: Re: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs Unfortunately, those cannot be used in the silicon packages. This is not new to this series, see existing code: https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec#L460 https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec#L481 https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec#L845 This series consolidates them to one silicon package declaration. We can clean up further but this series has been out for 2+ months, rebasing 40 patches is costly, and incremental changes can continue to be made in the future. I originally made this series to prepare the code for some Standalone MM changes and those are still waiting to be rebased. On 6/29/2021 1:09 AM, Ni, Ray wrote: > Michael, > Below PCDs are in MinPlatformPkg. Can you use them instead of adding new ones > in IntelSiliconPkg? > >## Indicates the MMIO base address of the microcode FV in flash. > > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0xFFE6|UINT3 > 2|0x3004 > >## Indicates the size of the microcode FV in flash. > > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize|0x000A|UINT3 > 2|0x3005 > >## Indicates the offset of the microcode FV relative to the beginning of > flash. > > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset|0x0066|UIN > T32|0x3006 > >## Indicates the offset of the actual microcode content relative to the > beginning of the microcode FV. > > gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv|0x90|UINT32|0x300 > 7 > > > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, June 25, 2021 2:21 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add > microcode FV PCDs > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 > > Adds the following PCDs to IntelSiliconPkg.dec to consolidate the PCD to a > single silicon declaration file. This allows libraries modules in > IntelSiliconPkg to be able to use this PCD. > >gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase >gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize >gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset > > Cc: Ray Ni > Cc: Rangasai V Chaganty > Signed-off-by: Michael Kubacki > Reviewed-by: Nate DeSimone > --- > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > index 097c4ca4d795..fb8391000347 100644 > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > @@ -91,6 +91,9 @@ [PcdsFeatureFlag] > [PcdsFixedAtBuild] > > gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF80|UINT32|0x0007 > > gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize|0x0080|UINT32|0x000 > 8 > + > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE6|UI > + NT > + 32|0x0009 > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A|UI > + NT > + 32|0x000A > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x0066| > + UI > + NT32|0x000B > > [PcdsFixedAtBuild, PcdsPatchableInModule] > ## Error code for VTd error. > -- > 2.28.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77316): https://edk2.groups.io/g/devel/message/77316 Mute This Topic: https://groups.io/mt/83794784/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs
Unfortunately, those cannot be used in the silicon packages. This is not new to this series, see existing code: https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec#L460 https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec#L481 https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec#L845 This series consolidates them to one silicon package declaration. We can clean up further but this series has been out for 2+ months, rebasing 40 patches is costly, and incremental changes can continue to be made in the future. I originally made this series to prepare the code for some Standalone MM changes and those are still waiting to be rebased. On 6/29/2021 1:09 AM, Ni, Ray wrote: Michael, Below PCDs are in MinPlatformPkg. Can you use them instead of adding new ones in IntelSiliconPkg? ## Indicates the MMIO base address of the microcode FV in flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0xFFE6|UINT32|0x3004 ## Indicates the size of the microcode FV in flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize|0x000A|UINT32|0x3005 ## Indicates the offset of the microcode FV relative to the beginning of flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset|0x0066|UINT32|0x3006 ## Indicates the offset of the actual microcode content relative to the beginning of the microcode FV. gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv|0x90|UINT32|0x3007 -Original Message- From: mikub...@linux.microsoft.com Sent: Friday, June 25, 2021 2:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the following PCDs to IntelSiliconPkg.dec to consolidate the PCD to a single silicon declaration file. This allows libraries modules in IntelSiliconPkg to be able to use this PCD. gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec index 097c4ca4d795..fb8391000347 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -91,6 +91,9 @@ [PcdsFeatureFlag] [PcdsFixedAtBuild] gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF80|UINT32|0x0007 gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize|0x0080|UINT32|0x0008 + + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE6|UINT + 32|0x0009 + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A|UINT + 32|0x000A + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x0066|UI + NT32|0x000B [PcdsFixedAtBuild, PcdsPatchableInModule] ## Error code for VTd error. -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77309): https://edk2.groups.io/g/devel/message/77309 Mute This Topic: https://groups.io/mt/83794784/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs
Michael, Below PCDs are in MinPlatformPkg. Can you use them instead of adding new ones in IntelSiliconPkg? ## Indicates the MMIO base address of the microcode FV in flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0xFFE6|UINT32|0x3004 ## Indicates the size of the microcode FV in flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize|0x000A|UINT32|0x3005 ## Indicates the offset of the microcode FV relative to the beginning of flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset|0x0066|UINT32|0x3006 ## Indicates the offset of the actual microcode content relative to the beginning of the microcode FV. gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv|0x90|UINT32|0x3007 -Original Message- From: mikub...@linux.microsoft.com Sent: Friday, June 25, 2021 2:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the following PCDs to IntelSiliconPkg.dec to consolidate the PCD to a single silicon declaration file. This allows libraries modules in IntelSiliconPkg to be able to use this PCD. gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec index 097c4ca4d795..fb8391000347 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -91,6 +91,9 @@ [PcdsFeatureFlag] [PcdsFixedAtBuild] gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF80|UINT32|0x0007 gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize|0x0080|UINT32|0x0008 + + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE6|UINT + 32|0x0009 + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A|UINT + 32|0x000A + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x0066|UI + NT32|0x000B [PcdsFixedAtBuild, PcdsPatchableInModule] ## Error code for VTd error. -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77245): https://edk2.groups.io/g/devel/message/77245 Mute This Topic: https://groups.io/mt/83794784/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs
Hi Michael, Is this change relevant to BZ 3307 ? Not sure if we need this change in IntelSiliconPkg. Recently as part of https://edk2.groups.io/g/devel/topic/82355106#74406, the microcode related PCDs were consolidated and moved into MinPlatformPkg. Did you find use case of microcode related PCds in in IntelSiliconPkg? Regards, Sai -Original Message- From: mikub...@linux.microsoft.com Sent: Friday, June 25, 2021 2:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the following PCDs to IntelSiliconPkg.dec to consolidate the PCD to a single silicon declaration file. This allows libraries modules in IntelSiliconPkg to be able to use this PCD. gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec index 097c4ca4d795..fb8391000347 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -91,6 +91,9 @@ [PcdsFeatureFlag] [PcdsFixedAtBuild] gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF80|UINT32|0x0007 gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize|0x0080|UINT32|0x0008 + + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE6|UINT + 32|0x0009 + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A|UINT + 32|0x000A + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x0066|UI + NT32|0x000B [PcdsFixedAtBuild, PcdsPatchableInModule] ## Error code for VTd error. -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77224): https://edk2.groups.io/g/devel/message/77224 Mute This Topic: https://groups.io/mt/83794784/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the following PCDs to IntelSiliconPkg.dec to consolidate the PCD to a single silicon declaration file. This allows libraries modules in IntelSiliconPkg to be able to use this PCD. gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec index 097c4ca4d795..fb8391000347 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -91,6 +91,9 @@ [PcdsFeatureFlag] [PcdsFixedAtBuild] gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF80|UINT32|0x0007 gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize|0x0080|UINT32|0x0008 + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE6|UINT32|0x0009 + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A|UINT32|0x000A + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x0066|UINT32|0x000B [PcdsFixedAtBuild, PcdsPatchableInModule] ## Error code for VTd error. -- 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77102): https://edk2.groups.io/g/devel/message/77102 Mute This Topic: https://groups.io/mt/83794784/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
