Re: [edk2-devel] [edk2-platforms PATCH 0/8] Marvell Pp2Dxe fixes

2022-04-20 Thread Ard Biesheuvel
On Thu, 7 Apr 2022 at 12:52, Sunny Wang  wrote:
>
> Sorry for the delay and thanks for fixing the issues, Marcin.
>
> The patch series look good to me.  Also, we have tested the patches on a 
> CN9130 based system, and it works fine. The patches fix the SCT failures 
> below, and UEFI network function works fine.
> - PlatformSpecificElements: [FAILED]
> - Shutdown_Func: [FAILED]
> - Start_Conf: [FAILED]
> - Start_Func: [FAILE]
> - Stop_Conf: [FAILED]
>
> Reviewed-by: Sunny Wang 
>

Pushed as 170f455d1b1b..fe223fb30f74

Thanks all,


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89126): https://edk2.groups.io/g/devel/message/89126
Mute This Topic: https://groups.io/mt/89776249/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [edk2-platforms PATCH 0/8] Marvell Pp2Dxe fixes

2022-04-07 Thread Sunny Wang
Sorry for the delay and thanks for fixing the issues, Marcin.

The patch series look good to me.  Also, we have tested the patches on a CN9130 
based system, and it works fine. The patches fix the SCT failures below, and 
UEFI network function works fine.
- PlatformSpecificElements: [FAILED]
- Shutdown_Func: [FAILED]
- Start_Conf: [FAILED]
- Start_Func: [FAILE]
- Stop_Conf: [FAILED]

Reviewed-by: Sunny Wang 

Best Regards,
Sunny
-Original Message-
From: Marcin Wojtas 
Sent: 06 April 2022 21:02
To: edk2-devel-groups-io 
Cc: Leif Lindholm ; Ard Biesheuvel 
; Grzegorz Jaszczyk ; Grzegorz 
Bernacki ; upstr...@semihalf.com; Sunny Wang 

Subject: Re: [edk2-platforms PATCH 0/8] Marvell Pp2Dxe fixes

Hi,


pon., 14 mar 2022 o 16:38 Marcin Wojtas  napisał(a):
>
> Hi,
>
> ES ACS v1.0 test suite (https://github.com/ARM-software/arm-systemready)
> unveiled a number of issues in Pp2Dxe SNP callbacks.
> This patchset fixes all of them and allow for
> successful SCT tests run.
>
> For convenience, the patches are exposed on a public branch:
> https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/pp2dxe-upstream-r20220314
>
> Any comments or remarks would be welcome.
>
> Best regards,
> Marcin
>
> Marcin Wojtas (8):
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpShutdown
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReceiveFilters
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpStart & Pp2SnpStop
>   Marvell/Drivers: Pp2Dxe: Implement Pp2SnpIpToMac
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpGetStatus
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpTransmit
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReset
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReceive
>
>  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 333 ++--
>  1 file changed, 299 insertions(+), 34 deletions(-)
>

Do you have any feedback about the patchset?

Best regards,
Marcin
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88519): https://edk2.groups.io/g/devel/message/88519
Mute This Topic: https://groups.io/mt/89776249/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [edk2-platforms PATCH 0/8] Marvell Pp2Dxe fixes

2022-04-06 Thread Marcin Wojtas
Hi,


pon., 14 mar 2022 o 16:38 Marcin Wojtas  napisał(a):
>
> Hi,
>
> ES ACS v1.0 test suite (https://github.com/ARM-software/arm-systemready)
> unveiled a number of issues in Pp2Dxe SNP callbacks.
> This patchset fixes all of them and allow for
> successful SCT tests run.
>
> For convenience, the patches are exposed on a public branch:
> https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/pp2dxe-upstream-r20220314
>
> Any comments or remarks would be welcome.
>
> Best regards,
> Marcin
>
> Marcin Wojtas (8):
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpShutdown
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReceiveFilters
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpStart & Pp2SnpStop
>   Marvell/Drivers: Pp2Dxe: Implement Pp2SnpIpToMac
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpGetStatus
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpTransmit
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReset
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReceive
>
>  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 333 ++--
>  1 file changed, 299 insertions(+), 34 deletions(-)
>

Do you have any feedback about the patchset?

Best regards,
Marcin


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88478): https://edk2.groups.io/g/devel/message/88478
Mute This Topic: https://groups.io/mt/89776249/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [edk2-platforms PATCH 0/8] Marvell Pp2Dxe fixes

2022-03-14 Thread Marcin Wojtas
Hi,

ES ACS v1.0 test suite (https://github.com/ARM-software/arm-systemready)
unveiled a number of issues in Pp2Dxe SNP callbacks.
This patchset fixes all of them and allow for
successful SCT tests run.

For convenience, the patches are exposed on a public branch:
https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/pp2dxe-upstream-r20220314

Any comments or remarks would be welcome.

Best regards,
Marcin

Marcin Wojtas (8):
  Marvell/Drivers: Pp2Dxe: Fix Pp2SnpShutdown
  Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReceiveFilters
  Marvell/Drivers: Pp2Dxe: Fix Pp2SnpStart & Pp2SnpStop
  Marvell/Drivers: Pp2Dxe: Implement Pp2SnpIpToMac
  Marvell/Drivers: Pp2Dxe: Fix Pp2SnpGetStatus
  Marvell/Drivers: Pp2Dxe: Fix Pp2SnpTransmit
  Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReset
  Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReceive

 Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 333 ++--
 1 file changed, 299 insertions(+), 34 deletions(-)

-- 
2.29.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87539): https://edk2.groups.io/g/devel/message/87539
Mute This Topic: https://groups.io/mt/89776249/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-