Re: [edk2-devel] [edk2-platforms PATCH V1 5/6] Platform/Intel: Removing ACPI FADT PCDs that are redefined

2022-07-07 Thread Oram, Isaac W
Reviewed-by: Isaac Oram 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Sinha, Ankit
Sent: Thursday, July 7, 2022 10:33 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L 
; Oram, Isaac W ; Dong, 
Eric 
Subject: [edk2-devel] [edk2-platforms PATCH V1 5/6] Platform/Intel: Removing 
ACPI FADT PCDs that are redefined

From: ankit13s 

Some PCDs are redefined in board package DEC file. Need to remove them.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec 
b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
index 196460e170b5..766dc5be4f6d 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
@@ -89,8 +89,6 @@ 
gPlatformModuleTokenSpaceGuid.PcdApicIoAddress|0xFEC0|UINT64|0x900D
 gPlatformModuleTokenSpaceGuid.PcdApicIoMmioSize|0x1000|UINT32|0x900E
 gPlatformModuleTokenSpaceGuid.PcdGttMmAddress|0xCF00|UINT64|0x900F
 gPlatformModuleTokenSpaceGuid.PcdGmAdrAddress|0xD000|UINT64|0x9010
-gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x9012
-gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x9013
 
gPlatformModuleTokenSpaceGuid.PcdPcieDockBridgeResourcePatchSmi|0x4D|UINT8|0x9014
 gPlatformModuleTokenSpaceGuid.PcdCmosFastBootDefaultValue|0x01|UINT8|0x9016
 
gPlatformModuleTokenSpaceGuid.PcdCmosDebugPrintErrorLevelDefaultValue|0x8046|UINT32|0x9017
-- 
2.27.0.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91167): https://edk2.groups.io/g/devel/message/91167
Mute This Topic: https://groups.io/mt/92233723/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [edk2-platforms PATCH V1 5/6] Platform/Intel: Removing ACPI FADT PCDs that are redefined

2022-07-07 Thread Sinha, Ankit
From: ankit13s 

Some PCDs are redefined in board package DEC file. Need to remove them.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec 
b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
index 196460e170b5..766dc5be4f6d 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
@@ -89,8 +89,6 @@ 
gPlatformModuleTokenSpaceGuid.PcdApicIoAddress|0xFEC0|UINT64|0x900D
 gPlatformModuleTokenSpaceGuid.PcdApicIoMmioSize|0x1000|UINT32|0x900E
 gPlatformModuleTokenSpaceGuid.PcdGttMmAddress|0xCF00|UINT64|0x900F
 gPlatformModuleTokenSpaceGuid.PcdGmAdrAddress|0xD000|UINT64|0x9010
-gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x9012
-gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x9013
 
gPlatformModuleTokenSpaceGuid.PcdPcieDockBridgeResourcePatchSmi|0x4D|UINT8|0x9014
 gPlatformModuleTokenSpaceGuid.PcdCmosFastBootDefaultValue|0x01|UINT8|0x9016
 
gPlatformModuleTokenSpaceGuid.PcdCmosDebugPrintErrorLevelDefaultValue|0x8046|UINT32|0x9017
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91153): https://edk2.groups.io/g/devel/message/91153
Mute This Topic: https://groups.io/mt/92233723/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-