Re: [edk2-devel] [edk2-platforms PATCH V1 6/6] Platform/Intel: Remove and re-categorize ACPI FADT PCDs

2022-07-07 Thread Oram, Isaac W 
Reviewed-by: Isaac Oram 

-Original Message-
From: Sinha, Ankit  
Sent: Thursday, July 7, 2022 10:34 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L 
; Oram, Isaac W ; Dong, 
Eric 
Subject: [edk2-platforms PATCH V1 6/6] Platform/Intel: Remove and re-categorize 
ACPI FADT PCDs

From: ankit13s 

1. Removing ACPI PCDs that were re-defined in board package 2. Re-categorize 
PCDs based on MinPlatformPkg definition

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec | 16   
Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc |  7 ---
 2 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec 
b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
index 7d8e0f34a104..fa2d61c9a71b 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
@@ -237,17 +237,11 @@
   #  is large enough to meet PEI requirement in the S3 phase.
   # @Prompt Reserved S3 Boot ACPI Memory Size
   
gPlatformModuleTokenSpaceGuid.PcdS3AcpiReservedMemorySize|0x8000|UINT32|0x90010039
-  gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x9012
-  gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x9013
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicCount|0|UINT8|0x9015
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicIdBase|0x09|UINT8|0x9016
   
gPlatformModuleTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000|UINT32|0x9017
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicInterruptBase|24|UINT32|0x9018
 
-
-  gPlatformModuleTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9025
-  gPlatformModuleTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x9026
-  gPlatformModuleTokenSpaceGuid.PcdFadtFlags|0x86A5|UINT32|0x9027
   
gPlatformModuleTokenSpaceGuid.PcdLocalApicAddress|0xFEE0|UINT32|0x900B
   gPlatformModuleTokenSpaceGuid.PcdIoApicAddress|0xFEC0|UINT32|0x900D
   gPlatformModuleTokenSpaceGuid.PcdIoApicId|0x02|UINT8|0x9014
@@ -438,16 +432,6 @@
   #  0x7F, 0xFF, 0x04, 0x00}
   gPlatformModuleTokenSpaceGuid.PcdTrustedConsoleOutputDevicePath|{0x02, 0x01, 
0x0C, 0x00, 0xd0, 0x41, 0x03, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x06, 
0x00,  0x00, 0x02, 0x7F, 0xFF, 0x04, 0x00}|VOID*|0x30C
 
-
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1AEventBlockAddress|0x1800|UINT16|0x00010035
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1BEventBlockAddress|0x|UINT16|0x00010036
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1AControlBlockAddress|0x1804|UINT16|0x0001037
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1BControlBlockAddress|0x|UINT16|0x00010038
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850|UINT16|0x00010039
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UINT16|0x0001003A
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT16|0x0001003B
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x|UINT16|0x0001003C
-
 #
 # UBA_START
 #
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc 
b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
index 8c4b9cf6ce28..cefee8273b27 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
@@ -397,9 +397,6 @@
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicInterruptBase|24
 
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
   gMinPlatformPkgTokenSpaceGuid.PcdLocalApicAddress|0xFEE0
   gMinPlatformPkgTokenSpaceGuid.PcdIoApicAddress|0xFEC0
   gMinPlatformPkgTokenSpaceGuid.PcdIoApicId|0x08
@@ -510,6 +507,10 @@
   gPlatformTokenSpaceGuid.PcdBootMenuFile|{ 0xdc, 0x5b, 0xc2, 0xee, 0xf2, 
0x67, 0x95, 0x4d, 0xb1, 0xd5, 0xf8, 0x1b, 0x20, 0x39, 0xd1, 0x1d }
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0
 
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
+
 [PcdsDynamicExDefault.X64]
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits|8
--
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91168): https://edk2.groups.io/g/devel/message/91168
Mute This Topic: https://groups.io/mt/92233724/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms PATCH V1 6/6] Platform/Intel: Remove and re-categorize ACPI FADT PCDs

2022-07-07 Thread Sinha, Ankit 
From: ankit13s 

1. Removing ACPI PCDs that were re-defined in board package
2. Re-categorize PCDs based on MinPlatformPkg definition

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Eric Dong 

Signed-off-by: Ankit Sinha 
---
 Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec | 16 
 Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc |  7 ---
 2 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec 
b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
index 7d8e0f34a104..fa2d61c9a71b 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec
@@ -237,17 +237,11 @@
   #  is large enough to meet PEI requirement in the S3 phase.
   # @Prompt Reserved S3 Boot ACPI Memory Size
   
gPlatformModuleTokenSpaceGuid.PcdS3AcpiReservedMemorySize|0x8000|UINT32|0x90010039
-  gPlatformModuleTokenSpaceGuid.PcdAcpiEnableSwSmi|0xF0|UINT8|0x9012
-  gPlatformModuleTokenSpaceGuid.PcdAcpiDisableSwSmi|0xF1|UINT8|0x9013
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicCount|0|UINT8|0x9015
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicIdBase|0x09|UINT8|0x9016
   
gPlatformModuleTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000|UINT32|0x9017
   gPlatformModuleTokenSpaceGuid.PcdPcIoApicInterruptBase|24|UINT32|0x9018
 
-
-  gPlatformModuleTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9025
-  gPlatformModuleTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x9026
-  gPlatformModuleTokenSpaceGuid.PcdFadtFlags|0x86A5|UINT32|0x9027
   
gPlatformModuleTokenSpaceGuid.PcdLocalApicAddress|0xFEE0|UINT32|0x900B
   gPlatformModuleTokenSpaceGuid.PcdIoApicAddress|0xFEC0|UINT32|0x900D
   gPlatformModuleTokenSpaceGuid.PcdIoApicId|0x02|UINT8|0x9014
@@ -438,16 +432,6 @@
   #  0x7F, 0xFF, 0x04, 0x00}
   gPlatformModuleTokenSpaceGuid.PcdTrustedConsoleOutputDevicePath|{0x02, 0x01, 
0x0C, 0x00, 0xd0, 0x41, 0x03, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x01, 0x01, 0x06, 
0x00,  0x00, 0x02, 0x7F, 0xFF, 0x04, 0x00}|VOID*|0x30C
 
-
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1AEventBlockAddress|0x1800|UINT16|0x00010035
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1BEventBlockAddress|0x|UINT16|0x00010036
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1AControlBlockAddress|0x1804|UINT16|0x0001037
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm1BControlBlockAddress|0x|UINT16|0x00010038
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850|UINT16|0x00010039
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UINT16|0x0001003A
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT16|0x0001003B
-  
gPlatformModuleTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x|UINT16|0x0001003C
-
 #
 # UBA_START
 #
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc 
b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
index 8c4b9cf6ce28..cefee8273b27 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
+++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
@@ -397,9 +397,6 @@
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicInterruptBase|24
 
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
-  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
   gMinPlatformPkgTokenSpaceGuid.PcdLocalApicAddress|0xFEE0
   gMinPlatformPkgTokenSpaceGuid.PcdIoApicAddress|0xFEC0
   gMinPlatformPkgTokenSpaceGuid.PcdIoApicId|0x08
@@ -510,6 +507,10 @@
   gPlatformTokenSpaceGuid.PcdBootMenuFile|{ 0xdc, 0x5b, 0xc2, 0xee, 0xf2, 
0x67, 0x95, 0x4d, 0xb1, 0xd5, 0xf8, 0x1b, 0x20, 0x39, 0xd1, 0x1d }
   gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicEnable|0x0
 
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x04
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x04A5
+
 [PcdsDynamicExDefault.X64]
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits|8
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91154): https://edk2.groups.io/g/devel/message/91154
Mute This Topic: https://groups.io/mt/92233724/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-