Re: [edk2-devel] [edk2-platforms Patch 14/28] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix the indentation
Reviewed-By: Zailiang Sun
-Original Message-
From: Kinney, Michael D
Sent: Thursday, July 11, 2019 3:05 AM
To: devel@edk2.groups.io
Cc: Gary Lin ; Sun, Zailiang ; Qian, Yi
Subject: [edk2-platforms Patch 14/28] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix the
indentation
From: Gary Lin
Fix the indentation of MiscSystemManufacturerFunction.c to improve the
readability.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
.../MiscSystemManufacturerFunction.c | 51 +--
1 file changed, 24 insertions(+), 27 deletions(-)
diff --git
a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
index f537e0db76..da660cb3a8 100644
---
a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufactu
+++ rerFunction.c
@@ -52,14 +52,14 @@ AddSmbiosManuCallback (
UINTN PdNameStrLen;
UINTN SerialNumStrLen;
UINTN SkuNumberStrLen;
- UINTNFamilyNameStrLen;
+ UINTN FamilyNameStrLen;
EFI_STATUSStatus;
EFI_STRINGManufacturer;
EFI_STRINGProductName;
EFI_STRINGVersion;
EFI_STRINGSerialNumber;
EFI_STRINGSkuNumber;
- EFI_STRING FamilyName;
+ EFI_STRINGFamilyName;
STRING_REFTokenToGet;
EFI_SMBIOS_HANDLE SmbiosHandle;
SMBIOS_TABLE_TYPE1*SmbiosRecord;
@@ -323,40 +323,37 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscSystemManufacturer)
{
EFI_STATUSStatus;
static BOOLEANCallbackIsInstalledManu = FALSE;
- VOID *AddSmbiosManuCallbackNotifyReg;
- EFI_EVENT AddSmbiosManuCallbackEvent;
+ VOID *AddSmbiosManuCallbackNotifyReg;
+ EFI_EVENT AddSmbiosManuCallbackEvent;
if (CallbackIsInstalledManu == FALSE) {
CallbackIsInstalledManu = TRUE;// Prevent more than 1 callback.
DEBUG ((EFI_D_INFO, "Create Smbios Manu callback.\n"));
- //
- // gEfiDxeSmmReadyToLockProtocolGuid is ready
- //
- Status = gBS->CreateEvent (
- EVT_NOTIFY_SIGNAL,
- TPL_CALLBACK,
- (EFI_EVENT_NOTIFY)AddSmbiosManuCallback,
- RecordData,
- &AddSmbiosManuCallbackEvent
- );
+//
+// gEfiDxeSmmReadyToLockProtocolGuid is ready
+//
+Status = gBS->CreateEvent (
+EVT_NOTIFY_SIGNAL,
+TPL_CALLBACK,
+(EFI_EVENT_NOTIFY)AddSmbiosManuCallback,
+RecordData,
+&AddSmbiosManuCallbackEvent
+);
- ASSERT_EFI_ERROR (Status);
- if (EFI_ERROR (Status)) {
+ASSERT_EFI_ERROR (Status);
+if (EFI_ERROR (Status)) {
+ return Status;
+}
+
+Status = gBS->RegisterProtocolNotify (
+&gEfiDxeSmmReadyToLockProtocolGuid,
+AddSmbiosManuCallbackEvent,
+&AddSmbiosManuCallbackNotifyReg
+);
return Status;
-
- }
-
- Status = gBS->RegisterProtocolNotify (
- &gEfiDxeSmmReadyToLockProtocolGuid,
- AddSmbiosManuCallbackEvent,
- &AddSmbiosManuCallbackNotifyReg
- );
-
- return Status;
}
return EFI_SUCCESS;
-
}
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43629): https://edk2.groups.io/g/devel/message/43629
Mute This Topic: https://groups.io/mt/32419735/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms Patch 14/28] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix the indentation
From: Gary Lin
Fix the indentation of MiscSystemManufacturerFunction.c to improve the
readability.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
.../MiscSystemManufacturerFunction.c | 51 +--
1 file changed, 24 insertions(+), 27 deletions(-)
diff --git
a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
index f537e0db76..da660cb3a8 100644
---
a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
+++
b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturerFunction.c
@@ -52,14 +52,14 @@ AddSmbiosManuCallback (
UINTN PdNameStrLen;
UINTN SerialNumStrLen;
UINTN SkuNumberStrLen;
- UINTNFamilyNameStrLen;
+ UINTN FamilyNameStrLen;
EFI_STATUSStatus;
EFI_STRINGManufacturer;
EFI_STRINGProductName;
EFI_STRINGVersion;
EFI_STRINGSerialNumber;
EFI_STRINGSkuNumber;
- EFI_STRING FamilyName;
+ EFI_STRINGFamilyName;
STRING_REFTokenToGet;
EFI_SMBIOS_HANDLE SmbiosHandle;
SMBIOS_TABLE_TYPE1*SmbiosRecord;
@@ -323,40 +323,37 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscSystemManufacturer)
{
EFI_STATUSStatus;
static BOOLEANCallbackIsInstalledManu = FALSE;
- VOID *AddSmbiosManuCallbackNotifyReg;
- EFI_EVENT AddSmbiosManuCallbackEvent;
+ VOID *AddSmbiosManuCallbackNotifyReg;
+ EFI_EVENT AddSmbiosManuCallbackEvent;
if (CallbackIsInstalledManu == FALSE) {
CallbackIsInstalledManu = TRUE;// Prevent more than 1 callback.
DEBUG ((EFI_D_INFO, "Create Smbios Manu callback.\n"));
- //
- // gEfiDxeSmmReadyToLockProtocolGuid is ready
- //
- Status = gBS->CreateEvent (
- EVT_NOTIFY_SIGNAL,
- TPL_CALLBACK,
- (EFI_EVENT_NOTIFY)AddSmbiosManuCallback,
- RecordData,
- &AddSmbiosManuCallbackEvent
- );
+//
+// gEfiDxeSmmReadyToLockProtocolGuid is ready
+//
+Status = gBS->CreateEvent (
+EVT_NOTIFY_SIGNAL,
+TPL_CALLBACK,
+(EFI_EVENT_NOTIFY)AddSmbiosManuCallback,
+RecordData,
+&AddSmbiosManuCallbackEvent
+);
- ASSERT_EFI_ERROR (Status);
- if (EFI_ERROR (Status)) {
+ASSERT_EFI_ERROR (Status);
+if (EFI_ERROR (Status)) {
+ return Status;
+}
+
+Status = gBS->RegisterProtocolNotify (
+&gEfiDxeSmmReadyToLockProtocolGuid,
+AddSmbiosManuCallbackEvent,
+&AddSmbiosManuCallbackNotifyReg
+);
return Status;
-
- }
-
- Status = gBS->RegisterProtocolNotify (
- &gEfiDxeSmmReadyToLockProtocolGuid,
- AddSmbiosManuCallbackEvent,
- &AddSmbiosManuCallbackNotifyReg
- );
-
- return Status;
}
return EFI_SUCCESS;
-
}
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43502): https://edk2.groups.io/g/devel/message/43502
Mute This Topic: https://groups.io/mt/32419735/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
