Oliver: The change is good to me. I also include ARM maintainer Ard to review this change. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> Thanks Liming > -----邮件原件----- > 发件人: Oliver Steffen <ostef...@redhat.com> > 发送时间: 2022年4月20日 16:16 > 收件人: devel@edk2.groups.io > 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn; > yuwei.c...@intel.com; Oliver Steffen <ostef...@redhat.com> > 主题: [PATCH v2 1/1] BaseTools: disable stack protector (gcc, AARCH64) > > Explicity disable the stack protection with > -fno-stack-protection for builds using GCC on > AARCH64. > > The gcc on Ubuntu enables -fstack-protector-strong > by default starting with Ubuntu 21.10. > > GenFw fails if stack protection is enabled. > > Signed-off-by: Oliver Steffen <ostef...@redhat.com> > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > index 9c310cf23d25..1a49671a2708 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1915,7 +1915,7 @@ DEFINE GCC48_ARM_ASM_FLAGS = > $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) DEF(GC > DEFINE GCC48_AARCH64_ASM_FLAGS = $(ARCHASM_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC_ASM_FLAGS) -mlittle-endian > DEFINE GCC48_ARM_CC_FLAGS = $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) DEF(GCC_ARM_CC_FLAGS) -fstack-protector > -mword-relocations > DEFINE GCC48_ARM_CC_XIPFLAGS = > DEF(GCC_ARM_CC_XIPFLAGS) > -DEFINE GCC48_AARCH64_CC_FLAGS = $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) -mcmodel=large DEF(GCC_AARCH64_CC_FLAGS) > +DEFINE GCC48_AARCH64_CC_FLAGS = $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) -mcmodel=large DEF(GCC_AARCH64_CC_FLAGS) > -fno-stack-protector > DEFINE GCC48_AARCH64_CC_XIPFLAGS = > DEF(GCC_AARCH64_CC_XIPFLAGS) > DEFINE GCC48_ARM_DLINK_FLAGS = > DEF(GCC_ARM_DLINK_FLAGS) -Wl,--oformat=elf32-littlearm > DEFINE GCC48_ARM_DLINK2_FLAGS = > DEF(GCC_DLINK2_FLAGS_COMMON) > -Wl,--defsym=PECOFF_HEADER_SIZE=0x220 > -- > 2.36.0
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89165): https://edk2.groups.io/g/devel/message/89165 Mute This Topic: https://groups.io/mt/90597935/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
