Re: 回复：Re: [edk2-devel] Some questions about Azure CI

2022-09-06 Thread Michael D Kinney 
Hi Chao,

You can update the package YAML file to declare ECC exceptions.  Here is an 
example of an existing exception that is similar to your use case.

https://github.com/tianocore/edk2/blob/f0f3f5aae7c4d346ea5e24970936d80dc5b60657/MdeModulePkg/MdeModulePkg.ci.yaml#L14

Mike


From: devel@edk2.groups.io  On Behalf Of Chao Li
Sent: Tuesday, September 6, 2022 7:14 AM
To: Michael Kubacki ; devel 
; Zhang, Shenglei ; Feng, Bob C 

Cc: Kinney, Michael D ; quic_rcran 
; spbrogan ; Gao, Liming 

Subject: 回复：Re: [edk2-devel] Some questions about Azure CI


Hi All,

The UEFI Spec V2.10 was published at the end of Aug, LoongArch is already 
supported by UEFI Spec V2.10, so I think it's time to enable LoongArch port in 
EDKII. As an old issues, I was create CI test on Azure and it still gives me 
the ECC error which is the same as pointed out in the previous email,  the 
detail error refer to: 
https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=50=logs=9701361e-2546-5093-77e5-58c75d95b7ce=27131ef8-75e1-57c3-3236-d806181f2f1f.



All of the errors come from the registers defined of the new Arch , while 
others Arch do not give this error. I think this bug is an obstacle to enabling 
LoongArch in EDKII, so please help me again.



Thanks,

Chao

--


原始邮件

发件人: mikubackmailto:mikub...@linux.microsoft.com>>

收件人: 
develmailto:devel@edk2.groups.io>>,lichaomailto:lic...@loongson.cn>>,Shenglei
 Zhangmailto:shenglei.zh...@intel.com>>,Bob 
Fengmailto:bob.c.f...@intel.com>>

抄送: 
michael.d.kinneymailto:michael.d.kin...@intel.com>>,quic_rcranmailto:quic_rc...@quicinc.com>>,spbroganmailto:spbro...@outlook.com>>,gaolimingmailto:gaolim...@byosoft.com.cn>>

主题: Re: [edk2-devel] Some questions about Azure CI



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93296): https://edk2.groups.io/g/devel/message/93296
Mute This Topic: https://groups.io/mt/93501549/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复：Re: [edk2-devel] Some questions about Azure CI

2022-09-06 Thread Chao Li 
Hi All,The UEFI Spec V2.10 was published at the end of Aug, LoongArch is already supported by UEFI Spec V2.10, so I think it's time to enable LoongArch port in EDKII. As an old issues, I was create CI test on Azure and it still gives me the ECC error which is the same as pointed out in the previous email,  the detail error refer to: https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=50=logs=9701361e-2546-5093-77e5-58c75d95b7ce=27131ef8-75e1-57c3-3236-d806181f2f1f.All of the errors come from the registers defined of the new Arch , while others Arch do not give this error. I think this bug is an obstacle to enabling LoongArch in EDKII, so please help me again.Thanks,
Chao
--原始邮件发件人: mikuback收件人: devel,lichao,Shenglei Zhang,Bob Feng抄送: michael.d.kinney,quic_rcran,spbrogan,gaoliming主题: Re: [edk2-devel] Some questions about Azure CI

 _._,_._,_Groups.io Links:   You receive all messages sent to this group. View/Reply Online (#93226) ||  Mute This Topic  | New TopicYour Subscription | Contact Group Owner |  Unsubscribe  [arch...@mail-archive.com] _._,_._,_

Re: [edk2-devel] Some questions about Azure CI

2022-05-22 Thread Chao Li 
Hi All,
Are you still following this issue? I have been waiting for the best way, thank 
you!

Thanks,
Chao



 -原始邮件-
 发件人: "Michael Kubacki" 
 发送时间: 2022-05-17 00:12:51 (星期二)
 收件人: devel@edk2.groups.io, lic...@loongson.cn, "Shenglei Zhang" 
, "Bob Feng" 
 抄送: "michael.d.kin...@intel.com" , 
"quic_rc...@quicinc.com" , "spbro...@outlook.com" 
, gaolim...@byosoft.com.cn
 主题: Re: [edk2-devel] Some questions about Azure CI
 
 I added some contacts that might know more about what ECC requires in 
 this case. I didn't see any obvious issues in a few of the snippets 
 reported.
 
 Regards,
 Michael
 
 On 5/16/2022 1:15 AM, Chao Li wrote:
  Hi All,
  
  There have one last error about EFI coding style error when buiding 
the 
  package for MdePkg, all errors are register defined.Refer 
  
URL:https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=42view=logsj=39eb2cd7-22b4-5bd2-0a69-7cfb110ec9cet=05ebc774-447e-5082-7d78-51b7641489fdl=511
 
  
  
  
  Such errorscome from adding new ARCH support, andLiming 
has suggested 
  that weupdate the field ExceptionList in MdePkg.ci.yaml to skip 
this 
  issue. I tried it and itpassed, but I don't think it 
isbest way.
  
  
  Question:
  
  Do you orother maintainer know why other ARCH don'tneed 
to do this? If 
  there is another way, we will try it. Please help me!
  
  
  Thanks,
  
  Chao
  
  
  
  -原始邮件-
  *发件人:*"Chao Li" 
  *发送时间:*2022-04-21 09:34:51 (星期四)
  *收件人:* "devel@edk2.groups.io" ,
  "mikub...@linux.microsoft.com" 
  *抄送:* "\"devel@edk2.groups.io\"" ,
  "\"michael.d.kin...@intel.com\"" ,
  "\"quic_rc...@quicinc.com\"" ,
  "\"spbro...@outlook.com\"" 
  *主题:* Re: [edk2-devel] Some questions about Azure CI
  
  Hi Micheal,
  
  Sorry for my so carelessness, I actually fixed our code 
yesterday, I
  think this bug was brought on by when I modified the code
  formatting, I will check carefully next time. Sorry again.
  
  --
  Thanks,
  Chao
  
  
  
  On 4月 20 2022, at 10:45 晚上, "Michael Kubacki"
   wrote:
  
  My understanding is that you were referring to the document on
  my fork
  being difficult to access and you shared a link to your CI
  results that
  does not have the message pointing to the wiki page yet.
  
  This is all correct. The wiki content has moved from my fork 
to the
  official wiki page and the patch that adds the message to the 
CI
  results
  has not been merged yet. It is posted on the mailing list 
here and
  waiting for reviews:
  
  https://edk2.groups.io/g/devel/message/89098
  
  ---
  
  As for your build failing between yesterday and today, note 
that
  the
  builds are based on different commits.
  
  Yesterday:
  
https://github.com/loongson/edk2/commit/8d100910a2ad98b71acaabc0dcdd70be7e0eba63
  
  
  Today:
  
https://github.com/loongson/edk2/commit/6ca5d9d6c55ca773a652fe52508e980c7aa372d3
  
  
  The commits have different content. In particular, I took a
  quick look
  at a build that is failing now (Build_GCC5
  TARGET_MDEMODULE_DEBUG) but
  previously succeeded.
  
  The compilation step is failing for reasons such as the 
following:
  
  INFO -
  
/home/vsts/work/1/s/MdePkg/Include/LoongArch64/ProcessorBind.h:35:24:
  
  error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before
  ‘UINT16’
  INFO - 35 | typedef unsigned shor UINT16;
  
  Notice, that there is a typo introduced in the new commit.
  "shor" versus
  "short", this is what is causing compilation failure.
  
  Here is a comparison of those two commits showing the line in
  ProcessorBind.h that is causing the problem:
  
  
https://github.com/loongson/edk2/compare/8d10091..6ca5d9d#diff-50b24eb92c5785d5c70097a70104040fcacfb70225dd8196c1a97ef3bbb305c8R35-R36
  
  
  Regards,
  Michael
  
  On 4/20/2022 7:08 AM, Chao Li wrote:
Hi Micheal,
   
Do you know if anyone has modified the Azure CI today? 
I did
  a CI test
today, and many modules reported errors, but yesterday, 
only
  two modules
reported errors, I don't know what happened. Please 
refer
  following two
links:
   
Today:
   
  
https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=32view=results
  
   
  
  
Yesterday:

Re: [edk2-devel] Some questions about Azure CI

2022-05-16 Thread Michael Kubacki 
I added some contacts that might know more about what ECC requires in 
this case. I didn't see any obvious issues in a few of the snippets 
reported.


Regards,
Michael

On 5/16/2022 1:15 AM, Chao Li wrote:

Hi All,

There have one last error about EFI coding style error when buiding the 
package for MdePkg, all errors are register defined. Refer 
URL: https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=42=logs=39eb2cd7-22b4-5bd2-0a69-7cfb110ec9ce=05ebc774-447e-5082-7d78-51b7641489fd=511 




Such errors come from adding new ARCH support, and Liming has suggested 
that we update the field ExceptionList in MdePkg.ci.yaml to skip this 
issue. I tried it and it passed, but I don't think it is best way.



Question:

Do you or other maintainer know why other ARCH don't need to do this? If 
there is another way, we will try it. Please help me!



Thanks,

Chao



-原始邮件-
*发件人:*"Chao Li" 
*发送时间:*2022-04-21 09:34:51 (星期四)
*收件人:* "devel@edk2.groups.io" ,
"mikub...@linux.microsoft.com" 
*抄送:* "\"devel@edk2.groups.io\"" ,
"\"michael.d.kin...@intel.com\"" ,
"\"quic_rc...@quicinc.com\"" ,
"\"spbro...@outlook.com\"" 
*主题:* Re: [edk2-devel] Some questions about Azure CI

Hi Micheal,

Sorry for my so carelessness, I actually fixed our code yesterday, I
think this bug was brought on by when I modified the code
formatting, I will check carefully next time. Sorry again.

--
Thanks,
Chao



On 4月 20 2022, at 10:45 晚上, "Michael Kubacki"
 wrote:

My understanding is that you were referring to the document on
my fork
being difficult to access and you shared a link to your CI
results that
does not have the message pointing to the wiki page yet.

This is all correct. The wiki content has moved from my fork to the
official wiki page and the patch that adds the message to the CI
results
has not been merged yet. It is posted on the mailing list here and
waiting for reviews:

https://edk2.groups.io/g/devel/message/89098

---

As for your build failing between yesterday and today, note that
the
builds are based on different commits.

Yesterday:

https://github.com/loongson/edk2/commit/8d100910a2ad98b71acaabc0dcdd70be7e0eba63


Today:

https://github.com/loongson/edk2/commit/6ca5d9d6c55ca773a652fe52508e980c7aa372d3


The commits have different content. In particular, I took a
quick look
at a build that is failing now (Build_GCC5
TARGET_MDEMODULE_DEBUG) but
previously succeeded.

The compilation step is failing for reasons such as the following:

INFO -
/home/vsts/work/1/s/MdePkg/Include/LoongArch64/ProcessorBind.h:35:24:

error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before
‘UINT16’
INFO - 35 | typedef unsigned shor UINT16;

Notice, that there is a typo introduced in the new commit.
"shor" versus
"short", this is what is causing compilation failure.

Here is a comparison of those two commits showing the line in
ProcessorBind.h that is causing the problem:


https://github.com/loongson/edk2/compare/8d10091..6ca5d9d#diff-50b24eb92c5785d5c70097a70104040fcacfb70225dd8196c1a97ef3bbb305c8R35-R36


Regards,
Michael

On 4/20/2022 7:08 AM, Chao Li wrote:
 > Hi Micheal,
 >
 > Do you know if anyone has modified the Azure CI today? I did
a CI test
 > today, and many modules reported errors, but yesterday, only
two modules
 > reported errors, I don't know what happened. Please refer
following two
 > links:
 >
 > Today:
 >

https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=32=results

 >

<https://link.getmailspring.com/link/3fb8cf0a-bf1b-4a0a-924b-3b5f6d7eb...@getmailspring.com/0?redirect=https%3A%2F%2Fdev.azure.com%2Fkilaterlee%2FLoongArch_edk2%2F_build%2Fresults%3FbuildId%3D32%26view%3Dresults=bWlrdWJhY2tAbGludXgubWljcm9zb2Z0LmNvbQ%3D%3D>

 > Yesterday:
 >

https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=31=results

 >

<https://link.getmailspring.com/link/3fb8cf0a-bf1b-4a0a-924b-3b5f6d7eb...@getmailspring.com/1?redirect=https%3A%2F%2Fdev.azure.com%2Fkilaterlee%2FLoongArch_edk2%2F_build%2Fresults%3FbuildId%3D31%26view%3Dresults=bWlrdWJhY2tAbGludXgubWljcm9zb2Z0LmNvbQ%3D%3D>

 >
 > --
 > Thanks,
 > Chao
 > 
 >
 >

Re: [edk2-devel] Some questions about Azure CI

2022-05-15 Thread Chao Li 
Hi All,

There have one last error about EFI coding style error when buiding the package 
for MdePkg, all errors are register defined. Refer URL: 
https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=42=logs=39eb2cd7-22b4-5bd2-0a69-7cfb110ec9ce=05ebc774-447e-5082-7d78-51b7641489fd=511




Such errors come from adding new ARCH support, and Liming has suggested that we 
update the field ExceptionList in MdePkg.ci.yaml to skip this issue. I tried it 
and it passed, but I don't think it is best way.




Question:

Do you or other maintainer know why other ARCH don't need to do this? If there 
is another way, we will try it. Please help me!




Thanks,

Chao



-原始邮件-
发件人:"Chao Li" 
发送时间:2022-04-21 09:34:51 (星期四)
收件人: "devel@edk2.groups.io" , 
"mikub...@linux.microsoft.com" 
抄送: "\"devel@edk2.groups.io\"" , 
"\"michael.d.kin...@intel.com\"" , 
"\"quic_rc...@quicinc.com\"" , 
"\"spbro...@outlook.com\"" 
主题: Re: [edk2-devel] Some questions about Azure CI


Hi Micheal,


Sorry for my so carelessness, I actually fixed our code yesterday, I think this 
bug was brought on by when I modified the code formatting, I will check 
carefully next time. Sorry again.



--
Thanks,
Chao




On 4月 20 2022, at 10:45 晚上, "Michael Kubacki"  
wrote:
My understanding is that you were referring to the document on my fork
being difficult to access and you shared a link to your CI results that
does not have the message pointing to the wiki page yet.


This is all correct. The wiki content has moved from my fork to the
official wiki page and the patch that adds the message to the CI results
has not been merged yet. It is posted on the mailing list here and
waiting for reviews:


https://edk2.groups.io/g/devel/message/89098


---


As for your build failing between yesterday and today, note that the
builds are based on different commits.


Yesterday:
https://github.com/loongson/edk2/commit/8d100910a2ad98b71acaabc0dcdd70be7e0eba63


Today:
https://github.com/loongson/edk2/commit/6ca5d9d6c55ca773a652fe52508e980c7aa372d3


The commits have different content. In particular, I took a quick look
at a build that is failing now (Build_GCC5 TARGET_MDEMODULE_DEBUG) but
previously succeeded.


The compilation step is failing for reasons such as the following:


INFO -
/home/vsts/work/1/s/MdePkg/Include/LoongArch64/ProcessorBind.h:35:24:
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘UINT16’
INFO - 35 | typedef unsigned shor UINT16;


Notice, that there is a typo introduced in the new commit. "shor" versus
"short", this is what is causing compilation failure.


Here is a comparison of those two commits showing the line in
ProcessorBind.h that is causing the problem:


https://github.com/loongson/edk2/compare/8d10091..6ca5d9d#diff-50b24eb92c5785d5c70097a70104040fcacfb70225dd8196c1a97ef3bbb305c8R35-R36


Regards,
Michael


On 4/20/2022 7:08 AM, Chao Li wrote:
> Hi Micheal,
>
> Do you know if anyone has modified the Azure CI today? I did a CI test
> today, and many modules reported errors, but yesterday, only two modules
> reported errors, I don't know what happened. Please refer following two
> links:
>
> Today:
> https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=32=results
> <https://link.getmailspring.com/link/3fb8cf0a-bf1b-4a0a-924b-3b5f6d7eb...@getmailspring.com/0?redirect=https%3A%2F%2Fdev.azure.com%2Fkilaterlee%2FLoongArch_edk2%2F_build%2Fresults%3FbuildId%3D32%26view%3Dresults=bWlrdWJhY2tAbGludXgubWljcm9zb2Z0LmNvbQ%3D%3D>
> Yesterday:
> https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=31=results
> <https://link.getmailspring.com/link/3fb8cf0a-bf1b-4a0a-924b-3b5f6d7eb...@getmailspring.com/1?redirect=https%3A%2F%2Fdev.azure.com%2Fkilaterlee%2FLoongArch_edk2%2F_build%2Fresults%3FbuildId%3D31%26view%3Dresults=bWlrdWJhY2tAbGludXgubWljcm9zb2Z0LmNvbQ%3D%3D>
>
> --
> Thanks,
> Chao
> 
>
>
> On 4月 20 2022, at 6:10 晚上, Chao Li  wrote:
>
> Hi Micheal,
>
> Sorry for late reply, I'm busy with other things, focusing on
> modifying our code, refer to the detailed error log file.
>
> I am learning how to get the detailed log from this link:
> https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
> <https://link.getmailspring.com/link/3fb8cf0a-bf1b-4a0a-924b-3b5f6d7eb...@getmailspring.com/2?redirect=https%3A%2F%2Flink.getmailspring.com%2Flink%2FCA5CE175-A392-4D5E-9BE9-392B7A97BB32%40getmailspring.com%2F0%3Fredirect%3Dhttps%253A%252F%252Fgithub.com%252Fmakubacki%252Ftianocore.github.io%252Fblob%252Fadd_ci_uncrustify_instructions%252FEDK-II-Code-Formatting.md%

回复: [edk2-devel] 回复: edk2-devel] Some questions about Azure CI

2022-04-23 Thread gaoliming 
Chao:

 You can to add them ECC exception list in MdePkg\MdePkg.ci.yaml if they are 
all defined in MdePkg. 

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Chao Li
发送时间: 2022年4月21日 16:53
收件人: "gaoliming" 
抄送: devel@edk2.groups.io; spbro...@outlook.com
主题: Re: [edk2-devel] 回复: edk2-devel] Some questions about Azure CI

 

Hi Liming,

 

For Q2, all ECC errors is come from register naming. I think what you are 
pointing out is not UEFI SPEC, we have the LoongArch ISA manual on GitHub where 
all of register naming are defined. Dose that means it is a public SPEC? If 
yes, what should I do to get the Azure CI ECC to pass?

 

LoongArch ISA manual link: 
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html 
<https://link.getmailspring.com/link/3631883d-61f4-43b6-bfbd-b37c74c06...@getmailspring.com/0?redirect=https%3A%2F%2Floongson.github.io%2FLoongArch-Documentation%2FLoongArch-Vol1-EN.html=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D>
 

 

Hope you reply, thank you!

 

--
Thanks,
Chao


 

On 4月 20 2022, at 7:39 早上, "gaoliming" mailto:gaolim...@byosoft.com.cn> > wrote:

For Q2, if key word is defined in public spec, they can be handled as the 
exception.  You can see MdePkg\MdePkg.ci.yaml EccCheck section that has 
ExceptionList and IgnoreFiles.

 

 

 

Thanks

 

Liming

 

发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>  mailto:devel@edk2.groups.io> > 代表 Sean

发送时间: 2022年4月20日 0:39

收件人: Chao Li mailto:lic...@loongson.cn> >; 
devel@edk2.groups.io <mailto:devel@edk2.groups.io> 

主题: Re: [edk2-devel] Some questions about Azure CI

 

 

Q1 - There should be more details in the actual log file, but your code has 
formatting errors.   In the last few months, the uncrusitfy tool has been 
introduced to get common formatting errors fixed.   See details here: EDK II 
Code Formatting · tianocore/tianocore.github.io Wiki 
<https://link.getmailspring.com/link/3631883d-61f4-43b6-bfbd-b37c74c06...@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Code-Formatting=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D>
 

 

Q2 - New code additions require passing ECC.  You will just need to work 
through the reported errors. 

 

Thanks

Sean

 

  
<https://link.getmailspring.com/open/3631883d-61f4-43b6-bfbd-b37c74c06...@getmailspring.com?me=a03b887c=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D>
 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89243): https://edk2.groups.io/g/devel/message/89243
Mute This Topic: https://groups.io/mt/90658334/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: edk2-devel] Some questions about Azure CI

2022-04-21 Thread Chao Li 
Hi Liming,

For Q2, all ECC errors is come from register naming. I think what you are 
pointing out is not UEFI SPEC, we have the LoongArch ISA manual on GitHub where 
all of register naming are defined. Dose that means it is a public SPEC? If 
yes, what should I do to get the Azure CI ECC to pass?
LoongArch ISA manual link: 
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html 
(https://link.getmailspring.com/link/3631883d-61f4-43b6-bfbd-b37c74c06...@getmailspring.com/0?redirect=https%3A%2F%2Floongson.github.io%2FLoongArch-Documentation%2FLoongArch-Vol1-EN.html=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D)
Hope you reply, thank you!

--
Thanks,
Chao


On 4月 20 2022, at 7:39 早上, "gaoliming"  wrote:
> For Q2, if key word is defined in public spec, they can be handled as the 
> exception. You can see MdePkg\MdePkg.ci.yaml EccCheck section that has 
> ExceptionList and IgnoreFiles.
>
>
> Thanks
> Liming
> 发件人: devel@edk2.groups.io  代表 Sean
> 发送时间: 2022年4月20日 0:39
> 收件人: Chao Li ; devel@edk2.groups.io
> 主题: Re: [edk2-devel] Some questions about Azure CI
>
>
>
>
>
> Q1 - There should be more details in the actual log file, but your code has 
> formatting errors. In the last few months, the uncrusitfy tool has been 
> introduced to get common formatting errors fixed. See details here: EDK II 
> Code Formatting · tianocore/tianocore.github.io Wiki 
> (https://link.getmailspring.com/link/3631883d-61f4-43b6-bfbd-b37c74c06...@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Code-Formatting=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D)
> Q2 - New code additions require passing ECC. You will just need to work 
> through the reported errors.
> Thanks
> Sean
>
>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89178): https://edk2.groups.io/g/devel/message/89178
Mute This Topic: https://groups.io/mt/90602057/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-20 Thread Chao Li 
2526view%253Dlogs%2526j%253D9701361e-2546-5093-77e5-58c75d95b7ce%2526t%253D27131ef8-75e1-57c3-3236-d806181f2f1f%26recipient%3DZGV2ZWxAZWRrMi5ncm91cHMuaW8%253D=bWlrdWJhY2tAbGludXgubWljcm9zb2Z0LmNvbQ%3D%3D>.
> >
> > --
> > Thanks,
> > Chao
> > 
> >
> >
> > On 4月 20 2022, at 9:56 上午, "Michael Kubacki"
> >  wrote:
> >
> > Hi Chao,
> >
> > Are you referring to the change I made to put the link to the
> > instructions in the build log. Here's an example of what that
> > will look
> > like:
> >
> > https://github.com/makubacki/tianocore.github.io/blob/temp_show_uncrustify_ci_link_in_build_log/images/edk-ii-code-formatting/temp-example-instruction-link-in-build-log.png?raw=true
> >
> > (some of the words running together are not in the actual change)
> >
> > I'm open to moving it elsewhere but developers will need to know
> > how to
> > at least find that or they will have trouble fixing build issues.
> >
> > Regards,
> > Michael
> >
> >
> > On 4/19/2022 9:46 PM, Chao Li wrote:
> > > Hi Micheal,
> > > Using the way your provided the link, I found the detail log,
> > thanks,
> > > but this way is not friendly to newbies, because they don't
> > know how to
> > > find the tutorial.:)
> > >
> > > --
> > > Thanks,
> > > Chao
> > > 
> > >
> > >
> > > On 4月 20 2022, at 7:43 早上, "Michael Kubacki"
> > >  wrote:
> > >
> > > The wiki update is here:
> > >
> > https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
> > >
> > > I am waiting for permissions to be updated so I can update
> > the actual
> > > wiki page and then I'll send a patch for the plugin change
> > with the link
> > > to that section.
> > >
> > > Regards,
> > > Michael
> > >
> > > On 4/19/2022 6:15 PM, Michael Kubacki wrote:
> > > > I agree that is ideal but I'm not aware of how to do that
> > at the
> > > moment.
> > > >
> > > > Thanks,
> > > > Michael
> > > >
> > > > On 4/19/2022 4:52 PM, Michael D Kinney wrote:
> > > >> Hi Michael,
> > > >>
> > > >> Can the build log provide a direct link to the log file
> > artifact
> > > if an
> > > >> error is detected?
> > > >>
> > > >> Mike
> > > >>
> > > >>> -Original Message-
> > > >>> From: devel@edk2.groups.io  On
> > Behalf Of
> > > >>> Michael Kubacki
> > > >>> Sent: Tuesday, April 19, 2022 12:42 PM
> > > >>> To: devel@edk2.groups.io; quic_rc...@quicinc.com;
> > > >>> spbro...@outlook.com; Chao Li 
> > > >>> Subject: Re: [edk2-devel] Some questions about Azure CI
> > > >>>
> > > >>> Hi Rebecca,
> > > >>>
> > > >>> We are trying to keep the results reporting experience
> > > consistent with
> > > >>> other plugins and prevent an overwhelming amount of
> > information
> > > being
> > > >>> printed to the build log.
> > > >>>
> > > >>> In case other errors are present, providing high-level
> > > information from
> > > >>> each plugin can help point the user in the right direction to
> > > get more
> > > >>> detail.
> > > >>>
> > > >>> I completely understand the concern though, so I'm
> > planning to make
> > > >>> another step toward providing more information about how to
> > > debug an
> > > >>> issue, when it occurs. That is to put the step-by-step
> > > information about
> > > >>> where to find the file diff into the EDK II Code Formatting
> > > wiki page
> > > >>> and then if a failure occurs, print a link to that section of
> > > the wiki
> > > >>> page. I am hoping this will provide sufficient information to
> > > get to the
> > > >>> file diff at the point of failure.
> > > >>>
> > > >>> I should be able to send these patches later today.
> > > >>>
> > > >>> Regards,
> > > >>> Michael
> > > >>>
> > > >>> On 4/19/2022 12:43 PM, Rebecca Cran wrote:
> > > >>>> Since people are going to keep running into this, could we
> > > just output
> > > >>>> the file diff to the console? That would avoid having to go
> > > hunting for
> > > >>>> the log file.
> > > >>>>
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > >
> > >
> > > Sent from Mailspring
> > > 
> >
> > Sent from Mailspring
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89167): https://edk2.groups.io/g/devel/message/89167
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-20 Thread Michael Kubacki 
gether are not in the actual change)

I'm open to moving it elsewhere but developers will need to know
how to
at least find that or they will have trouble fixing build issues.

Regards,
Michael


On 4/19/2022 9:46 PM, Chao Li wrote:
 > Hi Micheal,
 > Using the way your provided the link, I found the detail log,
thanks,
 > but this way is not friendly to newbies, because they don't
know how to
 > find the tutorial.:)
 >
 > --
 > Thanks,
 > Chao
 > 
 >
 >
 > On 4月 20 2022, at 7:43 早上, "Michael Kubacki"
 >  wrote:
 >
 > The wiki update is here:
 >

https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
 >
 > I am waiting for permissions to be updated so I can update
the actual
 > wiki page and then I'll send a patch for the plugin change
with the link
 > to that section.
 >
 > Regards,
 > Michael
 >
 > On 4/19/2022 6:15 PM, Michael Kubacki wrote:
 > > I agree that is ideal but I'm not aware of how to do that
at the
 > moment.
 > >
 > > Thanks,
 > > Michael
 > >
 > > On 4/19/2022 4:52 PM, Michael D Kinney wrote:
 > >> Hi Michael,
 > >>
 > >> Can the build log provide a direct link to the log file
artifact
 > if an
 > >> error is detected?
 > >>
 > >> Mike
 > >>
 > >>> -Original Message-
 > >>> From: devel@edk2.groups.io  On
    Behalf Of
 > >>> Michael Kubacki
 > >>> Sent: Tuesday, April 19, 2022 12:42 PM
 > >>> To: devel@edk2.groups.io; quic_rc...@quicinc.com;
 > >>> spbro...@outlook.com; Chao Li 
 > >>> Subject: Re: [edk2-devel] Some questions about Azure CI
 > >>>
 > >>> Hi Rebecca,
 > >>>
 > >>> We are trying to keep the results reporting experience
 > consistent with
 > >>> other plugins and prevent an overwhelming amount of
information
 > being
 > >>> printed to the build log.
 > >>>
 > >>> In case other errors are present, providing high-level
 > information from
 > >>> each plugin can help point the user in the right direction to
 > get more
 > >>> detail.
 > >>>
 > >>> I completely understand the concern though, so I'm
planning to make
 > >>> another step toward providing more information about how to
 > debug an
 > >>> issue, when it occurs. That is to put the step-by-step
 > information about
 > >>> where to find the file diff into the EDK II Code Formatting
 > wiki page
 > >>> and then if a failure occurs, print a link to that section of
 > the wiki
 > >>> page. I am hoping this will provide sufficient information to
 > get to the
 > >>> file diff at the point of failure.
 > >>>
 > >>> I should be able to send these patches later today.
 > >>>
 > >>> Regards,
 > >>> Michael
 > >>>
 > >>> On 4/19/2022 12:43 PM, Rebecca Cran wrote:
 > >>>> Since people are going to keep running into this, could we
 > just output
 > >>>> the file diff to the console? That would avoid having to go
 > hunting for
 > >>>> the log file.
 > >>>>
 > >>>
 > >>>
 > >>>
 > >>>
 > >>
 > >>
 > >>
 > >>
 > >>
 > >>
 >
 >
 > Sent from Mailspring
 > 


Sent from Mailspring



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89140): https://edk2.groups.io/g/devel/message/89140
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-20 Thread Chao Li 
Hi Micheal,

Do you know if anyone has modified the Azure CI today? I did a CI test today, 
and many modules reported errors, but yesterday, only two modules reported 
errors, I don't know what happened. Please refer following two links:
Today:
https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=32=results
 
(https://link.getmailspring.com/link/3fb8cf0a-bf1b-4a0a-924b-3b5f6d7eb...@getmailspring.com/0?redirect=https%3A%2F%2Fdev.azure.com%2Fkilaterlee%2FLoongArch_edk2%2F_build%2Fresults%3FbuildId%3D32%26view%3Dresults=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D)
Yesterday:
https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=31=results
 
(https://link.getmailspring.com/link/3fb8cf0a-bf1b-4a0a-924b-3b5f6d7eb...@getmailspring.com/1?redirect=https%3A%2F%2Fdev.azure.com%2Fkilaterlee%2FLoongArch_edk2%2F_build%2Fresults%3FbuildId%3D31%26view%3Dresults=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D)

--
Thanks,
Chao


On 4月 20 2022, at 6:10 晚上, Chao Li  wrote:
> Hi Micheal,
>
> Sorry for late reply, I'm busy with other things, focusing on modifying our 
> code, refer to the detailed error log file.
> I am learning how to get the detailed log from this link:
> https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
>  
> (https://link.getmailspring.com/link/3fb8cf0a-bf1b-4a0a-924b-3b5f6d7eb...@getmailspring.com/2?redirect=https%3A%2F%2Flink.getmailspring.com%2Flink%2FCA5CE175-A392-4D5E-9BE9-392B7A97BB32%40getmailspring.com%2F0%3Fredirect%3Dhttps%253A%252F%252Fgithub.com%252Fmakubacki%252Ftianocore.github.io%252Fblob%252Fadd_ci_uncrustify_instructions%252FEDK-II-Code-Formatting.md%2523how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci%26recipient%3DZGV2ZWxAZWRrMi5ncm91cHMuaW8%253D=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D).
> I didn't find the detailed log link in the Azure error log, it looks like:
> https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=31=logs=9701361e-2546-5093-77e5-58c75d95b7ce=27131ef8-75e1-57c3-3236-d806181f2f1f
>  
> (https://link.getmailspring.com/link/3fb8cf0a-bf1b-4a0a-924b-3b5f6d7eb...@getmailspring.com/3?redirect=https%3A%2F%2Flink.getmailspring.com%2Flink%2FCA5CE175-A392-4D5E-9BE9-392B7A97BB32%40getmailspring.com%2F1%3Fredirect%3Dhttps%253A%252F%252Fdev.azure.com%252Fkilaterlee%252FLoongArch_edk2%252F_build%252Fresults%253FbuildId%253D31%2526view%253Dlogs%2526j%253D9701361e-2546-5093-77e5-58c75d95b7ce%2526t%253D27131ef8-75e1-57c3-3236-d806181f2f1f%26recipient%3DZGV2ZWxAZWRrMi5ncm91cHMuaW8%253D=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D).
>
> --
> Thanks,
> Chao
> 
>
>
>
> On 4月 20 2022, at 9:56 上午, "Michael Kubacki"  
> wrote:
> > Hi Chao,
> >
> > Are you referring to the change I made to put the link to the
> > instructions in the build log. Here's an example of what that will look
> > like:
> >
> > https://github.com/makubacki/tianocore.github.io/blob/temp_show_uncrustify_ci_link_in_build_log/images/edk-ii-code-formatting/temp-example-instruction-link-in-build-log.png?raw=true
> > (some of the words running together are not in the actual change)
> > I'm open to moving it elsewhere but developers will need to know how to
> > at least find that or they will have trouble fixing build issues.
> >
> > Regards,
> > Michael
> >
> >
> > On 4/19/2022 9:46 PM, Chao Li wrote:
> > > Hi Micheal,
> > > Using the way your provided the link, I found the detail log, thanks,
> > > but this way is not friendly to newbies, because they don't know how to
> > > find the tutorial.:)
> > >
> > > --
> > > Thanks,
> > > Chao
> > > 
> > >
> > >
> > > On 4月 20 2022, at 7:43 早上, "Michael Kubacki"
> > >  wrote:
> > >
> > > The wiki update is here:
> > > https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
> > >
> > > I am waiting for permissions to be updated so I can update the actual
> > > wiki page and then I'll send a patch for the plugin change with the link
> > > to that section.
> > >
> > > Regards,
> > > Michael
> > >
> > > On 4/19/2022 6:15 PM, Michael Kubacki wrote:
> > > > I agree that is ideal but I'm not aware of how to do that at the
> > > moment.
> > > >
> > > > Thanks,
> > > > Michael
> > > >
> > > > On 4/19/2022 4:52 PM, Michael D Kinney wrote:
> > > &g

Re: [edk2-devel] Some questions about Azure CI

2022-04-20 Thread Chao Li 
Hi Micheal,

Sorry for late reply, I'm busy with other things, focusing on modifying our 
code, refer to the detailed error log file.
I am learning how to get the detailed log from this link:
https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
 
(https://link.getmailspring.com/link/ca5ce175-a392-4d5e-9be9-392b7a97b...@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2Fmakubacki%2Ftianocore.github.io%2Fblob%2Fadd_ci_uncrustify_instructions%2FEDK-II-Code-Formatting.md%23how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D).
I didn't find the detailed log link in the Azure error log, it looks like:
https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=31=logs=9701361e-2546-5093-77e5-58c75d95b7ce=27131ef8-75e1-57c3-3236-d806181f2f1f
 
(https://link.getmailspring.com/link/ca5ce175-a392-4d5e-9be9-392b7a97b...@getmailspring.com/1?redirect=https%3A%2F%2Fdev.azure.com%2Fkilaterlee%2FLoongArch_edk2%2F_build%2Fresults%3FbuildId%3D31%26view%3Dlogs%26j%3D9701361e-2546-5093-77e5-58c75d95b7ce%26t%3D27131ef8-75e1-57c3-3236-d806181f2f1f=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D).

--
Thanks,
Chao


On 4月 20 2022, at 9:56 上午, "Michael Kubacki"  
wrote:
> Hi Chao,
>
> Are you referring to the change I made to put the link to the
> instructions in the build log. Here's an example of what that will look
> like:
>
> https://github.com/makubacki/tianocore.github.io/blob/temp_show_uncrustify_ci_link_in_build_log/images/edk-ii-code-formatting/temp-example-instruction-link-in-build-log.png?raw=true
> (some of the words running together are not in the actual change)
> I'm open to moving it elsewhere but developers will need to know how to
> at least find that or they will have trouble fixing build issues.
>
> Regards,
> Michael
>
>
> On 4/19/2022 9:46 PM, Chao Li wrote:
> > Hi Micheal,
> > Using the way your provided the link, I found the detail log, thanks,
> > but this way is not friendly to newbies, because they don't know how to
> > find the tutorial.:)
> >
> > --
> > Thanks,
> > Chao
> > 
> >
> >
> > On 4月 20 2022, at 7:43 早上, "Michael Kubacki"
> >  wrote:
> >
> > The wiki update is here:
> > https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
> >
> > I am waiting for permissions to be updated so I can update the actual
> > wiki page and then I'll send a patch for the plugin change with the link
> > to that section.
> >
> > Regards,
> > Michael
> >
> > On 4/19/2022 6:15 PM, Michael Kubacki wrote:
> > > I agree that is ideal but I'm not aware of how to do that at the
> > moment.
> > >
> > > Thanks,
> > > Michael
> > >
> > > On 4/19/2022 4:52 PM, Michael D Kinney wrote:
> > >> Hi Michael,
> > >>
> > >> Can the build log provide a direct link to the log file artifact
> > if an
> > >> error is detected?
> > >>
> > >> Mike
> > >>
> > >>> -Original Message-
> > >>> From: devel@edk2.groups.io  On Behalf Of
> > >>> Michael Kubacki
> > >>> Sent: Tuesday, April 19, 2022 12:42 PM
> > >>> To: devel@edk2.groups.io; quic_rc...@quicinc.com;
> > >>> spbro...@outlook.com; Chao Li 
> > >>> Subject: Re: [edk2-devel] Some questions about Azure CI
> > >>>
> > >>> Hi Rebecca,
> > >>>
> > >>> We are trying to keep the results reporting experience
> > consistent with
> > >>> other plugins and prevent an overwhelming amount of information
> > being
> > >>> printed to the build log.
> > >>>
> > >>> In case other errors are present, providing high-level
> > information from
> > >>> each plugin can help point the user in the right direction to
> > get more
> > >>> detail.
> > >>>
> > >>> I completely understand the concern though, so I'm planning to make
> > >>> another step toward providing more information about how to
> > debug an
> > >>> issue, when it occurs. That is to put the step-by-step
> > information about
> > >>> where to find the file diff into the EDK II Code Formatting
> > wiki page
> > >>> and then if a failure occurs, print a

Re: [edk2-devel] Some questions about Azure CI

2022-04-19 Thread Michael Kubacki 

The TianoCore wiki page is updated:

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci

The patch to point to that section is here:

https://edk2.groups.io/g/devel/message/89098

Regards,
Michael

On 4/19/2022 7:43 PM, Michael Kubacki wrote:

The wiki update is here:
https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci 



I am waiting for permissions to be updated so I can update the actual 
wiki page and then I'll send a patch for the plugin change with the link 
to that section.


Regards,
Michael

On 4/19/2022 6:15 PM, Michael Kubacki wrote:

I agree that is ideal but I'm not aware of how to do that at the moment.

Thanks,
Michael

On 4/19/2022 4:52 PM, Michael D Kinney wrote:

Hi Michael,

Can the build log provide a direct link to the log file artifact if 
an error is detected?


Mike


-Original Message-
From: devel@edk2.groups.io  On Behalf Of 
Michael Kubacki

Sent: Tuesday, April 19, 2022 12:42 PM
To: devel@edk2.groups.io; quic_rc...@quicinc.com; 
spbro...@outlook.com; Chao Li 

Subject: Re: [edk2-devel] Some questions about Azure CI

Hi Rebecca,

We are trying to keep the results reporting experience consistent with
other plugins and prevent an overwhelming amount of information being
printed to the build log.

In case other errors are present, providing high-level information from
each plugin can help point the user in the right direction to get more
detail.

I completely understand the concern though, so I'm planning to make
another step toward providing more information about how to debug an
issue, when it occurs. That is to put the step-by-step information 
about

where to find the file diff into the EDK II Code Formatting wiki page
and then if a failure occurs, print a link to that section of the wiki
page. I am hoping this will provide sufficient information to get to 
the

file diff at the point of failure.

I should be able to send these patches later today.

Regards,
Michael

On 4/19/2022 12:43 PM, Rebecca Cran wrote:

Since people are going to keep running into this, could we just output
the file diff to the console? That would avoid having to go hunting 
for

the log file.
















-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89103): https://edk2.groups.io/g/devel/message/89103
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-19 Thread Michael Kubacki 

Hi Chao,

Are you referring to the change I made to put the link to the 
instructions in the build log. Here's an example of what that will look 
like:


https://github.com/makubacki/tianocore.github.io/blob/temp_show_uncrustify_ci_link_in_build_log/images/edk-ii-code-formatting/temp-example-instruction-link-in-build-log.png?raw=true

(some of the words running together are not in the actual change)

I'm open to moving it elsewhere but developers will need to know how to 
at least find that or they will have trouble fixing build issues.


Regards,
Michael


On 4/19/2022 9:46 PM, Chao Li wrote:

Hi Micheal,
Using the way your provided the link, I found the detail log, thanks, 
but this way is not friendly to newbies, because they don't know how to 
find the tutorial.:)


--
Thanks,
Chao



On 4月 20 2022, at 7:43 早上, "Michael Kubacki" 
 wrote:


The wiki update is here:

https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci

I am waiting for permissions to be updated so I can update the actual
wiki page and then I'll send a patch for the plugin change with the link
to that section.

Regards,
Michael

On 4/19/2022 6:15 PM, Michael Kubacki wrote:
 > I agree that is ideal but I'm not aware of how to do that at the
moment.
 >
 > Thanks,
 > Michael
 >
 > On 4/19/2022 4:52 PM, Michael D Kinney wrote:
 >> Hi Michael,
 >>
 >> Can the build log provide a direct link to the log file artifact
if an
 >> error is detected?
 >>
 >> Mike
 >>
 >>> -Original Message-
 >>> From: devel@edk2.groups.io  On Behalf Of
 >>> Michael Kubacki
 >>> Sent: Tuesday, April 19, 2022 12:42 PM
 >>> To: devel@edk2.groups.io; quic_rc...@quicinc.com;
 >>> spbro...@outlook.com; Chao Li 
 >>> Subject: Re: [edk2-devel] Some questions about Azure CI
 >>>
 >>> Hi Rebecca,
 >>>
 >>> We are trying to keep the results reporting experience
consistent with
 >>> other plugins and prevent an overwhelming amount of information
being
 >>> printed to the build log.
 >>>
 >>> In case other errors are present, providing high-level
information from
 >>> each plugin can help point the user in the right direction to
get more
 >>> detail.
 >>>
 >>> I completely understand the concern though, so I'm planning to make
 >>> another step toward providing more information about how to
debug an
 >>> issue, when it occurs. That is to put the step-by-step
information about
 >>> where to find the file diff into the EDK II Code Formatting
wiki page
 >>> and then if a failure occurs, print a link to that section of
the wiki
 >>> page. I am hoping this will provide sufficient information to
get to the
 >>> file diff at the point of failure.
 >>>
 >>> I should be able to send these patches later today.
 >>>
 >>> Regards,
 >>> Michael
 >>>
 >>> On 4/19/2022 12:43 PM, Rebecca Cran wrote:
 >>>> Since people are going to keep running into this, could we
just output
 >>>> the file diff to the console? That would avoid having to go
hunting for
 >>>> the log file.
 >>>>
 >>>
 >>>
 >>>
 >>>
 >>
 >>
 >>
 >>
 >>
 >>


Sent from Mailspring




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89102): https://edk2.groups.io/g/devel/message/89102
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-19 Thread Chao Li 
Hi Micheal,
Using the way your provided the link, I found the detail log, thanks, but this 
way is not friendly to newbies, because they don't know how to find the 
tutorial.:)

--
Thanks,
Chao


On 4月 20 2022, at 7:43 早上, "Michael Kubacki"  
wrote:
> The wiki update is here:
> https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
>
> I am waiting for permissions to be updated so I can update the actual
> wiki page and then I'll send a patch for the plugin change with the link
> to that section.
>
> Regards,
> Michael
>
> On 4/19/2022 6:15 PM, Michael Kubacki wrote:
> > I agree that is ideal but I'm not aware of how to do that at the moment.
> >
> > Thanks,
> > Michael
> >
> > On 4/19/2022 4:52 PM, Michael D Kinney wrote:
> >> Hi Michael,
> >>
> >> Can the build log provide a direct link to the log file artifact if an
> >> error is detected?
> >>
> >> Mike
> >>
> >>> -Original Message-
> >>> From: devel@edk2.groups.io  On Behalf Of
> >>> Michael Kubacki
> >>> Sent: Tuesday, April 19, 2022 12:42 PM
> >>> To: devel@edk2.groups.io; quic_rc...@quicinc.com;
> >>> spbro...@outlook.com; Chao Li 
> >>> Subject: Re: [edk2-devel] Some questions about Azure CI
> >>>
> >>> Hi Rebecca,
> >>>
> >>> We are trying to keep the results reporting experience consistent with
> >>> other plugins and prevent an overwhelming amount of information being
> >>> printed to the build log.
> >>>
> >>> In case other errors are present, providing high-level information from
> >>> each plugin can help point the user in the right direction to get more
> >>> detail.
> >>>
> >>> I completely understand the concern though, so I'm planning to make
> >>> another step toward providing more information about how to debug an
> >>> issue, when it occurs. That is to put the step-by-step information about
> >>> where to find the file diff into the EDK II Code Formatting wiki page
> >>> and then if a failure occurs, print a link to that section of the wiki
> >>> page. I am hoping this will provide sufficient information to get to the
> >>> file diff at the point of failure.
> >>>
> >>> I should be able to send these patches later today.
> >>>
> >>> Regards,
> >>> Michael
> >>>
> >>> On 4/19/2022 12:43 PM, Rebecca Cran wrote:
> >>>> Since people are going to keep running into this, could we just output
> >>>> the file diff to the console? That would avoid having to go hunting for
> >>>> the log file.
> >>>>
> >>>
> >>>
> >>>
> >>>
> >>
> >>
> >>
> >>
> >>
> >>
>
>
> 
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89100): https://edk2.groups.io/g/devel/message/89100
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-19 Thread Michael Kubacki 

The wiki update is here:
https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci

I am waiting for permissions to be updated so I can update the actual 
wiki page and then I'll send a patch for the plugin change with the link 
to that section.


Regards,
Michael

On 4/19/2022 6:15 PM, Michael Kubacki wrote:

I agree that is ideal but I'm not aware of how to do that at the moment.

Thanks,
Michael

On 4/19/2022 4:52 PM, Michael D Kinney wrote:

Hi Michael,

Can the build log provide a direct link to the log file artifact if an 
error is detected?


Mike


-Original Message-
From: devel@edk2.groups.io  On Behalf Of 
Michael Kubacki

Sent: Tuesday, April 19, 2022 12:42 PM
To: devel@edk2.groups.io; quic_rc...@quicinc.com; 
spbro...@outlook.com; Chao Li 

Subject: Re: [edk2-devel] Some questions about Azure CI

Hi Rebecca,

We are trying to keep the results reporting experience consistent with
other plugins and prevent an overwhelming amount of information being
printed to the build log.

In case other errors are present, providing high-level information from
each plugin can help point the user in the right direction to get more
detail.

I completely understand the concern though, so I'm planning to make
another step toward providing more information about how to debug an
issue, when it occurs. That is to put the step-by-step information about
where to find the file diff into the EDK II Code Formatting wiki page
and then if a failure occurs, print a link to that section of the wiki
page. I am hoping this will provide sufficient information to get to the
file diff at the point of failure.

I should be able to send these patches later today.

Regards,
Michael

On 4/19/2022 12:43 PM, Rebecca Cran wrote:

Since people are going to keep running into this, could we just output
the file diff to the console? That would avoid having to go hunting for
the log file.
















-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89092): https://edk2.groups.io/g/devel/message/89092
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] Some questions about Azure CI

2022-04-19 Thread gaoliming 
For Q2, if key word is defined in public spec, they can be handled as the 
exception.  You can see MdePkg\MdePkg.ci.yaml EccCheck section that has 
ExceptionList and IgnoreFiles. 

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Sean
发送时间: 2022年4月20日 0:39
收件人: Chao Li ; devel@edk2.groups.io
主题: Re: [edk2-devel] Some questions about Azure CI

 

Q1 - There should be more details in the actual log file, but your code has 
formatting errors.   In the last few months, the uncrusitfy tool has been 
introduced to get common formatting errors fixed.   See details here: EDK II 
Code Formatting · tianocore/tianocore.github.io Wiki 
<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting> 

Q2 - New code additions require passing ECC.  You will just need to work 
through the reported errors. 

Thanks
Sean 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89091): https://edk2.groups.io/g/devel/message/89091
Mute This Topic: https://groups.io/mt/90574287/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-19 Thread Michael Kubacki 

I agree that is ideal but I'm not aware of how to do that at the moment.

Thanks,
Michael

On 4/19/2022 4:52 PM, Michael D Kinney wrote:

Hi Michael,

Can the build log provide a direct link to the log file artifact if an error is 
detected?

Mike


-Original Message-
From: devel@edk2.groups.io  On Behalf Of Michael Kubacki
Sent: Tuesday, April 19, 2022 12:42 PM
To: devel@edk2.groups.io; quic_rc...@quicinc.com; spbro...@outlook.com; Chao Li 

Subject: Re: [edk2-devel] Some questions about Azure CI

Hi Rebecca,

We are trying to keep the results reporting experience consistent with
other plugins and prevent an overwhelming amount of information being
printed to the build log.

In case other errors are present, providing high-level information from
each plugin can help point the user in the right direction to get more
detail.

I completely understand the concern though, so I'm planning to make
another step toward providing more information about how to debug an
issue, when it occurs. That is to put the step-by-step information about
where to find the file diff into the EDK II Code Formatting wiki page
and then if a failure occurs, print a link to that section of the wiki
page. I am hoping this will provide sufficient information to get to the
file diff at the point of failure.

I should be able to send these patches later today.

Regards,
Michael

On 4/19/2022 12:43 PM, Rebecca Cran wrote:

Since people are going to keep running into this, could we just output
the file diff to the console? That would avoid having to go hunting for
the log file.
















-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89089): https://edk2.groups.io/g/devel/message/89089
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-19 Thread Michael D Kinney 
Hi Michael,

Can the build log provide a direct link to the log file artifact if an error is 
detected?

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Michael Kubacki
> Sent: Tuesday, April 19, 2022 12:42 PM
> To: devel@edk2.groups.io; quic_rc...@quicinc.com; spbro...@outlook.com; Chao 
> Li 
> Subject: Re: [edk2-devel] Some questions about Azure CI
> 
> Hi Rebecca,
> 
> We are trying to keep the results reporting experience consistent with
> other plugins and prevent an overwhelming amount of information being
> printed to the build log.
> 
> In case other errors are present, providing high-level information from
> each plugin can help point the user in the right direction to get more
> detail.
> 
> I completely understand the concern though, so I'm planning to make
> another step toward providing more information about how to debug an
> issue, when it occurs. That is to put the step-by-step information about
> where to find the file diff into the EDK II Code Formatting wiki page
> and then if a failure occurs, print a link to that section of the wiki
> page. I am hoping this will provide sufficient information to get to the
> file diff at the point of failure.
> 
> I should be able to send these patches later today.
> 
> Regards,
> Michael
> 
> On 4/19/2022 12:43 PM, Rebecca Cran wrote:
> > Since people are going to keep running into this, could we just output
> > the file diff to the console? That would avoid having to go hunting for
> > the log file.
> >
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89087): https://edk2.groups.io/g/devel/message/89087
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-19 Thread Michael Kubacki 

Hi Rebecca,

We are trying to keep the results reporting experience consistent with 
other plugins and prevent an overwhelming amount of information being 
printed to the build log.


In case other errors are present, providing high-level information from 
each plugin can help point the user in the right direction to get more 
detail.


I completely understand the concern though, so I'm planning to make 
another step toward providing more information about how to debug an 
issue, when it occurs. That is to put the step-by-step information about 
where to find the file diff into the EDK II Code Formatting wiki page 
and then if a failure occurs, print a link to that section of the wiki 
page. I am hoping this will provide sufficient information to get to the 
file diff at the point of failure.


I should be able to send these patches later today.

Regards,
Michael

On 4/19/2022 12:43 PM, Rebecca Cran wrote:
Since people are going to keep running into this, could we just output 
the file diff to the console? That would avoid having to go hunting for 
the log file.





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89085): https://edk2.groups.io/g/devel/message/89085
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-19 Thread Rebecca Cran 
Since people are going to keep running into this, could we just output 
the file diff to the console? That would avoid having to go hunting for 
the log file.


--
Rebecca Cran

On 4/19/22 10:39, Sean wrote:
Q1 - There should be more details in the actual log file, but your 
code has formatting errors.   In the last few months, the uncrusitfy 
tool has been introduced to get common formatting errors fixed.   See 
details here: EDK II Code Formatting · tianocore/tianocore.github.io 
Wiki 



Q2 - New code additions require passing ECC.  You will just need to 
work through the reported errors.


Thanks
Sean



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89083): https://edk2.groups.io/g/devel/message/89083
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Some questions about Azure CI

2022-04-19 Thread Sean 
Q1 - There should be more details in the actual log file, but your code has 
formatting errors.   In the last few months, the uncrusitfy tool has been 
introduced to get common formatting errors fixed.   See details here: EDK II 
Code Formatting · tianocore/tianocore.github.io Wiki ( 
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting )

Q2 - New code additions require passing ECC.  You will just need to work 
through the reported errors.

Thanks
Sean


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89082): https://edk2.groups.io/g/devel/message/89082
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Some questions about Azure CI

2022-04-18 Thread Chao Li 
Hi Sean and Bret,

I prepare submit a new architecture code to edk2, and I have applied for an 
Azure ID. There have two questions when trigger the Azure CI, please refer to 
the following two links: 
https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=31=logs=9701361e-2546-5093-77e5-58c75d95b7ce=27131ef8-75e1-57c3-3236-d806181f2f1f
 and 
https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=31=logs=5e3952f2-9c8a-5394-82c1-a803bcab3ca3=444fd513-1d27-501b-b92c-56decf629da5.
Question1:
The CI tells me a fail that: "Test Failed: Uncrustify Coding Standard Test 
NO-TARGET", I'm not sure what happens when this class failure occurs, can you 
tell me what happened and how to fix it?

Question2:
There are many coding style errors with ECC(like: "Variable name does not 
follow the rules: 1. First character should be upper case 2. Must contain lower 
case characters 3. No white space characters 4. Global variable name must start 
with a 'g', *Member variable [BASE_LIBRARY_JUMP_BUFFER.S2] NOT follow naming 
convention."), but I found that other architectures have the same coding style 
as ours, can you tell me how to fix thus coding style error?

Hope you reply, thank you very much.

--
Thanks,
Chao




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89051): https://edk2.groups.io/g/devel/message/89051
Mute This Topic: https://groups.io/mt/90555787/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-