Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver

2019-06-05 Thread Liming Gao 
Ard:

> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard 
> Biesheuvel
> Sent: Wednesday, June 5, 2019 2:25 PM
> To: edk2-devel-groups-io ; Ma, Maurice 
> ; Laszlo Ersek ; Leif
> Lindholm ; Gao, Liming ; 
> Kinney, Michael D 
> Cc: Dong, Guo ; You, Benjamin 
> Subject: Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
> 
> On Fri, 31 May 2019 at 01:06, Ma, Maurice  wrote:
> >
> > Reviewed-by: Maurice Ma 
> >
> 
> This patch has now been pushed, while I don't think it is a bugfix,
> and we are in the middle of the hard freeze period.

Seemly, not every person well knows the hard feature freeze period for 201905 
stable tag.
201905 stable tag period is deferred than original plan. So, some people may 
not notice it.

I can prepare the patch to roll back it for 201905 stable tag. 

> 
> 
> > > -Original Message-
> > > From: Dong, Guo
> > > Sent: Thursday, May 30, 2019 2:52
> > > To: devel@edk2.groups.io
> > > Cc: Ma, Maurice ; You, Benjamin
> > > ; Dong, Guo 
> > > Subject: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
> > >
> > > Since legacy PIC 8259 driver would be removed from edk2, update UEFI 
> > > payload
> > > to remove 8259 driver.
> > > If required, bootloader could disable 8259.
> > >
> > > Signed-off-by: Guo Dong 
> > > ---
> > >  UefiPayloadPkg/UefiPayloadPkg.fdf| 1 -
> > >  UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 1 -
> > >  UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 -
> > >  3 files changed, 3 deletions(-)
> > >
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > index ce3b34999b..4cd88a3f85 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> > > @@ -104,7 +104,6 @@ INF
> > > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
> > >  INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > >  INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > >  INF
> > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > > xe.inf
> > > -INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > >  INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > >  INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > >  INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > index 5b6ed36e9c..11cf17ca06 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> > > @@ -432,7 +432,6 @@
> > >UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > >MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > >
> > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > > xe.inf
> > > -  PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > >MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > >MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > >MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > > diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > index d57b5241dc..5b7994a62c 100644
> > > --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> > > @@ -433,7 +433,6 @@
> > >UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> > >MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > >
> > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> > > xe.inf
> > > -  PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > >MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> > >MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > >MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > > --
> > > 2.16.2.windows.1
> >
> >
> >
> >
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41917): https://edk2.groups.io/g/devel/message/41917
Mute This Topic: https://groups.io/mt/31837164/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver

2019-05-30 Thread Ma, Maurice 
Reviewed-by: Maurice Ma 

Regards,
Maurice

> -Original Message-
> From: Dong, Guo
> Sent: Thursday, May 30, 2019 2:52
> To: devel@edk2.groups.io
> Cc: Ma, Maurice ; You, Benjamin
> ; Dong, Guo 
> Subject: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver
> 
> Since legacy PIC 8259 driver would be removed from edk2, update UEFI payload
> to remove 8259 driver.
> If required, bootloader could disable 8259.
> 
> Signed-off-by: Guo Dong 
> ---
>  UefiPayloadPkg/UefiPayloadPkg.fdf| 1 -
>  UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 1 -
>  UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index ce3b34999b..4cd88a3f85 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -104,7 +104,6 @@ INF
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
>  INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
>  INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>  INF
> MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> xe.inf
> -INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
>  INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
>  INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
>  INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> index 5b6ed36e9c..11cf17ca06 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
> @@ -432,7 +432,6 @@
>UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
>MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> 
> MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> xe.inf
> -  PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
>MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
>MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
>MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> index d57b5241dc..5b7994a62c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
> @@ -433,7 +433,6 @@
>UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
>MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> 
> MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestD
> xe.inf
> -  PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
>MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
>MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
>MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41691): https://edk2.groups.io/g/devel/message/41691
Mute This Topic: https://groups.io/mt/31837164/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver

2019-05-29 Thread Guo Dong 
Since legacy PIC 8259 driver would be removed from edk2,
update UEFI payload to remove 8259 driver.
If required, bootloader could disable 8259.

Signed-off-by: Guo Dong 
---
 UefiPayloadPkg/UefiPayloadPkg.fdf| 1 -
 UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 1 -
 UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 -
 3 files changed, 3 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf 
b/UefiPayloadPkg/UefiPayloadPkg.fdf
index ce3b34999b..4cd88a3f85 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -104,7 +104,6 @@ INF 
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
 INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
 INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
 INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
-INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
 INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
 INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
 INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc 
b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
index 5b6ed36e9c..11cf17ca06 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc
@@ -432,7 +432,6 @@
   UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
   MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
   MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
-  PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
   MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
   MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
   MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc 
b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
index d57b5241dc..5b7994a62c 100644
--- a/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc
@@ -433,7 +433,6 @@
   UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
   MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
   MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
-  PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
   MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
   MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
   MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41645): https://edk2.groups.io/g/devel/message/41645
Mute This Topic: https://groups.io/mt/31837164/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-