回复: [edk2-devel] [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()

2022-11-15 Thread gaoliming via groups.io
PR https://github.com/tianocore/edk2/pull/3641 is created to merge it. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 gaoliming via
> groups.io
> 发送时间: 2022年11月15日 10:55
> 收件人: devel@edk2.groups.io; a...@kernel.org; pierre.gond...@arm.com
> 抄送: 'Ard Biesheuvel' ; 'Leif Lindholm'
> ; 'Sami Mujawar' 
> 主题: 回复: [edk2-devel] [PATCH 1/1][edk2-stable202211]
> ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()
> 
> Ard:
>   I am OK to merge it for this stable tag. I will do it.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Ard
> > Biesheuvel
> > 发送时间: 2022年11月14日 23:10
> > 收件人: pierre.gond...@arm.com
> > 抄送: devel@edk2.groups.io; Ard Biesheuvel
> ;
> > Leif Lindholm ; Sami Mujawar
> > ; Liming Gao 
> > 主题: Re: [edk2-devel] [PATCH 1/1][edk2-stable202211]
> ArmPkg/ArmTrngLib:
> > Remove ASSERT in GetArmTrngVersion()
> >
> > On Mon, 14 Nov 2022 at 15:44,  wrote:
> > >
> > > From: Pierre Gondois 
> > >
> > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150
> > >
> > > GetArmTrngVersion() is used to check the presence of an Arm
> > > Trng. If not found, an ASSERT prevents from booting in DEBUG
> > > builds.
> > > Remove this ASSERT.
> > >
> > > Reported-by: Sami Mujawar 
> > > Signed-off-by: Pierre Gondois 
> >
> > Acked-by: Ard Biesheuvel 
> >
> > Liming: please merge this if you are ok with it, or I can merge it if
> > you prefer.
> >
> > > ---
> > >  ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > > index fdabc02cd39c..3278722320c8 100644
> > > --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > > +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > > @@ -344,7 +344,6 @@ ArmTrngLibConstructor (
> > >
> > >Status = GetArmTrngVersion (&MajorRev, &MinorRev);
> > >if (RETURN_ERROR (Status)) {
> > > -ASSERT_RETURN_ERROR (Status);
> > >  goto ErrorHandler;
> > >}
> > >
> > > --
> > > 2.25.1
> > >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96412): https://edk2.groups.io/g/devel/message/96412
Mute This Topic: https://groups.io/mt/95058276/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




回复: [edk2-devel] [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()

2022-11-14 Thread gaoliming via groups.io
Ard:
  I am OK to merge it for this stable tag. I will do it. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Ard
> Biesheuvel
> 发送时间: 2022年11月14日 23:10
> 收件人: pierre.gond...@arm.com
> 抄送: devel@edk2.groups.io; Ard Biesheuvel ;
> Leif Lindholm ; Sami Mujawar
> ; Liming Gao 
> 主题: Re: [edk2-devel] [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib:
> Remove ASSERT in GetArmTrngVersion()
> 
> On Mon, 14 Nov 2022 at 15:44,  wrote:
> >
> > From: Pierre Gondois 
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150
> >
> > GetArmTrngVersion() is used to check the presence of an Arm
> > Trng. If not found, an ASSERT prevents from booting in DEBUG
> > builds.
> > Remove this ASSERT.
> >
> > Reported-by: Sami Mujawar 
> > Signed-off-by: Pierre Gondois 
> 
> Acked-by: Ard Biesheuvel 
> 
> Liming: please merge this if you are ok with it, or I can merge it if
> you prefer.
> 
> > ---
> >  ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > index fdabc02cd39c..3278722320c8 100644
> > --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> > @@ -344,7 +344,6 @@ ArmTrngLibConstructor (
> >
> >Status = GetArmTrngVersion (&MajorRev, &MinorRev);
> >if (RETURN_ERROR (Status)) {
> > -ASSERT_RETURN_ERROR (Status);
> >  goto ErrorHandler;
> >}
> >
> > --
> > 2.25.1
> >
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96374): https://edk2.groups.io/g/devel/message/96374
Mute This Topic: https://groups.io/mt/95036097/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-