回复: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details
These PRs are all failure. Please update them. Thanks Liming > -邮件原件- > 发件人: Pethaiyan, Madhan > 发送时间: 2024年5月13日 20:10 > 收件人: gaoliming ; Kinney, Michael D > ; devel@edk2.groups.io > 抄送: Liu, Zhiguang ; Li, Yi1 ; 'GuoX > Xu' > 主题: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo > description details > > Hi all , > > I had created EDK2 PR, few weeks ago, thought it will be reviewed and > approved . > Please help to check and approve. > > https://github.com/tianocore/edk2/pull/5584 > https://github.com/tianocore/edk2/pull/5586 > https://github.com/tianocore/edk2/pull/5587 > > Thanks, > P. Madhan > > -Original Message- > From: gaoliming > Sent: Thursday, March 28, 2024 6:41 AM > To: Pethaiyan, Madhan ; Kinney, Michael D > ; devel@edk2.groups.io > Cc: Liu, Zhiguang ; Li, Yi1 ; 'GuoX > Xu' > > Subject: 回复: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , > GetImageInfo description details > > Madhan: > I have no comments for this patch set. Reviewed-by: Liming Gao > > > Have you create Edk2 PR to verify the changes? > > Thanks > Liming > > -邮件原件- > > 发件人: Pethaiyan, Madhan > > 发送时间: 2024年3月14日 16:17 > > 收件人: Kinney, Michael D ; > > devel@edk2.groups.io > > 抄送: Liming Gao ; Liu, Zhiguang > > ; Li, Yi1 ; GuoX Xu > > > > 主题: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo > > description details > > > > Hi Mike , > > > > I had raised new code review addressing the coding standard errors and > those > > were not part of my change any way .. > > > > Thanks, > > P. Madhan > > > > -Original Message- > > From: Kinney, Michael D > > Sent: Sunday, March 10, 2024 1:47 AM > > To: devel@edk2.groups.io; Pethaiyan, Madhan > > > > Cc: Liming Gao ; Liu, Zhiguang > > ; Li, Yi1 ; GuoX Xu > > ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , > > GetImageInfo description details > > > > Hi Madhan, > > > > I created a PR with all 3 related patches to run through EDK II CI. > > > > https://github.com/tianocore/edk2/pull/5453 > > > > There are CI failures. Please resolve and send updated patches. > > > > Thanks, > > > > Mike > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of > > > Pethaiyan Madhan > > > Sent: Friday, March 8, 2024 3:17 PM > > > To: devel@edk2.groups.io > > > Cc: Pethaiyan, Madhan ; Kinney, Michael > > > D ; Liming Gao > > > ; Liu, Zhiguang ; > > > Li, Yi1 ; GuoX Xu > > > Subject: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , > > > GetImageInfo description details > > > > > > 1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): > > > Add the following sentence at the end of the Image parameter > > > description. "May be NULL with a zero ImageSize in order to > > > determine the size of the buffer needed". > > > > > > Modify the description of "EFI_INVALID_PARAMETER" return code as > > > "The ImageSize is not too small and Image is NULL." > > > > > > 2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo(): > > > Add the following sentence at the end of the ImageInfo parameter > > > description."May be NULL with a zero ImageInfoSize in order to > > > determine the size of the buffer needed". > > > > > > Modify the description of "EFI_INVALID_PARAMETER" return code as > > > "The ImageInfoSize is not too small and Image is NULL." and add new > > > descriptions for "EFI_INVALID_PARAMETER" return code. > > > > > > REF: UEFI spec v2.10 23.1.2 > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4660 > > > > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Cc: Zhiguang Liu > > > Cc: Yi Li > > > Cc: GuoX Xu > > > Signed-off-by: Pethaiyan Madhan > > > --- > > > MdePkg/Include/Protocol/FirmwareManagement.h | 14 -- > > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > > > diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h > > > b/MdePkg/Include/Protocol/FirmwareManagement.h > > > index e535bb697d..90b7d83c8f 100644 > > > --- a/MdePkg/Include/Protocol/FirmwareManagement.h > > > +++ b/MdePkg/Include/Protocol/FirmwareManagement.h > > > @@ -294,6 +29
回复: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details
Madhan: I have no comments for this patch set. Reviewed-by: Liming Gao Have you create Edk2 PR to verify the changes? Thanks Liming > -邮件原件- > 发件人: Pethaiyan, Madhan > 发送时间: 2024年3月14日 16:17 > 收件人: Kinney, Michael D ; > devel@edk2.groups.io > 抄送: Liming Gao ; Liu, Zhiguang > ; Li, Yi1 ; GuoX Xu > > 主题: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo > description details > > Hi Mike , > > I had raised new code review addressing the coding standard errors and those > were not part of my change any way .. > > Thanks, > P. Madhan > > -Original Message- > From: Kinney, Michael D > Sent: Sunday, March 10, 2024 1:47 AM > To: devel@edk2.groups.io; Pethaiyan, Madhan > > Cc: Liming Gao ; Liu, Zhiguang > ; Li, Yi1 ; GuoX Xu > ; Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , > GetImageInfo description details > > Hi Madhan, > > I created a PR with all 3 related patches to run through EDK II CI. > > https://github.com/tianocore/edk2/pull/5453 > > There are CI failures. Please resolve and send updated patches. > > Thanks, > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of > > Pethaiyan Madhan > > Sent: Friday, March 8, 2024 3:17 PM > > To: devel@edk2.groups.io > > Cc: Pethaiyan, Madhan ; Kinney, Michael D > > ; Liming Gao ; > > Liu, Zhiguang ; Li, Yi1 ; > > GuoX Xu > > Subject: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , > > GetImageInfo description details > > > > 1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): > > Add the following sentence at the end of the Image parameter > > description. "May be NULL with a zero ImageSize in order to determine > > the size of the buffer needed". > > > > Modify the description of "EFI_INVALID_PARAMETER" return code as "The > > ImageSize is not too small and Image is NULL." > > > > 2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo(): > > Add the following sentence at the end of the ImageInfo parameter > > description."May be NULL with a zero ImageInfoSize in order to > > determine the size of the buffer needed". > > > > Modify the description of "EFI_INVALID_PARAMETER" return code as "The > > ImageInfoSize is not too small and Image is NULL." and add new > > descriptions for "EFI_INVALID_PARAMETER" return code. > > > > REF: UEFI spec v2.10 23.1.2 > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4660 > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Yi Li > > Cc: GuoX Xu > > Signed-off-by: Pethaiyan Madhan > > --- > > MdePkg/Include/Protocol/FirmwareManagement.h | 14 -- > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h > > b/MdePkg/Include/Protocol/FirmwareManagement.h > > index e535bb697d..90b7d83c8f 100644 > > --- a/MdePkg/Include/Protocol/FirmwareManagement.h > > +++ b/MdePkg/Include/Protocol/FirmwareManagement.h > > @@ -294,6 +294,8 @@ EFI_STATUS > > to contain the image(s) > > information if the buffer was too small. > >@param[in, out] ImageInfo A pointer to the buffer in which > > firmware places the current image(s) > > information. The > information is > > an array of EFI_FIRMWARE_IMAGE_DESCRIPTORs. > > + May be NULL with a zero > > ImageInfoSize in order to determine the size of the > > + buffer needed. > >@param[out] DescriptorVersion A pointer to the location in > > which firmware returns the version number > > associated with the > > EFI_FIRMWARE_IMAGE_DESCRIPTOR. > >@param[out] DescriptorCountA pointer to the location in > > which firmware returns the number of > > @@ -314,7 +316,12 @@ EFI_STATUS > >@retval EFI_SUCCESSThe device was successfully > > updated with the new image. > >@retval EFI_BUFFER_TOO_SMALL The ImageInfo buffer was > too > > small. The current buffer size > > needed to hold the image(s) > > information is returned in ImageInfoSize. > > - @retval EFI_INVALID_PARAMETER ImageInfoSize is NULL. > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is not too small > > and ImageInfo is NULL. > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > > DescriptorVersion is NULL. > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > > DescriptorCount is NULL. > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > > DescriptorSize is NULL. > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > > PackageVersion is NULL. > > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > > PackageVersionName is NULL. > >@retval EFI_DEVICE_ERROR Valid information could not > be > > returned. Possible corrupted image.
