回复: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS 3.5 fields
Chang:
PR shows the patch coding style issue. Please fix them.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming
> 发送时间: 2022年4月20日 7:50
> 收件人: devel@edk2.groups.io; zhichao@intel.com; 'Ke, Bo-ChangX'
>
> 抄送: 'Liu, Zhiguang' ; 'Bi, Dandan'
> ; 'Zeng, Star' ; 'Kinney, Michael
> D'
> 主题: 回复: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9
> with SMBIOS 3.5 fields
>
> PR https://github.com/tianocore/edk2/pull/2797 is created.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Gao,
> Zhichao
> > 发送时间: 2022年4月19日 13:09
> > 收件人: devel@edk2.groups.io; Gao, Liming ;
> Ke,
> > Bo-ChangX
> > 抄送: Liu, Zhiguang ; Bi, Dandan
> > ; Zeng, Star ; Kinney, Michael
> D
> >
> > 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9
> with
> > SMBIOS 3.5 fields
> >
> > Hi Liming, Mike,
> >
> > Can you help to create the PR of these patch set? This is the first patch
> > and
> > the second one is ShellPkg with the same titile.
> >
> > Thanks,
> > Zhichao
> >
> > > -Original Message-
> > > From: devel@edk2.groups.io On Behalf Of
> > > gaoliming
> > > Sent: Sunday, April 17, 2022 11:25 AM
> > > To: devel@edk2.groups.io; Ke, Bo-ChangX ;
> Gao,
> > > Zhichao
> > > Cc: Liu, Zhiguang ; Bi, Dandan
> > > ; Zeng, Star ; Kinney,
> Michael
> > > D
> > > Subject: 回复: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type
> 9
> > > with SMBIOS 3.5 fields
> > >
> > > Reviewed-by: Liming Gao
> > >
> > > > -邮件原件-
> > > > 发件人: devel@edk2.groups.io 代表 Bo
> Chang
> > Ke
> > > > 发送时间: 2022年4月15日 16:35
> > > > 收件人: Gao, Zhichao ; devel@edk2.groups.io
> > > > 抄送: Liu, Zhiguang ; Bi, Dandan
> > > > ; Zeng, Star ; Gao, Liming
> > > > ; Kinney, Michael D
> > > >
> > > > 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9
> > > with
> > > > SMBIOS 3.5 fields
> > > >
> > > > Add Kinney, Michael D and Gao, Liming
> > > >
> > > > Best Regards.
> > > >
> > > > -Original Message-
> > > > From: Gao, Zhichao
> > > > Sent: Thursday, April 14, 2022 10:25 AM
> > > > To: Ke, Bo-ChangX ; devel@edk2.groups.io
> > > > Cc: Liu, Zhiguang ; Bi, Dandan
> > > > ; Zeng, Star
> > > > Subject: RE: [PATCH v2] MdePkg: Update smbiosview type 9 with
> SMBIOS
> > > > 3.5 fields
> > > >
> > > > Reviewed-by: Zhichao Gao
> > > >
> > > > Thanks,
> > > > Zhichao
> > > >
> > > > > -Original Message-
> > > > > From: Ke, Bo-ChangX
> > > > > Sent: Wednesday, April 13, 2022 11:14 AM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Liu, Zhiguang ; Gao, Zhichao
> > > > > ; Bi, Dandan ; Zeng,
> > > > > Star
> > > > > Subject: [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS
> > 3.5
> > > > > fields
> > > > >
> > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3896
> > > > >
> > > > > update smbiosview type 9 related fileds.
> > > > >
> > > > > Signed-off-by: Bo Chang Ke
> > > > > Cc: Zhiguang Liu
> > > > > Cc: Zhichao Gao
> > > > > Cc: Dandan Bi
> > > > > Cc: Star Zeng
> > > > > ---
> > > > > MdePkg/Include/IndustryStandard/SmBios.h | 49
> > > > > +++-
> > > > > 1 file changed, 48 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > index 2b1567b052..52f2e35ee9 100644
> > > > > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > @@ -1306,6 +1306,11 @@ typedef enum {
> > > > >SlotTypePciExpressMini52pinWithBSKO= 0x21,///< PCI
> > > > Express Mini 52-pin
> > > > > (CEM spec. 2.0) with bottom-side keep-outs.
> > > > >SlotTypePciExpressMini52pinWithoutBSKO = 0x22,///< PCI
> > Express
> > > > Mini 52-
> > > > > pin (CEM s
回复: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS 3.5 fields
PR https://github.com/tianocore/edk2/pull/2797 is created.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Gao, Zhichao
> 发送时间: 2022年4月19日 13:09
> 收件人: devel@edk2.groups.io; Gao, Liming ; Ke,
> Bo-ChangX
> 抄送: Liu, Zhiguang ; Bi, Dandan
> ; Zeng, Star ; Kinney, Michael D
>
> 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9 with
> SMBIOS 3.5 fields
>
> Hi Liming, Mike,
>
> Can you help to create the PR of these patch set? This is the first patch and
> the second one is ShellPkg with the same titile.
>
> Thanks,
> Zhichao
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of
> > gaoliming
> > Sent: Sunday, April 17, 2022 11:25 AM
> > To: devel@edk2.groups.io; Ke, Bo-ChangX ; Gao,
> > Zhichao
> > Cc: Liu, Zhiguang ; Bi, Dandan
> > ; Zeng, Star ; Kinney, Michael
> > D
> > Subject: 回复: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9
> > with SMBIOS 3.5 fields
> >
> > Reviewed-by: Liming Gao
> >
> > > -邮件原件-
> > > 发件人: devel@edk2.groups.io 代表 Bo Chang
> Ke
> > > 发送时间: 2022年4月15日 16:35
> > > 收件人: Gao, Zhichao ; devel@edk2.groups.io
> > > 抄送: Liu, Zhiguang ; Bi, Dandan
> > > ; Zeng, Star ; Gao, Liming
> > > ; Kinney, Michael D
> > >
> > > 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9
> > with
> > > SMBIOS 3.5 fields
> > >
> > > Add Kinney, Michael D and Gao, Liming
> > >
> > > Best Regards.
> > >
> > > -Original Message-
> > > From: Gao, Zhichao
> > > Sent: Thursday, April 14, 2022 10:25 AM
> > > To: Ke, Bo-ChangX ; devel@edk2.groups.io
> > > Cc: Liu, Zhiguang ; Bi, Dandan
> > > ; Zeng, Star
> > > Subject: RE: [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS
> > > 3.5 fields
> > >
> > > Reviewed-by: Zhichao Gao
> > >
> > > Thanks,
> > > Zhichao
> > >
> > > > -Original Message-
> > > > From: Ke, Bo-ChangX
> > > > Sent: Wednesday, April 13, 2022 11:14 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: Liu, Zhiguang ; Gao, Zhichao
> > > > ; Bi, Dandan ; Zeng,
> > > > Star
> > > > Subject: [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS
> 3.5
> > > > fields
> > > >
> > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3896
> > > >
> > > > update smbiosview type 9 related fileds.
> > > >
> > > > Signed-off-by: Bo Chang Ke
> > > > Cc: Zhiguang Liu
> > > > Cc: Zhichao Gao
> > > > Cc: Dandan Bi
> > > > Cc: Star Zeng
> > > > ---
> > > > MdePkg/Include/IndustryStandard/SmBios.h | 49
> > > > +++-
> > > > 1 file changed, 48 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > index 2b1567b052..52f2e35ee9 100644
> > > > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > @@ -1306,6 +1306,11 @@ typedef enum {
> > > >SlotTypePciExpressMini52pinWithBSKO= 0x21,///< PCI
> > > Express Mini 52-pin
> > > > (CEM spec. 2.0) with bottom-side keep-outs.
> > > >SlotTypePciExpressMini52pinWithoutBSKO = 0x22,///< PCI
> Express
> > > Mini 52-
> > > > pin (CEM spec. 2.0) without bottom-side keep-outs.
> > > >SlotTypePciExpressMini76pin= 0x23,///< PCI
> > > Express Mini 76-pin (CEM
> > > > spec. 2.0) Corresponds to Display-Mini card.
> > > > + SlotTypePCIExpressGen4SFF_8639 = 0x24,///< U.2
> > > > + SlotTypePCIExpressGen5SFF_8639 = 0x25,///< U.2
> > > > + SlotTypeOCPNIC30SmallFormFactor= 0x26,///< SFF
> > > > + SlotTypeOCPNIC30LargeFormFactor= 0x27,///< LFF
> > > > + SlotTypeOCPNICPriorto30= 0x28,
> > > >SlotTypeCXLFlexbus10 = 0x30,
> > > >SlotTypePC98C20= 0xA0,
> > > >SlotTypePC98C24= 0xA1,
> > > > @@ -1335,7 +1340,16 @@ typedef enum {
> > > >SlotTypePciExpressGen4X2 = 0xBA,
> > > >SlotTypePciExpressGen
回复: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS 3.5 fields
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Bo Chang Ke
> 发送时间: 2022年4月15日 16:35
> 收件人: Gao, Zhichao ; devel@edk2.groups.io
> 抄送: Liu, Zhiguang ; Bi, Dandan
> ; Zeng, Star ; Gao, Liming
> ; Kinney, Michael D
>
> 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9 with
> SMBIOS 3.5 fields
>
> Add Kinney, Michael D and Gao, Liming
>
> Best Regards.
>
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, April 14, 2022 10:25 AM
> To: Ke, Bo-ChangX ; devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Bi, Dandan
> ; Zeng, Star
> Subject: RE: [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS 3.5
> fields
>
> Reviewed-by: Zhichao Gao
>
> Thanks,
> Zhichao
>
> > -Original Message-
> > From: Ke, Bo-ChangX
> > Sent: Wednesday, April 13, 2022 11:14 AM
> > To: devel@edk2.groups.io
> > Cc: Liu, Zhiguang ; Gao, Zhichao
> > ; Bi, Dandan ; Zeng, Star
> >
> > Subject: [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS 3.5
> > fields
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3896
> >
> > update smbiosview type 9 related fileds.
> >
> > Signed-off-by: Bo Chang Ke
> > Cc: Zhiguang Liu
> > Cc: Zhichao Gao
> > Cc: Dandan Bi
> > Cc: Star Zeng
> > ---
> > MdePkg/Include/IndustryStandard/SmBios.h | 49
> > +++-
> > 1 file changed, 48 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > b/MdePkg/Include/IndustryStandard/SmBios.h
> > index 2b1567b052..52f2e35ee9 100644
> > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > @@ -1306,6 +1306,11 @@ typedef enum {
> >SlotTypePciExpressMini52pinWithBSKO= 0x21,///< PCI
> Express Mini 52-pin
> > (CEM spec. 2.0) with bottom-side keep-outs.
> >SlotTypePciExpressMini52pinWithoutBSKO = 0x22,///< PCI Express
> Mini 52-
> > pin (CEM spec. 2.0) without bottom-side keep-outs.
> >SlotTypePciExpressMini76pin= 0x23,///< PCI
> Express Mini 76-pin (CEM
> > spec. 2.0) Corresponds to Display-Mini card.
> > + SlotTypePCIExpressGen4SFF_8639 = 0x24,///< U.2
> > + SlotTypePCIExpressGen5SFF_8639 = 0x25,///< U.2
> > + SlotTypeOCPNIC30SmallFormFactor= 0x26,///< SFF
> > + SlotTypeOCPNIC30LargeFormFactor= 0x27,///< LFF
> > + SlotTypeOCPNICPriorto30= 0x28,
> >SlotTypeCXLFlexbus10 = 0x30,
> >SlotTypePC98C20= 0xA0,
> >SlotTypePC98C24= 0xA1,
> > @@ -1335,7 +1340,16 @@ typedef enum {
> >SlotTypePciExpressGen4X2 = 0xBA,
> >SlotTypePciExpressGen4X4 = 0xBB,
> >SlotTypePciExpressGen4X8 = 0xBC,
> > - SlotTypePciExpressGen4X16 = 0xBD
> > + SlotTypePciExpressGen4X16 = 0xBD,
> > + SlotTypePCIExpressGen5 = 0xBE,
> > + SlotTypePCIExpressGen5X1 = 0xBF,
> > + SlotTypePCIExpressGen5X2 = 0xC0,
> > + SlotTypePCIExpressGen5X4 = 0xC1,
> > + SlotTypePCIExpressGen5X8 = 0xC2,
> > + SlotTypePCIExpressGen5X16 = 0xC3,
> > + SlotTypePCIExpressGen6andBeyond= 0xC4,
> > + SlotTypeEnterpriseandDatacenter1UE1FormFactorSlot = 0xC5,
> > + SlotTypeEnterpriseandDatacenter3E3FormFactorSlot = 0xC6
> > } MISC_SLOT_TYPE;
> >
> > ///
> > @@ -1358,6 +1372,39 @@ typedef enum {
> >SlotDataBusWidth32X = 0x0E ///< Or X32
> > } MISC_SLOT_DATA_BUS_WIDTH;
> >
> > +///
> > +/// System Slots - Slot Physical Width.
> > +///
> > +typedef enum {
> > + SlotPhysicalWidthOther = 0x01,
> > + SlotPhysicalWidthUnknown = 0x02,
> > + SlotPhysicalWidth8Bit= 0x03,
> > + SlotPhysicalWidth16Bit = 0x04,
> > + SlotPhysicalWidth32Bit = 0x05,
> > + SlotPhysicalWidth64Bit = 0x06,
> > + SlotPhysicalWidth128Bit = 0x07,
> > + SlotPhysicalWidth1X = 0x08,///< Or X1
> > + SlotPhysicalWidth2X = 0x09,///< Or X2
> > + SlotPhysicalWidth4X = 0x0A,///< Or X4
> > + SlotPhysicalWidth8X = 0x0B,///< Or X8
> > + SlotPhysicalWidth12X = 0x0C,///< Or X12
> > + SlotPhysicalWidth16X = 0x0D,///< Or X16
> > + SlotPhysicalWidth32X = 0x0E ///< Or X32
> > +} MISC_SLOT_PHYSICAL_WIDTH;
> > +
> > +///
> > +/// System Slots - Slot Information.
> > +///
> > +typedef enum {
> > + others = 0x00,
> > + Gen1 = 0x01,
> > + Gen2 = 0x01,
> > + Gen3 = 0x03,
> > + Gen4 = 0x04,
> > + Gen5 = 0x05,
> > + Gen6 = 0x06
> > +} MISC_SLOT_INFORMATION;
> > +
> > ///
> > /// System Slots - Current Usage.
> > ///
> > --
> > 2.32.0.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88980): https://edk2.groups.io/g/devel/message/88980
Mute This Topic: https://groups.io/mt/90517216/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
