回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
Ard and Dandan: > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ard > Biesheuvel > 发送时间: 2021年3月16日 23:01 > 收件人: devel@edk2.groups.io; dandan...@intel.com; Laszlo Ersek > ; Andrew Fish > 抄送: Leif Lindholm ; Michael D Kinney > ; Liming Gao > 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > RegisterFilterLibNull instance > > On Tue, 16 Mar 2021 at 15:56, Dandan Bi wrote: > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > RFC: https://edk2.groups.io/g/devel/message/72530 > > > > > > Add RegisterFilterLibNull in dsc files in edk2-platforms repo, > > which will be consumed by IoLib and BaseLib. > > > > This is the following update in edk2-platforms repo for the change in edk2, > > which will add RegisterFilterLib dependency for IoLib and BaseLib to > filter/trace > > port IO/MMIO/MSR access. > > https://edk2.groups.io/g/devel/message/72754 > > > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Liming Gao > > > > It is a bit disappointing that we have to update every platform in > existence again to apply a change to a core module. > I suggest to add MdePkg.dsc.inc file to include the default library instance, and update all Platform DSC to include it. Then, for the future change, no change is required for platform DSC. Because this patch set updates every platform DSC, I suggest to introduce MdePkg.dsc.inc file in this patch set. Thanks Liming > Is there really not a better way to provide a 'default' resolution for > a library class? Maybe a change to the .DEC format, so that the file > which defines the library class can provide a resolution that is used > if none is provided by the .DSC file? > > > > > Dandan Bi (35): > > Drivers/ASIX: Consume RegisterFilterLibNull instance > > Drivers/DisplayLink: Consume RegisterFilterLibNull instance > > Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance > > Features/Debugging: Consume RegisterFilterLibNull instance > > Features/Network: Consume RegisterFilterLibNull instance > > Features/OutOfBandManagement: Consume RegisterFilterLibNull > instance > > Features/PowerManagement: Consume RegisterFilterLibNull instance > > Features/SystemInformation: Consume RegisterFilterLibNull instance > > Features/UserInterface: Consume RegisterFilterLibNull instance > > Platform/AMD: Consume RegisterFilterLibNull instance > > Platform/ARM: Consume RegisterFilterLibNull instance > > Platform/BeagleBoard: Consume RegisterFilterLibNull instance > > Platform/BoardModulePkg: Consume RegisterFilterLibNull instance > > Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance > > Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance > > Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance > > Platform/LeMaker: Consume RegisterFilterLibNull instance > > Platform/Qemu: Consume RegisterFilterLibNull instance > > Platform/RaspberryPi: Consume RegisterFilterLibNull instance > > Platform/RISC-V: Consume RegisterFilterLibNull instance > > Platform/SiFive: Consume RegisterFilterLibNull instance > > Platform/Socionext: Consume RegisterFilterLibNull instance > > Platform/SoftIron: Consume RegisterFilterLibNull instance > > Silicon/Hisilicon: Consume RegisterFilterLibNull instance > > Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance > > Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance > > Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance > > Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance > > Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance > > Silicon/Marvell: Consume RegisterFilterLibNull instance > > Silicon/NXP: Consume RegisterFilterLibNull instance > > Silicon/Openmoko: Consume RegisterFilterLibNull instance > > Silicon/RISC_V: Consume RegisterFilterLibNull instance > > Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull instance > > Silicon/TexasInstruments: Consume RegisterFilterLibNull instance > > > > Drivers/ASIX/Asix.dsc > | 1 + > > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1 + > > Drivers/OptionRomPkg/OptionRomPkg.dsc > | 3 ++- > > .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc | 3 > ++- > > .../Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc | 3 > ++- > > .../PostCodeDebugFeaturePkg/Include/PostCodeDebugFeature.dsc | 3 > ++- > > .../Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc | 3 > ++- > > .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 3 > ++- > > .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 3 > ++- > > .../OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc | 3 > ++- > > .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 3 > ++- > > .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc | 3 > ++- > > .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3 ++- > > .../UserAuthFeat
回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
Laszlo and Dandan: > -邮件原件- > 发件人: Laszlo Ersek > 发送时间: 2021年3月18日 1:08 > 收件人: Bi, Dandan ; devel@edk2.groups.io; > gaolim...@byosoft.com.cn; a...@kernel.org; 'Andrew Fish' > > 抄送: 'Leif Lindholm' ; Kinney, Michael D > > 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > RegisterFilterLibNull instance > > On 03/17/21 16:05, Bi, Dandan wrote: > >> -Original Message- > >> From: devel@edk2.groups.io On Behalf Of > >> gaoliming > >> Sent: Wednesday, March 17, 2021 11:05 AM > >> To: devel@edk2.groups.io; a...@kernel.org; Bi, Dandan > >> ; 'Laszlo Ersek' ; 'Andrew > Fish' > >> > >> Cc: 'Leif Lindholm' ; Kinney, Michael D > >> > >> Subject: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > >> RegisterFilterLibNull instance > >> > >> Ard and Dandan: > >> > >>> -邮件原件- > >>> 发件人: devel@edk2.groups.io 代表 Ard > >> Biesheuvel > >>> 发送时间: 2021年3月16日 23:01 > >>> 收件人: devel@edk2.groups.io; dandan...@intel.com; Laszlo Ersek > >>> ; Andrew Fish > >>> 抄送: Leif Lindholm ; Michael D Kinney > >>> ; Liming Gao > >>> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > >>> RegisterFilterLibNull instance > >>> > >>> On Tue, 16 Mar 2021 at 15:56, Dandan Bi wrote: > >>>> > >>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > >>>> RFC: https://edk2.groups.io/g/devel/message/72530 > >>>> > >>>> > >>>> Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which > >>>> will be consumed by IoLib and BaseLib. > >>>> > >>>> This is the following update in edk2-platforms repo for the change > >>>> in edk2, which will add RegisterFilterLib dependency for IoLib and > >>>> BaseLib to > >>> filter/trace > >>>> port IO/MMIO/MSR access. > >>>> https://edk2.groups.io/g/devel/message/72754 > >>>> > >>>> Cc: Leif Lindholm > >>>> Cc: Michael D Kinney > >>>> Cc: Liming Gao > >>>> > >>> > >>> It is a bit disappointing that we have to update every platform in > >>> existence again to apply a change to a core module. > >>> > >> > >> I suggest to add MdePkg.dsc.inc file to include the default library > >> instance, > >> and update all Platform DSC to include it. Then, for the future change, no > >> change is required for platform DSC. > >> > >> Because this patch set updates every platform DSC, I suggest to introduce > >> MdePkg.dsc.inc file in this patch set. > > > > Hi Liming, > > > > I agree that add MdePkg.dsc.inc file to include the default library instance > and make it consumed by platform dsc will benefit future similar incompatible > changes. > > But I wonder to know whether we could do it in a separated task/topic, as > > 1. It should be a code infrastructure design change/improvement in edk2. > > 2. Personally I don't hope the new solution will have much impact on my > current schedule, but it seems have. > > And we may need to: > > 1). Clarify the default library instances which should be added in > MdePkg.dsc.inc > > The library instances in MdePkg.dsc.inc should be generic enough to > be widely included in platform dsc files. > > 2). Update dsc files in edk2 and edk2-platforms repo to include > MdePkg.dsc.inc and cleanup the default Lib instance in dsc files. > > (1) The file name should be "MdeLibs.dsc.inc", and it should be > structured similarly "NetworkLibs.dsc.inc" -- no [LibraryClasses] header > should be part of the file. > I agree. > (2) The introduction of "MdeLibs.dsc.inc" is a big task, in my opinion. > The full MdeLibs.dsc.inc is a big task. But, it should be a separate task. For this patch set, the first version MdeLibs.dsc.inc can be added. It only includes RegisterFilterLibNull library instance. And, this patch set will update every platform DSC to include MdeLibs.dsc.inc. The future incompatible change can update MdeLibs.dsc.inc only, and avoid the change in each platform DSC. I would like to resolve the potential incompatible change by MdeLibs.dsc.inc on the first step. Thanks Liming > As I stated earlier, I wouldn't like to review a patch for OvmfPkg that > replaces (say) 50-100 lines of library class resolutions with a simpl
Re: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
On 03/18/21 05:43, gaoliming wrote: > Laszlo and Dandan: > >> -邮件原件- >> 发件人: Laszlo Ersek >> 发送时间: 2021年3月18日 1:08 >> 收件人: Bi, Dandan ; devel@edk2.groups.io; >> gaolim...@byosoft.com.cn; a...@kernel.org; 'Andrew Fish' >> >> 抄送: 'Leif Lindholm' ; Kinney, Michael D >> >> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume >> RegisterFilterLibNull instance >> >> On 03/17/21 16:05, Bi, Dandan wrote: >>>> -Original Message- >>>> From: devel@edk2.groups.io On Behalf Of >>>> gaoliming >>>> Sent: Wednesday, March 17, 2021 11:05 AM >>>> To: devel@edk2.groups.io; a...@kernel.org; Bi, Dandan >>>> ; 'Laszlo Ersek' ; 'Andrew >> Fish' >>>> >>>> Cc: 'Leif Lindholm' ; Kinney, Michael D >>>> >>>> Subject: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume >>>> RegisterFilterLibNull instance >>>> >>>> Ard and Dandan: >>>> >>>>> -邮件原件- >>>>> 发件人: devel@edk2.groups.io 代表 Ard >>>> Biesheuvel >>>>> 发送时间: 2021年3月16日 23:01 >>>>> 收件人: devel@edk2.groups.io; dandan...@intel.com; Laszlo Ersek >>>>> ; Andrew Fish >>>>> 抄送: Leif Lindholm ; Michael D Kinney >>>>> ; Liming Gao >>>>> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume >>>>> RegisterFilterLibNull instance >>>>> >>>>> On Tue, 16 Mar 2021 at 15:56, Dandan Bi wrote: >>>>>> >>>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 >>>>>> RFC: https://edk2.groups.io/g/devel/message/72530 >>>>>> >>>>>> >>>>>> Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which >>>>>> will be consumed by IoLib and BaseLib. >>>>>> >>>>>> This is the following update in edk2-platforms repo for the change >>>>>> in edk2, which will add RegisterFilterLib dependency for IoLib and >>>>>> BaseLib to >>>>> filter/trace >>>>>> port IO/MMIO/MSR access. >>>>>> https://edk2.groups.io/g/devel/message/72754 >>>>>> >>>>>> Cc: Leif Lindholm >>>>>> Cc: Michael D Kinney >>>>>> Cc: Liming Gao >>>>>> >>>>> >>>>> It is a bit disappointing that we have to update every platform in >>>>> existence again to apply a change to a core module. >>>>> >>>> >>>> I suggest to add MdePkg.dsc.inc file to include the default library >>>> instance, >>>> and update all Platform DSC to include it. Then, for the future change, no >>>> change is required for platform DSC. >>>> >>>> Because this patch set updates every platform DSC, I suggest to introduce >>>> MdePkg.dsc.inc file in this patch set. >>> >>> Hi Liming, >>> >>> I agree that add MdePkg.dsc.inc file to include the default library instance >> and make it consumed by platform dsc will benefit future similar incompatible >> changes. >>> But I wonder to know whether we could do it in a separated task/topic, as >>> 1. It should be a code infrastructure design change/improvement in edk2. >>> 2. Personally I don't hope the new solution will have much impact on my >> current schedule, but it seems have. >>> And we may need to: >>> 1). Clarify the default library instances which should be added in >> MdePkg.dsc.inc >>> The library instances in MdePkg.dsc.inc should be generic enough to >> be widely included in platform dsc files. >>> 2). Update dsc files in edk2 and edk2-platforms repo to include >> MdePkg.dsc.inc and cleanup the default Lib instance in dsc files. >> >> (1) The file name should be "MdeLibs.dsc.inc", and it should be >> structured similarly "NetworkLibs.dsc.inc" -- no [LibraryClasses] header >> should be part of the file. >> > I agree. > >> (2) The introduction of "MdeLibs.dsc.inc" is a big task, in my opinion. >> > The full MdeLibs.dsc.inc is a big task. But, it should be a separate task. > > For this patch set, the first version MdeLibs.dsc.inc can be added. It only > includes RegisterFilterLibNull library instance. > And, this patch set will update every platform DSC to include > MdeLi
Re: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
I know that NetworkPkg already provided a case of DSC header file. But NetworkPkg provides drivers and the dependent libs. Multiple instances of a single lib class are not common in NetworkPkg. So, for NetworkPkg, the consumer can simplify include the DSC header files. But for MdePkg, there are so many lib instances for a single lib class. I am not sure how we create the DSC header file (which lib instance should be chosen). Maybe having a DSC header file can avoid changing lots of code in each platform DSC *today*. But imagine that we look at the platform DSC file after couple years/months, we might be more frustrated about which lib instances are used in the platform. Still, I am open to see what the final MdePkg DSC header will be like. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, March 18, 2021 9:25 PM > To: gaoliming ; Bi, Dandan ; > devel@edk2.groups.io; a...@kernel.org; > 'Andrew Fish' > Cc: 'Leif Lindholm' ; Kinney, Michael D > > Subject: Re: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > RegisterFilterLibNull instance > > On 03/18/21 05:43, gaoliming wrote: > > Laszlo and Dandan: > > > >> -邮件原件- > >> 发件人: Laszlo Ersek > >> 发送时间: 2021年3月18日 1:08 > >> 收件人: Bi, Dandan ; devel@edk2.groups.io; > >> gaolim...@byosoft.com.cn; a...@kernel.org; 'Andrew Fish' > >> > >> 抄送: 'Leif Lindholm' ; Kinney, Michael D > >> > >> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > >> RegisterFilterLibNull instance > >> > >> On 03/17/21 16:05, Bi, Dandan wrote: > >>>> -Original Message- > >>>> From: devel@edk2.groups.io On Behalf Of > >>>> gaoliming > >>>> Sent: Wednesday, March 17, 2021 11:05 AM > >>>> To: devel@edk2.groups.io; a...@kernel.org; Bi, Dandan > >>>> ; 'Laszlo Ersek' ; 'Andrew > >> Fish' > >>>> > >>>> Cc: 'Leif Lindholm' ; Kinney, Michael D > >>>> > >>>> Subject: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > >>>> RegisterFilterLibNull instance > >>>> > >>>> Ard and Dandan: > >>>> > >>>>> -邮件原件- > >>>>> 发件人: devel@edk2.groups.io 代表 Ard > >>>> Biesheuvel > >>>>> 发送时间: 2021年3月16日 23:01 > >>>>> 收件人: devel@edk2.groups.io; dandan...@intel.com; Laszlo Ersek > >>>>> ; Andrew Fish > >>>>> 抄送: Leif Lindholm ; Michael D Kinney > >>>>> ; Liming Gao > >>>>> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > >>>>> RegisterFilterLibNull instance > >>>>> > >>>>> On Tue, 16 Mar 2021 at 15:56, Dandan Bi wrote: > >>>>>> > >>>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > >>>>>> RFC: https://edk2.groups.io/g/devel/message/72530 > >>>>>> > >>>>>> > >>>>>> Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which > >>>>>> will be consumed by IoLib and BaseLib. > >>>>>> > >>>>>> This is the following update in edk2-platforms repo for the change > >>>>>> in edk2, which will add RegisterFilterLib dependency for IoLib and > >>>>>> BaseLib to > >>>>> filter/trace > >>>>>> port IO/MMIO/MSR access. > >>>>>> https://edk2.groups.io/g/devel/message/72754 > >>>>>> > >>>>>> Cc: Leif Lindholm > >>>>>> Cc: Michael D Kinney > >>>>>> Cc: Liming Gao > >>>>>> > >>>>> > >>>>> It is a bit disappointing that we have to update every platform in > >>>>> existence again to apply a change to a core module. > >>>>> > >>>> > >>>> I suggest to add MdePkg.dsc.inc file to include the default library > >>>> instance, > >>>> and update all Platform DSC to include it. Then, for the future change, > >>>> no > >>>> change is required for platform DSC. > >>>> > >>>> Because this patch set updates every platform DSC, I suggest to introduce > >>>> MdePkg.dsc.inc file in this patch set. > >>> > >>> Hi Liming, > >>&
回复: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance
Ray: For now, this one MdeLibs.dsc.inc is introduced to mainly resolve the future incompatible change. For long term, this one MdeLibs.dsc.inc includes the default library instance from MdePkg. The platform DSC can still specify its library instance after include MdeLibs.dsc.inc. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ni, Ray > 发送时间: 2021年3月18日 21:42 > 收件人: devel@edk2.groups.io; ler...@redhat.com; gaoliming > ; Bi, Dandan ; > a...@kernel.org; 'Andrew Fish' > 抄送: 'Leif Lindholm' ; Kinney, Michael D > > 主题: Re: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > RegisterFilterLibNull instance > > I know that NetworkPkg already provided a case of DSC header file. > But NetworkPkg provides drivers and the dependent libs. Multiple instances > of a single lib class are not common in NetworkPkg. So, for NetworkPkg, the > consumer can simplify include the DSC header files. > > > But for MdePkg, there are so many lib instances for a single lib class. I am > not > sure how we create the DSC header file (which lib instance should be chosen). > > Maybe having a DSC header file can avoid changing lots of code in each > platform DSC *today*. But imagine that we look at the platform DSC file after > couple years/months, we might be more frustrated about which lib instances > are used in the platform. > > Still, I am open to see what the final MdePkg DSC header will be like. > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > > Sent: Thursday, March 18, 2021 9:25 PM > > To: gaoliming ; Bi, Dandan > ; devel@edk2.groups.io; a...@kernel.org; > > 'Andrew Fish' > > Cc: 'Leif Lindholm' ; Kinney, Michael D > > > Subject: Re: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > RegisterFilterLibNull instance > > > > On 03/18/21 05:43, gaoliming wrote: > > > Laszlo and Dandan: > > > > > >> -邮件原件- > > >> 发件人: Laszlo Ersek > > >> 发送时间: 2021年3月18日 1:08 > > >> 收件人: Bi, Dandan ; devel@edk2.groups.io; > > >> gaolim...@byosoft.com.cn; a...@kernel.org; 'Andrew Fish' > > >> > > >> 抄送: 'Leif Lindholm' ; Kinney, Michael D > > >> > > >> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > > >> RegisterFilterLibNull instance > > >> > > >> On 03/17/21 16:05, Bi, Dandan wrote: > > >>>> -----Original Message- > > >>>> From: devel@edk2.groups.io On Behalf Of > > >>>> gaoliming > > >>>> Sent: Wednesday, March 17, 2021 11:05 AM > > >>>> To: devel@edk2.groups.io; a...@kernel.org; Bi, Dandan > > >>>> ; 'Laszlo Ersek' ; > 'Andrew > > >> Fish' > > >>>> > > >>>> Cc: 'Leif Lindholm' ; Kinney, Michael D > > >>>> > > >>>> Subject: 回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > > >>>> RegisterFilterLibNull instance > > >>>> > > >>>> Ard and Dandan: > > >>>> > > >>>>> -邮件原件- > > >>>>> 发件人: devel@edk2.groups.io 代表 Ard > > >>>> Biesheuvel > > >>>>> 发送时间: 2021年3月16日 23:01 > > >>>>> 收件人: devel@edk2.groups.io; dandan...@intel.com; Laszlo Ersek > > >>>>> ; Andrew Fish > > >>>>> 抄送: Leif Lindholm ; Michael D Kinney > > >>>>> ; Liming Gao > > > >>>>> 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume > > >>>>> RegisterFilterLibNull instance > > >>>>> > > >>>>> On Tue, 16 Mar 2021 at 15:56, Dandan Bi > wrote: > > >>>>>> > > >>>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > >>>>>> RFC: https://edk2.groups.io/g/devel/message/72530 > > >>>>>> > > >>>>>> > > >>>>>> Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which > > >>>>>> will be consumed by IoLib and BaseLib. > > >>>>>> > > >>>>>> This is the following update in edk2-platforms repo for the change > > >>>>>> in edk2, which will add RegisterFilterLib dependency for IoLib and > > >>>>>> BaseLib to > > >>>>> filter/trace > > >&g
