Re: 回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
Thanks you so much Liming.
Regards,
Praveen Sankar
-Original Message-
From: gaoliming
Sent: Friday, May 10, 2024 6:16 AM
To: devel@edk2.groups.io; Praveen Sankar N
Cc: Srinivasan Mani ; Sundaresan S ;
michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
; Rabisha R
Subject: [EXTERNAL] 回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR
table Revision 4 structure
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening attachments, clicking links, or following guidance.**
It has been merged.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Praveen Sankar N
> via groups.io
> 发送时间: 2024年5月9日 14:33
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Srinivasan Mani ; Sundaresan S
> ; michael.d.kin...@intel.com;
> zhiguang@intel.com; Felix Polyudov ; Rabisha R
>
> 主题: Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
>
> Hi Liming,
> Pull request is done and pipelines are built successfully and
> the patch is ready to push to the master.
>
> Thanks,
> Praveen Sankar
>
> -Original Message-
> From: gaoliming
> Sent: Monday, May 6, 2024 7:53 AM
> To: Praveen Sankar N ; devel@edk2.groups.io
> Cc: Srinivasan Mani ; Sundaresan S
> ; michael.d.kin...@intel.com;
> zhiguang@intel.com; Felix Polyudov ; Rabisha R
>
> Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
>
>
> **CAUTION: The e-mail below is from an external source. Please
> exercise caution before opening attachments, clicking links, or
> following guidance.**
>
> Reviewed-by: Liming Gao
>
> > -邮件原件-
> > 发件人: Praveen Sankar N
> > 发送时间: 2024年5月2日 19:16
> > 收件人: devel@edk2.groups.io
> > 抄送: gaolim...@byosoft.com.cn; Srinivasan Mani ;
> > Sundaresan S ; michael.d.kin...@intel.com;
> > zhiguang@intel.com; Felix Polyudov ; Rabisha R
> >
> > 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
> >
> > In SPCR table, 4 structure members have been added newly as per SPCR
> > table Revision 4, which has to be added in
> > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
> >
> > Signed-off-by: Praveen Sankar N praveensank...@ami.com
> >
> > Cc: michael.d.kin...@intel.com
> >
> > Cc: gaolim...@byosoft.com.cn
> >
> > Cc: zhiguang@intel.com
> >
> > Cc: fel...@ami.com
> >
> > Cc: srinivas...@ami.com
> >
> > Cc: sundares...@ami.com
> >
> > Cc: rabis...@ami.com
> > ---
> > .../SerialPortConsoleRedirectionTable.h | 32 +++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > index eb5ae28390..bf967880ab 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > @@ -23,6 +23,7 @@
> > ///
> >
> > #define
> > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
> >
> >
> >
> > +#define
> > EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> > 0x04
> >
> > ///
> >
> > /// Serial Port Console Redirection Table Format
> >
> > ///
> >
> > @@ -50,6 +51,37 @@ typedef struct {
> >UINT32Reserved3;
> >
> > } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> >
> >
> > +///
> >
> > +/// Serial Port Console Redirection Table Format Revision 4
> >
> > +///
> >
> > +typedef struct {
> >
> > + EFI_ACPI_DESCRIPTION_HEADER Header;
> >
> > + UINT8 InterfaceType;
> >
> > + UINT8 Reserved1[3];
> >
> > + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTUREBaseAddress;
> >
> > + UINT8 InterruptType;
> >
> > + UINT8 Irq;
> >
> > + UINT32
> > GlobalSystemInterrupt;
> >
> > + UINT8 BaudRate;
> >
> > + UINT8 Parity;
> >
> > + UINT8 StopBits;
> >
> > + UINT8
回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
It has been merged.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Praveen Sankar
> N via groups.io
> 发送时间: 2024年5月9日 14:33
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Srinivasan Mani ; Sundaresan S
> ; michael.d.kin...@intel.com; zhiguang@intel.com;
> Felix Polyudov ; Rabisha R
> 主题: Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
>
> Hi Liming,
> Pull request is done and pipelines are built successfully and the patch
> is
> ready to push to the master.
>
> Thanks,
> Praveen Sankar
>
> -Original Message-
> From: gaoliming
> Sent: Monday, May 6, 2024 7:53 AM
> To: Praveen Sankar N ; devel@edk2.groups.io
> Cc: Srinivasan Mani ; Sundaresan S
> ; michael.d.kin...@intel.com; zhiguang@intel.com;
> Felix Polyudov ; Rabisha R
> Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
>
>
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution
> before opening attachments, clicking links, or following guidance.**
>
> Reviewed-by: Liming Gao
>
> > -邮件原件-
> > 发件人: Praveen Sankar N
> > 发送时间: 2024年5月2日 19:16
> > 收件人: devel@edk2.groups.io
> > 抄送: gaolim...@byosoft.com.cn; Srinivasan Mani ;
> > Sundaresan S ; michael.d.kin...@intel.com;
> > zhiguang@intel.com; Felix Polyudov ; Rabisha R
> >
> > 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
> >
> > In SPCR table, 4 structure members have been added newly as per SPCR
> > table Revision 4, which has to be added in
> > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
> >
> > Signed-off-by: Praveen Sankar N praveensank...@ami.com
> >
> > Cc: michael.d.kin...@intel.com
> >
> > Cc: gaolim...@byosoft.com.cn
> >
> > Cc: zhiguang@intel.com
> >
> > Cc: fel...@ami.com
> >
> > Cc: srinivas...@ami.com
> >
> > Cc: sundares...@ami.com
> >
> > Cc: rabis...@ami.com
> > ---
> > .../SerialPortConsoleRedirectionTable.h | 32 +++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > index eb5ae28390..bf967880ab 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > @@ -23,6 +23,7 @@
> > ///
> >
> > #define
> > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
> >
> >
> >
> > +#define
> > EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> > 0x04
> >
> > ///
> >
> > /// Serial Port Console Redirection Table Format
> >
> > ///
> >
> > @@ -50,6 +51,37 @@ typedef struct {
> >UINT32Reserved3;
> >
> > } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> >
> >
> > +///
> >
> > +/// Serial Port Console Redirection Table Format Revision 4
> >
> > +///
> >
> > +typedef struct {
> >
> > + EFI_ACPI_DESCRIPTION_HEADER Header;
> >
> > + UINT8 InterfaceType;
> >
> > + UINT8 Reserved1[3];
> >
> > + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTUREBaseAddress;
> >
> > + UINT8 InterruptType;
> >
> > + UINT8 Irq;
> >
> > + UINT32
> > GlobalSystemInterrupt;
> >
> > + UINT8 BaudRate;
> >
> > + UINT8 Parity;
> >
> > + UINT8 StopBits;
> >
> > + UINT8 FlowControl;
> >
> > + UINT8 TerminalType;
> >
> > + UINT8 Reserved2;
> >
> > + UINT16PciDeviceId;
> >
> > + UINT16PciVendorId;
> >
> > + UINT8 PciBusNumber;
> >
> > + UINT8 PciDeviceNumber;
> >
> > + UINT8 PciFunctionNumber;
> >
> > + UINT32PciFlags;
> >
> > + UINT8 PciSegment;
> >
> > + UINT32UartClockFrequency;
> >
> > + UINT32PreciseBaudRate;
> >
> > + UINT16
> > NameSpaceStrLength;
> >
> > + UINT16
> > NameSpaceStrOffset;
> >
> > + CHAR8
> > NameSpaceString[0];
> >
> > +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> > +
> >
> > #pragma pack()
> >
> >
> >
> > //
> >
> > --
> > 2.38.1.windows.1
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended
> to
> > be read only by the individual or entity to whom it is addressed or by
> their
> > designee. If the reader of this message
