Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Ray, it's merged to edk2 repo. -Original Message- From: Ni, Ray Sent: Wednesday, March 15, 2023 9:12 AM To: Palomino Sosa, Guillermo A ; Kinney, Michael D ; Feng, Bob C ; Gao, Liming ; devel@edk2.groups.io Cc: Chen, Christine ; Oram, Isaac W ; Sean Brogan ; a...@kernel.org Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report I saw the code was merged to edk2-basetools repo 5 days ago. When will the change be in edk2 repo? I am really interested in using the json files Thanks, Ray > -Original Message- > From: Palomino Sosa, Guillermo A > Sent: Monday, March 6, 2023 11:41 PM > To: Kinney, Michael D ; Feng, Bob C > ; Gao, Liming ; > devel@edk2.groups.io > Cc: Chen, Christine ; Ni, Ray > ; Oram, Isaac W ; Sean > Brogan ; a...@kernel.org > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > Hi guys, can we submit the pull request or do you have comments on it? > https://github.com/tianocore/edk2-basetools/pull/88 > > Thanks > > > -Original Message- > From: Palomino Sosa, Guillermo A > Sent: Tuesday, February 28, 2023 10:00 PM > To: Ni, Ray ; Kinney, Michael D > ; devel@edk2.groups.io; a...@kernel.org > Cc: Chen, Christine ; Feng, Bob C > ; Gao, Liming ; Oram, > Isaac W ; Sean Brogan > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > It takes same time as original build report to be generated as it > constructed using the same data structures as build report. So I think > its OK to not have it enabled by default. > > Patch is ready in the pull request to be reviews. > > > > -Original Message- > From: Ni, Ray > Sent: Tuesday, February 28, 2023 6:52 PM > To: Palomino Sosa, Guillermo A ; > Kinney, Michael D ; devel@edk2.groups.io; > a...@kernel.org > Cc: Chen, Christine ; Feng, Bob C > ; Gao, Liming ; Oram, > Isaac W ; Sean Brogan > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > What's the status of this patch? > Does report generation take time? If no, why not generate them by > default without individual flag control. > I really like the feature to generate "compile_commands.json" > > > -Original Message- > > From: Palomino Sosa, Guillermo A > > > > Sent: Tuesday, February 28, 2023 7:42 AM > > To: Kinney, Michael D ; > > devel@edk2.groups.io; a...@kernel.org > > Cc: Ni, Ray ; Chen, Christine > > ; Feng, Bob C ; Gao, > > Liming ; Oram, Isaac W > > ; Sean Brogan > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > information in build report > > > > I have updated the pull based on Sean feedback. I added following > > fields to > > module_report.json: > > * LibraryClass > > * ModuleEntryPointList > > * ConstructorList > > * DestructorList > > > > I have also added commit from Ard based on this request to fix build issue: > > https://github.com/tianocore/edk2-basetools/pull/88 > > > > Thanks > > > > -----Original Message- > > From: Kinney, Michael D > > Sent: Monday, February 27, 2023 4:36 PM > > To: devel@edk2.groups.io; a...@kernel.org; Palomino Sosa, Guillermo > > A > > Cc: Ni, Ray ; Chen, Christine > > ; Feng, Bob C ; Gao, > > Liming ; Oram, Isaac W > > ; Sean Brogan ; > > Kinney, Michael D > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > information in build report > > > > Hi Guillermo, > > > > Can you please look at Ards PR and make sure his fix is included in your PR. > > > > Also, please work with Christine and Bob to see what is going on > > with the Code Coverage check. We do want it to be easy for all > > community members to submit change requests. We may need support > > from the edk2-bastools maintainers to help with CI issues and help > > with changes to > address. > > > > Thanks, > > > > Mike > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of Ard > > > Biesheuvel > > > Sent: Monday, February 27, 2023 10:58 AM > > > To: devel@edk2.groups.io; Palomino Sosa, Guillermo A > > > > > > Cc: Ni, Ray ; Kinney, Michael D > > > ; Chen, Christine > > > ; Feng, Bob C ; Gao, > > > Liming ; Oram, Isaac W > > > ; Sean Brogan > > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate > > > compile inf
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
I saw the code was merged to edk2-basetools repo 5 days ago. When will the change be in edk2 repo? I am really interested in using the json files Thanks, Ray > -Original Message- > From: Palomino Sosa, Guillermo A > Sent: Monday, March 6, 2023 11:41 PM > To: Kinney, Michael D ; Feng, Bob C > ; Gao, Liming ; > devel@edk2.groups.io > Cc: Chen, Christine ; Ni, Ray ; > Oram, Isaac W ; Sean Brogan > ; a...@kernel.org > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > Hi guys, can we submit the pull request or do you have comments on it? > https://github.com/tianocore/edk2-basetools/pull/88 > > Thanks > > > -Original Message- > From: Palomino Sosa, Guillermo A > Sent: Tuesday, February 28, 2023 10:00 PM > To: Ni, Ray ; Kinney, Michael D > ; devel@edk2.groups.io; a...@kernel.org > Cc: Chen, Christine ; Feng, Bob C > ; Gao, Liming ; Oram, > Isaac W ; Sean Brogan > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > It takes same time as original build report to be generated as it constructed > using the same data structures as build report. So I think its OK to not have > it > enabled by default. > > Patch is ready in the pull request to be reviews. > > > > -Original Message- > From: Ni, Ray > Sent: Tuesday, February 28, 2023 6:52 PM > To: Palomino Sosa, Guillermo A ; > Kinney, Michael D ; devel@edk2.groups.io; > a...@kernel.org > Cc: Chen, Christine ; Feng, Bob C > ; Gao, Liming ; Oram, > Isaac W ; Sean Brogan > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > What's the status of this patch? > Does report generation take time? If no, why not generate them by default > without individual flag control. > I really like the feature to generate "compile_commands.json" > > > -Original Message- > > From: Palomino Sosa, Guillermo A > > Sent: Tuesday, February 28, 2023 7:42 AM > > To: Kinney, Michael D ; > > devel@edk2.groups.io; a...@kernel.org > > Cc: Ni, Ray ; Chen, Christine > > ; Feng, Bob C ; Gao, > > Liming ; Oram, Isaac W > > ; Sean Brogan > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > information in build report > > > > I have updated the pull based on Sean feedback. I added following > > fields to > > module_report.json: > > * LibraryClass > > * ModuleEntryPointList > > * ConstructorList > > * DestructorList > > > > I have also added commit from Ard based on this request to fix build issue: > > https://github.com/tianocore/edk2-basetools/pull/88 > > > > Thanks > > > > -Original Message----- > > From: Kinney, Michael D > > Sent: Monday, February 27, 2023 4:36 PM > > To: devel@edk2.groups.io; a...@kernel.org; Palomino Sosa, Guillermo A > > > > Cc: Ni, Ray ; Chen, Christine > > ; Feng, Bob C ; Gao, > > Liming ; Oram, Isaac W > > ; Sean Brogan ; > > Kinney, Michael D > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > information in build report > > > > Hi Guillermo, > > > > Can you please look at Ards PR and make sure his fix is included in your PR. > > > > Also, please work with Christine and Bob to see what is going on with > > the Code Coverage check. We do want it to be easy for all community > > members to submit change requests. We may need support from the > > edk2-bastools maintainers to help with CI issues and help with changes to > address. > > > > Thanks, > > > > Mike > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of Ard > > > Biesheuvel > > > Sent: Monday, February 27, 2023 10:58 AM > > > To: devel@edk2.groups.io; Palomino Sosa, Guillermo A > > > > > > Cc: Ni, Ray ; Kinney, Michael D > > > ; Chen, Christine > > > ; Feng, Bob C ; Gao, > > > Liming ; Oram, Isaac W > > > ; Sean Brogan > > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > > information in build report > > > > > > On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa > > > wrote: > > > > > > > > Hi. I have submitted a pull request to edk2-basetools repository: > > > > https://github.com/tianocore/edk2-basetools/pull/88 > > > > This is the feature request for it: > > > > https://github.com/tianocore/edk2
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Hi guys, can we submit the pull request or do you have comments on it? https://github.com/tianocore/edk2-basetools/pull/88 Thanks -Original Message- From: Palomino Sosa, Guillermo A Sent: Tuesday, February 28, 2023 10:00 PM To: Ni, Ray ; Kinney, Michael D ; devel@edk2.groups.io; a...@kernel.org Cc: Chen, Christine ; Feng, Bob C ; Gao, Liming ; Oram, Isaac W ; Sean Brogan Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report It takes same time as original build report to be generated as it constructed using the same data structures as build report. So I think its OK to not have it enabled by default. Patch is ready in the pull request to be reviews. -Original Message- From: Ni, Ray Sent: Tuesday, February 28, 2023 6:52 PM To: Palomino Sosa, Guillermo A ; Kinney, Michael D ; devel@edk2.groups.io; a...@kernel.org Cc: Chen, Christine ; Feng, Bob C ; Gao, Liming ; Oram, Isaac W ; Sean Brogan Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report What's the status of this patch? Does report generation take time? If no, why not generate them by default without individual flag control. I really like the feature to generate "compile_commands.json" > -Original Message- > From: Palomino Sosa, Guillermo A > Sent: Tuesday, February 28, 2023 7:42 AM > To: Kinney, Michael D ; > devel@edk2.groups.io; a...@kernel.org > Cc: Ni, Ray ; Chen, Christine > ; Feng, Bob C ; Gao, > Liming ; Oram, Isaac W > ; Sean Brogan > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > I have updated the pull based on Sean feedback. I added following > fields to > module_report.json: > * LibraryClass > * ModuleEntryPointList > * ConstructorList > * DestructorList > > I have also added commit from Ard based on this request to fix build issue: > https://github.com/tianocore/edk2-basetools/pull/88 > > Thanks > > -Original Message- > From: Kinney, Michael D > Sent: Monday, February 27, 2023 4:36 PM > To: devel@edk2.groups.io; a...@kernel.org; Palomino Sosa, Guillermo A > > Cc: Ni, Ray ; Chen, Christine > ; Feng, Bob C ; Gao, > Liming ; Oram, Isaac W > ; Sean Brogan ; > Kinney, Michael D > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > Hi Guillermo, > > Can you please look at Ards PR and make sure his fix is included in your PR. > > Also, please work with Christine and Bob to see what is going on with > the Code Coverage check. We do want it to be easy for all community > members to submit change requests. We may need support from the > edk2-bastools maintainers to help with CI issues and help with changes to > address. > > Thanks, > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Ard > > Biesheuvel > > Sent: Monday, February 27, 2023 10:58 AM > > To: devel@edk2.groups.io; Palomino Sosa, Guillermo A > > > > Cc: Ni, Ray ; Kinney, Michael D > > ; Chen, Christine > > ; Feng, Bob C ; Gao, > > Liming ; Oram, Isaac W > > ; Sean Brogan > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > information in build report > > > > On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa > > wrote: > > > > > > Hi. I have submitted a pull request to edk2-basetools repository: > > > https://github.com/tianocore/edk2-basetools/pull/88 > > > This is the feature request for it: > > > https://github.com/tianocore/edk2-basetools/issues/87 > > > I'm also attaching the patch here: > > > (0001-BaseTools-Generate-compile-information-in-build-repo.patch) > > > > > > On a side note, seems like tip of edk2-basetools is broken due > > > this > commit that makes direct import of Common package: > > > https://github.com/tianocore/edk2- > basetools/commit/8e6018d3ea4c1aae7 > > > 185f589d129cea14a5d89fd > > > edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py: > > > import Common.LongFilePathOs as os > > > > > > > > > > I sent a fix and a PR for this about a month ago: > > > > https://github.com/tianocore/edk2-basetools/pull/86 > > > > but CodeCov seems to take issue with it, for reasons I don't > > understand (and I can't be bothered to spend more time on yet > > another CI automation pass that adds to my workload rather than > > reduce it) > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100736): https://edk2.groups.io/g/devel/message/100736 Mute This Topic: https://groups.io/mt/96800354/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
It takes same time as original build report to be generated as it constructed using the same data structures as build report. So I think its OK to not have it enabled by default. Patch is ready in the pull request to be reviews. -Original Message- From: Ni, Ray Sent: Tuesday, February 28, 2023 6:52 PM To: Palomino Sosa, Guillermo A ; Kinney, Michael D ; devel@edk2.groups.io; a...@kernel.org Cc: Chen, Christine ; Feng, Bob C ; Gao, Liming ; Oram, Isaac W ; Sean Brogan Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report What's the status of this patch? Does report generation take time? If no, why not generate them by default without individual flag control. I really like the feature to generate "compile_commands.json" > -Original Message- > From: Palomino Sosa, Guillermo A > Sent: Tuesday, February 28, 2023 7:42 AM > To: Kinney, Michael D ; > devel@edk2.groups.io; a...@kernel.org > Cc: Ni, Ray ; Chen, Christine > ; Feng, Bob C ; Gao, > Liming ; Oram, Isaac W > ; Sean Brogan > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > I have updated the pull based on Sean feedback. I added following > fields to > module_report.json: > * LibraryClass > * ModuleEntryPointList > * ConstructorList > * DestructorList > > I have also added commit from Ard based on this request to fix build issue: > https://github.com/tianocore/edk2-basetools/pull/88 > > Thanks > > -Original Message- > From: Kinney, Michael D > Sent: Monday, February 27, 2023 4:36 PM > To: devel@edk2.groups.io; a...@kernel.org; Palomino Sosa, Guillermo A > > Cc: Ni, Ray ; Chen, Christine > ; Feng, Bob C ; Gao, > Liming ; Oram, Isaac W > ; Sean Brogan ; > Kinney, Michael D > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > Hi Guillermo, > > Can you please look at Ards PR and make sure his fix is included in your PR. > > Also, please work with Christine and Bob to see what is going on with > the Code Coverage check. We do want it to be easy for all community > members to submit change requests. We may need support from the > edk2-bastools maintainers to help with CI issues and help with changes to > address. > > Thanks, > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Ard > > Biesheuvel > > Sent: Monday, February 27, 2023 10:58 AM > > To: devel@edk2.groups.io; Palomino Sosa, Guillermo A > > > > Cc: Ni, Ray ; Kinney, Michael D > > ; Chen, Christine > > ; Feng, Bob C ; Gao, > > Liming ; Oram, Isaac W > > ; Sean Brogan > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > information in build report > > > > On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa > > wrote: > > > > > > Hi. I have submitted a pull request to edk2-basetools repository: > > > https://github.com/tianocore/edk2-basetools/pull/88 > > > This is the feature request for it: > > > https://github.com/tianocore/edk2-basetools/issues/87 > > > I'm also attaching the patch here: > > > (0001-BaseTools-Generate-compile-information-in-build-repo.patch) > > > > > > On a side note, seems like tip of edk2-basetools is broken due > > > this > commit that makes direct import of Common package: > > > https://github.com/tianocore/edk2- > basetools/commit/8e6018d3ea4c1aae7 > > > 185f589d129cea14a5d89fd > > > edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py: > > > import Common.LongFilePathOs as os > > > > > > > > > > I sent a fix and a PR for this about a month ago: > > > > https://github.com/tianocore/edk2-basetools/pull/86 > > > > but CodeCov seems to take issue with it, for reasons I don't > > understand (and I can't be bothered to spend more time on yet > > another CI automation pass that adds to my workload rather than > > reduce it) > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100558): https://edk2.groups.io/g/devel/message/100558 Mute This Topic: https://groups.io/mt/96800354/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
What's the status of this patch? Does report generation take time? If no, why not generate them by default without individual flag control. I really like the feature to generate "compile_commands.json" > -Original Message- > From: Palomino Sosa, Guillermo A > Sent: Tuesday, February 28, 2023 7:42 AM > To: Kinney, Michael D ; devel@edk2.groups.io; > a...@kernel.org > Cc: Ni, Ray ; Chen, Christine ; > Feng, Bob C ; Gao, Liming > ; Oram, Isaac W ; > Sean Brogan > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > I have updated the pull based on Sean feedback. I added following fields to > module_report.json: > * LibraryClass > * ModuleEntryPointList > * ConstructorList > * DestructorList > > I have also added commit from Ard based on this request to fix build issue: > https://github.com/tianocore/edk2-basetools/pull/88 > > Thanks > > -Original Message- > From: Kinney, Michael D > Sent: Monday, February 27, 2023 4:36 PM > To: devel@edk2.groups.io; a...@kernel.org; Palomino Sosa, Guillermo A > > Cc: Ni, Ray ; Chen, Christine ; > Feng, Bob C ; Gao, Liming > ; Oram, Isaac W ; > Sean Brogan ; Kinney, Michael D > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > Hi Guillermo, > > Can you please look at Ards PR and make sure his fix is included in your PR. > > Also, please work with Christine and Bob to see what is going on with the > Code Coverage check. We do want it to be easy for all community members > to submit change requests. We may need support from the edk2-bastools > maintainers to help with CI issues and help with changes to address. > > Thanks, > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Ard > > Biesheuvel > > Sent: Monday, February 27, 2023 10:58 AM > > To: devel@edk2.groups.io; Palomino Sosa, Guillermo A > > > > Cc: Ni, Ray ; Kinney, Michael D > > ; Chen, Christine ; > > Feng, Bob C ; Gao, Liming > > ; Oram, Isaac W ; > > Sean Brogan > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > information in build report > > > > On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa > > wrote: > > > > > > Hi. I have submitted a pull request to edk2-basetools repository: > > > https://github.com/tianocore/edk2-basetools/pull/88 > > > This is the feature request for it: > > > https://github.com/tianocore/edk2-basetools/issues/87 > > > I'm also attaching the patch here: > > > (0001-BaseTools-Generate-compile-information-in-build-repo.patch) > > > > > > On a side note, seems like tip of edk2-basetools is broken due this > commit that makes direct import of Common package: > > > https://github.com/tianocore/edk2- > basetools/commit/8e6018d3ea4c1aae7 > > > 185f589d129cea14a5d89fd > > > edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py: > > > import Common.LongFilePathOs as os > > > > > > > > > > I sent a fix and a PR for this about a month ago: > > > > https://github.com/tianocore/edk2-basetools/pull/86 > > > > but CodeCov seems to take issue with it, for reasons I don't > > understand (and I can't be bothered to spend more time on yet another > > CI automation pass that adds to my workload rather than reduce it) > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100553): https://edk2.groups.io/g/devel/message/100553 Mute This Topic: https://groups.io/mt/96800354/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
I have updated the pull based on Sean feedback. I added following fields to module_report.json: * LibraryClass * ModuleEntryPointList * ConstructorList * DestructorList I have also added commit from Ard based on this request to fix build issue: https://github.com/tianocore/edk2-basetools/pull/88 Thanks -Original Message- From: Kinney, Michael D Sent: Monday, February 27, 2023 4:36 PM To: devel@edk2.groups.io; a...@kernel.org; Palomino Sosa, Guillermo A Cc: Ni, Ray ; Chen, Christine ; Feng, Bob C ; Gao, Liming ; Oram, Isaac W ; Sean Brogan ; Kinney, Michael D Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report Hi Guillermo, Can you please look at Ards PR and make sure his fix is included in your PR. Also, please work with Christine and Bob to see what is going on with the Code Coverage check. We do want it to be easy for all community members to submit change requests. We may need support from the edk2-bastools maintainers to help with CI issues and help with changes to address. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Monday, February 27, 2023 10:58 AM > To: devel@edk2.groups.io; Palomino Sosa, Guillermo A > > Cc: Ni, Ray ; Kinney, Michael D > ; Chen, Christine ; > Feng, Bob C ; Gao, Liming > ; Oram, Isaac W ; > Sean Brogan > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa > wrote: > > > > Hi. I have submitted a pull request to edk2-basetools repository: > > https://github.com/tianocore/edk2-basetools/pull/88 > > This is the feature request for it: > > https://github.com/tianocore/edk2-basetools/issues/87 > > I'm also attaching the patch here: > > (0001-BaseTools-Generate-compile-information-in-build-repo.patch) > > > > On a side note, seems like tip of edk2-basetools is broken due this commit > > that makes direct import of Common package: > > https://github.com/tianocore/edk2-basetools/commit/8e6018d3ea4c1aae7 > > 185f589d129cea14a5d89fd > > edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py: > > import Common.LongFilePathOs as os > > > > > > I sent a fix and a PR for this about a month ago: > > https://github.com/tianocore/edk2-basetools/pull/86 > > but CodeCov seems to take issue with it, for reasons I don't > understand (and I can't be bothered to spend more time on yet another > CI automation pass that adds to my workload rather than reduce it) > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100528): https://edk2.groups.io/g/devel/message/100528 Mute This Topic: https://groups.io/mt/96800354/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Hi Guillermo, Can you please look at Ards PR and make sure his fix is included in your PR. Also, please work with Christine and Bob to see what is going on with the Code Coverage check. We do want it to be easy for all community members to submit change requests. We may need support from the edk2-bastools maintainers to help with CI issues and help with changes to address. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Monday, February 27, 2023 10:58 AM > To: devel@edk2.groups.io; Palomino Sosa, Guillermo A > > Cc: Ni, Ray ; Kinney, Michael D > ; Chen, Christine ; Feng, > Bob C ; Gao, Liming ; Oram, > Isaac W ; Sean Brogan > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa > wrote: > > > > Hi. I have submitted a pull request to edk2-basetools repository: > > https://github.com/tianocore/edk2-basetools/pull/88 > > This is the feature request for it: > > https://github.com/tianocore/edk2-basetools/issues/87 > > I'm also attaching the patch here: > > (0001-BaseTools-Generate-compile-information-in-build-repo.patch) > > > > On a side note, seems like tip of edk2-basetools is broken due this commit > > that makes direct import of Common package: > > https://github.com/tianocore/edk2-basetools/commit/8e6018d3ea4c1aae7185f589d129cea14a5d89fd > > edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py: > > import Common.LongFilePathOs as os > > > > > > I sent a fix and a PR for this about a month ago: > > https://github.com/tianocore/edk2-basetools/pull/86 > > but CodeCov seems to take issue with it, for reasons I don't > understand (and I can't be bothered to spend more time on yet another > CI automation pass that adds to my workload rather than reduce it) > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100522): https://edk2.groups.io/g/devel/message/100522 Mute This Topic: https://groups.io/mt/96800354/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa wrote: > > Hi. I have submitted a pull request to edk2-basetools repository: > https://github.com/tianocore/edk2-basetools/pull/88 > This is the feature request for it: > https://github.com/tianocore/edk2-basetools/issues/87 > I'm also attaching the patch here: > (0001-BaseTools-Generate-compile-information-in-build-repo.patch) > > On a side note, seems like tip of edk2-basetools is broken due this commit > that makes direct import of Common package: > https://github.com/tianocore/edk2-basetools/commit/8e6018d3ea4c1aae7185f589d129cea14a5d89fd > edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py: > import Common.LongFilePathOs as os > > I sent a fix and a PR for this about a month ago: https://github.com/tianocore/edk2-basetools/pull/86 but CodeCov seems to take issue with it, for reasons I don't understand (and I can't be bothered to spend more time on yet another CI automation pass that adds to my workload rather than reduce it) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100521): https://edk2.groups.io/g/devel/message/100521 Mute This Topic: https://groups.io/mt/96800354/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Hi. I have submitted a pull request to edk2-basetools repository: https://github.com/tianocore/edk2-basetools/pull/88 This is the feature request for it: https://github.com/tianocore/edk2-basetools/issues/87 I'm also attaching the patch here: (0001-BaseTools-Generate-compile-information-in-build-repo.patch) On a side note, seems like tip of edk2-basetools is broken due this commit that makes direct import of Common package: https://github.com/tianocore/edk2-basetools/commit/8e6018d3ea4c1aae7185f589d129cea14a5d89fd edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py: import Common.LongFilePathOs as os -Original Message- From: Ni, Ray Sent: Wednesday, February 15, 2023 6:51 PM To: Kinney, Michael D ; devel@edk2.groups.io; Chen, Christine ; Palomino Sosa, Guillermo A Cc: Feng, Bob C ; Gao, Liming Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report Mike, Thanks for the explanation of status and plan. > -Original Message- > From: Kinney, Michael D > Sent: Thursday, February 16, 2023 7:13 AM > To: Ni, Ray ; devel@edk2.groups.io; Chen, Christine > ; Palomino Sosa, Guillermo A > > Cc: Feng, Bob C ; Gao, Liming > ; Kinney, Michael D > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > Hi Ray, > > Right now we want the commit in both places. > > The priority is edk2-basetools first. It has more CI checks than edk2 > repo for tools and packages up as a pip module. > > As soon as edk2-basetools change is merged, the edk2 repo change can > be submitted and merged because the reviews have already been > completed by the BaseTools maintainers. > > We do not like commit in 2 places. As soon as possible, we would like > to see the python sources removed from edk2/BaseTools and all devs/CI > only use edk2- basetools for python based tools. > > Mike > > > -Original Message- > > From: Ni, Ray > > Sent: Wednesday, February 15, 2023 12:17 AM > > To: devel@edk2.groups.io; Chen, Christine ; > Kinney, Michael D ; Palomino Sosa, > > Guillermo A > > Cc: Feng, Bob C ; Gao, Liming > > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > > > Christine, > > If BaseTools related changes is implemented in edk2-basetools repo, > > does that mean if I only checkout edk2 repo, I am using an older > > version of > BaseTools? > > > > Thanks, > > Ray > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of > Yuwei > > > Chen > > > Sent: Wednesday, February 15, 2023 1:38 PM > > > To: Kinney, Michael D ; > devel@edk2.groups.io; > > > Palomino Sosa, Guillermo A > > > Cc: Feng, Bob C ; Gao, Liming > > > > > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate > > > compile information in build report > > > > > > Hi Mike, thanks for reminder. > > > > > > Hi Willy, currently, BaseTools related changes will be implemented > > > on the edk2-basetools repo. Please send the patch based on the > > > edk2-basetools repo~ > > > > > > Thanks, > > > Christine > > > > > > > -Original Message- > > > > From: Kinney, Michael D > > > > Sent: Wednesday, February 15, 2023 11:43 AM > > > > To: devel@edk2.groups.io; Chen, Christine > > > > ; Palomino Sosa, Guillermo A > > > > > > > > Cc: Feng, Bob C ; Gao, Liming > > > > ; Kinney, Michael D > > > > > > > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate > > > > compile information in build report > > > > > > > > Has this been reviewed for edk2-basetools repo? > > > > > > > > Mike > > > > > > > > > -Original Message- > > > > > From: devel@edk2.groups.io On Behalf Of > > > Yuwei > > > > > Chen > > > > > Sent: Tuesday, February 14, 2023 6:44 PM > > > > > To: Palomino Sosa, Guillermo A > ; > > > > > devel@edk2.groups.io > > > > > Cc: Feng, Bob C ; Gao, Liming > > > > > > > > > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate > compile > > > > > information in build report > > > > > > > > > > Reviewed-by: Yuwei Chen > > > > > > > > > > > -Original Message- > > > > > > From: Palomino Sosa, G
Re: [edk2-devel] [PATCH V1 1/1] BaseTools: Generate compile information in build report
Hi. I have submitted a pull request to edk2-basetools repository:
https://github.com/tianocore/edk2-basetools/pull/88
This is the feature request for it:
https://github.com/tianocore/edk2-basetools/issues/87
I'm also attaching the patch here: (
0001-BaseTools-Generate-compile-information-in-build-repo.patch)
On a side note, seems like tip of edk2-basetools is broken due this commit (
https://github.com/tianocore/edk2-basetools/commit/8e6018d3ea4c1aae7185f589d129cea14a5d89fd
) that makes direct import of Common package:
edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py:
>
> import Common.LongFilePathOs as os
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100515): https://edk2.groups.io/g/devel/message/100515
Mute This Topic: https://groups.io/mt/96800354/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
From ddb21cdaca196f740a50fdd6524730c3e2cb76fb Mon Sep 17 00:00:00 2001
From: Guillermo Antonio Palomino Sosa
Date: Mon, 27 Feb 2023 10:29:53 -0600
Subject: [PATCH 1/1] BaseTools: Generate compile information in build report
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2850
Add "-Y REPORT_INFO" option to build command to generate compile
information as part of BuildReport.
This option generates files to be used by external tools as IDE's
to enhance functionality.
Files are created inside build folder:
///CompileInfo
Files created:
* compile_commands.json - Compilation Database. To be used by IDE's
to enable advance features
* cscope.files - List of files used in compilation. Used by Cscope to parse
C code and provide browse functionality.
* module_report.json - Module data form buildReport in Json format.
Signed-off-by: Guillermo Antonio Palomino Sosa
---
edk2basetools/build/BuildReport.py | 138
edk2basetools/build/buildoptions.py | 4 +-
2 files changed, 140 insertions(+), 2 deletions(-)
diff --git a/edk2basetools/build/BuildReport.py
b/edk2basetools/build/BuildReport.py
index 553bfe5..9cfe9dc 100644
--- a/edk2basetools/build/BuildReport.py
+++ b/edk2basetools/build/BuildReport.py
@@ -21,6 +21,8 @@
import hashlib
import subprocess
import threading
+import json
+from pathlib import Path
from datetime import datetime
from io import BytesIO
from edk2basetools.Common import EdkLogger
@@ -41,6 +43,7 @@
import collections
from edk2basetools.Common.Expression import *
from edk2basetools.GenFds.AprioriSection import DXE_APRIORI_GUID,
PEI_APRIORI_GUID
+from edk2basetools.AutoGen.IncludesAutoGen import IncludesAutoGen
## Pattern to extract contents in EDK DXS files
gDxsDependencyPattern = re.compile(r"DEPENDENCY_START(.+)DEPENDENCY_END",
re.DOTALL)
@@ -2298,6 +2301,10 @@ def AddPlatformReport(self, Wa, MaList=None):
def GenerateReport(self, BuildDuration, AutoGenTime, MakeTime, GenFdsTime):
if self.ReportFile:
try:
+
+if "COMPILE_INFO" in self.ReportType:
+self.GenerateCompileInfo()
+
File = []
for (Wa, MaList) in self.ReportList:
PlatformReport(Wa, MaList,
self.ReportType).GenerateReport(File, BuildDuration, AutoGenTime, MakeTime,
GenFdsTime, self.ReportType)
@@ -2310,6 +2317,137 @@ def GenerateReport(self, BuildDuration, AutoGenTime,
MakeTime, GenFdsTime):
EdkLogger.error("BuildReport", CODE_ERROR, "Unknown fatal
error when generating build report", ExtraData=self.ReportFile,
RaiseError=False)
EdkLogger.quiet("(Python %s on %s\n%s)" %
(platform.python_version(), sys.platform, traceback.format_exc()))
+
+##
+# Generates compile data files to be used by external tools.
+# Compile information will be generated in
///CompileInfo
+# Files generated: compile_commands.json, cscope.files, modules_report.json
+#
+# @param selfThe object pointer
+#
+def GenerateCompileInfo(self):
+try:
+# Lists for the output elements
+compile_commands = []
+used_files = set()
+module_report = []
+
+for (Wa, MaList) in self.ReportList:
+# Obtain list of all processed Workspace files
+for file_path in Wa._GetMetaFiles(Wa.BuildTarget,
Wa.ToolChain):
+used_files.add(file_path)
+
+for autoGen in Wa.AutoGenObjectList:
+
+# Loop through all modules
+for module in (autoGen.LibraryAutoGenList +
autoGen.ModuleAutoGenList):
+
+used_files.add(module.MetaFile.Path)
+
+# Main elements of module report
+module_report_data = {}
+module_report_data["Name"] = module.Name
+module_report_data["Arch"] = module.Arch
+
Re: [edk2-devel] [PATCH V1 1/1] BaseTools: Generate compile information in build report
Thanks guys. I will create a new patch based on edk2-basetools next week. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100341): https://edk2.groups.io/g/devel/message/100341 Mute This Topic: https://groups.io/mt/96800354/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Mike, Thanks for the explanation of status and plan. > -Original Message- > From: Kinney, Michael D > Sent: Thursday, February 16, 2023 7:13 AM > To: Ni, Ray ; devel@edk2.groups.io; Chen, Christine > ; Palomino Sosa, Guillermo A > > Cc: Feng, Bob C ; Gao, Liming > ; Kinney, Michael D > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > Hi Ray, > > Right now we want the commit in both places. > > The priority is edk2-basetools first. It has more CI checks than edk2 repo > for > tools and > packages up as a pip module. > > As soon as edk2-basetools change is merged, the edk2 repo change can be > submitted and > merged because the reviews have already been completed by the BaseTools > maintainers. > > We do not like commit in 2 places. As soon as possible, we would like to see > the > python sources removed from edk2/BaseTools and all devs/CI only use edk2- > basetools > for python based tools. > > Mike > > > -Original Message- > > From: Ni, Ray > > Sent: Wednesday, February 15, 2023 12:17 AM > > To: devel@edk2.groups.io; Chen, Christine ; > Kinney, Michael D ; Palomino Sosa, > > Guillermo A > > Cc: Feng, Bob C ; Gao, Liming > > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > > > Christine, > > If BaseTools related changes is implemented in edk2-basetools repo, > > does that mean if I only checkout edk2 repo, I am using an older version of > BaseTools? > > > > Thanks, > > Ray > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of > Yuwei > > > Chen > > > Sent: Wednesday, February 15, 2023 1:38 PM > > > To: Kinney, Michael D ; > devel@edk2.groups.io; > > > Palomino Sosa, Guillermo A > > > Cc: Feng, Bob C ; Gao, Liming > > > > > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > > information in build report > > > > > > Hi Mike, thanks for reminder. > > > > > > Hi Willy, currently, BaseTools related changes will be implemented on the > > > edk2-basetools repo. Please send the patch based on the edk2-basetools > > > repo~ > > > > > > Thanks, > > > Christine > > > > > > > -Original Message- > > > > From: Kinney, Michael D > > > > Sent: Wednesday, February 15, 2023 11:43 AM > > > > To: devel@edk2.groups.io; Chen, Christine ; > > > > Palomino Sosa, Guillermo A > > > > Cc: Feng, Bob C ; Gao, Liming > > > > ; Kinney, Michael D > > > > > > > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > > > information in build report > > > > > > > > Has this been reviewed for edk2-basetools repo? > > > > > > > > Mike > > > > > > > > > -Original Message- > > > > > From: devel@edk2.groups.io On Behalf Of > > > Yuwei > > > > > Chen > > > > > Sent: Tuesday, February 14, 2023 6:44 PM > > > > > To: Palomino Sosa, Guillermo A > ; > > > > > devel@edk2.groups.io > > > > > Cc: Feng, Bob C ; Gao, Liming > > > > > > > > > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate > compile > > > > > information in build report > > > > > > > > > > Reviewed-by: Yuwei Chen > > > > > > > > > > > -Original Message- > > > > > > From: Palomino Sosa, Guillermo A > > > > > > > > > > > > Sent: Tuesday, February 7, 2023 11:07 AM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Feng, Bob C ; Gao, Liming > > > > > > ; Chen, Christine > > > > > > > Subject: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > > > > > information in build report > > > > > > > > > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2850 > > > > > > > > > > > > Add "-Y REPORT_INFO" option to build command to generate > compile > > > > > > information as part of BuildReport. > > > > > > This option generates files to be used by external tools as IDE's to > > > > > > enhance functionality. > > > > > > Files are
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Hi Ray, Right now we want the commit in both places. The priority is edk2-basetools first. It has more CI checks than edk2 repo for tools and packages up as a pip module. As soon as edk2-basetools change is merged, the edk2 repo change can be submitted and merged because the reviews have already been completed by the BaseTools maintainers. We do not like commit in 2 places. As soon as possible, we would like to see the python sources removed from edk2/BaseTools and all devs/CI only use edk2-basetools for python based tools. Mike > -Original Message- > From: Ni, Ray > Sent: Wednesday, February 15, 2023 12:17 AM > To: devel@edk2.groups.io; Chen, Christine ; Kinney, > Michael D ; Palomino Sosa, > Guillermo A > Cc: Feng, Bob C ; Gao, Liming > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > Christine, > If BaseTools related changes is implemented in edk2-basetools repo, > does that mean if I only checkout edk2 repo, I am using an older version of > BaseTools? > > Thanks, > Ray > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Yuwei > > Chen > > Sent: Wednesday, February 15, 2023 1:38 PM > > To: Kinney, Michael D ; devel@edk2.groups.io; > > Palomino Sosa, Guillermo A > > Cc: Feng, Bob C ; Gao, Liming > > > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > information in build report > > > > Hi Mike, thanks for reminder. > > > > Hi Willy, currently, BaseTools related changes will be implemented on the > > edk2-basetools repo. Please send the patch based on the edk2-basetools > > repo~ > > > > Thanks, > > Christine > > > > > -Original Message- > > > From: Kinney, Michael D > > > Sent: Wednesday, February 15, 2023 11:43 AM > > > To: devel@edk2.groups.io; Chen, Christine ; > > > Palomino Sosa, Guillermo A > > > Cc: Feng, Bob C ; Gao, Liming > > > ; Kinney, Michael D > > > > > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > > information in build report > > > > > > Has this been reviewed for edk2-basetools repo? > > > > > > Mike > > > > > > > -----Original Message- > > > > From: devel@edk2.groups.io On Behalf Of > > Yuwei > > > > Chen > > > > Sent: Tuesday, February 14, 2023 6:44 PM > > > > To: Palomino Sosa, Guillermo A ; > > > > devel@edk2.groups.io > > > > Cc: Feng, Bob C ; Gao, Liming > > > > > > > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > > > information in build report > > > > > > > > Reviewed-by: Yuwei Chen > > > > > > > > > -Original Message- > > > > > From: Palomino Sosa, Guillermo A > > > > > > > > > > Sent: Tuesday, February 7, 2023 11:07 AM > > > > > To: devel@edk2.groups.io > > > > > Cc: Feng, Bob C ; Gao, Liming > > > > > ; Chen, Christine > > > > > Subject: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > > > > information in build report > > > > > > > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2850 > > > > > > > > > > Add "-Y REPORT_INFO" option to build command to generate compile > > > > > information as part of BuildReport. > > > > > This option generates files to be used by external tools as IDE's to > > > > > enhance functionality. > > > > > Files are created inside build folder: > > > > > ///CompileInfo > > > > > > > > > > Files created: > > > > > * compile_commands.json - Compilation Database. To be used by IDE's > > > > > to enable advance features > > > > > * cscope.files - List of files used in compilation. Used by Cscope to > > > > > parse > > > > > C code and provide browse functionality. > > > > > * module_report.json - Module data form buildReport in Json format. > > > > > > > > > > Signed-off-by: Guillermo Antonio Palomino Sosa > > > > > > > > > > --- > > > > > BaseTools/Source/Python/build/BuildReport.py | 139 > > > > > +++- > > > > > BaseTools/Source/Python/build/buildoptions.py | 4 +- > > > > > 2 files changed, 140 insertions(+), 3
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Christine, If BaseTools related changes is implemented in edk2-basetools repo, does that mean if I only checkout edk2 repo, I am using an older version of BaseTools? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yuwei > Chen > Sent: Wednesday, February 15, 2023 1:38 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Palomino Sosa, Guillermo A > Cc: Feng, Bob C ; Gao, Liming > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > Hi Mike, thanks for reminder. > > Hi Willy, currently, BaseTools related changes will be implemented on the > edk2-basetools repo. Please send the patch based on the edk2-basetools > repo~ > > Thanks, > Christine > > > -Original Message- > > From: Kinney, Michael D > > Sent: Wednesday, February 15, 2023 11:43 AM > > To: devel@edk2.groups.io; Chen, Christine ; > > Palomino Sosa, Guillermo A > > Cc: Feng, Bob C ; Gao, Liming > > ; Kinney, Michael D > > > > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > information in build report > > > > Has this been reviewed for edk2-basetools repo? > > > > Mike > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of > Yuwei > > > Chen > > > Sent: Tuesday, February 14, 2023 6:44 PM > > > To: Palomino Sosa, Guillermo A ; > > > devel@edk2.groups.io > > > Cc: Feng, Bob C ; Gao, Liming > > > > > > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > > information in build report > > > > > > Reviewed-by: Yuwei Chen > > > > > > > -Original Message- > > > > From: Palomino Sosa, Guillermo A > > > > > > > > Sent: Tuesday, February 7, 2023 11:07 AM > > > > To: devel@edk2.groups.io > > > > Cc: Feng, Bob C ; Gao, Liming > > > > ; Chen, Christine > > > > Subject: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > > > > information in build report > > > > > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2850 > > > > > > > > Add "-Y REPORT_INFO" option to build command to generate compile > > > > information as part of BuildReport. > > > > This option generates files to be used by external tools as IDE's to > > > > enhance functionality. > > > > Files are created inside build folder: > > > > ///CompileInfo > > > > > > > > Files created: > > > > * compile_commands.json - Compilation Database. To be used by IDE's > > > > to enable advance features > > > > * cscope.files - List of files used in compilation. Used by Cscope to > > > > parse > > > > C code and provide browse functionality. > > > > * module_report.json - Module data form buildReport in Json format. > > > > > > > > Signed-off-by: Guillermo Antonio Palomino Sosa > > > > > > > > --- > > > > BaseTools/Source/Python/build/BuildReport.py | 139 > > > > +++- > > > > BaseTools/Source/Python/build/buildoptions.py | 4 +- > > > > 2 files changed, 140 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/BaseTools/Source/Python/build/BuildReport.py > > > > b/BaseTools/Source/Python/build/BuildReport.py > > > > index 468772930c..33b43d471f 100644 > > > > --- a/BaseTools/Source/Python/build/BuildReport.py > > > > +++ b/BaseTools/Source/Python/build/BuildReport.py > > > > @@ -10,6 +10,8 @@ > > > > > > > > ## Import Modules > > > > # > > > > +import json > > > > +from pathlib import Path > > > > import Common.LongFilePathOs as os > > > > import re > > > > import platform > > > > @@ -41,6 +43,7 @@ from Common.DataType import * import > > collections > > > > from Common.Expression import * from GenFds.AprioriSection import > > > > DXE_APRIORI_GUID, PEI_APRIORI_GUID > > > > +from AutoGen.IncludesAutoGen import IncludesAutoGen > > > > > > > > ## Pattern to extract contents in EDK DXS files > > > > gDxsDependencyPattern = > > > > re.compile(r"DEPENDENCY_START(.+)DEPENDENCY_END", re.DOTALL) > > @@ - > > > > 2298,6 +2301,10 @@ class BuildReport(object): > > > > def GenerateReport(se
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Hi Mike, thanks for reminder.
Hi Willy, currently, BaseTools related changes will be implemented on the
edk2-basetools repo. Please send the patch based on the edk2-basetools repo~
Thanks,
Christine
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, February 15, 2023 11:43 AM
> To: devel@edk2.groups.io; Chen, Christine ;
> Palomino Sosa, Guillermo A
> Cc: Feng, Bob C ; Gao, Liming
> ; Kinney, Michael D
>
> Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile
> information in build report
>
> Has this been reviewed for edk2-basetools repo?
>
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Yuwei
> > Chen
> > Sent: Tuesday, February 14, 2023 6:44 PM
> > To: Palomino Sosa, Guillermo A ;
> > devel@edk2.groups.io
> > Cc: Feng, Bob C ; Gao, Liming
> >
> > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile
> > information in build report
> >
> > Reviewed-by: Yuwei Chen
> >
> > > -Original Message-
> > > From: Palomino Sosa, Guillermo A
> > >
> > > Sent: Tuesday, February 7, 2023 11:07 AM
> > > To: devel@edk2.groups.io
> > > Cc: Feng, Bob C ; Gao, Liming
> > > ; Chen, Christine
> > > Subject: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile
> > > information in build report
> > >
> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2850
> > >
> > > Add "-Y REPORT_INFO" option to build command to generate compile
> > > information as part of BuildReport.
> > > This option generates files to be used by external tools as IDE's to
> > > enhance functionality.
> > > Files are created inside build folder:
> > > ///CompileInfo
> > >
> > > Files created:
> > > * compile_commands.json - Compilation Database. To be used by IDE's
> > > to enable advance features
> > > * cscope.files - List of files used in compilation. Used by Cscope to
> > > parse
> > > C code and provide browse functionality.
> > > * module_report.json - Module data form buildReport in Json format.
> > >
> > > Signed-off-by: Guillermo Antonio Palomino Sosa
> > >
> > > ---
> > > BaseTools/Source/Python/build/BuildReport.py | 139
> > > +++-
> > > BaseTools/Source/Python/build/buildoptions.py | 4 +-
> > > 2 files changed, 140 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/BaseTools/Source/Python/build/BuildReport.py
> > > b/BaseTools/Source/Python/build/BuildReport.py
> > > index 468772930c..33b43d471f 100644
> > > --- a/BaseTools/Source/Python/build/BuildReport.py
> > > +++ b/BaseTools/Source/Python/build/BuildReport.py
> > > @@ -10,6 +10,8 @@
> > >
> > > ## Import Modules
> > > #
> > > +import json
> > > +from pathlib import Path
> > > import Common.LongFilePathOs as os
> > > import re
> > > import platform
> > > @@ -41,6 +43,7 @@ from Common.DataType import * import
> collections
> > > from Common.Expression import * from GenFds.AprioriSection import
> > > DXE_APRIORI_GUID, PEI_APRIORI_GUID
> > > +from AutoGen.IncludesAutoGen import IncludesAutoGen
> > >
> > > ## Pattern to extract contents in EDK DXS files
> > > gDxsDependencyPattern =
> > > re.compile(r"DEPENDENCY_START(.+)DEPENDENCY_END", re.DOTALL)
> @@ -
> > > 2298,6 +2301,10 @@ class BuildReport(object):
> > > def GenerateReport(self, BuildDuration, AutoGenTime, MakeTime,
> > > GenFdsTime):
> > > if self.ReportFile:
> > > try:
> > > +
> > > +if "COMPILE_INFO" in self.ReportType:
> > > +self.GenerateCompileInfo()
> > > +
> > > File = []
> > > for (Wa, MaList) in self.ReportList:
> > > PlatformReport(Wa, MaList,
> > > self.ReportType).GenerateReport(File, BuildDuration, AutoGenTime,
> > > MakeTime, GenFdsTime, self.ReportType) @@ -2310,7 +2317,137 @@
> class
> > > BuildReport(object):
> > > EdkLogger.error("BuildReport", CODE_ERROR, "Unknown
> > > fatal error when generating build report",
> > > ExtraData=self.ReportFile,
> > > RaiseError=False)
> > > EdkLogger.quiet("(Python %s on %s\n
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Has this been reviewed for edk2-basetools repo?
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei Chen
> Sent: Tuesday, February 14, 2023 6:44 PM
> To: Palomino Sosa, Guillermo A ;
> devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile
> information in build report
>
> Reviewed-by: Yuwei Chen
>
> > -Original Message-
> > From: Palomino Sosa, Guillermo A
> > Sent: Tuesday, February 7, 2023 11:07 AM
> > To: devel@edk2.groups.io
> > Cc: Feng, Bob C ; Gao, Liming
> > ; Chen, Christine
> > Subject: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile
> > information in build report
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2850
> >
> > Add "-Y REPORT_INFO" option to build command to generate compile
> > information as part of BuildReport.
> > This option generates files to be used by external tools as IDE's to enhance
> > functionality.
> > Files are created inside build folder:
> > ///CompileInfo
> >
> > Files created:
> > * compile_commands.json - Compilation Database. To be used by IDE's
> > to enable advance features
> > * cscope.files - List of files used in compilation. Used by Cscope to parse
> > C code and provide browse functionality.
> > * module_report.json - Module data form buildReport in Json format.
> >
> > Signed-off-by: Guillermo Antonio Palomino Sosa
> >
> > ---
> > BaseTools/Source/Python/build/BuildReport.py | 139
> > +++-
> > BaseTools/Source/Python/build/buildoptions.py | 4 +-
> > 2 files changed, 140 insertions(+), 3 deletions(-)
> >
> > diff --git a/BaseTools/Source/Python/build/BuildReport.py
> > b/BaseTools/Source/Python/build/BuildReport.py
> > index 468772930c..33b43d471f 100644
> > --- a/BaseTools/Source/Python/build/BuildReport.py
> > +++ b/BaseTools/Source/Python/build/BuildReport.py
> > @@ -10,6 +10,8 @@
> >
> > ## Import Modules
> > #
> > +import json
> > +from pathlib import Path
> > import Common.LongFilePathOs as os
> > import re
> > import platform
> > @@ -41,6 +43,7 @@ from Common.DataType import * import collections
> > from Common.Expression import * from GenFds.AprioriSection import
> > DXE_APRIORI_GUID, PEI_APRIORI_GUID
> > +from AutoGen.IncludesAutoGen import IncludesAutoGen
> >
> > ## Pattern to extract contents in EDK DXS files gDxsDependencyPattern =
> > re.compile(r"DEPENDENCY_START(.+)DEPENDENCY_END", re.DOTALL) @@ -
> > 2298,6 +2301,10 @@ class BuildReport(object):
> > def GenerateReport(self, BuildDuration, AutoGenTime, MakeTime,
> > GenFdsTime):
> > if self.ReportFile:
> > try:
> > +
> > +if "COMPILE_INFO" in self.ReportType:
> > +self.GenerateCompileInfo()
> > +
> > File = []
> > for (Wa, MaList) in self.ReportList:
> > PlatformReport(Wa, MaList,
> > self.ReportType).GenerateReport(File, BuildDuration, AutoGenTime,
> > MakeTime, GenFdsTime, self.ReportType) @@ -2310,7 +2317,137 @@ class
> > BuildReport(object):
> > EdkLogger.error("BuildReport", CODE_ERROR, "Unknown fatal
> > error when generating build report", ExtraData=self.ReportFile,
> > RaiseError=False)
> > EdkLogger.quiet("(Python %s on %s\n%s)" %
> > (platform.python_version(), sys.platform, traceback.format_exc()))
> >
> > +
> > +##
> > +# Generates compile data files to be used by external tools.
> > +# Compile information will be generated in
> > ///CompileInfo
> > +# Files generated: compile_commands.json, cscope.files,
> > modules_report.json
> > +#
> > +# @param selfThe object pointer
> > +#
> > +def GenerateCompileInfo(self):
> > +try:
> > +# Lists for the output elements
> > +compile_commands = []
> > +used_files = set()
> > +module_report = []
> > +
> > +for (Wa, MaList) in self.ReportList:
> > +# Obtain list of all processed Workspace files
> > +for file_path in Wa._GetMetaFiles(Wa.BuildTarget,
> > Wa.ToolChain):
> > +used_files.add(file_path)
> > +
> > +for autoGen in Wa.AutoGenObjectList:
> > +
Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Palomino Sosa, Guillermo A
> Sent: Tuesday, February 7, 2023 11:07 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> Subject: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile
> information in build report
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2850
>
> Add "-Y REPORT_INFO" option to build command to generate compile
> information as part of BuildReport.
> This option generates files to be used by external tools as IDE's to enhance
> functionality.
> Files are created inside build folder:
> ///CompileInfo
>
> Files created:
> * compile_commands.json - Compilation Database. To be used by IDE's
> to enable advance features
> * cscope.files - List of files used in compilation. Used by Cscope to parse
> C code and provide browse functionality.
> * module_report.json - Module data form buildReport in Json format.
>
> Signed-off-by: Guillermo Antonio Palomino Sosa
>
> ---
> BaseTools/Source/Python/build/BuildReport.py | 139
> +++-
> BaseTools/Source/Python/build/buildoptions.py | 4 +-
> 2 files changed, 140 insertions(+), 3 deletions(-)
>
> diff --git a/BaseTools/Source/Python/build/BuildReport.py
> b/BaseTools/Source/Python/build/BuildReport.py
> index 468772930c..33b43d471f 100644
> --- a/BaseTools/Source/Python/build/BuildReport.py
> +++ b/BaseTools/Source/Python/build/BuildReport.py
> @@ -10,6 +10,8 @@
>
> ## Import Modules
> #
> +import json
> +from pathlib import Path
> import Common.LongFilePathOs as os
> import re
> import platform
> @@ -41,6 +43,7 @@ from Common.DataType import * import collections
> from Common.Expression import * from GenFds.AprioriSection import
> DXE_APRIORI_GUID, PEI_APRIORI_GUID
> +from AutoGen.IncludesAutoGen import IncludesAutoGen
>
> ## Pattern to extract contents in EDK DXS files gDxsDependencyPattern =
> re.compile(r"DEPENDENCY_START(.+)DEPENDENCY_END", re.DOTALL) @@ -
> 2298,6 +2301,10 @@ class BuildReport(object):
> def GenerateReport(self, BuildDuration, AutoGenTime, MakeTime,
> GenFdsTime):
> if self.ReportFile:
> try:
> +
> +if "COMPILE_INFO" in self.ReportType:
> +self.GenerateCompileInfo()
> +
> File = []
> for (Wa, MaList) in self.ReportList:
> PlatformReport(Wa, MaList,
> self.ReportType).GenerateReport(File, BuildDuration, AutoGenTime,
> MakeTime, GenFdsTime, self.ReportType) @@ -2310,7 +2317,137 @@ class
> BuildReport(object):
> EdkLogger.error("BuildReport", CODE_ERROR, "Unknown fatal
> error when generating build report", ExtraData=self.ReportFile,
> RaiseError=False)
> EdkLogger.quiet("(Python %s on %s\n%s)" %
> (platform.python_version(), sys.platform, traceback.format_exc()))
>
> +
> +##
> +# Generates compile data files to be used by external tools.
> +# Compile information will be generated in
> ///CompileInfo
> +# Files generated: compile_commands.json, cscope.files,
> modules_report.json
> +#
> +# @param selfThe object pointer
> +#
> +def GenerateCompileInfo(self):
> +try:
> +# Lists for the output elements
> +compile_commands = []
> +used_files = set()
> +module_report = []
> +
> +for (Wa, MaList) in self.ReportList:
> +# Obtain list of all processed Workspace files
> +for file_path in Wa._GetMetaFiles(Wa.BuildTarget,
> Wa.ToolChain):
> +used_files.add(file_path)
> +
> +for autoGen in Wa.AutoGenObjectList:
> +
> +# Loop through all modules
> +for module in (autoGen.LibraryAutoGenList +
> autoGen.ModuleAutoGenList):
> +
> +used_files.add(module.MetaFile.Path)
> +
> +# Main elements of module report
> +module_report_data = {}
> +module_report_data["Name"] = module.Name
> +module_report_data["Arch"] = module.Arch
> +module_report_data["Path"] = module.MetaFile.Path
> +module_report_data["Guid"] = module.Guid
> +module_report_data["BuildType"] = module.BuildType
> +module_report_data["IsLibrary"] = module.IsLibrary
> +module_report_data["SourceDir"] = module.SourceDir
> +module_report_data["Files"] = []
> +
> +# Files used by module
> +for data_file in module.SourceFileList:
> +module_report_data["Files"].append({"Name":
> + data_file.Name, "Path": data_file.Path})
> +
> +# Libraries used by module
> +module_report_data["Libraries"] = []
> +
