Re: [edk2-devel] [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields

2022-04-11 Thread Ni, Ray 
Reviewed-by: Ray Ni 

> -Original Message-
> From: Gao, Zhichao 
> Sent: Tuesday, April 12, 2022 9:02 AM
> To: Ke, Bo-ChangX ; devel@edk2.groups.io
> Cc: Ni, Ray 
> Subject: RE: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 
> fields
> 
> Reviewed-by: Zhichao Gao 
> 
> Thanks,
> Zhichao
> 
> > -Original Message-
> > From: Ke, Bo-ChangX 
> > Sent: Monday, April 11, 2022 3:18 PM
> > To: devel@edk2.groups.io
> > Cc: Ni, Ray ; Gao, Zhichao 
> > Subject: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5
> > fields
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900
> >
> > update smbiosview type 41 related fileds.
> >
> > Signed-off-by: Bo Chang Ke 
> > Cc: Ray Ni 
> > Cc: Zhichao Gao 
> > ---
> >  .../SmbiosView/QueryTable.c   | 24 +++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git
> > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > c
> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > c
> > index c4a6acb167..7ec6d2b5f1 100644
> > ---
> > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > c
> > +++
> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > c
> > @@ -1766,6 +1766,30 @@ TABLE_ITEM  OnboardDeviceTypesTable[] = {
> >  0x0A,
> >  L"  Sas Controller"
> >},
> > +  {
> > +0x0B,
> > +L"  Wireless LAN"
> > +  },
> > +  {
> > +0x0C,
> > +L"  Bluetooth"
> > +  },
> > +  {
> > +0x0D,
> > +L"  WWAN"
> > +  },
> > +  {
> > +0x0E,
> > +L"  embedded Multi-Media Controller"
> > +  },
> > +  {
> > +0x0F,
> > +L"  NVMe Controller"
> > +  },
> > +  {
> > +0x10,
> > +L"  UFS Controller"
> > +  }
> >  };
> >
> >  TABLE_ITEM  SELTypesTable[] = {
> > --
> > 2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88756): https://edk2.groups.io/g/devel/message/88756
Mute This Topic: https://groups.io/mt/90339486/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields

2022-04-11 Thread Gao, Zhichao 
Reviewed-by: Zhichao Gao 

Thanks,
Zhichao

> -Original Message-
> From: Ke, Bo-ChangX 
> Sent: Monday, April 11, 2022 3:18 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao 
> Subject: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5
> fields
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900
> 
> update smbiosview type 41 related fileds.
> 
> Signed-off-by: Bo Chang Ke 
> Cc: Ray Ni 
> Cc: Zhichao Gao 
> ---
>  .../SmbiosView/QueryTable.c   | 24 +++
>  1 file changed, 24 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> index c4a6acb167..7ec6d2b5f1 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> @@ -1766,6 +1766,30 @@ TABLE_ITEM  OnboardDeviceTypesTable[] = {
>  0x0A,
>  L"  Sas Controller"
>},
> +  {
> +0x0B,
> +L"  Wireless LAN"
> +  },
> +  {
> +0x0C,
> +L"  Bluetooth"
> +  },
> +  {
> +0x0D,
> +L"  WWAN"
> +  },
> +  {
> +0x0E,
> +L"  embedded Multi-Media Controller"
> +  },
> +  {
> +0x0F,
> +L"  NVMe Controller"
> +  },
> +  {
> +0x10,
> +L"  UFS Controller"
> +  }
>  };
> 
>  TABLE_ITEM  SELTypesTable[] = {
> --
> 2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88751): https://edk2.groups.io/g/devel/message/88751
Mute This Topic: https://groups.io/mt/90339486/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields

2022-04-10 Thread Zeng, Star 
Personally, I think "eMMC" should be enough to instead " embedded Multi-Media 
Controller ".
Others look good to me.

And you'd better to get RB from ShellPkg's maintainer (Cced).

Thanks,
Star

-Original Message-
From: Ke, Bo-ChangX  
Sent: Saturday, April 9, 2022 12:26 AM
To: devel@edk2.groups.io
Cc: Bi, Dandan ; Zeng, Star 
Subject: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900

update smbiosview type 41 related fileds.

Signed-off-by: Bo Chang Ke 
Cc: Dandan Bi 
Cc: Star Zeng 
---
 .../SmbiosView/QueryTable.c   | 24 +++
 1 file changed, 24 insertions(+)

diff --git 
a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c 
b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index c4a6acb167..7ec6d2b5f1 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -1766,6 +1766,30 @@ TABLE_ITEM  OnboardDeviceTypesTable[] = {
 0x0A,
 L"  Sas Controller"
   },
+  {
+0x0B,
+L"  Wireless LAN"
+  },
+  {
+0x0C,
+L"  Bluetooth"
+  },
+  {
+0x0D,
+L"  WWAN"
+  },
+  {
+0x0E,
+L"  embedded Multi-Media Controller"
+  },
+  {
+0x0F,
+L"  NVMe Controller"
+  },
+  {
+0x10,
+L"  UFS Controller"
+  }
 };
 
 TABLE_ITEM  SELTypesTable[] = {
-- 
2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88679): https://edk2.groups.io/g/devel/message/88679
Mute This Topic: https://groups.io/mt/90339486/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-