Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
@jdzh...@kunluntech.com.cn<mailto:jdzh...@kunluntech.com.cn> It’s checked in by below PR. UefiPayloadPkg: Define default values for the DynamicEX PCDs by gguo11837463 · Pull Request #3798 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3798> Thanks, Gua From: Guo, Gua Sent: Tuesday, December 20, 2022 9:25 AM To: devel@edk2.groups.io; jdzh...@kunluntech.com.cn; Lu, James Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs @Lu, James<mailto:james...@intel.com> Could you help us to add push label on it ? UefiPayloadPkg: Define default values for the DynamicEX PCDs by jiadingzhang · Pull Request #3792 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3792> The change purpose is for resolving ECC issue. @jdzh...@kunluntech.com.cn<mailto:jdzh...@kunluntech.com.cn> Thanks for the change. Thanks, Gua From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> On Behalf Of Jiading Zhang Sent: Monday, December 19, 2022 8:56 PM To: Guo; Guo, Gua mailto:gua@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs Hi. I commit a PR again, and the PR passed all the test. https://github.com/tianocore/edk2/pull/3792/commits Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97607): https://edk2.groups.io/g/devel/message/97607 Mute This Topic: https://groups.io/mt/94949814/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
@Lu, James<mailto:james...@intel.com> Could you help us to add push label on it ? UefiPayloadPkg: Define default values for the DynamicEX PCDs by jiadingzhang · Pull Request #3792 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3792> The change purpose is for resolving ECC issue. @jdzh...@kunluntech.com.cn<mailto:jdzh...@kunluntech.com.cn> Thanks for the change. Thanks, Gua From: devel@edk2.groups.io On Behalf Of Jiading Zhang Sent: Monday, December 19, 2022 8:56 PM To: Guo; Guo, Gua ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs Hi. I commit a PR again, and the PR passed all the test. https://github.com/tianocore/edk2/pull/3792/commits Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97594): https://edk2.groups.io/g/devel/message/97594 Mute This Topic: https://groups.io/mt/94949814/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
Hi. I commit a PR again, and the PR passed all the test. https://github.com/tianocore/edk2/pull/3792/commits Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97556): https://edk2.groups.io/g/devel/message/97556 Mute This Topic: https://groups.io/mt/94949814/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
OK. I Commit a PR for the change: UefiPayloadPkg: Define default values for the DynamicEX PCDs #3785 Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97526): https://edk2.groups.io/g/devel/message/97526 Mute This Topic: https://groups.io/mt/94949814/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
@jdzh...@kunluntech.com.cn<mailto:jdzh...@kunluntech.com.cn> Edk2 hardware freeze in unlock, Could you help send the Edk2 PR for it ? We can help to check in it to unlock the ECC failure. Thanks Gua From: Guo, Gua Sent: Friday, November 11, 2022 9:40 AM To: devel@edk2.groups.io; jdzh...@kunluntech.com.cn Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs Due to hardware freeze, it needs to wait after hardware freeze. Reviewed-by: Gua Guo mailto:gua@intel.com>> From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> On Behalf Of Jiading Zhang Sent: Friday, November 11, 2022 8:56 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs The following PCDs have no value in UefiPayloadPkg.dsc，and they can not pass the Ecc tool check, so assign the default values the same as they are in *.dec file. gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize Signed-off-by: jdzhang mailto:jdzh...@kunluntech.com.cn>> --- UefiPayloadPkg/UefiPayloadPkg.dsc | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 1150be6acd..ce7d3a7f89 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -530,14 +530,14 @@ gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|$(UART_DEFAULT_PARITY) gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|$(UART_DEFAULT_STOP_BITS) gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|$(DEFAULT_TERMINAL_TYPE) - gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize - gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds - gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize + gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|TRUE + gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport|FALSE + gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|TRUE + gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x1 + gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|5 + gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode|1 + gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress|0x0 + gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize|0x0 !if ($(TARGET) == DEBUG || $(USE_CBMEM_FOR_CONSOLE) == TRUE) gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE !else -- 2.38.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96799): https://edk2.groups.io/g/devel/message/96799 Mute This Topic: https://groups.io/mt/94949814/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs
Due to hardware freeze, it needs to wait after hardware freeze. Reviewed-by: Gua Guo mailto:gua@intel.com>> From: devel@edk2.groups.io On Behalf Of Jiading Zhang Sent: Friday, November 11, 2022 8:56 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs The following PCDs have no value in UefiPayloadPkg.dsc，and they can not pass the Ecc tool check, so assign the default values the same as they are in *.dec file. gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize Signed-off-by: jdzhang mailto:jdzh...@kunluntech.com.cn>> --- UefiPayloadPkg/UefiPayloadPkg.dsc | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 1150be6acd..ce7d3a7f89 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -530,14 +530,14 @@ gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|$(UART_DEFAULT_PARITY) gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|$(UART_DEFAULT_STOP_BITS) gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|$(DEFAULT_TERMINAL_TYPE) - gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize - gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds - gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize + gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|TRUE + gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport|FALSE + gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|TRUE + gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize|0x1 + gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|5 + gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode|1 + gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress|0x0 + gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize|0x0 !if ($(TARGET) == DEBUG || $(USE_CBMEM_FOR_CONSOLE) == TRUE) gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE !else -- 2.38.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96224): https://edk2.groups.io/g/devel/message/96224 Mute This Topic: https://groups.io/mt/94949814/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
